pi-onedev-toolkit 0.2.0 → 0.2.1

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 0.2.1 — 2026-09-03
+
+### Fixed
+
+- "Always allow" now saves one project-wide approval (`[server, project, "*"]`) instead of a single operation, so new operations no longer re-prompt after approving. Legacy per-operation entries are still honored.
+- "Allow for this session" also covers every operation in the project for the session.
+- Concurrent identical mutations share one approval dialog instead of opening several.
+- Safer dialog default (session-wide allow) and explicit "ALL OneDev mutations" labels; Enter no longer silently picks "Allow once".
+
 ## 0.2.0 — 2026-08-26
 
 ### Security and correctness

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-onedev-toolkit",
-	"version": "0.2.0",
+	"version": "0.2.1",
 	"description": "Lightweight OneDev integration for Pi via TOD: repo-aware issue, pull request, build, and watch tools",
 	"type": "module",
 	"author": {

package/src/mutation-approvals.ts

@@ -10,10 +10,12 @@ import {
 } from "./config-storage.js";
 
 const ALLOW_ONCE = "Allow once";
-const ALLOW_SESSION = "Allow for this session";
-const ALLOW_SAVED = "Always allow for this server and project";
+const ALLOW_SESSION = "Allow ALL OneDev mutations in this project this session";
+const ALLOW_SAVED = "Always allow ALL OneDev mutations in this project";
 const CANCEL = "Cancel";
 
+const ALL_OPERATIONS = "*";
+
 export const MUTATION_OPERATIONS = [
 	"issue.create",
 	"issue.edit",
@@ -50,13 +52,14 @@ export interface MutationApprovalRequest {
 
 function scopeKey(
 	context: OneDevSessionContext,
-	operation: MutationOperation,
+	operation: MutationOperation | typeof ALL_OPERATIONS,
 ): string {
 	return JSON.stringify([context.serverUrl, context.project, operation]);
 }
 
 export class MutationApprovalManager {
 	readonly #session = new Set<string>();
+	readonly #pending = new Map<string, Promise<void>>();
 
 	constructor(
 		readonly configPath = join(getAgentDir(), "onedev-toolkit.json"),
@@ -70,6 +73,24 @@ export class MutationApprovalManager {
 		context: OneDevSessionContext,
 		ctx: ExtensionContext,
 		request: MutationApprovalRequest,
+	): Promise<void> {
+		const key = `${context.serverUrl}\n${context.project}\n${request.operation}`;
+		// ponytail: coalesces identical in-flight confirms only; parallel
+		// different-operation dialogs still queue on Pi core's single selector
+		const inFlight = this.#pending.get(key);
+		if (inFlight) return inFlight;
+
+		const approval = this.#runConfirm(context, ctx, request).finally(() => {
+			this.#pending.delete(key);
+		});
+		this.#pending.set(key, approval);
+		return approval;
+	}
+
+	async #runConfirm(
+		context: OneDevSessionContext,
+		ctx: ExtensionContext,
+		request: MutationApprovalRequest,
 	): Promise<void> {
 		if (request.signal?.aborted) {
 			throw request.signal.reason instanceof Error
@@ -80,11 +101,13 @@ export class MutationApprovalManager {
 			throw new Error("OneDev mutation requires a ready server and project context");
 		}
 
-		const scope = scopeKey(context, request.operation);
-		if (this.#session.has(scope)) return;
+		const operationScope = scopeKey(context, request.operation);
+		const projectScope = scopeKey(context, ALL_OPERATIONS);
+		if (this.#session.has(projectScope)) return;
 		try {
 			const savedScopes = await readAllowedMutationScopes(this.configPath);
-			if (savedScopes.includes(scope)) return;
+			// legacy per-operation entries saved by older versions stay honored
+			if (savedScopes.includes(projectScope) || savedScopes.includes(operationScope)) return;
 		} catch (error) {
 			if (ctx.hasUI) {
 				ctx.ui.notify(
@@ -107,7 +130,7 @@ export class MutationApprovalManager {
 		].join("\n");
 		const choice = await ctx.ui.select(
 			prompt,
-			[ALLOW_ONCE, ALLOW_SESSION, ALLOW_SAVED, CANCEL],
+			[ALLOW_SESSION, ALLOW_SAVED, ALLOW_ONCE, CANCEL],
 			{ signal: request.signal },
 		);
 		if (!choice || choice === CANCEL) {
@@ -115,10 +138,10 @@ export class MutationApprovalManager {
 		}
 		if (choice === ALLOW_ONCE) return;
 
-		this.#session.add(scope);
+		this.#session.add(projectScope);
 		if (choice === ALLOW_SAVED) {
 			try {
-				await saveAllowedMutationScope(this.configPath, scope);
+				await saveAllowedMutationScope(this.configPath, projectScope);
 			} catch (error) {
 				ctx.ui.notify(
 					`Approval applies to this session only; it could not be saved: ${error instanceof Error ? error.message : String(error)}`,