pi-observational-memory 2.4.3 → 3.0.0

package/src/tools/recall-observation.ts

@@ -1,17 +1,17 @@
-import { Type } from "@mariozechner/pi-ai";
-import type { Message, ToolResultMessage } from "@mariozechner/pi-ai";
-import { defineTool, type ExtensionAPI } from "@mariozechner/pi-coding-agent";
-import type { AgentToolResult } from "@mariozechner/pi-agent-core";
-import { Text } from "@mariozechner/pi-tui";
+import type { AgentToolResult } from "@earendil-works/pi-agent-core";
+import { Type } from "@earendil-works/pi-ai";
+import type { Message, ToolResultMessage } from "@earendil-works/pi-ai";
+import { defineTool, type ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { Text } from "@earendil-works/pi-tui";
 import {
 	recallMemorySources,
 	type Entry,
-	type RecallMemoryObservation,
-	type RecallMemorySourcesResult,
-} from "../branch.js";
+	type RecallResult,
+	type RecalledObservation,
+} from "../session-ledger/recall.js";
+import type { Observation, Reflection } from "../session-ledger/index.js";
 import { renderRecallSourceEntries, renderRecallSourceEntry } from "../serialize.js";
 import { estimateEntryTokens } from "../tokens.js";
-import type { ObservationRecord, ReflectionRecord } from "../types.js";
 
 export const RECALL_OBSERVATION_TOOL_NAME = "recall";
 
@@ -23,11 +23,10 @@ type RecallObservationToolStatus =
 	| "invalid_id"
 	| "not_found"
 	| "no_source"
-	| "source_unavailable"
-	| "no_provenance";
+	| "source_unavailable";
 
-type ObservationDetails = Pick<ObservationRecord, "id" | "content" | "timestamp" | "relevance">;
-type ReflectionDetails = Pick<ReflectionRecord, "id" | "content" | "supportingObservationIds" | "legacy"> & { reflectionIndex: number };
+type ObservationDetails = Pick<Observation, "id" | "content" | "timestamp" | "relevance"> & { status?: "active" | "dropped" };
+type ReflectionDetails = Pick<Reflection, "id" | "content" | "supportingObservationIds"> & { reflectionIndex: number };
 
 export type RecallSourceEntryDetails = {
 	id: string;
@@ -39,7 +38,7 @@ export type RecallSourceEntryDetails = {
 };
 
 type RecallObservationMatchDetails = {
-	status: RecallMemoryObservation["status"];
+	status: "active" | "dropped" | "source_unavailable" | "no_source";
 	observationEntryId: string;
 	observationRecordIndex: number;
 	observation: ObservationDetails;
@@ -51,17 +50,9 @@ type RecallObservationMatchDetails = {
 };
 
 type RecallUnavailableSupportingObservationDetails = {
-	reflectionId: string;
-	reflectionIndex: number;
 	observationId: string;
 };
 
-type RecallUnavailableReflectionProvenanceDetails = {
-	reflectionId: string;
-	reflectionIndex: number;
-	reason: "legacy";
-};
-
 export type RecallObservationToolDetails = {
 	status: RecallObservationToolStatus;
 	memoryId: string;
@@ -74,7 +65,6 @@ export type RecallObservationToolDetails = {
 	matches: RecallObservationMatchDetails[];
 	sourceEntries: RecallSourceEntryDetails[];
 	unavailableSupportingObservations: RecallUnavailableSupportingObservationDetails[];
-	unavailableReflectionProvenance: RecallUnavailableReflectionProvenanceDetails[];
 	missingSourceEntryIds: string[];
 	nonSourceEntryIds: string[];
 	sourceCharacterCount?: number;
@@ -117,16 +107,11 @@ function sourceOriginAndQualifiers(entry: Entry): { origin: string; timestamp: s
 					.filter((block) => block.type === "toolCall" && typeof block.name === "string")
 					.map((block) => block.name as string),
 			);
-			return {
-				origin: "Assistant",
-				timestamp,
-				qualifiers: toolCalls.length > 0 ? [`tool calls: ${toolCalls.join(", ")}`] : [],
-			};
+			return { origin: "Assistant", timestamp, qualifiers: toolCalls.length > 0 ? [`tool calls: ${toolCalls.join(", ")}`] : [] };
 		}
 		const toolName = (msg as ToolResultMessage).toolName;
 		return { origin: `Tool result: ${typeof toolName === "string" && toolName ? toolName : "unknown"}`, timestamp, qualifiers: [] };
 	}
-
 	if (entry.type === "custom_message") {
 		return {
 			origin: "Custom message",
@@ -134,11 +119,7 @@ function sourceOriginAndQualifiers(entry: Entry): { origin: string; timestamp: s
 			qualifiers: typeof entry.customType === "string" && entry.customType ? [`custom: ${entry.customType}`] : [],
 		};
 	}
-
-	if (entry.type === "branch_summary") {
-		return { origin: "Branch summary", timestamp: formatDisplayTimestamp(entry.timestamp), qualifiers: [] };
-	}
-
+	if (entry.type === "branch_summary") return { origin: "Branch summary", timestamp: formatDisplayTimestamp(entry.timestamp), qualifiers: [] };
 	return { origin: entry.type || "Entry", timestamp: formatDisplayTimestamp(entry.timestamp), qualifiers: [] };
 }
 
@@ -160,67 +141,32 @@ function sourceEntryDetails(entry: Entry, includeContent: boolean): RecallSource
 	};
 }
 
-function observationDetails(observation: ObservationRecord): ObservationDetails {
-	return {
-		id: observation.id,
-		content: observation.content,
-		timestamp: observation.timestamp,
-		relevance: observation.relevance,
-	};
+function observationDetails(observation: Observation, status?: "active" | "dropped"): ObservationDetails {
+	return { id: observation.id, content: observation.content, timestamp: observation.timestamp, relevance: observation.relevance, ...(status ? { status } : {}) };
 }
 
-function reflectionDetails(reflection: ReflectionRecord, reflectionIndex: number): ReflectionDetails {
-	return {
-		id: reflection.id,
-		content: reflection.content,
-		supportingObservationIds: reflection.supportingObservationIds,
-		...(reflection.legacy === true ? { legacy: true } : {}),
-		reflectionIndex,
-	};
+function reflectionDetails(reflection: Reflection, reflectionIndex: number): ReflectionDetails {
+	return { id: reflection.id, content: reflection.content, supportingObservationIds: reflection.supportingObservationIds, reflectionIndex };
 }
 
-function observationMatchDetails(match: RecallMemoryObservation, includeSourceContent = true): RecallObservationMatchDetails {
-	if (match.status === "ok") {
-		return {
-			status: "ok",
-			observationEntryId: match.observationEntryId,
-			observationRecordIndex: match.observationRecordIndex,
-			observation: observationDetails(match.observation),
-			sourceEntryIds: match.sourceEntryIds,
-			sourceEntries: match.sourceEntries.map((entry) => sourceEntryDetails(entry, includeSourceContent)),
-			sourceCharacterCount: renderRecallSourceEntries(match.sourceEntries).length,
-		};
-	}
-	if (match.status === "source_unavailable") {
-		return {
-			status: "source_unavailable",
-			observationEntryId: match.observationEntryId,
-			observationRecordIndex: match.observationRecordIndex,
-			observation: observationDetails(match.observation),
-			sourceEntryIds: match.sourceEntryIds,
-			...(includeSourceContent
-				? {
-						sourceEntries: match.sourceEntries.map((entry) => sourceEntryDetails(entry, true)),
-						sourceCharacterCount: renderRecallSourceEntries(match.sourceEntries).length,
-					}
-				: {}),
-			missingSourceEntryIds: match.missingSourceEntryIds,
-			nonSourceEntryIds: match.nonSourceEntryIds,
-		};
-	}
+function observationMatchDetails(match: RecalledObservation, includeSourceContent = true): RecallObservationMatchDetails {
+	const unavailable = match.missingSourceEntryIds.length > 0 || match.nonSourceEntryIds.length > 0;
+	const status = unavailable ? "source_unavailable" : match.sourceEntries.length === 0 ? "no_source" : match.status;
 	return {
-		status: "no_source",
+		status,
 		observationEntryId: match.observationEntryId,
 		observationRecordIndex: match.observationRecordIndex,
-		observation: observationDetails(match.observation),
+		observation: observationDetails(match.observation, match.status),
+		sourceEntryIds: match.sourceEntryIds,
+		sourceEntries: match.sourceEntries.map((entry) => sourceEntryDetails(entry, includeSourceContent)),
+		missingSourceEntryIds: match.missingSourceEntryIds,
+		nonSourceEntryIds: match.nonSourceEntryIds,
+		sourceCharacterCount: renderRecallSourceEntries(match.sourceEntries).length,
 	};
 }
 
 function textResult(text: string, details: RecallObservationToolDetails) {
-	return {
-		content: [{ type: "text" as const, text }],
-		details,
-	};
+	return { content: [{ type: "text" as const, text }], details };
 }
 
 function emptyDetails(status: RecallObservationToolStatus, memoryId: string, message: string): RecallObservationToolDetails {
@@ -236,7 +182,6 @@ function emptyDetails(status: RecallObservationToolStatus, memoryId: string, mes
 		matches: [],
 		sourceEntries: [],
 		unavailableSupportingObservations: [],
-		unavailableReflectionProvenance: [],
 		missingSourceEntryIds: [],
 		nonSourceEntryIds: [],
 		message,
@@ -244,20 +189,15 @@ function emptyDetails(status: RecallObservationToolStatus, memoryId: string, mes
 }
 
 function aggregateStatus(details: Omit<RecallObservationToolDetails, "status">): RecallObservationToolStatus {
-	const observationOnly = details.reflections.length === 0 && details.unavailableSupportingObservations.length === 0 && details.unavailableReflectionProvenance.length === 0;
-	if (observationOnly && details.observations.some((match) => match.status === "ok")) return "ok";
-	if (observationOnly && details.observations.some((match) => match.status === "source_unavailable")) return "source_unavailable";
-	if (observationOnly && details.observations.length > 0) return "no_source";
-	if (details.unavailableReflectionProvenance.length > 0 && details.observations.length === 0 && details.sourceEntries.length === 0) return "no_provenance";
+	const observationOnly = details.reflections.length === 0 && details.unavailableSupportingObservations.length === 0;
 	if (details.partial) return "partial";
-	if (details.sourceEntries.length > 0) return "ok";
-	if (details.reflections.length > 0) return "ok";
-	if (details.observations.length > 0) return "no_source";
-	return "not_found";
+	if (observationOnly && details.observations.some((match) => match.status === "source_unavailable")) return "source_unavailable";
+	if (observationOnly && details.observations.length > 0 && details.sourceEntries.length === 0 && details.matches.every((match) => (match.sourceEntries ?? []).length === 0)) return "no_source";
+	return "ok";
 }
 
 function friendlyNoSourceMessage(memoryId: string): string {
-	return `Observation ${memoryId} has no source entries associated with it. This can happen for legacy observations created before source recall was available.`;
+	return `Observation ${memoryId} has no source entries associated with it.`;
 }
 
 function friendlySourceUnavailableMessage(match: RecallObservationMatchDetails): string {
@@ -271,79 +211,43 @@ function reflectionLineText(reflection: ReflectionDetails): string {
 }
 
 function observationLineText(observation: ObservationDetails): string {
-	return `[${observation.id}] ${observation.timestamp} [${observation.relevance}] ${observation.content}`;
+	const status = observation.status === "dropped" ? " [dropped]" : "";
+	return `[${observation.id}]${status} ${observation.timestamp} [${observation.relevance}] ${observation.content}`;
+}
+
+function directObservationMatches(result: Extract<RecallResult, { status: "found" }>): RecalledObservation[] {
+	return result.observations.filter((match) => match.observation.id === result.memoryId);
 }
 
-function renderObservationOnlyTextFromResult(result: Extract<RecallMemorySourcesResult, { status: "found" }>): string {
+function renderObservationOnlyTextFromResult(result: Extract<RecallResult, { status: "found" }>): string {
 	const sections: string[] = [];
-	if (result.collision) {
-		sections.push(`Multiple observations share id ${result.memoryId}; returning all matching source results from the current branch.`);
-	}
-	for (const match of result.directObservationMatches) {
-		if (match.status === "ok") {
-			const sourceText = renderRecallSourceEntries(match.sourceEntries);
-			if (sourceText.trim()) sections.push(sourceText);
-			else sections.push(`Observation ${match.observation.id} has source entries associated, but they rendered no text content.`);
+	if (result.collision) sections.push(`Memory id ${result.memoryId} matched multiple observations; returning all matching source results from the current branch.`);
+	for (const match of directObservationMatches(result)) {
+		if (match.status === "dropped") sections.push(`Observation ${match.observation.id} is dropped from active memory but remains recallable.`);
+		if (match.missingSourceEntryIds.length > 0 || match.nonSourceEntryIds.length > 0) {
+			sections.push(friendlySourceUnavailableMessage(observationMatchDetails(match, false)));
 			continue;
 		}
-		if (match.status === "source_unavailable") {
-			sections.push(friendlySourceUnavailableMessage(observationMatchDetails(match, false)));
+		if (match.sourceEntries.length === 0) {
+			sections.push(friendlyNoSourceMessage(match.observation.id));
 			continue;
 		}
-		sections.push(friendlyNoSourceMessage(match.observation.id));
+		const sourceText = renderRecallSourceEntries(match.sourceEntries);
+		sections.push(sourceText.trim() ? sourceText : `Observation ${match.observation.id} has source entries associated, but they rendered no text content.`);
 	}
 	return sections.join("\n\n");
 }
 
 function unavailableSupportingLineText(item: RecallUnavailableSupportingObservationDetails): string {
-	return `Supporting observation ${item.observationId} for reflection ${item.reflectionId} is unavailable on the current branch.`;
-}
-
-function unavailableReflectionProvenanceLineText(item: RecallUnavailableReflectionProvenanceDetails): string {
-	return `Reflection ${item.reflectionId} was migrated from legacy memory created before reflection provenance was recorded, so no supporting observations or raw sources are available.`;
-}
-
-function unavailableObservationSourceLineText(match: RecallMemoryObservation): string {
-	return `Observation ${match.observation.id} has no source entries associated. This can happen for legacy observations created before source recall was available.`;
+	return `Supporting observation ${item.observationId} is unavailable on the current branch.`;
 }
 
-function renderMemoryText(result: Extract<RecallMemorySourcesResult, { status: "found" }>): string {
+function renderMemoryText(result: Extract<RecallResult, { status: "found" }>): string {
 	const sections: string[] = [];
-	if (result.collision) {
-		sections.push(`Memory id ${result.memoryId} matched multiple observations/reflections; returning all available evidence from the current branch.`);
-	}
-	if (result.reflectionMatches.length > 0) {
-		sections.push(`Reflections:\n${result.reflectionMatches.map((match) => reflectionLineText(reflectionDetails(match.reflection, match.reflectionIndex))).join("\n")}`);
-	}
-	if (result.observations.length > 0) {
-		sections.push(`Observations:\n${result.observations.map((match) => observationLineText(match.observation)).join("\n")}`);
-	}
-	if (result.unavailableSupportingObservations.length > 0) {
-		sections.push(
-			`Unavailable supporting observations:\n${result.unavailableSupportingObservations
-				.map((item) => unavailableSupportingLineText({
-					reflectionId: item.reflection.id,
-					reflectionIndex: item.reflectionIndex,
-					observationId: item.observationId,
-				}))
-				.join("\n")}`,
-		);
-	}
-	if (result.unavailableReflectionProvenance.length > 0) {
-		sections.push(
-			`Unavailable reflection provenance:\n${result.unavailableReflectionProvenance
-				.map((item) => unavailableReflectionProvenanceLineText({
-					reflectionId: item.reflection.id,
-					reflectionIndex: item.reflectionIndex,
-					reason: item.reason,
-				}))
-				.join("\n")}`,
-		);
-	}
-	const noSourceObservations = result.observations.filter((match) => match.status === "no_source");
-	if (noSourceObservations.length > 0) {
-		sections.push(`Unavailable observation sources:\n${noSourceObservations.map(unavailableObservationSourceLineText).join("\n")}`);
-	}
+	if (result.collision) sections.push(`Memory id ${result.memoryId} matched multiple observations/reflections; returning all available evidence from the current branch.`);
+	if (result.reflections.length > 0) sections.push(`Reflections:\n${result.reflections.map((match) => reflectionLineText(reflectionDetails(match.reflection, match.reflectionRecordIndex))).join("\n")}`);
+	if (result.observations.length > 0) sections.push(`Observations:\n${result.observations.map((match) => observationLineText(observationDetails(match.observation, match.status))).join("\n")}`);
+	if (result.missingSupportingObservationIds.length > 0) sections.push(`Unavailable supporting observations:\n${result.missingSupportingObservationIds.map((id) => unavailableSupportingLineText({ observationId: id })).join("\n")}`);
 	if (result.missingSourceEntryIds.length > 0 || result.nonSourceEntryIds.length > 0) {
 		const parts: string[] = [];
 		if (result.missingSourceEntryIds.length > 0) parts.push(`missing: ${result.missingSourceEntryIds.join(", ")}`);
@@ -356,53 +260,36 @@ function renderMemoryText(result: Extract<RecallMemorySourcesResult, { status: "
 	return sections.join("\n\n");
 }
 
-function resultDetails(result: Extract<RecallMemorySourcesResult, { status: "found" }>, includeSourceContent = true): RecallObservationToolDetails {
-	const reflections = result.reflectionMatches.map((match) => reflectionDetails(match.reflection, match.reflectionIndex));
-	const memoryLayerRecall = result.reflectionMatches.length > 0 || result.unavailableSupportingObservations.length > 0;
-	const includeObservationSources = (_match: RecallMemoryObservation) => includeSourceContent;
-	const observations = result.observations.map((match) => observationMatchDetails(match, includeObservationSources(match)));
-	const directObservationMatches = result.directObservationMatches.map((match) => observationMatchDetails(match, includeObservationSources(match)));
-	const sourceEntries = memoryLayerRecall ? result.sourceEntries.map((entry) => sourceEntryDetails(entry, includeSourceContent)) : [];
-	const unavailableSupportingObservations = result.unavailableSupportingObservations.map((item) => ({
-		reflectionId: item.reflection.id,
-		reflectionIndex: item.reflectionIndex,
-		observationId: item.observationId,
-	}));
-	const unavailableReflectionProvenance = result.unavailableReflectionProvenance.map((item) => ({
-		reflectionId: item.reflection.id,
-		reflectionIndex: item.reflectionIndex,
-		reason: item.reason,
-	}));
-	const partial = result.partial;
+function resultDetails(result: Extract<RecallResult, { status: "found" }>, includeSourceContent = true): RecallObservationToolDetails {
+	const reflections = result.reflections.map((match) => reflectionDetails(match.reflection, match.reflectionRecordIndex));
+	const observations = result.observations.map((match) => observationMatchDetails(match, includeSourceContent));
+	const directMatches = directObservationMatches(result).map((match) => observationMatchDetails(match, includeSourceContent));
+	const sourceEntries = result.sourceEntries.map((entry) => sourceEntryDetails(entry, includeSourceContent));
 	const detailWithoutStatus = {
 		memoryId: result.memoryId,
 		observationId: result.memoryId,
 		collision: result.collision,
-		partial,
+		partial: result.partial,
 		reflections,
-		directObservationMatches,
+		directObservationMatches: directMatches,
 		observations,
-		matches: directObservationMatches,
+		matches: directMatches,
 		sourceEntries,
-		unavailableSupportingObservations,
-		unavailableReflectionProvenance,
+		unavailableSupportingObservations: result.missingSupportingObservationIds.map((observationId) => ({ observationId })),
 		missingSourceEntryIds: result.missingSourceEntryIds,
 		nonSourceEntryIds: result.nonSourceEntryIds,
 		sourceCharacterCount: renderRecallSourceEntries(result.sourceEntries).length,
 	};
-	return {
-		status: aggregateStatus(detailWithoutStatus),
-		...detailWithoutStatus,
-	};
+	return { status: aggregateStatus(detailWithoutStatus), ...detailWithoutStatus };
 }
 
 function isObservationOnly(details: RecallObservationToolDetails): boolean {
-	return details.reflections.length === 0 && details.unavailableSupportingObservations.length === 0 && details.unavailableReflectionProvenance.length === 0;
+	return details.reflections.length === 0 && details.unavailableSupportingObservations.length === 0;
 }
 
-function renderFoundResult(result: Extract<RecallMemorySourcesResult, { status: "found" }>): ReturnType<typeof textResult> {
+function renderFoundResult(result: Extract<RecallResult, { status: "found" }>): ReturnType<typeof textResult> {
 	const details = resultDetails(result);
-	const text = isObservationOnly(details) ? renderObservationOnlyTextFromResult(result) : renderMemoryText(result);
+	const text = result.kind === "observation" ? renderObservationOnlyTextFromResult(result) : renderMemoryText(result);
 	return textResult(text, details);
 }
 
@@ -429,7 +316,6 @@ function observationCountForHeader(details: RecallObservationToolDetails): numbe
 
 export function formatRecallHeaderForTui(details: RecallObservationToolDetails): string {
 	if (isFailureStatus(details.status)) return "× failure";
-
 	const parts = ["✓ success"];
 	if (details.reflections.length > 0) parts.push(plural(details.reflections.length, "reflection"));
 	const observations = observationCountForHeader(details);
@@ -438,6 +324,7 @@ export function formatRecallHeaderForTui(details: RecallObservationToolDetails):
 	if (sources.length > 0) parts.push(plural(sources.length, "source"));
 	const tokens = sources.reduce((sum, source) => sum + source.tokens, 0);
 	if (tokens > 0) parts.push(tokenSummary(tokens));
+	if (details.partial && details.status !== "ok") parts.push(details.status.replace(/_/g, " "));
 	return parts.join(" · ");
 }
 
@@ -463,7 +350,8 @@ function sourceMetadataLine(source: RecallSourceEntryDetails): string {
 }
 
 function observationLine(observation: ObservationDetails): string {
-	return alignedRow("✓ observation", `${observation.timestamp} [${observation.relevance}]`, observation.content);
+	const status = observation.status === "dropped" ? " dropped" : "";
+	return alignedRow("✓ observation", `${observation.timestamp} [${observation.relevance}]${status}`, observation.content);
 }
 
 function reflectionLine(reflection: ReflectionDetails): string {
@@ -475,16 +363,10 @@ function noteLine(kind: string, text: string): string {
 }
 
 function indentContent(content: string): string {
-	return content
-		.split("\n")
-		.map((line) => `    ${line}`)
-		.join("\n");
+	return content.split("\n").map((line) => `    ${line}`).join("\n");
 }
 
-function unavailableEvidenceMessage(details: RecallObservationToolDetails): string {
-	if (details.unavailableReflectionProvenance.length > 0 && details.observations.length === 0) {
-		return "migrated legacy reflection has no supporting observations";
-	}
+function unavailableEvidenceMessage(_details: RecallObservationToolDetails): string {
 	return "no source entries are available for this memory id";
 }
 
@@ -500,10 +382,7 @@ function pushSourceLines(lines: string[], sources: RecallSourceEntryDetails[], e
 
 function memoryRows(details: RecallObservationToolDetails): string[] {
 	if (isObservationOnly(details)) return details.matches.map((match) => observationLine(match.observation));
-	return [
-		...details.reflections.map((reflection) => reflectionLine(reflection)),
-		...details.observations.map((observation) => observationLine(observation.observation)),
-	];
+	return [...details.reflections.map((reflection) => reflectionLine(reflection)), ...details.observations.map((observation) => observationLine(observation.observation))];
 }
 
 function noteRows(details: RecallObservationToolDetails, sources: RecallSourceEntryDetails[]): string[] {
@@ -517,22 +396,20 @@ function noteRows(details: RecallObservationToolDetails, sources: RecallSourceEn
 		return notes;
 	}
 	if (details.collision) notes.push(noteLine("id collision", `multiple memory items share ${details.memoryId}`));
-	if (sources.length === 0 && (details.reflections.length > 0 || details.observations.length > 0 || details.matches.length > 0)) {
-		notes.push(noteLine("unavailable evidence", unavailableEvidenceMessage(details)));
-	}
+	if (details.observations.some((match) => match.observation.status === "dropped")) notes.push(noteLine("dropped", "one or more observations are dropped from active memory but remain recallable"));
+	if (details.unavailableSupportingObservations.length > 0) notes.push(noteLine("missing support", details.unavailableSupportingObservations.map((item) => item.observationId).join(", ")));
+	if (details.missingSourceEntryIds.length > 0) notes.push(noteLine("missing source", details.missingSourceEntryIds.join(", ")));
+	if (details.nonSourceEntryIds.length > 0) notes.push(noteLine("non-source", details.nonSourceEntryIds.join(", ")));
+	if (sources.length === 0 && (details.reflections.length > 0 || details.observations.length > 0 || details.matches.length > 0)) notes.push(noteLine("unavailable evidence", unavailableEvidenceMessage(details)));
 	return notes;
 }
 
 export function formatRecallResultForTui(result: AgentToolResult<RecallObservationToolDetails>, expanded: boolean): string {
 	const details = result.details;
 	if (!details) {
-		const text = result.content
-			.filter((part): part is { type: "text"; text: string } => part.type === "text" && typeof part.text === "string")
-			.map((part) => part.text)
-			.join("\n");
+		const text = result.content.filter((part): part is { type: "text"; text: string } => part.type === "text" && typeof part.text === "string").map((part) => part.text).join("\n");
 		return text || "recall";
 	}
-
 	const sources = sourceEntriesFromDetails(details);
 	const lines: string[] = [];
 	const rows = memoryRows(details);
@@ -542,10 +419,7 @@ export function formatRecallResultForTui(result: AgentToolResult<RecallObservati
 	lines.push(...notes);
 	if ((rows.length > 0 || notes.length > 0) && sources.length > 0) lines.push("");
 	pushSourceLines(lines, sources, expanded);
-
-	if (!expanded && sources.some((source) => source.content)) {
-		lines.push("", "(Ctrl+O to expand)");
-	}
+	if (!expanded && sources.some((source) => source.content)) lines.push("", "(Ctrl+O to expand)");
 	return lines.join("\n").trimEnd();
 }
 
@@ -579,9 +453,7 @@ export const recallObservationTool = defineTool({
 	parameters: Type.Object({
 		id: Type.String({
 			pattern: "^[a-f0-9]{12}$",
-			description:
-				"12-character lowercase hex observation or reflection id shown in compacted memory, /om-view, or a previous recall result. " +
-				"Must be a specific id; this tool does not search by topic.",
+			description: "12-character lowercase hex observation or reflection id shown in compacted memory, /om-view, or a previous recall result. Must be a specific id; this tool does not search by topic.",
 		}),
 	}),
 	renderCall(args) {
@@ -596,14 +468,12 @@ export const recallObservationTool = defineTool({
 			const message = `Memory id must be 12 lowercase hex characters. Received: ${memoryId}`;
 			return textResult(message, emptyDetails("invalid_id", memoryId, message));
 		}
-
 		const branchEntries = ctx.sessionManager.getBranch() as Entry[];
 		const result = recallMemorySources(branchEntries, memoryId);
 		if (result.status === "not_found") {
 			const message = `No observation or reflection with id ${memoryId} was found on the current branch.`;
 			return textResult(message, emptyDetails("not_found", memoryId, message));
 		}
-
 		return renderFoundResult(result);
 	},
 });