pi-observational-memory 1.0.1 → 1.0.3

package/README.md

@@ -94,12 +94,14 @@ That's it. The extension hooks into Pi's compaction lifecycle automatically. No
 
 ### Extension settings
 
-Create `~/.pi/agent/observational-memory.json` (or `.pi/observational-memory.json` per project):
+Settings live under the `observational-memory` key in Pi's `settings.json` — globally at `~/.pi/agent/settings.json`, or per-project at `.pi/settings.json`. Project values override global.
 
 ```json
 {
-  "observationThreshold": 50000,
-  "reflectionThreshold": 30000
+  "observational-memory": {
+    "observationThreshold": 50000,
+    "reflectionThreshold": 30000
+  }
 }
 ```
 
@@ -115,13 +117,15 @@ The observer and reflector don't need the same capabilities as your coding agent
 
 ```json
 {
-  "compactionModel": { "provider": "openrouter", "id": "google/gemma-4-31b-it" }
+  "observational-memory": {
+    "compactionModel": { "provider": "openrouter", "id": "google/gemma-4-31b-it" }
+  }
 }
 ```
 
 ### Pi compaction settings
 
-The extension works with Pi's built-in compaction settings in `~/.pi/agent/settings.json`:
+The extension works alongside Pi's built-in compaction settings in the same `settings.json`:
 
 ```json
 {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-observational-memory",
-  "version": "1.0.1",
+  "version": "1.0.3",
   "description": "Observational memory extension for pi — cache-friendly tiered compaction with observations and reflections.",
   "type": "module",
   "license": "MIT",

package/src/config.ts

@@ -13,24 +13,26 @@ export const DEFAULTS: Config = {
 	reflectionThreshold: 30_000,
 };
 
-export function loadConfig(cwd: string): Config {
-	const globalPath = join(getAgentDir(), "observational-memory.json");
-	const projectPath = join(cwd, ".pi", "observational-memory.json");
-
-	let globalConfig: Partial<Config> = {};
-	let projectConfig: Partial<Config> = {};
+const SETTINGS_KEY = "observational-memory";
 
-	if (existsSync(globalPath)) {
-		try {
-			globalConfig = JSON.parse(readFileSync(globalPath, "utf-8"));
-		} catch {}
+function readNamespacedConfig(path: string): Partial<Config> {
+	if (!existsSync(path)) return {};
+	try {
+		const raw = JSON.parse(readFileSync(path, "utf-8")) as Record<string, unknown>;
+		const nested = raw[SETTINGS_KEY];
+		return nested && typeof nested === "object" ? (nested as Partial<Config>) : {};
+	} catch {
+		return {};
 	}
+}
 
-	if (existsSync(projectPath)) {
-		try {
-			projectConfig = JSON.parse(readFileSync(projectPath, "utf-8"));
-		} catch {}
-	}
+export function loadConfig(cwd: string): Config {
+	const globalPath = join(getAgentDir(), "settings.json");
+	const projectPath = join(cwd, ".pi", "settings.json");
 
-	return { ...DEFAULTS, ...globalConfig, ...projectConfig };
+	return {
+		...DEFAULTS,
+		...readNamespacedConfig(globalPath),
+		...readNamespacedConfig(projectPath),
+	};
 }

package/src/index.ts

@@ -1,6 +1,6 @@
-import { completeSimple } from "@mariozechner/pi-ai";
+import { completeSimple, type Message, type TextContent, type ToolCall, type ToolResultMessage } from "@mariozechner/pi-ai";
 import type { ExtensionAPI } from "@mariozechner/pi-coding-agent";
-import { convertToLlm, serializeConversation } from "@mariozechner/pi-coding-agent";
+import { convertToLlm, SettingsManager } from "@mariozechner/pi-coding-agent";
 import { DEFAULTS, loadConfig } from "./config.js";
 import type { Config } from "./config.js";
 import { CONTEXT_USAGE_INSTRUCTIONS, OBSERVER_SYSTEM, REFLECTOR_SYSTEM } from "./prompts.js";
@@ -8,6 +8,52 @@ import { estimateRawTailTokens, estimateTokens, extractText } from "./tokens.js"
 import type { MemoryDetails, MemoryState } from "./types.js";
 import { isMemoryDetails } from "./types.js";
 
+function localDate(epochMs: number): string {
+	const d = new Date(epochMs);
+	return `${d.getFullYear()}-${String(d.getMonth() + 1).padStart(2, "0")}-${String(d.getDate()).padStart(2, "0")}`;
+}
+
+function localTime(epochMs: number): string {
+	const d = new Date(epochMs);
+	return `${String(d.getHours()).padStart(2, "0")}:${String(d.getMinutes()).padStart(2, "0")}`;
+}
+
+function serializeWithTimestamps(messages: Message[]): string {
+	return messages
+		.map((msg): string | null => {
+			const time = localTime(msg.timestamp);
+			if (msg.role === "user") {
+				const text =
+					typeof msg.content === "string"
+						? msg.content
+						: msg.content
+							.filter((b): b is TextContent => b.type === "text")
+							.map((b) => b.text)
+							.join("\n");
+				return `[User @ ${time}]: ${text}`;
+			}
+			if (msg.role === "assistant") {
+				const parts = msg.content.map((b) => {
+					if (b.type === "text") return b.text;
+					if (b.type === "thinking") return b.redacted ? "" : `[thinking: ${b.thinking}]`;
+					if (b.type === "toolCall") return `[${b.name}(${JSON.stringify(b.arguments)})]`;
+					return "";
+				});
+				const body = parts.filter(Boolean).join("\n");
+				if (!body) return null;
+				return `[Assistant @ ${time}]: ${body}`;
+			}
+			// toolResult
+			const text = msg.content
+				.filter((b): b is TextContent => b.type === "text")
+				.map((b) => b.text)
+				.join("\n");
+			return `[Tool result for ${(msg as ToolResultMessage).toolName} @ ${time}]: ${text}`;
+		})
+		.filter((line): line is string => line !== null)
+		.join("\n\n");
+}
+
 export default function observationalMemory(pi: ExtensionAPI) {
 	let config: Config = { ...DEFAULTS };
 	let state: MemoryState = { observations: "", reflections: "" };
@@ -42,16 +88,22 @@ export default function observationalMemory(pi: ExtensionAPI) {
 				compactInFlight = false;
 				return;
 			}
-			ctx.compact({
-				onComplete: () => {
-					compactInFlight = false;
-					if (ctx.hasUI) ctx.ui.notify("Observational memory: compaction complete", "info");
-				},
-				onError: (error) => {
-					compactInFlight = false;
-					if (ctx.hasUI) ctx.ui.notify(`Observational memory: ${error.message}`, "error");
-				},
-			});
+			try {
+				ctx.compact({
+					onComplete: () => {
+						compactInFlight = false;
+						if (ctx.hasUI) ctx.ui.notify("Observational memory: compaction complete", "info");
+					},
+					onError: (error) => {
+						compactInFlight = false;
+						if (ctx.hasUI) ctx.ui.notify(`Observational memory: ${error.message}`, "error");
+					},
+				});
+			} catch (error) {
+				compactInFlight = false;
+				const msg = error instanceof Error ? error.message : String(error);
+				if (ctx.hasUI) ctx.ui.notify(`Observational memory: compact threw: ${msg}`, "error");
+			}
 		}, 0);
 	});
 
@@ -79,10 +131,28 @@ export default function observationalMemory(pi: ExtensionAPI) {
 		const allMessages = [...messagesToSummarize, ...turnPrefixMessages];
 		if (allMessages.length === 0) return;
 
-		const conversationText = serializeConversation(convertToLlm(allMessages));
+		// Bug 1: use local date, not UTC
 		const now = new Date();
-		const dateStr = now.toISOString().split("T")[0];
-		const timeStr = now.toTimeString().slice(0, 5);
+		const dateStr = localDate(now.getTime());
+		const timeStr = localTime(now.getTime());
+
+		// Bug 2: serialize with per-message timestamps
+		const llmMessages = convertToLlm(allMessages);
+		const conversationText = serializeWithTimestamps(llmMessages);
+
+		// Bug 3: inform the Observer of the message date range
+		let dateRangeNote = "";
+		if (llmMessages.length > 0) {
+			const timestamps = llmMessages.map((m) => m.timestamp);
+			const firstTs = timestamps.reduce((a, b) => Math.min(a, b));
+			const lastTs = timestamps.reduce((a, b) => Math.max(a, b));
+			const firstMsgDate = localDate(firstTs);
+			const lastMsgDate = localDate(lastTs);
+			dateRangeNote =
+				firstMsgDate === lastMsgDate
+					? ` Messages in this batch are from ${firstMsgDate}.`
+					: ` Messages in this batch span ${firstMsgDate} to ${lastMsgDate}.`;
+		}
 
 		ctx.ui.notify("Observational memory: running observer...", "info");
 
@@ -101,7 +171,7 @@ export default function observationalMemory(pi: ExtensionAPI) {
 							content: [
 								{
 									type: "text" as const,
-									text: `Today is ${dateStr}, current time is ${timeStr}.\n\n<current-reflections>\n${state.reflections || "(none yet)"}\n</current-reflections>\n\n<current-observations>\n${state.observations || "(none yet)"}\n</current-observations>\n\nCompress the following conversation into new observations:\n\n<conversation>\n${conversationText}\n</conversation>`,
+									text: `Today is ${dateStr}, current time is ${timeStr}.${dateRangeNote}\n\n<current-reflections>\n${state.reflections || "(none yet)"}\n</current-reflections>\n\n<current-observations>\n${state.observations || "(none yet)"}\n</current-observations>\n\nCompress the following conversation into new observations:\n\n<conversation>\n${conversationText}\n</conversation>`,
 								},
 							],
 							timestamp: Date.now(),
@@ -199,6 +269,7 @@ export default function observationalMemory(pi: ExtensionAPI) {
 			const rawTokens = estimateRawTailTokens(entries);
 			const obsTokens = estimateTokens(state.observations);
 			const refTokens = estimateTokens(state.reflections);
+			const keepRecentTokens = SettingsManager.create(ctx.cwd).getCompactionKeepRecentTokens();
 
 			const lines = [
 				"── Observational Memory ──",
@@ -208,7 +279,8 @@ export default function observationalMemory(pi: ExtensionAPI) {
 				"",
 				"── Parameters ──",
 				`Observation threshold: ${config.observationThreshold.toLocaleString()}`,
-				`Reflection threshold:  ${config.reflectionThreshold.toLocaleString()}`,
+				`Reflection threshold:  ${config.reflectionThreshold.toLocaleString()} (interpreted as observations token budget)`,
+				`Keep recent tokens:    ${keepRecentTokens.toLocaleString()} (pi compaction, how many tokens in raw messages)`,
 			];
 
 			ctx.ui.notify(lines.join("\n"), "info");
@@ -255,7 +327,7 @@ export default function observationalMemory(pi: ExtensionAPI) {
 				sections.push("");
 				sections.push("── Raw Messages ──");
 				if (rawMessages.length > 0) {
-					sections.push(serializeConversation(convertToLlm(rawMessages)));
+					sections.push(serializeWithTimestamps(convertToLlm(rawMessages)));
 				} else {
 					sections.push("(none)");
 				}

package/src/prompts.ts

@@ -1,11 +1,11 @@
-export const OBSERVER_SYSTEM = `You are an observation agent for a coding assistant. Compress conversation messages into concise, timestamped observations.
+export const OBSERVER_SYSTEM = `You are an observation agent for a coding assistant. Compress conversation messages into concise, timestamped observations. Messages arrive pre-timestamped as \`[User @ HH:MM]\`, \`[Assistant @ HH:MM]\`, and \`[Tool result for <name> @ HH:MM]\` — use those inline timestamps when assigning times to your observations.
 
 Format as a date-grouped log:
 
 Date: YYYY-MM-DD
 - 🔴 HH:MM Observation text
-  - 🔴 HH:MM Sub-observation
-  - 🟡 HH:MM Sub-observation
+  - Sub-observation (no timestamp if same moment)
+  - Sub-observation
 - 🟢 HH:MM Another observation
 
 Priority levels: