pi-note 0.33.3 → 0.33.4

package/README.md

@@ -90,20 +90,13 @@ client-local and is never sent to the service or persisted as launch state.
 Only a fresh session can consume it. The service must share the GUI's database;
 missing/stale revisions fail closed. Resume, reload and `/new` never replay the
 handoff or replace another selection. Pi keeps its normal endpoint/token settings.
-With pi-note 0.33.1+, completing the launched task from the menu, footer or
-**Complete task and exit** runs `git pull --ff-only --no-rebase --no-autostash` in
-Pi's working directory before exiting, so Kitty closes its dedicated tab (or the
-standalone window's last tab). It never merges, rebases or stashes local changes.
-If Git fails, times out (30 seconds), or the session/draft changes, Pi stays open;
-the task remains completed and is not retried. Check Git manually, then `/quit`.
-With pi-note 0.33.3+, directories outside Git, repositories without remotes, and
-branches without a configured upstream skip the pull and exit without a warning.
-Broken Git configuration, detached HEAD in a remote-backed repository, and failures
-to pull a configured upstream still keep Pi open.
-`/quit` and Exit without completing do not pull.
+With pi-note 0.33.4+, completing the launched task from the menu, footer or
+**Complete task and exit** exits Pi directly, so Kitty closes its dedicated tab
+(or the standalone window's last tab). Completion never runs Git commands;
+Git configuration and network availability do not affect closing the session.
 This ownership survives `/reload`, but not `/new`, resume, fork, tree navigation
 or process restart. Completing a different task or an externally completed task
-does not pull or close Pi; failed/uncertain completion stays open.
+does not close Pi; failed/uncertain completion stays open.
 
 ### Agent tools and context
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-note",
-  "version": "0.33.3",
+  "version": "0.33.4",
   "description": "Persistent pinote tasks, Markdown handoffs, and task status for Pi",
   "license": "MIT",
   "type": "module",

package/remote/exit.ts

@@ -1,43 +1,10 @@
-import { spawnSync } from 'node:child_process';
-import { CustomEditor, type ExtensionAPI, type ExtensionContext } from '@earendil-works/pi-coding-agent';
+import { CustomEditor, type ExtensionAPI } from '@earendil-works/pi-coding-agent';
 import { truncateToWidth } from '@earendil-works/pi-tui';
 import { clean } from './protocol.ts';
 import type { RemoteSession } from './session.ts';
 
-/** Completion is already committed: pull failures must never retry the task action. */
-export async function pullBeforeExit(pi: ExtensionAPI, ctx: ExtensionContext, signal: AbortSignal, current: () => boolean): Promise<boolean> {
-  const sessionId = ctx.sessionManager.getSessionId(), branch = ctx.sessionManager.getLeafId();
-  const draft = ctx.ui.getEditorText();
-  const unchanged = () => current() && !signal.aborted && ctx.isIdle() &&
-    ctx.sessionManager.getSessionId() === sessionId && ctx.sessionManager.getLeafId() === branch && ctx.ui.getEditorText() === draft;
-  if (!unchanged()) return false;
-  try {
-    const git = (args: string[]) => spawnSync('git', args, {
-      cwd: ctx.cwd, encoding: 'utf8', timeout: 3000, env: { ...process.env, LC_ALL: 'C' },
-    });
-    const repository = git(['rev-parse', '--show-toplevel']);
-    if (!repository.error && repository.status === 128 && repository.stderr.startsWith('fatal: not a git repository (or any ')) return unchanged();
-    if (repository.error || repository.status !== 0 || !unchanged()) throw new Error('Git repository check failed');
-    const remotes = git(['remote']);
-    if (remotes.error || remotes.status !== 0) throw new Error('Git remote check failed');
-    if (!remotes.stdout.trim()) return unchanged();
-    const branch = git(['symbolic-ref', '--quiet', 'HEAD']);
-    if (branch.error || branch.status !== 0 || !branch.stdout.startsWith('refs/heads/')) throw new Error('Git branch check failed');
-    const branchName = branch.stdout.trim().slice('refs/heads/'.length);
-    const upstream = git(['config', '--get', `branch.${branchName}.merge`]);
-    if (upstream.error || (upstream.status !== 0 && upstream.status !== 1)) throw new Error('Git upstream check failed');
-    if (upstream.status === 1) return unchanged();
-    if (!upstream.stdout.trim() || !unchanged()) throw new Error('Git upstream or session changed');
-    ctx.ui.notify('Task completed. Running git pull --ff-only before closing Pi…', 'info');
-    const result = await pi.exec('git', ['pull', '--ff-only', '--no-rebase', '--no-autostash'], { cwd: ctx.cwd, signal, timeout: 30_000 });
-    if (result.code === 0 && !result.killed && unchanged()) return true;
-  } catch { /* Completion succeeded; only the local pull failed. */ }
-  if (current()) ctx.ui.notify('Task completed, but Pi stayed open: git pull failed or the session changed. Check Git manually, then /quit. Completion will not be retried.', 'warning');
-  return false;
-}
-
 /** Default remote companion. /quit and nonempty-editor exit input remain Pi-owned. */
-export function registerRemoteExit(pi: ExtensionAPI, getSession: () => RemoteSession | undefined, ownsLaunch = (_taskId: number) => false): void {
+export function registerRemoteExit(pi: ExtensionAPI, getSession: () => RemoteSession | undefined): void {
   let invalidate: (() => void) | undefined;
   let stop: (() => void) | undefined;
   let confirm: ((reason: 'exit' | 'new') => Promise<boolean>) | undefined;
@@ -88,9 +55,6 @@ export function registerRemoteExit(pi: ExtensionAPI, getSession: () => RemoteSes
         await session.action(view, done, undefined, () => current() && ctx.isIdle() && ctx.sessionManager.getLeafId() === branch);
         if (!current()) return false;
         if (session.view && session.view.state.selectedId == null) {
-          if (reason === 'exit' && typeof view.state.selectedId === 'number' && ownsLaunch(view.state.selectedId)) {
-            return await pullBeforeExit(pi, ctx, operation.signal, current);
-          }
           return true;
         }
         ctx.ui.notify('Pinote: Pi stayed in this session because the selection was not cleared. Refresh /pinote before retrying.', 'warning');

package/remote/ui.ts

@@ -4,7 +4,6 @@ import { NativeFooter } from './footer.ts';
 import { clean, cleanUnbounded, editorText, footerText, literal, type NativeControl, type NativeView } from './protocol.ts';
 import { RemoteFailure } from './client.ts';
 import { RemoteSession } from './session.ts';
-import { pullBeforeExit } from './exit.ts';
 import { inlineHeight, remoteMenu, type MenuState } from './menu.ts';
 
 const line = (text: string) => clean(text).replace(/\n/g, ' ');
@@ -114,10 +113,8 @@ export class RemoteUI {
       if (!current()) return false;
       if (control.id === 'done' && ctx.isIdle() && typeof view.state.selectedId === 'number' &&
           this.session.view && this.session.view.state.selectedId == null && this.exitOnComplete(view.state.selectedId)) {
-        if (await pullBeforeExit(this.pi, ctx, signal, current)) {
-          this.closing = true;
-          ctx.shutdown();
-        }
+        this.closing = true;
+        ctx.shutdown();
         return true;
       }
       if (result.preview) this.pi.appendEntry('pinote-remote-preview', { title: line(view.title), text: clean(result.preview) });

package/remote.ts

@@ -112,5 +112,5 @@ export default function pinoteRemote(pi: ExtensionAPI): void {
         (char) => `\\u${char.charCodeAt(0).toString(16).padStart(4, '0')}`),
     ].join('\n\n');
   });
-  registerRemoteExit(pi, () => session, ownsLaunch);
+  registerRemoteExit(pi, () => session);
 }