pi-note 0.29.1 → 0.31.0

package/README.md

@@ -63,14 +63,25 @@ No Kitty action handler is needed for this extension.
 
 Completion keeps the conversation and editor. With an empty editor, **Ctrl+D**
 (or your configured exit key) offers Cancel, Exit without completing, or Complete
-task and exit. Completion requires idle Pi and a current displayed revision;
-failures leave Pi open. `/quit` exits without completing.
-
-Reload/resume restores the active
-branch's selection; `/new` retains it. Unrelated fresh launches start unselected.
+task and exit. **`/new`** offers Cancel, Start new session without completing, or
+Complete task and start new session. With no selected task, `/new` proceeds normally.
+Completion requires idle Pi and a current displayed revision; failures keep the
+current session open. `/quit` exits without completing.
+
+Reload/resume restores the active branch's selection. Starting a new session
+without completing retains the selection; completing starts it unselected.
+Unrelated fresh launches start unselected.
 Changing endpoints starts a separate selection namespace. Unsaved Pi sessions
 cannot guarantee selection persistence.
 
+The GTK app's **Start in Kitty…** action (note 0.13.0+) chooses a working directory
+and opens a named tab with this task selected, without submitting a prompt. Client
+and service both need pi-note 0.31.0+. The one-shot `PINOTE_LAUNCH_TASK` environment
+handoff carries only the task ID and displayed revision, never task text or tokens.
+Only a fresh session can consume it. The service must share the GUI's database;
+missing/stale revisions fail closed. Resume, reload and `/new` never replay the
+handoff or replace another selection. Pi keeps its normal endpoint/token settings.
+
 ### Agent tools and context
 
 The extension registers `pinote_search`, `pinote_get_task`, `pinote_get_current`,

package/dist-mcp/mcp/core.js

@@ -29,6 +29,7 @@ const ProposalInput = z.union([NewProposal, ExistingProposal]);
 const Proposal = z.union([NewProposal.extend({ id: z.string().uuid() }), ExistingProposal.extend({ id: z.string().uuid() })]);
 const Context = z.object({ conversationId: z.string().min(1).max(256), contextId: z.string().min(1).max(256).optional(), state: z.object({
         proposal: Proposal.nullable().optional(),
+        launch: z.object({ task_id: TaskId, updated_at: z.string().min(1).max(128) }).strict().optional(),
         selectedId: z.number().int().positive().safe().nullable().optional(), screen: z.enum(['tasks', 'settings', 'field']).optional(),
         field: z.string().refine((value) => [...value].length <= 64, 'Field name exceeds 64 code points').optional(), search: z.string().max(256).optional(),
     }).default({}) });
@@ -128,7 +129,10 @@ async function selection(state, signal) {
     return { task, proposal, proposedTask };
 }
 async function snapshot(state, signal) {
-    const tasks = JSON.parse(await note(['list', '--json'], signal));
+    const launchTask = state.launch ? JSON.parse(await note(['agent', 'get', String(state.launch.task_id)], signal)) : null;
+    const tasks = state.launch
+        ? launchTask && ['active', 'in_progress'].includes(launchTask.state) ? [launchTask] : []
+        : JSON.parse(await note(['list', '--json'], signal));
     const { task, proposal, proposedTask } = await selection(state, signal);
     const config = settings();
     const suggestion = proposal && ('task_id' in proposal ? proposedTask : proposal);
@@ -223,7 +227,9 @@ function view(data, scoped = false, secondary = false, features = {}) {
         }
         controls.push({ id: 'add', label: 'New task', icon: icons.add, kind: 'text', multiline: true, value: '', confirm: 'Create and select this task?' });
         controls.push({ id: 'search', label: 'Filter tasks', kind: 'text', value: state.search ?? '' });
-        const matches = tasks.filter((t) => `${t.text} ${t.tag ?? ''}`.toLowerCase().includes((state.search ?? '').toLowerCase()));
+        const matches = tasks.filter((t) => state.launch
+            ? t.id === state.launch.task_id && t.updated_at === state.launch.updated_at
+            : `${t.text} ${t.tag ?? ''}`.toLowerCase().includes((state.search ?? '').toLowerCase()));
         for (const candidate of matches.slice(0, 200))
             action(`select:${candidate.id}`, `${candidate.tag ? `[${candidate.tag}] ` : ''}${candidate.text.split('\n')[0]}`, { description: `#${candidate.id} · ${candidate.state}`, confirm: 'Select and start this task for this conversation?' });
         if (matches.length > 200)
@@ -362,6 +368,7 @@ export function createPinoteServer(options = {}) {
         if (!control || (control.revision ?? before.revision) !== request.params.revision)
             staleAction();
         const next = { ...before.state };
+        delete next.launch; // A launcher filter is one-shot; ordinary navigation restores the list.
         let draft, preview;
         if (action === 'proposal:accept' || action === 'proposal:dismiss') {
             const proposal = before.state.proposal;
@@ -395,7 +402,7 @@ export function createPinoteServer(options = {}) {
             if (!candidate)
                 staleAction();
             const target = JSON.parse(await note(['agent', 'get', String(id)], extra.signal));
-            if (target.text !== candidate.text || target.state !== candidate.state || target.tag !== candidate.tag)
+            if (target.text !== candidate.text || target.state !== candidate.state || target.tag !== candidate.tag || state.launch && target.updated_at !== state.launch.updated_at)
                 staleAction();
             if (next.proposal)
                 await consume(next.proposal.id);

package/mcp/core.ts

@@ -30,6 +30,7 @@ const ProposalInput = z.union([NewProposal, ExistingProposal]);
 const Proposal = z.union([NewProposal.extend({ id: z.string().uuid() }), ExistingProposal.extend({ id: z.string().uuid() })]);
 const Context = z.object({ conversationId: z.string().min(1).max(256), contextId: z.string().min(1).max(256).optional(), state: z.object({
   proposal: Proposal.nullable().optional(),
+  launch: z.object({ task_id: TaskId, updated_at: z.string().min(1).max(128) }).strict().optional(),
   selectedId: z.number().int().positive().safe().nullable().optional(), screen: z.enum(['tasks', 'settings', 'field']).optional(),
   field: z.string().refine((value) => [...value].length <= 64, 'Field name exceeds 64 code points').optional(), search: z.string().max(256).optional(),
 }).default({}) });
@@ -110,7 +111,10 @@ async function selection(state: State, signal: AbortSignal) {
   return { task, proposal, proposedTask };
 }
 async function snapshot(state: State, signal: AbortSignal) {
-  const tasks: Task[] = JSON.parse(await note(['list', '--json'], signal));
+  const launchTask: Task | null = state.launch ? JSON.parse(await note(['agent', 'get', String(state.launch.task_id)], signal)) : null;
+  const tasks: Task[] = state.launch
+    ? launchTask && ['active', 'in_progress'].includes(launchTask.state) ? [launchTask] : []
+    : JSON.parse(await note(['list', '--json'], signal));
   const { task, proposal, proposedTask } = await selection(state, signal);
   const config = settings();
   const suggestion = proposal && ('task_id' in proposal ? proposedTask : proposal);
@@ -193,7 +197,9 @@ function view(data: Snapshot, scoped = false, secondary = false, features: { foo
     }
     controls.push({ id: 'add', label: 'New task', icon: icons.add, kind: 'text', multiline: true, value: '', confirm: 'Create and select this task?' });
     controls.push({ id: 'search', label: 'Filter tasks', kind: 'text', value: state.search ?? '' });
-    const matches = tasks.filter((t) => `${t.text} ${t.tag ?? ''}`.toLowerCase().includes((state.search ?? '').toLowerCase()));
+    const matches = tasks.filter((t) => state.launch
+      ? t.id === state.launch.task_id && t.updated_at === state.launch.updated_at
+      : `${t.text} ${t.tag ?? ''}`.toLowerCase().includes((state.search ?? '').toLowerCase()));
     for (const candidate of matches.slice(0, 200)) action(`select:${candidate.id}`, `${candidate.tag ? `[${candidate.tag}] ` : ''}${candidate.text.split('\n')[0]}`, { description: `#${candidate.id} · ${candidate.state}`, confirm: 'Select and start this task for this conversation?' });
     if (matches.length > 200) body += '\nShowing the first 200 matches; use Filter tasks to narrow the list.';
   }
@@ -303,6 +309,7 @@ server.setRequestHandler(Action, (request, extra) => serial(async () => {
   const control = view(before, scoped, secondaryActions(request.params._meta), footerFeatures(request.params._meta)).controls.find((item) => item.id === action);
   if (!control || (control.revision ?? before.revision) !== request.params.revision) staleAction();
   const next: State = { ...before.state };
+  delete next.launch; // A launcher filter is one-shot; ordinary navigation restores the list.
   let draft: string | undefined, preview: string | undefined;
   if (action === 'proposal:accept' || action === 'proposal:dismiss') {
     const proposal = before.state.proposal;
@@ -324,7 +331,7 @@ server.setRequestHandler(Action, (request, extra) => serial(async () => {
     const candidate = before.tasks.find((task) => task.id === id);
     if (!candidate) staleAction();
     const target: Task = JSON.parse(await note(['agent', 'get', String(id)], extra.signal));
-    if (target.text !== candidate.text || target.state !== candidate.state || target.tag !== candidate.tag) staleAction();
+    if (target.text !== candidate.text || target.state !== candidate.state || target.tag !== candidate.tag || state.launch && target.updated_at !== state.launch.updated_at) staleAction();
     if (next.proposal) await consume(next.proposal.id);
     await note(['agent', 'start', String(id), '--expected-updated-at', target.updated_at], extra.signal); next.selectedId = id; next.proposal = null;
   } else if (action === 'add') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-note",
-  "version": "0.29.1",
+  "version": "0.31.0",
   "description": "Persistent pinote tasks, Markdown handoffs, and task status for Pi",
   "license": "MIT",
   "type": "module",

package/remote/exit.ts

@@ -3,13 +3,11 @@ import { truncateToWidth } from '@earendil-works/pi-tui';
 import { clean } from './protocol.ts';
 import type { RemoteSession } from './session.ts';
 
-const leave = 'Exit without completing';
-const complete = 'Complete task and exit';
-
-/** Default remote companion. /quit and nonempty-editor input remain Pi-owned. */
+/** Default remote companion. /quit and nonempty-editor exit input remain Pi-owned. */
 export function registerRemoteExit(pi: ExtensionAPI, getSession: () => RemoteSession | undefined): void {
   let invalidate: (() => void) | undefined;
   let stop: (() => void) | undefined;
+  let confirm: ((reason: 'exit' | 'new') => Promise<boolean>) | undefined;
   pi.on('session_start', (_event, ctx) => {
     stop?.();
     if (ctx.mode !== 'tui' || !ctx.hasUI) return;
@@ -17,33 +15,36 @@ export function registerRemoteExit(pi: ExtensionAPI, getSession: () => RemoteSes
     let alive = true, pending = false, epoch = 0;
     let controller: AbortController | undefined;
     invalidate = () => { epoch++; controller?.abort(); };
-    const exit = async () => {
-      if (!alive || pending) return;
+    confirm = async (reason) => {
+      if (!alive || pending) return false;
+      const leave = reason === 'new' ? 'Start new session without completing' : 'Exit without completing';
+      const complete = reason === 'new' ? 'Complete task and start new session' : 'Complete task and exit';
       pending = true;
       const generation = epoch, session = getSession();
       const operation = controller = new AbortController();
       const sessionId = ctx.sessionManager.getSessionId();
+      const draft = ctx.ui.getEditorText();
       const validSession = session?.current();
       const current = () => alive && generation === epoch && !operation.signal.aborted &&
         session === getSession() && !!validSession?.() &&
-        ctx.sessionManager.getSessionId() === sessionId && ctx.ui.getEditorText().length === 0;
-      const shutdown = () => { if (!ctx.isIdle()) ctx.abort(); ctx.shutdown(); };
+        ctx.sessionManager.getSessionId() === sessionId &&
+        (reason === 'exit' ? ctx.ui.getEditorText().length === 0 : ctx.ui.getEditorText() === draft);
       try {
         if (!session) throw new Error('unavailable');
         await session.refresh(true);
-        if (!current()) return;
+        if (!current()) return false;
         const view = session.view;
         if (!view) throw new Error('unavailable');
-        if (view.state.selectedId == null) { shutdown(); return; }
+        if (view.state.selectedId == null) return true;
         const branch = ctx.sessionManager.getLeafId();
         const done = view.controls.find((c) => c.id === 'done' && c.kind === 'action');
         const title = truncateToWidth(clean((view.body ?? view.title).split('\n', 1)[0]), 70);
         const choice = await ctx.ui.select(`Pinote · ${title}`, ['Cancel', leave, complete], {
           signal: AbortSignal.any([operation.signal, session.signal]),
         });
-        if (!current()) return;
-        if (choice === leave) { shutdown(); return; }
-        if (choice !== complete) return;
+        if (!current()) return false;
+        if (choice === leave) return true;
+        if (choice !== complete) return false;
         const latest = session.view;
         if (!ctx.isIdle() || ctx.sessionManager.getLeafId() !== branch || !done ||
             !latest || latest.state.selectedId !== view.state.selectedId || latest.revision !== view.revision ||
@@ -51,13 +52,20 @@ export function registerRemoteExit(pi: ExtensionAPI, getSession: () => RemoteSes
           throw new Error('changed');
         }
         // Approval belongs to this exact displayed view, never to a refreshed revision.
-        await session.action(view, done, undefined, () => ctx.isIdle());
-        if (!current()) return;
-        if (session.view && session.view.state.selectedId == null) ctx.shutdown();
-        else ctx.ui.notify('Pinote: Pi stayed open because the selection was not cleared. Refresh /pinote before retrying.', 'warning');
+        await session.action(view, done, undefined, () => current() && ctx.isIdle() && ctx.sessionManager.getLeafId() === branch);
+        if (!current()) return false;
+        if (session.view && session.view.state.selectedId == null) return true;
+        ctx.ui.notify('Pinote: Pi stayed in this session because the selection was not cleared. Refresh /pinote before retrying.', 'warning');
       } catch {
-        if (alive && generation === epoch) ctx.ui.notify('Pinote: Pi stayed open. Completion was not confirmed and may have committed; refresh /pinote before retrying. /quit exits without completing.', 'warning');
+        if (alive && generation === epoch) ctx.ui.notify('Pinote: Pi stayed in this session. Completion was not confirmed and may have committed; refresh /pinote before retrying. /quit exits without completing.', 'warning');
       } finally { pending = false; }
+      return false;
+    };
+    const exit = async () => {
+      if (await confirm?.('exit')) {
+        if (!ctx.isIdle()) ctx.abort();
+        ctx.shutdown();
+      }
     };
     const factory: NonNullable<ReturnType<typeof ctx.ui.getEditorComponent>> = (tui, theme, keybindings) => {
       const editor = previous ? previous(tui, theme, keybindings) : new CustomEditor(tui, theme, keybindings);
@@ -75,10 +83,15 @@ export function registerRemoteExit(pi: ExtensionAPI, getSession: () => RemoteSes
       if (ctx.ui.getEditorComponent() === factory) ctx.ui.setEditorComponent(previous);
     };
   });
-  pi.on('session_shutdown', () => { stop?.(); stop = invalidate = undefined; });
+  pi.on('session_shutdown', () => { stop?.(); stop = invalidate = confirm = undefined; });
   const interrupted = () => { invalidate?.(); };
   pi.on('agent_start', interrupted);
-  pi.on('session_before_switch', interrupted);
+  pi.on('session_before_switch', async (event, ctx) => {
+    interrupted();
+    if (event.reason === 'new' && ctx.mode === 'tui' && ctx.hasUI && !await confirm?.('new')) {
+      return { cancel: true };
+    }
+  });
   pi.on('session_before_fork', interrupted);
   pi.on('session_before_tree', interrupted);
 }

package/remote.ts

@@ -14,6 +14,8 @@ const transfers: Map<string, SavedState> = ((globalThis as any)[key] ??= new Map
 export default function pinoteRemote(pi: ExtensionAPI): void {
   let session: RemoteSession | undefined, ui: RemoteUI | undefined;
   let file: string | undefined;
+  let launchRequest = process.env.PINOTE_LAUNCH_TASK;
+  delete process.env.PINOTE_LAUNCH_TASK; // Never inherit consent into another Pi process or /reload.
   const getSession = () => { if (!session) throw new RemoteFailure(); return session; };
   registerTools(pi, getSession);
   registerPreview(pi);
@@ -34,6 +36,7 @@ export default function pinoteRemote(pi: ExtensionAPI): void {
   pi.registerCommand('pinote', { description: 'Open remote Pinote tasks and settings', handler: open });
   pi.registerCommand('pi-note', { description: 'Open remote Pinote (compatibility alias)', handler: open });
   const start = async (ctx: ExtensionContext, reason?: string, previous?: string) => {
+    const request = launchRequest; launchRequest = undefined; // Never replay an uncertain start.
     ui?.detach(); await session?.stop();
     ui = undefined; session = undefined;
     try {
@@ -42,12 +45,34 @@ export default function pinoteRemote(pi: ExtensionAPI): void {
       ui = new RemoteUI(pi, session);
       ui.attach(ctx);
       file = ctx.sessionManager.getSessionFile();
-      const carried = reason === 'new' && previous ? transfers.get(previous) : undefined;
-      await session.start(ctx.sessionManager.getBranch(), ctx.sessionManager.getSessionId() || randomUUID(), carried);
+      const branch = ctx.sessionManager.getBranch();
+      let carried = reason === 'new' && previous ? transfers.get(previous) : undefined;
+      let launch: { task_id: number; updated_at: string } | undefined;
+      if (request) {
+        try {
+          if (reason !== 'startup' || branch.some((entry) => entry.type === 'message' || entry.type === 'custom' && entry.customType === ENTRY_TYPE)) throw new Error('Launch requires a fresh Pi session');
+          const parsed = JSON.parse(request);
+          if (!parsed || !Number.isSafeInteger(parsed.task_id) || parsed.task_id < 1 ||
+              typeof parsed.updated_at !== 'string' || !parsed.updated_at.length || parsed.updated_at.length > 128) throw new Error('Invalid launch request');
+          launch = { task_id: parsed.task_id, updated_at: parsed.updated_at };
+          carried = { scope: config.scope, contextId: randomUUID(), state: { launch } };
+        } catch {
+          ctx.ui.notify('Pinote launch ignored: invalid request or nonempty/resumed session. Existing selection is unchanged.', 'warning');
+        }
+      }
+      await session.start(branch, ctx.sessionManager.getSessionId() || randomUUID(), carried);
+      if (launch) {
+        const view = session.view!;
+        // The service exposes this control only for the exact GUI-displayed revision.
+        if (JSON.stringify(view.state.launch) !== JSON.stringify(launch)) throw new Error('Service does not support launch handoffs');
+        const control = view.controls.find((item) => item.id === `select:${launch.task_id}`);
+        if (!control) throw new Error('Launch task changed or belongs to another service');
+        await session.action(view, control); // The directory chooser's Start click granted consent.
+      }
       if (reason === 'new' && previous) transfers.delete(previous);
     } catch (error) {
       // Configuration messages are fixed strings; transport response bodies are never shown.
-      ctx.ui.notify(error instanceof RemoteFailure ? error.message : 'Pinote unavailable: check PINOTE_URL and private token configuration, then /reload.', 'warning');
+      ctx.ui.notify(error instanceof RemoteFailure ? error.message : 'Pinote unavailable or launch task changed: check the service, task revision and private token configuration. Use /pinote to select manually; launch requests are never retried.', 'warning');
     }
   };
   pi.on('session_start', (event, ctx) => start(ctx, event.reason, event.previousSessionFile));