pi-note 0.11.0 → 0.11.1

package/README.md

@@ -63,7 +63,7 @@ they are not copied into the draft. The default prompt asks for a summary, not i
 Existing drafts are preserved; nothing is submitted automatically.
 With a selected task it offers **Continue**, **Done**, **Switch task**, and **Settings**.
 Press **Tab** from the task menu or picker to open global settings; Tab
-returns to tasks without saving. Settings also lists fields found on the current
+returns to tasks, keeping saved changes. Settings also lists fields found on the current
 task, so existing values can be configured without creating another task.
 Type in the task picker to filter by text, ID, tag, or state (all words must match).
 Use ↑/↓ and Enter to select, or Esc to cancel. Rows show **●** for in progress or
@@ -110,10 +110,11 @@ values or unreadable/malformed configuration suppress offers; interactive startu
 warns until you fix the file and reload. No project-local configuration is read.
 
 In `/pi-note → Settings`, select **Task prompt** to edit the text inserted after
-selection or **Continue**. **Shift+Enter** or **Ctrl+J** adds a newline; **Enter** applies it to
-the settings draft, **Ctrl+C** clears it, and **Esc** cancels that edit. Select **Save settings** to
-persist it globally; leaving Settings with **Esc** or **Tab** discards the draft.
-Saving never changes existing editor input or submits anything.
+selection or **Continue**. **Shift+Enter** or **Ctrl+J** adds a newline; **Enter** saves it
+globally, **Ctrl+C** clears the edit, and **Esc** cancels that unfinished edit.
+Settings and fields save automatically after each confirmed change; no separate
+Save action is needed. Leaving Settings with **Esc** or **Tab** keeps saved changes
+and discards only unfinished input. Saving never changes existing editor input or submits anything.
 
 Task selection and **Continue** reread `handoffPrompt` each time; changing that
 field needs no `/reload`. Its value is literal text, not a prompt template; use
@@ -209,9 +210,12 @@ accepted. Missing/blank values do not display and do not consume the field limit
 In `/pi-note → Settings`, **Add field** adds a global display definition, not a
 task value. Select any field to edit **Link**, **Label**, **Format**, and **Width**.
 Label starts as the field name; clear it for no prefix. Link off displays plain
-text without a clickable link. **Save** persists the draft; cancellation leaves
-configuration untouched. Saves include the task prompt and preserve unrelated
-settings (such as `taskOfferPolicy`) and reject configuration changes made while the dialog was open.
+text without a clickable link. Toggles, field additions/removals, and edits confirmed
+with **Enter** save immediately. **Esc** returns from a field to settings without
+undoing saved changes. Invalid edits and failed saves stay open with an error;
+failed saves leave saved values unchanged and can be retried. Saves include the task
+prompt, preserve unrelated settings (such as `taskOfferPolicy`), and reject external
+configuration changes made since opening settings or the last successful save.
 Concurrent saves use `pi-note.json.lock`; remove stale locks only when no save is
 running. Symlinked configuration must be edited manually; saves never replace the link.
 

package/footer-config.ts

@@ -90,7 +90,7 @@ export function loadFooterConfig(warn: (message: string) => void): FooterConfig
 
 // Synchronous compare-and-replace: reject edits made while the settings dialog was open,
 // preserve unrelated keys, and never leave partial JSON behind.
-export function saveFooterConfig(config: FooterConfig, expectedRaw: string | null, handoffPrompt?: string): FooterConfig {
+export function saveFooterConfig(config: FooterConfig, expectedRaw: string | null, handoffPrompt?: string) {
   const checked = parseFooterConfig({ footer: config });
   const prompt = handoffPrompt === undefined ? {} : { handoffPrompt: parseHandoffPrompt(handoffPrompt) };
   const directory = getAgentDir();
@@ -101,15 +101,17 @@ export function saveFooterConfig(config: FooterConfig, expectedRaw: string | nul
   try { descriptor = openSync(lock, "wx", 0o600); }
   catch { throw new Error("Pinote settings are locked. Retry after another save finishes; remove a stale pi-note.json.lock only when no save is running."); }
   const temp = join(directory, `.pi-note-${randomUUID()}.tmp`);
+  let raw: string;
   try {
     if (readRaw() !== expectedRaw) throw new Error("Pi-note configuration changed while settings were open. Reopen settings before saving.");
     if (lstatSync(path, { throwIfNoEntry: false })?.isSymbolicLink()) throw new Error("pi-note.json is a symlink. Edit its target manually rather than replacing the link.");
     const root = expectedRaw === null ? {} : JSON.parse(expectedRaw);
     if (!object(root)) throw new Error("Invalid pi-note configuration; expected an object.");
-    writeFileSync(temp, `${JSON.stringify({ ...root, ...prompt, footer: checked }, null, 2)}\n`, { flag: "wx", mode: 0o600 });
+    raw = `${JSON.stringify({ ...root, ...prompt, footer: checked }, null, 2)}\n`;
+    writeFileSync(temp, raw, { flag: "wx", mode: 0o600 });
     renameSync(temp, path);
   } finally { rmSync(temp, { force: true }); closeSync(descriptor); rmSync(lock, { force: true }); }
-  return checked;
+  return { config: checked, raw };
 }
 
 export function effectiveFooterFields(config: FooterConfig, notes: Record<string, string> = {}): FooterField[] {

package/footer-settings.ts

@@ -44,7 +44,8 @@ export class FooterSettings {
   private knownFields: string[];
   private theme: Theme;
   private matches: Matches;
-  private done: (result: PinoteSettings | "tasks" | undefined) => void;
+  private done: (result: "tasks" | undefined) => void;
+  private save: (settings: PinoteSettings) => void;
   private requestRender: () => void;
   private index = 0;
   private field?: FooterField;
@@ -53,10 +54,12 @@ export class FooterSettings {
   private hasFocus = false;
 
   constructor(config: PinoteSettings, knownFields: string[], theme: Theme, matches: Matches,
-    done: (result: PinoteSettings | "tasks" | undefined) => void, requestRender: () => void, createEditor: () => Editor) {
+    done: (result: "tasks" | undefined) => void, requestRender: () => void, createEditor: () => Editor,
+    save: (settings: PinoteSettings) => void) {
     this.draft = structuredClone(config.footer);
     this.prompt = config.handoffPrompt;
     this.createEditor = createEditor;
+    this.save = save;
     this.draft.fields ??= [];
     this.knownFields = [...new Set(knownFields)].filter((name) => name !== "Bar");
     this.theme = theme; this.matches = matches; this.done = done; this.requestRender = requestRender;
@@ -76,6 +79,20 @@ export class FooterSettings {
   private validate(field: FooterField): FooterField {
     return parseFooterConfig({ footer: { fields: [field] } }).fields![0];
   }
+  private persist(footer = this.draft, handoffPrompt = this.prompt) {
+    const settings = { footer: parseFooterConfig({ footer }), handoffPrompt: parseHandoffPrompt(handoffPrompt) };
+    this.save(structuredClone(settings));
+    this.draft = settings.footer;
+    this.prompt = settings.handoffPrompt;
+  }
+  private persistField(field: FooterField) {
+    const candidate = this.validate(field);
+    const fields = this.draft.fields!.filter((entry) => entry.name !== candidate.name);
+    const index = this.draft.fields!.findIndex((entry) => entry.name === candidate.name);
+    fields.splice(index < 0 ? fields.length : index, 0, candidate);
+    this.persist({ ...this.draft, fields });
+    this.field = candidate;
+  }
   private edit(name: string) {
     this.field = structuredClone(this.draft.fields!.find((field) => field.name === name) ?? defaultFooterField(name));
     this.index = 0; this.error = "";
@@ -86,7 +103,7 @@ export class FooterSettings {
       action: () => this.ask(key, String(this.draft[key]), (value) => {
         const candidate = { ...this.draft, [key]: Number(value) };
         if (!value.trim()) throw new Error("Enter a number.");
-        this.draft = parseFooterConfig({ footer: candidate });
+        this.persist(candidate);
       }),
     }));
     rows.push({ label: `Task prompt: ${display(this.prompt)}`, action: () => {
@@ -101,40 +118,36 @@ export class FooterSettings {
     }
     rows.push({ label: "+ Add field", action: () => this.ask("Field name", "", (value) => {
       const field = this.validate(defaultFooterField(value));
-      this.edit(field.name);
-    }) }, { label: "Save settings", action: () => this.done({ footer: parseFooterConfig({ footer: this.draft }), handoffPrompt: parseHandoffPrompt(this.prompt) }) },
+      if (this.draft.fields!.some((entry) => entry.name === field.name)) this.edit(field.name);
+      else {
+        this.persistField(field);
+        this.index = 0;
+      }
+    }) },
     { label: "Return to tasks", action: () => this.done("tasks") });
     return rows;
   }
   private fieldRows(): Row[] {
     const field = this.field!;
     const rows: Row[] = [
-      { label: `Link: ${field.link ? "on" : "off (plain text)"}`, action: () => { field.link = !field.link; } },
+      { label: `Link: ${field.link ? "on" : "off (plain text)"}`, action: () => this.persistField({ ...field, link: !field.link }) },
       { label: `Label: ${display(field.label) || "(none)"}`, action: () => this.ask("Label (empty = no prefix)", field.label, (value) => {
-        this.field = this.validate({ ...field, label: value });
+        this.persistField({ ...field, label: value });
       }) },
       { label: `Format: ${display(field.format) || "(empty)"}`, action: () => this.ask("Format: <value>, <url>, <number>", field.format, (value) => {
-        this.field = this.validate({ ...field, format: value });
+        this.persistField({ ...field, format: value });
       }) },
       { label: `Width: ${field.width ?? `default (${this.draft.fieldWidth})`}`, action: () => this.ask("Width (empty = default)", field.width === undefined ? "" : String(field.width), (value) => {
         const candidate = { ...field };
         if (value.trim()) candidate.width = Number(value); else delete candidate.width;
-        this.field = this.validate(candidate);
+        this.persistField(candidate);
       }) },
-      { label: "Save field", action: () => {
-        const candidate = this.validate(field);
-        const fields = this.draft.fields!.filter((entry) => entry.name !== candidate.name);
-        const index = this.draft.fields!.findIndex((entry) => entry.name === candidate.name);
-        fields.splice(index < 0 ? fields.length : index, 0, candidate);
-        this.draft = parseFooterConfig({ footer: { ...this.draft, fields } });
-        this.field = undefined; this.index = 0;
-      } },
     ];
     if (this.draft.fields!.some((entry) => entry.name === field.name)) rows.push({ label: "Remove field", action: () => {
-      this.draft.fields = this.draft.fields!.filter((entry) => entry.name !== field.name);
+      this.persist({ ...this.draft, fields: this.draft.fields!.filter((entry) => entry.name !== field.name) });
       this.field = undefined; this.index = 0;
     } });
-    rows.push({ label: "Cancel field", action: () => { this.field = undefined; this.index = 0; } });
+    rows.push({ label: "Back to settings", action: () => { this.field = undefined; this.index = 0; } });
     return rows;
   }
   handleInput(data: string) {
@@ -146,7 +159,7 @@ export class FooterSettings {
         else if (this.matches(data, "tui.select.cancel")) this.editor = undefined;
         else if (this.matches(data, "tui.input.newLine")) this.editor.handleInput(data);
         else if (this.matches(data, "tui.select.confirm")) {
-          this.prompt = parseHandoffPrompt(this.editor.getExpandedText());
+          this.persist(this.draft, this.editor.getExpandedText());
           this.editor = undefined;
         } else this.editor.handleInput(data);
       } else if (this.input) {
@@ -172,10 +185,10 @@ export class FooterSettings {
     const lines = [this.theme.fg("accent", "Pinote — Global Settings"), this.theme.fg("dim", "Tasks (Tab) · Settings · Fields")];
     if (this.editor) {
       lines.push(this.theme.fg("accent", "Task prompt"), ...this.editor.render(width),
-        this.theme.fg("dim", "Enter apply · Shift+Enter/Ctrl+J newline · Ctrl+C clear · Esc cancel"));
+        this.theme.fg("dim", "Enter save · Shift+Enter/Ctrl+J newline · Ctrl+C clear · Esc cancel edit"));
     } else if (this.input) {
       lines.push(this.theme.fg("accent", this.input.heading), ...this.input.widget.render(width),
-        this.theme.fg("dim", "Enter apply to draft · Esc cancel"));
+        this.theme.fg("dim", "Enter save · Esc cancel edit"));
     } else {
       if (this.field) lines.push(this.theme.fg("accent", `Field: ${display(this.field.name)}`));
       const rows = this.field ? this.fieldRows() : this.rootRows();
@@ -184,10 +197,10 @@ export class FooterSettings {
       lines.push(...rows.slice(start, start + 8).map((row, offset) => offset + start === this.index
         ? this.theme.fg("accent", `> ${row.label}`) : `  ${row.label}`));
       if (rows.length > 8) lines.push(this.theme.fg("dim", `${this.index + 1}/${rows.length}`));
-      lines.push(this.theme.fg("dim", "↑↓ navigate · Enter edit · Esc cancel"));
+      lines.push(this.theme.fg("dim", "↑↓ navigate · Enter edit · Esc back"));
     }
     if (this.error) lines.push(this.theme.fg("error", this.error));
-    lines.push(this.theme.fg("dim", "Tab: tasks, discard draft · Save settings: persist globally"));
+    lines.push(this.theme.fg("dim", "Changes save automatically · Tab: tasks"));
     return lines.map((line) => truncateToWidth(line, width));
   }
   invalidate() { this.input?.widget.invalidate(); this.editor?.invalidate(); }

package/index.ts

@@ -380,7 +380,8 @@ export default function (pi: ExtensionAPI) {
               footer: { ...document.config, fields: effectiveFooterFields(document.config, current?.agent_notes) },
               handoffPrompt: "handoffPrompt" in root ? parseHandoffPrompt(root.handoffPrompt) : defaultHandoffPrompt,
             };
-            const edited = await ctx.ui.custom<PinoteSettings | "tasks" | undefined>((tui, theme, kb, done) =>
+            let expectedRaw = document.raw;
+            const edited = await ctx.ui.custom<"tasks" | undefined>((tui, theme, kb, done) =>
               new FooterSettings(config, Object.keys(current?.agent_notes ?? {}).filter((name) => name !== "Bar"),
                 theme, (data, action) => kb.matches(data, action as Keybinding), done, () => tui.requestRender(),
                 () => new Editor(tui, {
@@ -388,12 +389,16 @@ export default function (pi: ExtensionAPI) {
                   selectList: { selectedPrefix: (line) => theme.fg("accent", line), selectedText: (line) => theme.fg("accent", line),
                     description: (line) => theme.fg("muted", line), scrollInfo: (line) => theme.fg("dim", line),
                     noMatch: (line) => theme.fg("warning", line) },
-                })));
+                }), (updated) => {
+                  if (!canAct()) throw new Error("This session changed. Reopen settings before editing.");
+                  const saved = saveFooterConfig(updated.footer, expectedRaw, updated.handoffPrompt);
+                  expectedRaw = saved.raw;
+                  footerConfig = saved.config;
+                  void refresh(ctx);
+                }));
             if (!canAct() || edited === undefined) return;
-            if (edited === "tasks") { settings = false; continue; }
-            footerConfig = saveFooterConfig(edited.footer, document.raw, edited.handoffPrompt);
-            ctx.ui.notify("Global Pinote settings saved.", "info");
-            return;
+            settings = false;
+            continue;
           }
           const action = current
             ? await ctx.ui.custom<string | undefined>((tui, theme, kb, done) =>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-note",
-  "version": "0.11.0",
+  "version": "0.11.1",
   "description": "Persistent pinote tasks, Markdown handoffs, and task status for Pi",
   "license": "MIT",
   "type": "module",