pi-namespace-patch 1.0.2-namespace.2 → 1.0.4-namespace.1

package/dist/modes/interactive/interactive-mode.js

@@ -11,7 +11,7 @@ import * as TuiLayouts from "@earendil-works/pi-tui";
 import { CombinedAutocompleteProvider, Container, fuzzyFilter, getCapabilities, hyperlink, Markdown, matchesKey, Spacer, setCapabilityOverrides, setKeybindings, Text, TruncatedText, TuiAltScreen, TuiMainScreen, visibleWidth, } from "@earendil-works/pi-tui";
 import chalk from "chalk";
 import { spawn } from "child_process";
-import { APP_NAME, APP_TITLE, CONFIG_DIR_NAME, getAgentDir, getAuthPath, getDebugLogPath, getDocsPath, VERSION, } from "../../config.js";
+import { APP_NAME, APP_TITLE, CONFIG_DIR_NAME, detectInstallChange, getAgentDir, getAuthPath, getDebugLogPath, getDocsPath, VERSION, } from "../../config.js";
 import { parseSkillBlock } from "../../core/agent-session.js";
 import { SessionImportFileNotFoundError } from "../../core/agent-session-runtime.js";
 import { CACHE_TTL_MS, collectCacheMisses, computeCacheWaste, detectCacheMiss, } from "../../core/cache-stats.js";
@@ -129,7 +129,9 @@ function isCompactionCostNotice(item) {
 function isUsageSessionEntry(item) {
     return "type" in item && item.type === "usage";
 }
-const DEAD_TERMINAL_ERROR_CODES = new Set(["EIO", "EPIPE", "ENOTCONN"]);
+// EIO: tty reads/ioctls from an orphaned background process group, or writes after hangup.
+// ENOTTY: the tty was revoked (macOS) and stdin is no longer a terminal.
+const DEAD_TERMINAL_ERROR_CODES = new Set(["EIO", "EPIPE", "ENOTCONN", "ENOTTY"]);
 function isDeadTerminalError(error) {
     if (!error || typeof error !== "object" || !("code" in error)) {
         return false;
@@ -314,6 +316,7 @@ export class InteractiveMode {
     shutdownRequested = false;
     /** The `/bug` hint is shown at most once per session so error output stays readable. */
     bugReportHintShown = false;
+    installChangeWarningShown = false;
     // Extension UI state
     extensionSelector = undefined;
     extensionInput = undefined;
@@ -1661,8 +1664,32 @@ export class InteractiveMode {
             return;
         if (/\b(?:abort(?:ed)?|cancel(?:l?ed)?)\b/i.test(message.errorMessage ?? ""))
             return;
+        if (this.maybeShowInstallChangeWarning())
+            return;
         this.suggestBugReport();
     }
+    /**
+     * After an error, check whether an update replaced or removed this install while the session ran.
+     * Code loaded on demand then fails with missing modules until restart (#10439). Returns true when
+     * the install changed.
+     */
+    maybeShowInstallChangeWarning() {
+        if (this.installChangeWarningShown)
+            return true;
+        const change = detectInstallChange();
+        if (!change)
+            return false;
+        this.installChangeWarningShown = true;
+        const cause = change.kind === "updated"
+            ? `${APP_NAME} was updated to ${change.version} while this session was running (${VERSION})`
+            : `The ${APP_NAME} installation this session runs from was removed or replaced`;
+        const resumeCommand = formatResumeCommand(this.sessionManager);
+        const restart = resumeCommand
+            ? `Restart with \`${resumeCommand}\` to continue this session.`
+            : `Restart ${APP_NAME}.`;
+        this.showWarning(`${cause}. Features that load code on demand can fail until restart. ${restart}`);
+        return true;
+    }
     renderCurrentSessionState() {
         this.loadedResourcesContainer.clear();
         this.chatContainer.clear();
@@ -2905,6 +2932,8 @@ export class InteractiveMode {
                 break;
             }
             case "tool_execution_end": {
+                if (event.isError)
+                    this.maybeShowInstallChangeWarning();
                 const component = this.pendingTools.get(event.toolCallId);
                 if (component) {
                     component.updateResult({ ...event.result, isError: event.isError });
@@ -3489,6 +3518,10 @@ export class InteractiveMode {
      * paste / Kitty / modifyOtherKeys sequences.
      */
     uncaughtCrash(error) {
+        // A dead terminal is not a pi crash. Do not try to restore it or record it.
+        if (isDeadTerminalError(error)) {
+            this.emergencyTerminalExit();
+        }
         if (this.isShuttingDown) {
             process.exit(1);
         }
@@ -3547,10 +3580,13 @@ export class InteractiveMode {
             }
             throw error;
         };
-        process.stdout.on("error", terminalErrorHandler);
-        process.stderr.on("error", terminalErrorHandler);
-        this.signalCleanupHandlers.push(() => process.stdout.off("error", terminalErrorHandler));
-        this.signalCleanupHandlers.push(() => process.stderr.off("error", terminalErrorHandler));
+        // stdin needs the handler too: once the terminal is gone, reads and setRawMode
+        // fail with EIO (orphaned background process group) or ENOTTY (revoked tty).
+        // Node emits these as stream errors, which are uncaught without a listener.
+        for (const stream of [process.stdin, process.stdout, process.stderr]) {
+            stream.on("error", terminalErrorHandler);
+            this.signalCleanupHandlers.push(() => stream.off("error", terminalErrorHandler));
+        }
         // Restore the terminal before the process dies on any uncaught throw.
         // Without this, an unhandled exception from extension code (or anywhere
         // in pi) leaves the terminal in raw mode with no cursor.