pi-multimodal-proxy 1.18.0 → 1.18.1

package/CHANGELOG.md

@@ -4,6 +4,16 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 
+## [1.18.1] - 2026-08-30
+
+### Fixed (post-release review of 1.18.0)
+
+- **The stage-2 syntax gate was a silent no-op on Windows.** `tools/check-syntax.mjs` compared `walk()` paths (backslash separators) against TypeScript-normalized source-file names (forward slashes), so the `has()` filter dropped every diagnostic — a planted `await`-in-non-async probe passed the gate. Both sides are now normalized; the planted-probe test fails the gate as intended. (Linux CI paths happened to match, so releases were still protected — local/dev Windows runs were not.)
+- **Default-substitution notice no longer fires when the proxy is `off`** — model resolution is irrelevant with media analysis disabled.
+- **The substitution hint is now cause-aware**: when the substituted-from model is missing from the catalog the notice suggests updating pi / pinning a model, instead of the (wrong) `pi --login` key hint that only fits the no-API-key case.
+- **`writePersisted`'s fire-and-forget status refresh gained a `.catch`** — a rejected key probe can no longer surface as an unhandled promise rejection in daemon processes.
+- **`withModelFallback` skips the 5 async key probes for explicit configs** (`PI_VISION_PROXY_MODEL` or persisted `modelExplicit`), where resolution is a no-op by definition.
+
 ## [1.18.0] - 2026-08-30
 
 ### Added

package/extensions/vision-proxy.ts

@@ -667,9 +667,10 @@ function shouldStripImages(config: VisionConfig, model: ExtensionContext["model"
  * this runs on every prompt, tool result, and status refresh.
  */
 async function withModelFallback(config: VisionConfig, ctx: ExtensionContext): Promise<VisionConfig> {
-	const hasModel = (p: string, m: string) => Boolean(ctx.modelRegistry.find(p, m));
-	if (envFlags().model) return applyDefaultModelFallback(config, hasModel, true);
+	// Explicit choices are never rewritten — skip the key probes entirely.
+	if (envFlags().model || config.modelExplicit === true) return config;
 
+	const hasModel = (p: string, m: string) => Boolean(ctx.modelRegistry.find(p, m));
 	const state = getSessionState(ctx);
 	state.keyProbe ??= new Map<string, boolean>();
 	const probe = async (p: string, m: string): Promise<boolean> => {
@@ -708,6 +709,8 @@ async function withModelFallback(config: VisionConfig, ctx: ExtensionContext): P
  * configured model — e.g. no zai key → deepseek/deepseek-v4-flash-vision-exp.
  */
 function notifyDefaultSubstitution(config: VisionConfig, resolved: VisionConfig, ctx: ExtensionContext): void {
+	// Proxy disabled — model resolution is irrelevant, don't add noise.
+	if (resolved.mode === "off") return;
 	const state = getSessionState(ctx);
 	const before = `${config.provider}/${config.modelId}`;
 	const after = `${resolved.provider}/${resolved.modelId}`;
@@ -715,11 +718,11 @@ function notifyDefaultSubstitution(config: VisionConfig, resolved: VisionConfig,
 	const key = `${before}→${after}`;
 	if (state.notifiedDefaultSub === key) return;
 	state.notifiedDefaultSub = key;
-	ctx.ui.notify(
-		`[multimodal-proxy] Vision default resolved to ${after} (${before} not usable here). ` +
-			`Pin a model with /multimodal-proxy model, or add a key: pi --login ${config.provider}`,
-		"info",
-	);
+	const missingFromCatalog = !ctx.modelRegistry.find(config.provider, config.modelId);
+	const hint = missingFromCatalog
+		? "update pi (older model catalog), or pin a model with /multimodal-proxy model"
+		: `add a key: pi --login ${config.provider} — or pin a model with /multimodal-proxy model`;
+	ctx.ui.notify(`[multimodal-proxy] Vision default resolved to ${after} (${before} not usable here). ${hint}`, "info");
 }
 
 // ── Content sniffing (Pi ≥ 0.84.4) ───────────────────────────────────────
@@ -2814,9 +2817,13 @@ export default function (pi: ExtensionAPI) {
 				const eff = resolveConfig(ctx.sessionManager.getEntries(), process.env, _fileConfig);
 				// Fire-and-forget: writePersisted stays synchronous for its ~30 call
 				// sites; the status refresh just needs the resolved model eventually.
-				void withModelFallback(eff, ctx).then((resolved) =>
+				void withModelFallback(eff, ctx)
+				.then((resolved) =>
 					ctx.ui.setStatus("multimodal-proxy", steadyStatusText(resolved, ctx.modelRegistry)),
-				);
+				)
+				.catch(() => {
+					// Key probing must never surface as an unhandled rejection in daemons.
+				});
 				return validated;
 			};
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-multimodal-proxy",
-  "version": "1.18.0",
+  "version": "1.18.1",
   "description": "Automatic image, video and audio description for any model in Pi. Routes media to a multimodal model and injects descriptions into context.",
   "keywords": [
     "pi-package"