pi-model-profiles 0.3.3 → 0.3.4

package/CHANGELOG.md

@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.3.4] - 2026-06-16
+
+### Fixed
+- Resolved symlinks before writing agent markdown to avoid overwriting the symlink target's parent instead of the linked file.
+- Used `parseCompleteNumericScalar` for frontmatter number parsing to handle trailing non-numeric characters correctly.
+
 ## [0.3.3] - 2026-06-01
 
 ### Changed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-model-profiles",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "private": false,
   "description": "Pi extension for saving, importing, and applying agent model frontmatter profiles.",
   "type": "module",
@@ -57,8 +57,8 @@
     ]
   },
   "peerDependencies": {
-    "@earendil-works/pi-coding-agent": "^0.74.0 || ^0.75.0 || ^0.77.0 || ^0.78.0",
-    "@earendil-works/pi-tui": "^0.74.0 || ^0.75.0 || ^0.77.0 || ^0.78.0"
+    "@earendil-works/pi-coding-agent": "^0.74.0 || ^0.75.0 || ^0.77.0 || ^0.78.0 || ^0.79.0",
+    "@earendil-works/pi-tui": "^0.74.0 || ^0.75.0 || ^0.77.0 || ^0.78.0 || ^0.79.0"
   },
   "publishConfig": {
     "access": "public"

package/src/agent-writer.ts

@@ -1,4 +1,4 @@
-import { existsSync, readdirSync, readFileSync } from "node:fs";
+import { existsSync, lstatSync, readdirSync, readFileSync, realpathSync } from "node:fs";
 import { basename, dirname, join, resolve } from "node:path";
 
 import { AGENTS_DIR } from "./constants.js";
@@ -33,6 +33,12 @@ interface SessionManagerLike {
 	getEntries(): readonly unknown[];
 }
 
+interface AgentDirectoryEntry {
+	name: string;
+	isFile(): boolean;
+	isSymbolicLink(): boolean;
+}
+
 type AgentScope = "user" | "project" | "both";
 
 export interface AgentSelectionOptions {
@@ -130,6 +136,22 @@ function isDirectory(path: string): boolean {
 	}
 }
 
+function isMarkdownAgentEntry(entry: AgentDirectoryEntry): boolean {
+	return entry.name.endsWith(".md") && (entry.isFile() || entry.isSymbolicLink());
+}
+
+function resolveAgentWritePath(filePath: string): string {
+	try {
+		return lstatSync(filePath).isSymbolicLink() ? realpathSync(filePath) : filePath;
+	} catch {
+		return filePath;
+	}
+}
+
+function writeAgentMarkdown(filePath: string, markdown: string): void {
+	writeFileAtomic(resolveAgentWritePath(filePath), markdown);
+}
+
 function findNearestProjectAgentDirs(cwd: string): string[] {
 	let currentDir = resolve(cwd);
 
@@ -187,15 +209,15 @@ export function scanAgentFiles(options: string | AgentSelectionOptions = AGENTS_
 	const agentsByName = new Map<string, AgentFileRecord>();
 
 	for (const agentsDir of sourceDirs) {
-		let entries: Array<{ name: string; isFile(): boolean }>;
+		let entries: AgentDirectoryEntry[];
 		try {
-			entries = readdirSync(agentsDir, { withFileTypes: true }) as Array<{ name: string; isFile(): boolean }>;
+			entries = readdirSync(agentsDir, { withFileTypes: true }) as AgentDirectoryEntry[];
 		} catch {
 			throw new ModelProfilesError(`Unable to read agents directory '${agentsDir}'.`, "AGENTS_DIR_UNAVAILABLE");
 		}
 
 		for (const entry of entries.sort((left, right) => left.name.localeCompare(right.name))) {
-			if (!entry.isFile() || !entry.name.endsWith(".md")) {
+			if (!isMarkdownAgentEntry(entry)) {
 				continue;
 			}
 
@@ -247,7 +269,7 @@ export function applyProfileToAgentRecord(agent: AgentFileRecord, fields: Profil
 	const normalizedFields = normalizeProfileFields(fields);
 	const markdown = readFileSync(agent.path, "utf-8");
 	const updatedMarkdown = updateMarkdownProfileFields(markdown, normalizedFields);
-	writeFileAtomic(agent.path, updatedMarkdown);
+	writeAgentMarkdown(agent.path, updatedMarkdown);
 	return {
 		updatedPath: agent.path,
 		fileName: agent.fileName,
@@ -314,7 +336,7 @@ export function applySavedProfile(profile: SavedProfile, options: string | Agent
 	}
 
 	for (const pending of pendingWrites) {
-		writeFileAtomic(pending.target.path, pending.updatedMarkdown);
+		writeAgentMarkdown(pending.target.path, pending.updatedMarkdown);
 	}
 
 	return {

package/src/command-handler.ts

@@ -1,137 +1,137 @@
-import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
-
-import {
-	INITIAL_PROFILE_NAME,
-	PROFILE_NAME_SUFFIX,
-	PROFILE_STORE_PATH,
-} from "./constants.js";
-import { applySavedProfile, captureAgentSnapshots, detectActiveAgentName } from "./agent-writer.js";
-import { toErrorMessage } from "./errors.js";
-import { loadAndPrepareProfiles } from "./import-service.js";
-import { updateProfileAndReturn } from "./profile-update-service.js";
-import {
-	appendProfile,
-	createProfile,
-	findProfileById,
-	renameStoredProfile,
-	resolveUniqueProfileName,
-	saveProfilesFile,
-} from "./profile-store.js";
-import { removeProfileAndUpdate } from "./profile-removal-service.js";
-import { openProfilesModal, type ProfileModalResult } from "./profile-modal.js";
-import type { AppliedProfileOutcome, ProfilesFile } from "./types.js";
-
-function buildCurrentProfileName(activeAgentName: string | null, data: ProfilesFile): string {
-	const baseName = activeAgentName ? `${activeAgentName} ${PROFILE_NAME_SUFFIX}` : INITIAL_PROFILE_NAME;
-	return resolveUniqueProfileName(baseName, data.profiles);
-}
-
-function notifyWarnings(ctx: ExtensionCommandContext, warnings: readonly string[]): void {
-	if (warnings.length === 0) {
-		return;
-	}
-	ctx.ui.notify(warnings.join(" "), "warning");
-}
-
-function summarizeApplyOutcome(outcome: AppliedProfileOutcome): string {
-	const appliedCount = outcome.appliedAgents.length;
-	const missingCount = outcome.missingAgents.length;
-	const appliedLabel = `${appliedCount} agent file${appliedCount === 1 ? "" : "s"}`;
-	if (missingCount === 0) {
-		return appliedLabel;
-	}
-	return `${appliedLabel}; ${missingCount} missing`;
-}
-
-async function reloadAfterApply(ctx: ExtensionCommandContext, outcome: AppliedProfileOutcome): Promise<void> {
-	const summary = summarizeApplyOutcome(outcome);
-	ctx.ui.notify(`Profile '${outcome.profileName}' applied across ${summary}. Reloading…`, "info");
-
-	try {
-		await ctx.reload();
-	} catch (error) {
-		ctx.ui.notify(
-			`Profile '${outcome.profileName}' applied across ${summary}, but automatic reload failed: ${toErrorMessage(error)}. Run /reload.`,
-			"error",
-		);
-	}
-}
-
-export async function handleModelProfilesCommand(ctx: ExtensionCommandContext): Promise<void> {
-	const agentOptions = { cwd: ctx.cwd, scope: "both" as const };
-	const prepared = loadAndPrepareProfiles(PROFILE_STORE_PATH, agentOptions);
-	notifyWarnings(ctx, prepared.warnings);
-
-	let data = prepared.data;
-	const activeAgentName = detectActiveAgentName(ctx.sessionManager, ctx.getSystemPrompt());
-
-	const result: ProfileModalResult = await openProfilesModal(ctx, data, activeAgentName, {
-		renameProfile: async (profileId, nextName) => {
-			data = renameStoredProfile(data, profileId, nextName);
-			saveProfilesFile(data, PROFILE_STORE_PATH);
-			return {
-				data,
-				message: `Renamed saved snapshot to '${nextName.trim()}'.`,
-				selectedProfileId: profileId,
-			};
-		},
-		addCurrentProfile: async () => {
-			const snapshot = captureAgentSnapshots(agentOptions);
-			notifyWarnings(ctx, snapshot.warnings);
-			const profile = createProfile(buildCurrentProfileName(activeAgentName, data), snapshot.agents);
-			data = appendProfile(data, profile);
-			saveProfilesFile(data, PROFILE_STORE_PATH);
-			return {
-				data,
-				message: `Saved current agents snapshot (${snapshot.agents.length} agents).`,
-				selectedProfileId: profile.id,
-			};
-		},
-		applyProfile: async (profileId) => {
-			const profile = findProfileById(data, profileId);
-			if (!profile) {
-				throw new Error(`Saved profile '${profileId}' was not found.`);
-			}
-			const applied = applySavedProfile(profile, agentOptions);
-			notifyWarnings(ctx, applied.warnings);
-			return {
-				...applied,
-				profileName: profile.name,
-			};
-		},
-		removeProfile: async (profileId) => {
-			const profile = findProfileById(data, profileId);
-			if (!profile) {
-				throw new Error(`Saved profile '${profileId}' was not found.`);
-			}
-			const removal = removeProfileAndUpdate(data, profileId);
-			data = removal.data;
-			saveProfilesFile(data, PROFILE_STORE_PATH);
-			return {
-				data,
-				message: `Removed saved snapshot '${removal.result.removedProfileName}' (${removal.result.remainingCount} snapshots remaining).`,
-				selectedProfileId: data.profiles[0]?.id,
-			};
-		},
-		updateProfile: async (profileId) => {
-			const profile = findProfileById(data, profileId);
-			if (!profile) {
-				throw new Error(`Saved profile '${profileId}' was not found.`);
-			}
-			const update = updateProfileAndReturn(data, profileId, agentOptions);
-			notifyWarnings(ctx, update.result.warnings);
-			data = update.data;
-			saveProfilesFile(data, PROFILE_STORE_PATH);
-			return {
-				data,
-				message: `Updated '${profile.name}' with current agent state (${update.result.updatedAgents} agents).`,
-				selectedProfileId: profileId,
-			};
-		},
-	});
-
-	if (result.type === "applied") {
-		await reloadAfterApply(ctx, result.outcome);
-		return;
-	}
-}
+import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
+
+import {
+	INITIAL_PROFILE_NAME,
+	PROFILE_NAME_SUFFIX,
+	PROFILE_STORE_PATH,
+} from "./constants.js";
+import { applySavedProfile, captureAgentSnapshots, detectActiveAgentName } from "./agent-writer.js";
+import { toErrorMessage } from "./errors.js";
+import { loadAndPrepareProfiles } from "./import-service.js";
+import { updateProfileAndReturn } from "./profile-update-service.js";
+import {
+	appendProfile,
+	createProfile,
+	findProfileById,
+	renameStoredProfile,
+	resolveUniqueProfileName,
+	saveProfilesFile,
+} from "./profile-store.js";
+import { removeProfileAndUpdate } from "./profile-removal-service.js";
+import { openProfilesModal, type ProfileModalResult } from "./profile-modal.js";
+import type { AppliedProfileOutcome, ProfilesFile } from "./types.js";
+
+function buildCurrentProfileName(activeAgentName: string | null, data: ProfilesFile): string {
+	const baseName = activeAgentName ? `${activeAgentName} ${PROFILE_NAME_SUFFIX}` : INITIAL_PROFILE_NAME;
+	return resolveUniqueProfileName(baseName, data.profiles);
+}
+
+function notifyWarnings(ctx: ExtensionCommandContext, warnings: readonly string[]): void {
+	if (warnings.length === 0) {
+		return;
+	}
+	ctx.ui.notify(warnings.join(" "), "warning");
+}
+
+function summarizeApplyOutcome(outcome: AppliedProfileOutcome): string {
+	const appliedCount = outcome.appliedAgents.length;
+	const missingCount = outcome.missingAgents.length;
+	const appliedLabel = `${appliedCount} agent file${appliedCount === 1 ? "" : "s"}`;
+	if (missingCount === 0) {
+		return appliedLabel;
+	}
+	return `${appliedLabel}; ${missingCount} missing`;
+}
+
+async function reloadAfterApply(ctx: ExtensionCommandContext, outcome: AppliedProfileOutcome): Promise<void> {
+	const summary = summarizeApplyOutcome(outcome);
+	ctx.ui.notify(`Profile '${outcome.profileName}' applied across ${summary}. Reloading…`, "info");
+
+	try {
+		await ctx.reload();
+	} catch (error) {
+		ctx.ui.notify(
+			`Profile '${outcome.profileName}' applied across ${summary}, but automatic reload failed: ${toErrorMessage(error)}. Run /reload.`,
+			"error",
+		);
+	}
+}
+
+export async function handleModelProfilesCommand(ctx: ExtensionCommandContext): Promise<void> {
+	const agentOptions = { cwd: ctx.cwd, scope: "both" as const };
+	const prepared = loadAndPrepareProfiles(PROFILE_STORE_PATH, agentOptions);
+	notifyWarnings(ctx, prepared.warnings);
+
+	let data = prepared.data;
+	const activeAgentName = detectActiveAgentName(ctx.sessionManager, ctx.getSystemPrompt());
+
+	const result: ProfileModalResult = await openProfilesModal(ctx, data, activeAgentName, {
+		renameProfile: async (profileId, nextName) => {
+			data = renameStoredProfile(data, profileId, nextName);
+			saveProfilesFile(data, PROFILE_STORE_PATH);
+			return {
+				data,
+				message: `Renamed saved snapshot to '${nextName.trim()}'.`,
+				selectedProfileId: profileId,
+			};
+		},
+		addCurrentProfile: async () => {
+			const snapshot = captureAgentSnapshots(agentOptions);
+			notifyWarnings(ctx, snapshot.warnings);
+			const profile = createProfile(buildCurrentProfileName(activeAgentName, data), snapshot.agents);
+			data = appendProfile(data, profile);
+			saveProfilesFile(data, PROFILE_STORE_PATH);
+			return {
+				data,
+				message: `Saved current agents snapshot (${snapshot.agents.length} agents).`,
+				selectedProfileId: profile.id,
+			};
+		},
+		applyProfile: async (profileId) => {
+			const profile = findProfileById(data, profileId);
+			if (!profile) {
+				throw new Error(`Saved profile '${profileId}' was not found.`);
+			}
+			const applied = applySavedProfile(profile, agentOptions);
+			notifyWarnings(ctx, applied.warnings);
+			return {
+				...applied,
+				profileName: profile.name,
+			};
+		},
+		removeProfile: async (profileId) => {
+			const profile = findProfileById(data, profileId);
+			if (!profile) {
+				throw new Error(`Saved profile '${profileId}' was not found.`);
+			}
+			const removal = removeProfileAndUpdate(data, profileId);
+			data = removal.data;
+			saveProfilesFile(data, PROFILE_STORE_PATH);
+			return {
+				data,
+				message: `Removed saved snapshot '${removal.result.removedProfileName}' (${removal.result.remainingCount} snapshots remaining).`,
+				selectedProfileId: data.profiles[0]?.id,
+			};
+		},
+		updateProfile: async (profileId) => {
+			const profile = findProfileById(data, profileId);
+			if (!profile) {
+				throw new Error(`Saved profile '${profileId}' was not found.`);
+			}
+			const update = updateProfileAndReturn(data, profileId, agentOptions);
+			notifyWarnings(ctx, update.result.warnings);
+			data = update.data;
+			saveProfilesFile(data, PROFILE_STORE_PATH);
+			return {
+				data,
+				message: `Updated '${profile.name}' with current agent state (${update.result.updatedAgents} agents).`,
+				selectedProfileId: profileId,
+			};
+		},
+	});
+
+	if (result.type === "applied") {
+		await reloadAfterApply(ctx, result.outcome);
+		return;
+	}
+}

package/src/errors.ts

@@ -1,18 +1,18 @@
-export const COMMAND_NAME = "model-profiles";
-
-export class ModelProfilesError extends Error {
-	readonly code: string;
-
-	constructor(message: string, code = "MODEL_PROFILES_ERROR") {
-		super(message);
-		this.name = "ModelProfilesError";
-		this.code = code;
-	}
-}
-
-export function toErrorMessage(error: unknown): string {
-	if (error instanceof Error && error.message.trim()) {
-		return error.message;
-	}
-	return String(error);
-}
+export const COMMAND_NAME = "model-profiles";
+
+export class ModelProfilesError extends Error {
+	readonly code: string;
+
+	constructor(message: string, code = "MODEL_PROFILES_ERROR") {
+		super(message);
+		this.name = "ModelProfilesError";
+		this.code = code;
+	}
+}
+
+export function toErrorMessage(error: unknown): string {
+	if (error instanceof Error && error.message.trim()) {
+		return error.message;
+	}
+	return String(error);
+}

package/src/frontmatter-parser.ts

@@ -1,249 +1,250 @@
-import { PROFILE_FIELD_KEYS, type ProfileFieldKey, type ProfileFields } from "./types.js";
-import { ModelProfilesError } from "./errors.js";
-
-interface FrontmatterDocument {
-	frontmatter: string;
-	body: string;
-}
-
-interface FrontmatterBlock {
-	key: string | null;
-	lines: string[];
-}
-
-const ANCHOR_KEYS = new Set(["name", "mode", "color", "description"]);
-const SAFE_UNQUOTED_SCALAR = /^[A-Za-z0-9._/@:-]+$/;
-const PROFILE_KEY_SET = new Set<string>(PROFILE_FIELD_KEYS);
-
-function normalizeNewlines(value: string): string {
-	return value.replace(/\r\n/g, "\n").replace(/\r/g, "\n");
-}
-
-function extractTopLevelKey(line: string): string | null {
-	if (!line || line.startsWith(" ") || line.startsWith("\t")) {
-		return null;
-	}
-
-	const match = /^([A-Za-z0-9_-]+):(?:\s*(.*))?$/.exec(line);
-	if (!match) {
-		return null;
-	}
-
-	return match[1] ?? null;
-}
-
-function parseScalarText(value: string): string {
-	const trimmed = value.trim();
-	if (!trimmed) {
-		return "";
-	}
-	if (trimmed.startsWith('"') && trimmed.endsWith('"')) {
-		try {
-			return JSON.parse(trimmed) as string;
-		} catch {
-			return trimmed.slice(1, -1);
-		}
-	}
-	if (trimmed.startsWith("'") && trimmed.endsWith("'")) {
-		return trimmed.slice(1, -1).replace(/''/g, "'");
-	}
-	return trimmed;
-}
-
-function splitFrontmatterBlocks(frontmatter: string): FrontmatterBlock[] {
-	const lines = frontmatter.split("\n");
-	const starts: Array<{ index: number; key: string }> = [];
-
-	for (let index = 0; index < lines.length; index += 1) {
-		const key = extractTopLevelKey(lines[index] ?? "");
-		if (key) {
-			starts.push({ index, key });
-		}
-	}
-
-	if (starts.length === 0) {
-		return [{ key: null, lines }];
-	}
-
-	const blocks: FrontmatterBlock[] = [];
-	if ((starts[0]?.index ?? 0) > 0) {
-		blocks.push({ key: null, lines: lines.slice(0, starts[0]?.index) });
-	}
-
-	for (let index = 0; index < starts.length; index += 1) {
-		const current = starts[index];
-		const next = starts[index + 1];
-		blocks.push({
-			key: current?.key ?? null,
-			lines: lines.slice(current?.index ?? 0, next ? next.index : lines.length),
-		});
-	}
-
-	return blocks.filter((block) => block.lines.length > 0);
-}
-
-function trimBlankEdges(lines: string[]): string[] {
-	let start = 0;
-	let end = lines.length;
-	while (start < end && !(lines[start] ?? "").trim()) {
-		start += 1;
-	}
-	while (end > start && !(lines[end - 1] ?? "").trim()) {
-		end -= 1;
-	}
-	return lines.slice(start, end);
-}
-
-function joinBlocks(blocks: FrontmatterBlock[]): string {
-	const lines = blocks.flatMap((block) => block.lines);
-	return trimBlankEdges(lines).join("\n");
-}
-
-function serializeScalar(value: string): string {
-	return SAFE_UNQUOTED_SCALAR.test(value) ? value : JSON.stringify(value);
-}
-
-function serializeProfileLines(fields: ProfileFields): string[] {
-	const lines: string[] = [];
-	if (fields.model !== undefined) {
-		lines.push(`model: ${serializeScalar(fields.model)}`);
-	}
-	if (fields.temperature !== undefined) {
-		lines.push(`temperature: ${String(fields.temperature)}`);
-	}
-	if (fields.reasoningEffort !== undefined) {
-		lines.push(`reasoningEffort: ${serializeScalar(fields.reasoningEffort)}`);
-	}
-	return lines;
-}
-
-function findInsertIndex(blocks: FrontmatterBlock[]): number {
-	const firstProfileIndex = blocks.findIndex((block) => block.key !== null && PROFILE_KEY_SET.has(block.key));
-	if (firstProfileIndex !== -1) {
-		let keptBefore = 0;
-		for (let index = 0; index < firstProfileIndex; index += 1) {
-			if (!PROFILE_KEY_SET.has(blocks[index]?.key ?? "")) {
-				keptBefore += 1;
-			}
-		}
-		return keptBefore;
-	}
-
-	let lastAnchorIndex = -1;
-	for (let index = 0; index < blocks.length; index += 1) {
-		const key = blocks[index]?.key;
-		if (key && ANCHOR_KEYS.has(key)) {
-			lastAnchorIndex = index;
-		}
-	}
-
-	if (lastAnchorIndex !== -1) {
-		return lastAnchorIndex + 1;
-	}
-
-	return blocks[0]?.key === null ? 1 : 0;
-}
-
-export function extractFrontmatterDocument(markdown: string): FrontmatterDocument {
-	const normalized = normalizeNewlines(markdown);
-	const lines = normalized.split("\n");
-	if ((lines[0] ?? "") !== "---") {
-		throw new ModelProfilesError("Agent markdown is missing opening frontmatter delimiter.", "INVALID_FRONTMATTER");
-	}
-
-	let endIndex = -1;
-	for (let index = 1; index < lines.length; index += 1) {
-		if ((lines[index] ?? "") === "---") {
-			endIndex = index;
-			break;
-		}
-	}
-
-	if (endIndex === -1) {
-		throw new ModelProfilesError("Agent markdown is missing closing frontmatter delimiter.", "INVALID_FRONTMATTER");
-	}
-
-	return {
-		frontmatter: lines.slice(1, endIndex).join("\n"),
-		body: lines.slice(endIndex + 1).join("\n"),
-	};
-}
-
-export function readTopLevelScalarMap(frontmatter: string): Record<string, string> {
-	const values: Record<string, string> = {};
-	for (const line of frontmatter.split("\n")) {
-		const key = extractTopLevelKey(line);
-		if (!key) {
-			continue;
-		}
-		const separatorIndex = line.indexOf(":");
-		const rawValue = line.slice(separatorIndex + 1).trim();
-		if (!rawValue) {
-			continue;
-		}
-		values[key] = parseScalarText(rawValue);
-	}
-	return values;
-}
-
-export function readAgentNameFromMarkdown(markdown: string): string {
-	const { frontmatter } = extractFrontmatterDocument(markdown);
-	const name = readTopLevelScalarMap(frontmatter).name?.trim();
-	if (!name) {
-		throw new ModelProfilesError("Agent markdown frontmatter is missing a non-empty 'name' field.", "INVALID_AGENT_NAME");
-	}
-	return name;
-}
-
-export function readProfileFieldsFromMarkdown(markdown: string): ProfileFields {
-	const { frontmatter } = extractFrontmatterDocument(markdown);
-	const values = readTopLevelScalarMap(frontmatter);
-	const fields: ProfileFields = {};
-
-	const model = values.model?.trim();
-	if (model) {
-		fields.model = model;
-	}
-
-	if (values.temperature !== undefined) {
-		const parsedTemperature = Number.parseFloat(values.temperature);
-		if (!Number.isFinite(parsedTemperature)) {
-			throw new ModelProfilesError(
-				`Frontmatter field 'temperature' must be numeric, received '${values.temperature}'.`,
-				"INVALID_TEMPERATURE",
-			);
-		}
-		fields.temperature = parsedTemperature;
-	}
-
-	const reasoningEffort = values.reasoningEffort?.trim();
-	if (reasoningEffort) {
-		fields.reasoningEffort = reasoningEffort;
-	}
-
-	return fields;
-}
-
-export function updateMarkdownProfileFields(markdown: string, fields: ProfileFields): string {
-	const document = extractFrontmatterDocument(markdown);
-	const originalBlocks = splitFrontmatterBlocks(document.frontmatter);
-	const keptBlocks = originalBlocks.filter((block) => !PROFILE_KEY_SET.has(block.key ?? ""));
-	const insertIndex = findInsertIndex(originalBlocks);
-	const profileLines = serializeProfileLines(fields);
-	const nextBlocks = [...keptBlocks];
-
-	if (profileLines.length > 0) {
-		nextBlocks.splice(insertIndex, 0, { key: null, lines: profileLines });
-	}
-
-	const nextFrontmatter = joinBlocks(nextBlocks);
-	return `---\n${nextFrontmatter}\n---\n${document.body}`;
-}
-
-export function listAppliedKeys(fields: ProfileFields): ProfileFieldKey[] {
-	return PROFILE_FIELD_KEYS.filter((key) => fields[key] !== undefined);
-}
-
-export function listRemovedKeys(fields: ProfileFields): ProfileFieldKey[] {
-	return PROFILE_FIELD_KEYS.filter((key) => fields[key] === undefined);
-}
+import { PROFILE_FIELD_KEYS, type ProfileFieldKey, type ProfileFields } from "./types.js";
+import { ModelProfilesError } from "./errors.js";
+import { parseCompleteNumericScalar } from "./profile-fields.js";
+
+interface FrontmatterDocument {
+	frontmatter: string;
+	body: string;
+}
+
+interface FrontmatterBlock {
+	key: string | null;
+	lines: string[];
+}
+
+const ANCHOR_KEYS = new Set(["name", "mode", "color", "description"]);
+const SAFE_UNQUOTED_SCALAR = /^[A-Za-z0-9._/@:-]+$/;
+const PROFILE_KEY_SET = new Set<string>(PROFILE_FIELD_KEYS);
+
+function normalizeNewlines(value: string): string {
+	return value.replace(/\r\n/g, "\n").replace(/\r/g, "\n");
+}
+
+function extractTopLevelKey(line: string): string | null {
+	if (!line || line.startsWith(" ") || line.startsWith("\t")) {
+		return null;
+	}
+
+	const match = /^([A-Za-z0-9_-]+):(?:\s*(.*))?$/.exec(line);
+	if (!match) {
+		return null;
+	}
+
+	return match[1] ?? null;
+}
+
+function parseScalarText(value: string): string {
+	const trimmed = value.trim();
+	if (!trimmed) {
+		return "";
+	}
+	if (trimmed.startsWith('"') && trimmed.endsWith('"')) {
+		try {
+			return JSON.parse(trimmed) as string;
+		} catch {
+			return trimmed.slice(1, -1);
+		}
+	}
+	if (trimmed.startsWith("'") && trimmed.endsWith("'")) {
+		return trimmed.slice(1, -1).replace(/''/g, "'");
+	}
+	return trimmed;
+}
+
+function splitFrontmatterBlocks(frontmatter: string): FrontmatterBlock[] {
+	const lines = frontmatter.split("\n");
+	const starts: Array<{ index: number; key: string }> = [];
+
+	for (let index = 0; index < lines.length; index += 1) {
+		const key = extractTopLevelKey(lines[index] ?? "");
+		if (key) {
+			starts.push({ index, key });
+		}
+	}
+
+	if (starts.length === 0) {
+		return [{ key: null, lines }];
+	}
+
+	const blocks: FrontmatterBlock[] = [];
+	if ((starts[0]?.index ?? 0) > 0) {
+		blocks.push({ key: null, lines: lines.slice(0, starts[0]?.index) });
+	}
+
+	for (let index = 0; index < starts.length; index += 1) {
+		const current = starts[index];
+		const next = starts[index + 1];
+		blocks.push({
+			key: current?.key ?? null,
+			lines: lines.slice(current?.index ?? 0, next ? next.index : lines.length),
+		});
+	}
+
+	return blocks.filter((block) => block.lines.length > 0);
+}
+
+function trimBlankEdges(lines: string[]): string[] {
+	let start = 0;
+	let end = lines.length;
+	while (start < end && !(lines[start] ?? "").trim()) {
+		start += 1;
+	}
+	while (end > start && !(lines[end - 1] ?? "").trim()) {
+		end -= 1;
+	}
+	return lines.slice(start, end);
+}
+
+function joinBlocks(blocks: FrontmatterBlock[]): string {
+	const lines = blocks.flatMap((block) => block.lines);
+	return trimBlankEdges(lines).join("\n");
+}
+
+function serializeScalar(value: string): string {
+	return SAFE_UNQUOTED_SCALAR.test(value) ? value : JSON.stringify(value);
+}
+
+function serializeProfileLines(fields: ProfileFields): string[] {
+	const lines: string[] = [];
+	if (fields.model !== undefined) {
+		lines.push(`model: ${serializeScalar(fields.model)}`);
+	}
+	if (fields.temperature !== undefined) {
+		lines.push(`temperature: ${String(fields.temperature)}`);
+	}
+	if (fields.reasoningEffort !== undefined) {
+		lines.push(`reasoningEffort: ${serializeScalar(fields.reasoningEffort)}`);
+	}
+	return lines;
+}
+
+function findInsertIndex(blocks: FrontmatterBlock[]): number {
+	const firstProfileIndex = blocks.findIndex((block) => block.key !== null && PROFILE_KEY_SET.has(block.key));
+	if (firstProfileIndex !== -1) {
+		let keptBefore = 0;
+		for (let index = 0; index < firstProfileIndex; index += 1) {
+			if (!PROFILE_KEY_SET.has(blocks[index]?.key ?? "")) {
+				keptBefore += 1;
+			}
+		}
+		return keptBefore;
+	}
+
+	let lastAnchorIndex = -1;
+	for (let index = 0; index < blocks.length; index += 1) {
+		const key = blocks[index]?.key;
+		if (key && ANCHOR_KEYS.has(key)) {
+			lastAnchorIndex = index;
+		}
+	}
+
+	if (lastAnchorIndex !== -1) {
+		return lastAnchorIndex + 1;
+	}
+
+	return blocks[0]?.key === null ? 1 : 0;
+}
+
+export function extractFrontmatterDocument(markdown: string): FrontmatterDocument {
+	const normalized = normalizeNewlines(markdown);
+	const lines = normalized.split("\n");
+	if ((lines[0] ?? "") !== "---") {
+		throw new ModelProfilesError("Agent markdown is missing opening frontmatter delimiter.", "INVALID_FRONTMATTER");
+	}
+
+	let endIndex = -1;
+	for (let index = 1; index < lines.length; index += 1) {
+		if ((lines[index] ?? "") === "---") {
+			endIndex = index;
+			break;
+		}
+	}
+
+	if (endIndex === -1) {
+		throw new ModelProfilesError("Agent markdown is missing closing frontmatter delimiter.", "INVALID_FRONTMATTER");
+	}
+
+	return {
+		frontmatter: lines.slice(1, endIndex).join("\n"),
+		body: lines.slice(endIndex + 1).join("\n"),
+	};
+}
+
+export function readTopLevelScalarMap(frontmatter: string): Record<string, string> {
+	const values: Record<string, string> = {};
+	for (const line of frontmatter.split("\n")) {
+		const key = extractTopLevelKey(line);
+		if (!key) {
+			continue;
+		}
+		const separatorIndex = line.indexOf(":");
+		const rawValue = line.slice(separatorIndex + 1).trim();
+		if (!rawValue) {
+			continue;
+		}
+		values[key] = parseScalarText(rawValue);
+	}
+	return values;
+}
+
+export function readAgentNameFromMarkdown(markdown: string): string {
+	const { frontmatter } = extractFrontmatterDocument(markdown);
+	const name = readTopLevelScalarMap(frontmatter).name?.trim();
+	if (!name) {
+		throw new ModelProfilesError("Agent markdown frontmatter is missing a non-empty 'name' field.", "INVALID_AGENT_NAME");
+	}
+	return name;
+}
+
+export function readProfileFieldsFromMarkdown(markdown: string): ProfileFields {
+	const { frontmatter } = extractFrontmatterDocument(markdown);
+	const values = readTopLevelScalarMap(frontmatter);
+	const fields: ProfileFields = {};
+
+	const model = values.model?.trim();
+	if (model) {
+		fields.model = model;
+	}
+
+	if (values.temperature !== undefined) {
+		const parsedTemperature = parseCompleteNumericScalar(values.temperature);
+		if (parsedTemperature === undefined) {
+			throw new ModelProfilesError(
+				`Frontmatter field 'temperature' must be numeric, received '${values.temperature}'.`,
+				"INVALID_TEMPERATURE",
+			);
+		}
+		fields.temperature = parsedTemperature;
+	}
+
+	const reasoningEffort = values.reasoningEffort?.trim();
+	if (reasoningEffort) {
+		fields.reasoningEffort = reasoningEffort;
+	}
+
+	return fields;
+}
+
+export function updateMarkdownProfileFields(markdown: string, fields: ProfileFields): string {
+	const document = extractFrontmatterDocument(markdown);
+	const originalBlocks = splitFrontmatterBlocks(document.frontmatter);
+	const keptBlocks = originalBlocks.filter((block) => !PROFILE_KEY_SET.has(block.key ?? ""));
+	const insertIndex = findInsertIndex(originalBlocks);
+	const profileLines = serializeProfileLines(fields);
+	const nextBlocks = [...keptBlocks];
+
+	if (profileLines.length > 0) {
+		nextBlocks.splice(insertIndex, 0, { key: null, lines: profileLines });
+	}
+
+	const nextFrontmatter = joinBlocks(nextBlocks);
+	return `---\n${nextFrontmatter}\n---\n${document.body}`;
+}
+
+export function listAppliedKeys(fields: ProfileFields): ProfileFieldKey[] {
+	return PROFILE_FIELD_KEYS.filter((key) => fields[key] !== undefined);
+}
+
+export function listRemovedKeys(fields: ProfileFields): ProfileFieldKey[] {
+	return PROFILE_FIELD_KEYS.filter((key) => fields[key] === undefined);
+}

package/src/index.ts

@@ -1,36 +1,36 @@
-import type { ExtensionAPI, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
-
-import { COMMAND_NAME, toErrorMessage } from "./errors.js";
-import { onResourcesDiscover, refreshModelRegistry } from "./pi-api-utils.js";
-
-export default function modelProfilesExtension(pi: ExtensionAPI): void {
-	// Register handler to refresh model registry on /reload
-	// This works around the issue where AgentSession.reload() doesn't call ModelRegistry.refresh()
-	onResourcesDiscover(pi, (event, ctx): void => {
-		if (event.reason === "reload") {
-			refreshModelRegistry(ctx);
-		}
-	});
-
-	pi.registerCommand(COMMAND_NAME, {
-		description: "Open saved whole-agent model profile snapshots",
-		handler: async (args: string, ctx: ExtensionCommandContext): Promise<void> => {
-			if (args.trim()) {
-				ctx.ui.notify(`Usage: /${COMMAND_NAME}`, "warning");
-				return;
-			}
-
-			if (!ctx.hasUI) {
-				ctx.ui.notify(`/${COMMAND_NAME} requires interactive TUI mode.`, "warning");
-				return;
-			}
-
-			try {
-				const { handleModelProfilesCommand } = await import("./command-handler.js");
-				await handleModelProfilesCommand(ctx);
-			} catch (error) {
-				ctx.ui.notify(`/${COMMAND_NAME} failed: ${toErrorMessage(error)}`, "error");
-			}
-		},
-	});
-}
+import type { ExtensionAPI, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
+
+import { COMMAND_NAME, toErrorMessage } from "./errors.js";
+import { onResourcesDiscover, refreshModelRegistry } from "./pi-api-utils.js";
+
+export default function modelProfilesExtension(pi: ExtensionAPI): void {
+	// Register handler to refresh model registry on /reload
+	// This works around the issue where AgentSession.reload() doesn't call ModelRegistry.refresh()
+	onResourcesDiscover(pi, (event, ctx): void => {
+		if (event.reason === "reload") {
+			refreshModelRegistry(ctx);
+		}
+	});
+
+	pi.registerCommand(COMMAND_NAME, {
+		description: "Open saved whole-agent model profile snapshots",
+		handler: async (args: string, ctx: ExtensionCommandContext): Promise<void> => {
+			if (args.trim()) {
+				ctx.ui.notify(`Usage: /${COMMAND_NAME}`, "warning");
+				return;
+			}
+
+			if (!ctx.hasUI) {
+				ctx.ui.notify(`/${COMMAND_NAME} requires interactive TUI mode.`, "warning");
+				return;
+			}
+
+			try {
+				const { handleModelProfilesCommand } = await import("./command-handler.js");
+				await handleModelProfilesCommand(ctx);
+			} catch (error) {
+				ctx.ui.notify(`/${COMMAND_NAME} failed: ${toErrorMessage(error)}`, "error");
+			}
+		},
+	});
+}

package/src/profile-fields.ts

@@ -1,83 +1,93 @@
-import type { ProfileFieldKey, ProfileFields } from "./types.js";
-
-function toRecord(value: unknown): Record<string, unknown> {
-	if (!value || typeof value !== "object" || Array.isArray(value)) {
-		return {};
-	}
-	return value as Record<string, unknown>;
-}
-
-function normalizeOptionalString(value: unknown): string | undefined {
-	if (typeof value !== "string") {
-		return undefined;
-	}
-	const trimmed = value.trim();
-	return trimmed ? trimmed : undefined;
-}
-
-function normalizeTemperatureValue(value: unknown): number | undefined {
-	if (typeof value === "number") {
-		return Number.isFinite(value) ? value : undefined;
-	}
-	if (typeof value === "string" && value.trim()) {
-		const parsed = Number.parseFloat(value);
-		return Number.isFinite(parsed) ? parsed : undefined;
-	}
-	return undefined;
-}
-
-export function normalizeProfileFields(value: unknown): ProfileFields {
-	const source = toRecord(value);
-	const fields: ProfileFields = {};
-
-	const model = normalizeOptionalString(source.model);
-	if (model) {
-		fields.model = model;
-	}
-
-	const temperature = normalizeTemperatureValue(source.temperature);
-	if (temperature !== undefined) {
-		fields.temperature = temperature;
-	}
-
-	const reasoningEffort = normalizeOptionalString(source.reasoningEffort);
-	if (reasoningEffort) {
-		fields.reasoningEffort = reasoningEffort;
-	}
-
-	return fields;
-}
-
-export function hasProfileFields(fields: ProfileFields): boolean {
-	return fields.model !== undefined || fields.temperature !== undefined || fields.reasoningEffort !== undefined;
-}
-
-export function describeProfileFields(fields: ProfileFields): string {
-	const parts: string[] = [];
-	if (fields.model !== undefined) {
-		parts.push("model");
-	}
-	if (fields.temperature !== undefined) {
-		parts.push("temperature");
-	}
-	if (fields.reasoningEffort !== undefined) {
-		parts.push("reasoning");
-	}
-	return parts.length > 0 ? parts.join(", ") : "clears model overrides";
-}
-
-export function formatProfileFieldValue(key: ProfileFieldKey, fields: ProfileFields): string {
-	switch (key) {
-		case "model":
-			return fields.model ?? "(absent)";
-		case "temperature":
-			return fields.temperature !== undefined ? String(fields.temperature) : "(absent)";
-		case "reasoningEffort":
-			return fields.reasoningEffort ?? "(absent)";
-	}
-}
-
-export function sanitizeProfileName(value: string): string | null {
-	const trimmed = value.trim();
-	return trimmed ? trimmed : null;
-}
+import type { ProfileFieldKey, ProfileFields } from "./types.js";
+
+function toRecord(value: unknown): Record<string, unknown> {
+	if (!value || typeof value !== "object" || Array.isArray(value)) {
+		return {};
+	}
+	return value as Record<string, unknown>;
+}
+
+function normalizeOptionalString(value: unknown): string | undefined {
+	if (typeof value !== "string") {
+		return undefined;
+	}
+	const trimmed = value.trim();
+	return trimmed ? trimmed : undefined;
+}
+
+const COMPLETE_NUMERIC_SCALAR = /^[+-]?(?:\d+\.?\d*|\.\d+)$/;
+
+export function parseCompleteNumericScalar(value: string): number | undefined {
+	const trimmed = value.trim();
+	if (!COMPLETE_NUMERIC_SCALAR.test(trimmed)) {
+		return undefined;
+	}
+	const parsed = Number.parseFloat(trimmed);
+	return Number.isFinite(parsed) ? parsed : undefined;
+}
+
+function normalizeTemperatureValue(value: unknown): number | undefined {
+	if (typeof value === "number") {
+		return Number.isFinite(value) ? value : undefined;
+	}
+	if (typeof value === "string" && value.trim()) {
+		return parseCompleteNumericScalar(value);
+	}
+	return undefined;
+}
+
+export function normalizeProfileFields(value: unknown): ProfileFields {
+	const source = toRecord(value);
+	const fields: ProfileFields = {};
+
+	const model = normalizeOptionalString(source.model);
+	if (model) {
+		fields.model = model;
+	}
+
+	const temperature = normalizeTemperatureValue(source.temperature);
+	if (temperature !== undefined) {
+		fields.temperature = temperature;
+	}
+
+	const reasoningEffort = normalizeOptionalString(source.reasoningEffort);
+	if (reasoningEffort) {
+		fields.reasoningEffort = reasoningEffort;
+	}
+
+	return fields;
+}
+
+export function hasProfileFields(fields: ProfileFields): boolean {
+	return fields.model !== undefined || fields.temperature !== undefined || fields.reasoningEffort !== undefined;
+}
+
+export function describeProfileFields(fields: ProfileFields): string {
+	const parts: string[] = [];
+	if (fields.model !== undefined) {
+		parts.push("model");
+	}
+	if (fields.temperature !== undefined) {
+		parts.push("temperature");
+	}
+	if (fields.reasoningEffort !== undefined) {
+		parts.push("reasoning");
+	}
+	return parts.length > 0 ? parts.join(", ") : "clears model overrides";
+}
+
+export function formatProfileFieldValue(key: ProfileFieldKey, fields: ProfileFields): string {
+	switch (key) {
+		case "model":
+			return fields.model ?? "(absent)";
+		case "temperature":
+			return fields.temperature !== undefined ? String(fields.temperature) : "(absent)";
+		case "reasoningEffort":
+			return fields.reasoningEffort ?? "(absent)";
+	}
+}
+
+export function sanitizeProfileName(value: string): string | null {
+	const trimmed = value.trim();
+	return trimmed ? trimmed : null;
+}