pi-model-profiles 0.3.2 → 0.3.4

package/src/index.ts

@@ -1,130 +1,7 @@
-import type { ExtensionAPI, ExtensionCommandContext, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import type { ExtensionAPI, ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 
-import { COMMAND_NAME, INITIAL_PROFILE_NAME, PROFILE_NAME_SUFFIX, PROFILE_STORE_PATH } from "./constants.js";
-import { applySavedProfile, captureAgentSnapshots, detectActiveAgentName } from "./agent-writer.js";
-import { toErrorMessage } from "./errors.js";
-import { loadAndPrepareProfiles } from "./import-service.js";
-import { updateProfileAndReturn } from "./profile-update-service.js";
-import { appendProfile, createProfile, findProfileById, renameStoredProfile, resolveUniqueProfileName, saveProfilesFile } from "./profile-store.js";
-import { removeProfileAndUpdate } from "./profile-removal-service.js";
-import { openProfilesModal, type ProfileModalResult } from "./profile-modal.js";
+import { COMMAND_NAME, toErrorMessage } from "./errors.js";
 import { onResourcesDiscover, refreshModelRegistry } from "./pi-api-utils.js";
-import type { AppliedProfileOutcome, ProfilesFile } from "./types.js";
-
-function buildCurrentProfileName(activeAgentName: string | null, data: ProfilesFile): string {
-	const baseName = activeAgentName ? `${activeAgentName} ${PROFILE_NAME_SUFFIX}` : INITIAL_PROFILE_NAME;
-	return resolveUniqueProfileName(baseName, data.profiles);
-}
-
-function notifyWarnings(ctx: ExtensionCommandContext, warnings: readonly string[]): void {
-	if (warnings.length === 0) {
-		return;
-	}
-	ctx.ui.notify(warnings.join(" "), "warning");
-}
-
-function summarizeApplyOutcome(outcome: AppliedProfileOutcome): string {
-	const appliedCount = outcome.appliedAgents.length;
-	const missingCount = outcome.missingAgents.length;
-	const appliedLabel = `${appliedCount} agent file${appliedCount === 1 ? "" : "s"}`;
-	if (missingCount === 0) {
-		return appliedLabel;
-	}
-	return `${appliedLabel}; ${missingCount} missing`;
-}
-
-async function reloadAfterApply(ctx: ExtensionCommandContext, outcome: AppliedProfileOutcome): Promise<void> {
-	const summary = summarizeApplyOutcome(outcome);
-	ctx.ui.notify(`Profile '${outcome.profileName}' applied across ${summary}. Reloading…`, "info");
-
-	try {
-		await ctx.reload();
-	} catch (error) {
-		ctx.ui.notify(
-			`Profile '${outcome.profileName}' applied across ${summary}, but automatic reload failed: ${toErrorMessage(error)}. Run /reload.`,
-			"error",
-		);
-	}
-}
-
-async function handleModelProfilesCommand(ctx: ExtensionCommandContext): Promise<void> {
-	const agentOptions = { cwd: ctx.cwd, scope: "both" as const };
-	const prepared = loadAndPrepareProfiles(PROFILE_STORE_PATH, agentOptions);
-	notifyWarnings(ctx, prepared.warnings);
-
-	let data = prepared.data;
-	const activeAgentName = detectActiveAgentName(ctx.sessionManager, ctx.getSystemPrompt());
-
-	const result: ProfileModalResult = await openProfilesModal(ctx, data, activeAgentName, {
-		renameProfile: async (profileId, nextName) => {
-			data = renameStoredProfile(data, profileId, nextName);
-			saveProfilesFile(data, PROFILE_STORE_PATH);
-			return {
-				data,
-				message: `Renamed saved snapshot to '${nextName.trim()}'.`,
-				selectedProfileId: profileId,
-			};
-		},
-		addCurrentProfile: async () => {
-			const snapshot = captureAgentSnapshots(agentOptions);
-			notifyWarnings(ctx, snapshot.warnings);
-			const profile = createProfile(buildCurrentProfileName(activeAgentName, data), snapshot.agents);
-			data = appendProfile(data, profile);
-			saveProfilesFile(data, PROFILE_STORE_PATH);
-			return {
-				data,
-				message: `Saved current agents snapshot (${snapshot.agents.length} agents).`,
-				selectedProfileId: profile.id,
-			};
-		},
-		applyProfile: async (profileId) => {
-			const profile = findProfileById(data, profileId);
-			if (!profile) {
-				throw new Error(`Saved profile '${profileId}' was not found.`);
-			}
-			const applied = applySavedProfile(profile, agentOptions);
-			notifyWarnings(ctx, applied.warnings);
-			return {
-				...applied,
-				profileName: profile.name,
-			};
-		},
-		removeProfile: async (profileId) => {
-			const profile = findProfileById(data, profileId);
-			if (!profile) {
-				throw new Error(`Saved profile '${profileId}' was not found.`);
-			}
-			const removal = removeProfileAndUpdate(data, profileId);
-			data = removal.data;
-			saveProfilesFile(data, PROFILE_STORE_PATH);
-			return {
-				data,
-				message: `Removed saved snapshot '${removal.result.removedProfileName}' (${removal.result.remainingCount} snapshots remaining).`,
-				selectedProfileId: data.profiles[0]?.id,
-			};
-		},
-		updateProfile: async (profileId) => {
-			const profile = findProfileById(data, profileId);
-			if (!profile) {
-				throw new Error(`Saved profile '${profileId}' was not found.`);
-			}
-			const update = updateProfileAndReturn(data, profileId, agentOptions);
-			notifyWarnings(ctx, update.result.warnings);
-			data = update.data;
-			saveProfilesFile(data, PROFILE_STORE_PATH);
-			return {
-				data,
-				message: `Updated '${profile.name}' with current agent state (${update.result.updatedAgents} agents).`,
-				selectedProfileId: profileId,
-			};
-		},
-	});
-
-	if (result.type === "applied") {
-		await reloadAfterApply(ctx, result.outcome);
-		return;
-	}
-}
 
 export default function modelProfilesExtension(pi: ExtensionAPI): void {
 	// Register handler to refresh model registry on /reload
@@ -149,6 +26,7 @@ export default function modelProfilesExtension(pi: ExtensionAPI): void {
 			}
 
 			try {
+				const { handleModelProfilesCommand } = await import("./command-handler.js");
 				await handleModelProfilesCommand(ctx);
 			} catch (error) {
 				ctx.ui.notify(`/${COMMAND_NAME} failed: ${toErrorMessage(error)}`, "error");

package/src/profile-fields.ts

@@ -1,83 +1,93 @@
-import type { ProfileFieldKey, ProfileFields } from "./types.js";
-
-function toRecord(value: unknown): Record<string, unknown> {
-	if (!value || typeof value !== "object" || Array.isArray(value)) {
-		return {};
-	}
-	return value as Record<string, unknown>;
-}
-
-function normalizeOptionalString(value: unknown): string | undefined {
-	if (typeof value !== "string") {
-		return undefined;
-	}
-	const trimmed = value.trim();
-	return trimmed ? trimmed : undefined;
-}
-
-function normalizeTemperatureValue(value: unknown): number | undefined {
-	if (typeof value === "number") {
-		return Number.isFinite(value) ? value : undefined;
-	}
-	if (typeof value === "string" && value.trim()) {
-		const parsed = Number.parseFloat(value);
-		return Number.isFinite(parsed) ? parsed : undefined;
-	}
-	return undefined;
-}
-
-export function normalizeProfileFields(value: unknown): ProfileFields {
-	const source = toRecord(value);
-	const fields: ProfileFields = {};
-
-	const model = normalizeOptionalString(source.model);
-	if (model) {
-		fields.model = model;
-	}
-
-	const temperature = normalizeTemperatureValue(source.temperature);
-	if (temperature !== undefined) {
-		fields.temperature = temperature;
-	}
-
-	const reasoningEffort = normalizeOptionalString(source.reasoningEffort);
-	if (reasoningEffort) {
-		fields.reasoningEffort = reasoningEffort;
-	}
-
-	return fields;
-}
-
-export function hasProfileFields(fields: ProfileFields): boolean {
-	return fields.model !== undefined || fields.temperature !== undefined || fields.reasoningEffort !== undefined;
-}
-
-export function describeProfileFields(fields: ProfileFields): string {
-	const parts: string[] = [];
-	if (fields.model !== undefined) {
-		parts.push("model");
-	}
-	if (fields.temperature !== undefined) {
-		parts.push("temperature");
-	}
-	if (fields.reasoningEffort !== undefined) {
-		parts.push("reasoning");
-	}
-	return parts.length > 0 ? parts.join(", ") : "clears model overrides";
-}
-
-export function formatProfileFieldValue(key: ProfileFieldKey, fields: ProfileFields): string {
-	switch (key) {
-		case "model":
-			return fields.model ?? "(absent)";
-		case "temperature":
-			return fields.temperature !== undefined ? String(fields.temperature) : "(absent)";
-		case "reasoningEffort":
-			return fields.reasoningEffort ?? "(absent)";
-	}
-}
-
-export function sanitizeProfileName(value: string): string | null {
-	const trimmed = value.trim();
-	return trimmed ? trimmed : null;
-}
+import type { ProfileFieldKey, ProfileFields } from "./types.js";
+
+function toRecord(value: unknown): Record<string, unknown> {
+	if (!value || typeof value !== "object" || Array.isArray(value)) {
+		return {};
+	}
+	return value as Record<string, unknown>;
+}
+
+function normalizeOptionalString(value: unknown): string | undefined {
+	if (typeof value !== "string") {
+		return undefined;
+	}
+	const trimmed = value.trim();
+	return trimmed ? trimmed : undefined;
+}
+
+const COMPLETE_NUMERIC_SCALAR = /^[+-]?(?:\d+\.?\d*|\.\d+)$/;
+
+export function parseCompleteNumericScalar(value: string): number | undefined {
+	const trimmed = value.trim();
+	if (!COMPLETE_NUMERIC_SCALAR.test(trimmed)) {
+		return undefined;
+	}
+	const parsed = Number.parseFloat(trimmed);
+	return Number.isFinite(parsed) ? parsed : undefined;
+}
+
+function normalizeTemperatureValue(value: unknown): number | undefined {
+	if (typeof value === "number") {
+		return Number.isFinite(value) ? value : undefined;
+	}
+	if (typeof value === "string" && value.trim()) {
+		return parseCompleteNumericScalar(value);
+	}
+	return undefined;
+}
+
+export function normalizeProfileFields(value: unknown): ProfileFields {
+	const source = toRecord(value);
+	const fields: ProfileFields = {};
+
+	const model = normalizeOptionalString(source.model);
+	if (model) {
+		fields.model = model;
+	}
+
+	const temperature = normalizeTemperatureValue(source.temperature);
+	if (temperature !== undefined) {
+		fields.temperature = temperature;
+	}
+
+	const reasoningEffort = normalizeOptionalString(source.reasoningEffort);
+	if (reasoningEffort) {
+		fields.reasoningEffort = reasoningEffort;
+	}
+
+	return fields;
+}
+
+export function hasProfileFields(fields: ProfileFields): boolean {
+	return fields.model !== undefined || fields.temperature !== undefined || fields.reasoningEffort !== undefined;
+}
+
+export function describeProfileFields(fields: ProfileFields): string {
+	const parts: string[] = [];
+	if (fields.model !== undefined) {
+		parts.push("model");
+	}
+	if (fields.temperature !== undefined) {
+		parts.push("temperature");
+	}
+	if (fields.reasoningEffort !== undefined) {
+		parts.push("reasoning");
+	}
+	return parts.length > 0 ? parts.join(", ") : "clears model overrides";
+}
+
+export function formatProfileFieldValue(key: ProfileFieldKey, fields: ProfileFields): string {
+	switch (key) {
+		case "model":
+			return fields.model ?? "(absent)";
+		case "temperature":
+			return fields.temperature !== undefined ? String(fields.temperature) : "(absent)";
+		case "reasoningEffort":
+			return fields.reasoningEffort ?? "(absent)";
+	}
+}
+
+export function sanitizeProfileName(value: string): string | null {
+	const trimmed = value.trim();
+	return trimmed ? trimmed : null;
+}

package/src/profile-removal-service.ts

@@ -1,106 +1,106 @@
-import { multiProfilesDebugLogger } from "./debug-logger.js";
-import { ModelProfilesError } from "./errors.js";
-import type { ProfilesFile, ProfileRemovalResult, SavedProfile } from "./types.js";
-
-/**
- * Error code for profile not found during removal.
- */
-export const PROFILE_NOT_FOUND_CODE = "PROFILE_NOT_FOUND";
-
-export interface ProfileRemovalUpdateResult {
-	data: ProfilesFile;
-	result: ProfileRemovalResult;
-}
-
-interface ProfileRemovalPlan {
-	profile: SavedProfile;
-	remainingProfiles: SavedProfile[];
-	result: ProfileRemovalResult;
-}
-
-function createProfileNotFoundError(profileId: string): ModelProfilesError {
-	return new ModelProfilesError(
-		`Profile '${profileId}' not found. It may have been removed already.`,
-		PROFILE_NOT_FOUND_CODE,
-	);
-}
-
-function buildRemovalPlan(data: ProfilesFile, profileId: string): ProfileRemovalPlan {
-	const profileIndex = data.profiles.findIndex((profile) => profile.id === profileId);
-	const profile = data.profiles[profileIndex];
-
-	if (profileIndex === -1 || !profile) {
-		multiProfilesDebugLogger.log("profile-removal", {
-			event: "removal_failed",
-			profileId,
-			reason: "profile_not_found",
-			profileCount: data.profiles.length,
-		});
-		throw createProfileNotFoundError(profileId);
-	}
-
-	const remainingProfiles = [
-		...data.profiles.slice(0, profileIndex),
-		...data.profiles.slice(profileIndex + 1),
-	];
-
-	return {
-		profile,
-		remainingProfiles,
-		result: {
-			removedProfileId: profile.id,
-			removedProfileName: profile.name,
-			remainingCount: remainingProfiles.length,
-		},
-	};
-}
-
-function logProfileRemoved(plan: ProfileRemovalPlan): void {
-	multiProfilesDebugLogger.log("profile-removal", {
-		event: "profile_removed",
-		profileId: plan.profile.id,
-		profileName: plan.profile.name,
-		agentCount: plan.profile.agents.length,
-		remainingCount: plan.result.remainingCount,
-	});
-}
-
-/**
- * Remove a profile from the profiles file.
- *
- * Validates that the profile exists before removal.
- * Preserves other profiles unchanged (immutable pattern).
- * Logs removal event via debug logger.
- *
- * @param data - The profiles file data
- * @param profileId - The ID of the profile to remove
- * @returns ProfileRemovalResult with removed profile info and remaining count
- * @throws ModelProfilesError with code PROFILE_NOT_FOUND if profile doesn't exist
- */
-export function removeProfile(data: ProfilesFile, profileId: string): ProfileRemovalResult {
-	const plan = buildRemovalPlan(data, profileId);
-	logProfileRemoved(plan);
-	return plan.result;
-}
-
-/**
- * Remove a profile and return the updated profiles file with removal metadata.
- *
- * @param data - The profiles file data
- * @param profileId - The ID of the profile to remove
- * @returns New ProfilesFile with the profile removed and removal metadata
- * @throws ModelProfilesError with code PROFILE_NOT_FOUND if profile doesn't exist
- */
-export function removeProfileAndUpdate(data: ProfilesFile, profileId: string): ProfileRemovalUpdateResult {
-	const plan = buildRemovalPlan(data, profileId);
-	logProfileRemoved(plan);
-
-	return {
-		data: {
-			version: data.version,
-			importedAt: data.importedAt,
-			profiles: plan.remainingProfiles,
-		},
-		result: plan.result,
-	};
-}
+import { multiProfilesDebugLogger } from "./debug-logger.js";
+import { ModelProfilesError } from "./errors.js";
+import type { ProfilesFile, ProfileRemovalResult, SavedProfile } from "./types.js";
+
+/**
+ * Error code for profile not found during removal.
+ */
+export const PROFILE_NOT_FOUND_CODE = "PROFILE_NOT_FOUND";
+
+export interface ProfileRemovalUpdateResult {
+	data: ProfilesFile;
+	result: ProfileRemovalResult;
+}
+
+interface ProfileRemovalPlan {
+	profile: SavedProfile;
+	remainingProfiles: SavedProfile[];
+	result: ProfileRemovalResult;
+}
+
+function createProfileNotFoundError(profileId: string): ModelProfilesError {
+	return new ModelProfilesError(
+		`Profile '${profileId}' not found. It may have been removed already.`,
+		PROFILE_NOT_FOUND_CODE,
+	);
+}
+
+function buildRemovalPlan(data: ProfilesFile, profileId: string): ProfileRemovalPlan {
+	const profileIndex = data.profiles.findIndex((profile) => profile.id === profileId);
+	const profile = data.profiles[profileIndex];
+
+	if (profileIndex === -1 || !profile) {
+		multiProfilesDebugLogger.log("profile-removal", {
+			event: "removal_failed",
+			profileId,
+			reason: "profile_not_found",
+			profileCount: data.profiles.length,
+		});
+		throw createProfileNotFoundError(profileId);
+	}
+
+	const remainingProfiles = [
+		...data.profiles.slice(0, profileIndex),
+		...data.profiles.slice(profileIndex + 1),
+	];
+
+	return {
+		profile,
+		remainingProfiles,
+		result: {
+			removedProfileId: profile.id,
+			removedProfileName: profile.name,
+			remainingCount: remainingProfiles.length,
+		},
+	};
+}
+
+function logProfileRemoved(plan: ProfileRemovalPlan): void {
+	multiProfilesDebugLogger.log("profile-removal", {
+		event: "profile_removed",
+		profileId: plan.profile.id,
+		profileName: plan.profile.name,
+		agentCount: plan.profile.agents.length,
+		remainingCount: plan.result.remainingCount,
+	});
+}
+
+/**
+ * Remove a profile from the profiles file.
+ *
+ * Validates that the profile exists before removal.
+ * Preserves other profiles unchanged (immutable pattern).
+ * Logs removal event via debug logger.
+ *
+ * @param data - The profiles file data
+ * @param profileId - The ID of the profile to remove
+ * @returns ProfileRemovalResult with removed profile info and remaining count
+ * @throws ModelProfilesError with code PROFILE_NOT_FOUND if profile doesn't exist
+ */
+export function removeProfile(data: ProfilesFile, profileId: string): ProfileRemovalResult {
+	const plan = buildRemovalPlan(data, profileId);
+	logProfileRemoved(plan);
+	return plan.result;
+}
+
+/**
+ * Remove a profile and return the updated profiles file with removal metadata.
+ *
+ * @param data - The profiles file data
+ * @param profileId - The ID of the profile to remove
+ * @returns New ProfilesFile with the profile removed and removal metadata
+ * @throws ModelProfilesError with code PROFILE_NOT_FOUND if profile doesn't exist
+ */
+export function removeProfileAndUpdate(data: ProfilesFile, profileId: string): ProfileRemovalUpdateResult {
+	const plan = buildRemovalPlan(data, profileId);
+	logProfileRemoved(plan);
+
+	return {
+		data: {
+			version: data.version,
+			importedAt: data.importedAt,
+			profiles: plan.remainingProfiles,
+		},
+		result: plan.result,
+	};
+}