pi-midcompact 0.5.0 → 0.5.1

package/README.md

@@ -127,7 +127,7 @@ Run:
 /midcompact start
 ```
 
-Pi opens a three-way chooser before creating transaction state: **Drop**, **Agent direct**, or **User manual**. Agent direct starts the existing inventory-first Agent workflow. User manual sends the same transaction guidance with a final “acknowledge only” instruction; after the Agent replies briefly, the Selection workbench opens. It does not start planning or mutate the DraftPlan until the user hands off later. Save the initial DraftPlan, close the UI, then tell the Agent to continue when you are ready. You can include an initial focus in the same command:
+Pi opens a three-way chooser before creating transaction state: **Agent direct**, **User manual**, or **Drop**. Agent direct is the first and default-highlighted option, matching the previous fast path. The chooser is the standard `select` dialog, identical in interactive and RPC mode; RPC carries it as an extension UI `select` message with a bounded timeout, so an unresponsive client cancels instead of blocking. print/JSON modes have no dialog and default to **Agent direct**. Agent direct starts the existing inventory-first Agent workflow. User manual sends the same transaction guidance with a final “acknowledge only” instruction; after the Agent replies briefly, the Selection workbench opens (browser-based outside interactive mode). It does not start planning or mutate the DraftPlan until the user hands off later. Save the initial DraftPlan, close the UI, then tell the Agent to continue when you are ready. You can include an initial focus in the same command:
 
 ```text
 /midcompact start Compress the early repository exploration, but keep user requirements verbatim.
@@ -211,7 +211,7 @@ Enter/Esc/q        close
 
 | Command | Result |
 | --- | --- |
-| `/midcompact start [instructions]` | Opens Drop / Agent direct / User manual, then starts a transaction at the current session-tree leaf. |
+| `/midcompact start [instructions]` | Opens Agent direct / User manual / Drop, then starts a transaction at the current session-tree leaf. |
 | `/midcompact select` | Opens the native TUI Selection workbench for range and KEEP editing. |
 | `/midcompact select-webui` | Opens the local browser Selection workbench. |
 | `/midcompact review` | Opens summary/topic review in the native TUI. |

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-midcompact",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Branch-aware mid-context compression for the Pi coding agent",
   "author": "frostime",
   "repository": {

package/src/index.ts

@@ -17,8 +17,20 @@ import { projectMessages } from "./projection.js";
 import { registerStateRenderer, stateTreeLabel } from "./renderers.js";
 import { showReviewUi } from "./review-ui.js";
 import { showSelectionUi } from "./selection-ui.js";
-import { showStartChoiceUi } from "./start-ui.js";
+import { showStartChoice } from "./start-ui.js";
 import { showReviewWebUi } from "./review-webui.js";
+
+/**
+ * Browser opener for the web workbenches. Tests override it to keep the suites
+ * from spawning a system browser; production leaves it undefined and opens the
+ * default browser.
+ */
+export let openReviewWebBrowser: ((url: string) => void) | undefined;
+
+/** Test seam setter; see `openReviewWebBrowser`. */
+export function setOpenReviewWebBrowser(opener?: (url: string) => void): void {
+  openReviewWebBrowser = opener;
+}
 import {
   DRAFT_ENTRY,
   STATE_ENTRY,
@@ -218,23 +230,18 @@ export default function (pi: ExtensionAPI) {
       ctx.ui.notify("Cannot start midcompact without a session leaf.", "error");
       return;
     }
-    if (ctx.hasUI && ctx.mode !== "tui") {
-      const ok = await ctx.ui.confirm(
-        "Start midcompact transaction?",
-        "The current context snapshot will be frozen as an anchor. You will need to review and explicitly commit or abort later.",
-      );
-      if (!ok) {
-        ctx.ui.notify("Midcompact start cancelled.", "info");
-        return;
-      }
-    }
     // Mode choice: Agent-first or User-first. Both operate on the same DraftPlan;
-    // neither freezes boundaries. No mode flags on the command line.
+    // neither freezes boundaries. Drop maps to cancellation, so this one chooser
+    // replaces the separate confirmation. No mode flags on the command line.
     const modeChoice = await chooseStartMode(ctx);
     if (modeChoice === "cancelled") {
       ctx.ui.notify("Midcompact start cancelled.", "info");
       return;
     }
+    if (modeChoice === "unrecognized") {
+      ctx.ui.notify("Midcompact start cancelled: the dialog returned an unrecognized choice.", "warning");
+      return;
+    }
     const startMode: StartMode = modeChoice;
     transaction = {
       version: 1,
@@ -261,9 +268,11 @@ export default function (pi: ExtensionAPI) {
     await openSelectionUi(ctx);
   }
 
-  async function chooseStartMode(ctx: ExtensionCommandContext): Promise<StartMode | "cancelled"> {
-    if (!ctx.hasUI || ctx.mode !== "tui") return "agent";
-    return showStartChoiceUi(ctx);
+  async function chooseStartMode(ctx: ExtensionCommandContext): Promise<StartMode | "cancelled" | "unrecognized"> {
+    // The standard `select` dialog works identically in TUI and RPC; modes
+    // without any UI (json/print) cannot prompt and default to Agent-first.
+    if (!ctx.hasUI) return "agent";
+    return showStartChoice(ctx);
   }
 
   async function openSelectionUi(ctx: ExtensionCommandContext, mode: "auto" | "tui" | "web" = "auto"): Promise<void> {
@@ -312,7 +321,7 @@ export default function (pi: ExtensionAPI) {
           pi.appendEntry(DRAFT_ENTRY, draft);
           updateStatus(ctx, currentTx, draft, planningLock.owner);
         },
-      }, "selection");
+      }, "selection", { openBrowser: openReviewWebBrowser });
       ctx.ui.notify("Selection closed. The DraftPlan is saved; tell the Agent to continue when ready.", "info");
     } finally {
       releaseUi(planningLock);
@@ -457,7 +466,7 @@ export default function (pi: ExtensionAPI) {
         editSummary: (id, summary) => commitMutation(updateDraftRange(draft ?? emptyDraft(currentTx.id), id, { summary })),
         editTopic: (id, topic) => commitMutation(updateDraftRange(draft ?? emptyDraft(currentTx.id), id, { topic: topic || undefined })),
         remove: (id) => commitMutation(removeDraftRange(draft ?? emptyDraft(currentTx.id), id)),
-      });
+      }, undefined, { openBrowser: openReviewWebBrowser });
       ctx.ui.notify("Midcompact review-webui closed.", "info");
       return;
     }

package/src/start-ui.ts

@@ -1,57 +1,52 @@
 import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
-import { Key, matchesKey, truncateToWidth } from "@earendil-works/pi-tui";
 
 import type { StartMode } from "./types.js";
 
-export type StartChoice = StartMode | "cancelled";
+export type StartChoice = StartMode | "cancelled" | "unrecognized";
 
-export async function showStartChoiceUi(ctx: ExtensionCommandContext): Promise<StartChoice> {
-  if (ctx.mode !== "tui") return "agent";
-  return ctx.ui.custom<StartChoice>(
-    (tui, theme, _keybindings, done) => {
-      const choices: Array<{ value: StartChoice; title: string; detail: string }> = [
-        { value: "cancelled", title: "Drop", detail: "Leave the session unchanged" },
-        { value: "agent", title: "Agent direct", detail: "Inspect and draft with Agent" },
-        { value: "user", title: "User manual", detail: "Select the initial DraftPlan yourself" },
-      ];
-      let selected = 1;
-      const component = {
-        render(width: number): string[] {
-          const w = Math.max(48, Math.min(width, 94));
-          const line = (text: string) => theme.fg("border", `| ${truncateToWidth(text, w - 4, "...", true).padEnd(w - 4)} |`);
-          const rule = theme.fg("border", `+${"-".repeat(w - 2)}+`);
-          const rows = choices.map((choice, index) => {
-            const marker = index === selected ? theme.fg("accent", ">") : " ";
-            const rawTitle = choice.title.padEnd(18);
-            const title = index === selected ? theme.fg("accent", theme.bold(rawTitle)) : rawTitle;
-            return line(`${marker} ${String(index + 1)}  ${title} ${theme.fg("dim", choice.detail)}`);
-          });
-          return [
-            rule,
-            line(theme.fg("accent", theme.bold("Midcompact | Freeze current context"))),
-            line(theme.fg("dim", "Choose how to enter. Only Agent direct starts a model turn.")),
-            rule,
-            ...rows,
-            rule,
-            line(theme.fg("dim", "left/right or j/k move | Enter choose | Esc drop")),
-            rule,
-          ];
-        },
-        invalidate(): void {},
-        handleInput(data: string): void {
-          if (matchesKey(data, Key.escape) || data === "q") { done("cancelled"); return; }
-          if (matchesKey(data, Key.enter)) { done(choices[selected]!.value); return; }
-          if (data === "1") { done("cancelled"); return; }
-          if (data === "2") { done("agent"); return; }
-          if (data === "3") { done("user"); return; }
-          if (matchesKey(data, Key.left) || matchesKey(data, Key.up) || data === "k") selected = (selected + choices.length - 1) % choices.length;
-          else if (matchesKey(data, Key.right) || matchesKey(data, Key.down) || data === "j") selected = (selected + 1) % choices.length;
-          else return;
-          tui.requestRender();
-        },
-      };
-      return component;
-    },
-    { overlay: true, overlayOptions: { width: "76%", maxHeight: 13, anchor: "center" } },
-  );
+interface StartChoiceOption {
+  value: StartChoice;
+  label: string;
 }
+
+/**
+ * The three entry decisions. Shared by TUI and RPC so every mode offers the
+ * same choice set in the same order. Agent direct comes first: the standard
+ * selector highlights the first option, so Enter on open keeps the fast
+ * Agent-first start path, and RPC clients see the recommended entry first.
+ */
+const START_CHOICES: StartChoiceOption[] = [
+  { value: "agent", label: "Agent direct — Inspect and draft with Agent" },
+  { value: "user", label: "User manual — Select the initial DraftPlan yourself" },
+  { value: "cancelled", label: "Drop — Leave the session unchanged" },
+];
+
+/**
+ * Bound for RPC dialog waits. The timeout exists only as a safety net: when
+ * the RPC client never answers, the extension-UI sub-protocol auto-resolves
+ * the dialog (`undefined`) so the start cancels instead of blocking the
+ * extension forever. 120s is generous for the human on the other side of the
+ * wire (pi's own examples use 5s for urgent security confirms) while still
+ * bounding the worst-case stall. TUI mode passes no timeout: interactive
+ * users may take as long as they want.
+ */
+const START_DIALOG_TIMEOUT_MS = 120_000;
+
+/**
+ * Standard `select` dialog for the start mode, used identically in TUI and
+ * RPC. It serializes as an extension UI `select` request over the RPC
+ * sub-protocol, while interactive mode renders the built-in selector.
+ */
+export async function showStartChoice(ctx: ExtensionCommandContext): Promise<StartChoice> {
+  const options = START_CHOICES.map((choice) => choice.label);
+  const choice = await ctx.ui.select(
+    "Midcompact start — freeze the current context as an anchor; review, then commit or abort explicitly",
+    options,
+    ctx.mode === "rpc" ? { timeout: START_DIALOG_TIMEOUT_MS } : undefined,
+  );
+  if (choice === undefined) return "cancelled";
+  // A value outside the offered options is a protocol mismatch on the client
+  // side, not a user decision; keep it distinguishable from a real Drop.
+  const index = options.indexOf(choice);
+  return index >= 0 ? START_CHOICES[index]!.value : "unrecognized";
+}