pi-mcp-adapter 2.3.4 → 2.3.5

package/CHANGELOG.md

@@ -7,6 +7,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [2.3.5] - 2026-04-13
+
+### Fixed
+- Session lifecycle now always tears down OAuth callback state on restart and shutdown, preventing callback-server leaks across session transitions.
+- OAuth callback server now calls `unref()` after successful bind so it no longer keeps sub-agent processes alive by itself.
+- Strict OAuth port mode now rebinds to the configured callback port when safe, while refusing to switch ports when authorizations are still pending.
+- Added focused lifecycle/callback-server regression coverage for teardown, `unref()`, strict rebinding, and pending-auth guardrails.
+- Thanks @blai for the investigation and PR #43 that surfaced the sub-agent hang/root lifecycle issues.
+
 ## [2.3.4] - 2026-04-12
 
 ### Fixed

package/index.ts

@@ -8,7 +8,7 @@ import { flushMetadataCache, initializeMcp, updateStatusBar } from "./init.js";
 import { loadMetadataCache } from "./metadata-cache.js";
 import { executeCall, executeConnect, executeDescribe, executeList, executeSearch, executeStatus, executeUiMessages } from "./proxy-modes.js";
 import { getConfigPathFromArgv, truncateAtWord } from "./utils.js";
-import { initializeOAuth } from "./mcp-auth-flow.js";
+import { initializeOAuth, shutdownOAuth } from "./mcp-auth-flow.js";
 
 export default function mcpAdapter(pi: ExtensionAPI) {
   let state: McpExtensionState | null = null;
@@ -85,7 +85,10 @@ export default function mcpAdapter(pi: ExtensionAPI) {
     initPromise = null;
 
     try {
-      await shutdownState(previousState, "session_restart");
+      await Promise.all([
+        shutdownState(previousState, "session_restart"),
+        shutdownOAuth(),
+      ]);
     } catch (error) {
       console.error("MCP: failed to shut down previous session state", error);
     }
@@ -133,7 +136,10 @@ export default function mcpAdapter(pi: ExtensionAPI) {
     initPromise = null;
 
     try {
-      await shutdownState(currentState, "session_shutdown");
+      await Promise.all([
+        shutdownState(currentState, "session_shutdown"),
+        shutdownOAuth(),
+      ]);
     } catch (error) {
       console.error("MCP: session shutdown cleanup failed", error);
     }

package/mcp-callback-server.ts

@@ -155,9 +155,13 @@ export async function ensureCallbackServer(options: EnsureCallbackServerOptions
   if (server) {
     if (!strictPort || getOAuthCallbackPort() === configuredPort) return
 
-    throw new Error(
-      `OAuth callback server is already running on port ${getOAuthCallbackPort()}, but strict callback port ${configuredPort} is required`
-    )
+    if (pendingAuths.size > 0) {
+      throw new Error(
+        `OAuth callback server is running on port ${getOAuthCallbackPort()}, but strict callback port ${configuredPort} is required and cannot be switched while authorizations are pending`
+      )
+    }
+
+    await stopCallbackServer()
   }
 
   const preferredPort = configuredPort
@@ -180,6 +184,7 @@ export async function ensureCallbackServer(options: EnsureCallbackServerOptions
       })
 
       server = candidateServer
+      server.unref()
       setOAuthCallbackPort(candidatePort)
       return
     } catch (error) {
@@ -257,7 +262,7 @@ export async function stopCallbackServer(): Promise<void> {
   const pendingList = Array.from(pendingAuths.entries())
   pendingAuths.clear()
   setTimeout(() => {
-    for (const [state, pending] of pendingList) {
+    for (const [, pending] of pendingList) {
       clearTimeout(pending.timeout)
       pending.reject(new Error("OAuth callback server stopped"))
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-mcp-adapter",
-  "version": "2.3.4",
+  "version": "2.3.5",
   "description": "MCP (Model Context Protocol) adapter extension for Pi coding agent",
   "type": "module",
   "license": "MIT",