pi-maestro-teammate 2.4.0 → 2.6.0

package/README.md

@@ -189,12 +189,12 @@ project .pi/agents > project .agents > ~/.agents > legacy user directory > bundl
 
 Configure task-type defaults with `Alt+M` or `/teammate-models`. The Control Center's **Profiles** tab is the saved-template system: it manages multiple named routing Profiles shared by every project. Its **Routing** tab edits the active global Profile and combines built-in task types, discovered agent types, and types already present in that Profile.
 
-Switch the current project's template directly by stable Profile ID or display name. With no argument, the command opens the Control Center on **Profiles**:
+Switch the current project's template directly by stable Profile ID or display name. With no argument, the same command opens the full Control Center:
 
 ```text
-/teammate-model fast-lane
-/teammate-model Fast Lane
-/teammate-model
+/teammate-models fast-lane
+/teammate-models Fast Lane
+/teammate-models
 ```
 
 Command completion lists every saved template and marks the project-active and global-default entries. If display names are duplicated, use the stable ID. Direct switching disables but preserves project overrides, matching the Profiles UI.
@@ -359,6 +359,12 @@ observe({ action: "watch", targets: [{ kind: "teammate", id: "reviewer" }], time
 
 A durable, per-workspace-isolated message queue backing cross-session delivery (staging → ready → claimed → accepted, atomic writes + idempotent receipts). Cold resume stays synchronous when the mailbox is authoritative; Windows file-lock renames retry automatically and orphaned state records are garbage-collected. External consumers (the Flow host) integrate through the `pi-maestro-teammate/v1/mailbox` subpath: the extension publishes a live `MailboxHostRegistry` on the shared-process bridge key `Symbol.for("pi-maestro-teammate.mailbox-registry")` (durable `enqueueTaskNotification`, per-recipient `pendingCount`, and `negotiate` capability v1/v2, with `taskId`-keyed dedup); `pi-maestro-flow` consumes it via `mailboxRegistry()` (see `packages/pi-maestro-flow/src/extension/index.ts`) and the contract is covered by `test/mailbox-registry.test.ts`.
 
+## Advisor Compatibility
+
+When installed by itself, `pi-maestro-teammate` keeps the low-frequency standalone Advisor. Configure its defaults in `.pi/settings.json` under `monitor.advisor` (or the top-level `advisor` key), or with `PI_ADVISOR`, `PI_ADVISOR_COOLDOWN_MS`, and `PI_ADVISOR_MAX_REVIEWS`. `/advisor on|off` is a current-session override; `/advisor status` shows the effective state.
+
+When `pi-maestro-flow` is also loaded, its `pi-maestro-flow/advisor` runtime is the canonical owner and this package's priority-10 fallback sleeps, even when the Flow Advisor is disabled. A process-wide registry and one dynamic `/advisor` broker prevent duplicate commands, double dispatch, and stale delivery in either package load order. Flow reads canonical `.pi/advisor.json` first, otherwise the legacy settings above, then defaults, and finally the same environment overrides. See the Flow Advisor guide for manual/hybrid mode, automatic review budgets, and `reviewEveryToolResults: 0`.
+
 ## Runtime
 
 - Foreground dispatch is the default and returns child results directly.

package/agents/analyst.md

@@ -4,7 +4,6 @@ description: "Read-only technical analysis and review specialist. Use for techni
 systemPromptMode: replace
 inheritProjectContext: false
 thinking: high
-taskType: analysis
 tools: read, grep, find, ls
 inheritSkills: false
 ---

package/agents/explorer.md

@@ -3,7 +3,6 @@ name: explorer
 description: "Read-only codebase discovery and call-chain tracing specialist. Use when you need file:line answers fast; not for analysis, planning, or implementation."
 systemPromptMode: replace
 thinking: low
-taskType: explore
 tools: read, grep, find, ls
 inheritProjectContext: false
 inheritSkills: false

package/agents/general.md

@@ -1,7 +1,6 @@
 ---
 name: general
 description: "General-purpose teammate for direct implementation, analysis, and verification. Use for direct work in the project; not for read-only discovery, planning, or DAG orchestration."
-taskType: development
 systemPromptMode: append
 inheritProjectContext: true
 tools: read, grep, find, ls, bash, edit, write

package/agents/planner.md

@@ -4,7 +4,6 @@ description: "Read-only architecture and execution planning specialist. Use to p
 systemPromptMode: replace
 inheritProjectContext: true
 thinking: high
-taskType: planning
 tools: read, grep, find, ls
 inheritSkills: false
 ---
@@ -59,7 +58,8 @@ Return only Markdown for the Plan, with no preface, commentary, interview log, o
    Dependencies must form an executable DAG and identify safe parallel work. A task is a verifiable outcome, not a command or activity log.
 8. `## Validation`: specify exact commands or observable checks, expected results, requirement coverage, and relevant regression or integration boundaries.
 9. `## Risks and Recovery`: state concrete risks, mitigations, and rollback or recovery behavior.
-10. `## Open Decisions`: list unresolved user-owned decisions. Write `None` only after evidence-based review; a Plan with unresolved decisions is not confirmation-ready.
+10. `## Knowledge Outcome`: require an end-of-execution assessment after implementation and verification. Name plausible candidate topics only when the work may produce a reusable non-obvious pitfall, failure lesson, trade-off, or prescriptive constraint; otherwise write `None expected` with a concrete reason. This section predicts what to assess—it must not fabricate knowledge in advance. Actual staging happens after approval in Act/Run mode, and the executor must explicitly report zero candidates when no result meets the project's knowledge quality bar.
+11. `## Open Decisions`: list unresolved user-owned decisions. Write `None` only after evidence-based review; a Plan with unresolved decisions is not confirmation-ready.
 
 Execution ownership: after the Plan is approved, implementation defaults to the project's `general-executor` agent (fallback: `general` when that role is not discovered). State this default in the Plan's Execution Plan section when it helps, and shape each task so a generic executor can consume it without rediscovery — concrete outcome, bounded scope, named files, acceptance criteria, and verification commands. Do not assume a workflow-task pipeline (`.task/TASK-*.json`) exists; the Plan must be executable by `general-executor` from the Plan text alone.
 

package/agents/research.md

@@ -1,7 +1,6 @@
 ---
 name: research
 description: "Read-only project knowledge and external web research specialist. Use for source-grounded answers from knowledge bases or the web; not for code discovery or implementation."
-taskType: analysis
 thinking: high
 systemPromptMode: replace
 inheritProjectContext: true

package/agents/verifier.md

@@ -1,7 +1,6 @@
 ---
 name: verifier
 description: "Independent read-only fallback verifier for Goal completion claims. Use only when a Goal declares no acceptance commands; not for ordinary review."
-taskType: verification
 thinking: low
 systemPromptMode: replace
 inheritProjectContext: false

package/agents/workflow.md

@@ -4,7 +4,6 @@ description: "Decomposes complex problems and dispatches dependency-aware teamma
 systemPromptMode: replace
 inheritProjectContext: true
 thinking: high
-taskType: planning
 tools: read, grep, find, ls, teammate, teammate-send, teammate-list, observe
 inheritSkills: false
 ---

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-maestro-teammate",
-  "version": "2.4.0",
+  "version": "2.6.0",
   "description": "Pi extension — teammate agent dispatch with DAG task graphs, RPC messaging, and compact TUI",
   "type": "module",
   "engines": {
@@ -195,8 +195,8 @@
     "cross-spawn": "7.0.6",
     "jiti": "2.7.0",
     "pi-maestro-settings-core": "0.2.1",
-    "pi-maestro-backend-core": "*",
-    "pi-maestro-backends": "*",
+    "pi-maestro-backend-core": "0.1.3",
+    "pi-maestro-backends": "0.1.3",
     "proper-lockfile": "4.1.2",
     "ssh2": "1.17.0",
     "zod": "4.4.3"

package/src/completion-outbox/coordinator.ts

@@ -150,6 +150,7 @@ export class CompletionDeliveryCoordinator {
   readonly #operations = new Set<Promise<unknown>>();
   #binding: CompletionSessionBinding | undefined;
   #unsubscribe: (() => void) | undefined;
+  #accepting = true;
   #disposed = false;
   // Throttle GC attempts inside reconcile(). tryGc() also persists a cross-process
   // page/expiry fence, but this local guard prevents one coordinator from
@@ -169,8 +170,12 @@ export class CompletionDeliveryCoordinator {
     });
   }
 
-  async beginDispatch(seed: CompletionDispatchSeed): Promise<CompletionDispatchDurability> {
-    if (!this.#enabled()) return { durable: false };
+  beginDispatch(seed: CompletionDispatchSeed): Promise<CompletionDispatchDurability> {
+    return this.#track(this.#beginDispatch(seed));
+  }
+
+  async #beginDispatch(seed: CompletionDispatchSeed): Promise<CompletionDispatchDurability> {
+    if (!this.#accepting || this.#disposed || !this.#enabled()) return { durable: false };
     const existing = this.#dispatches.get(seed.dispatchId);
     if (existing) {
       if (existing.handle.reservationId !== seed.reservationId
@@ -181,21 +186,42 @@ export class CompletionDeliveryCoordinator {
     }
     const provider = this.registry.current();
     if (!provider) return { durable: false };
-    await this.store.reserve(seed);
+    // Acquire the cross-extension ownership pin before the first await. Flow
+    // may retire its current provider as soon as shutdown begins, but capture
+    // must retain this exact generation until the admitted begin either commits
+    // into #dispatches or rolls back.
+    const releaseProviderPin = this.registry.pinDispatch(seed.dispatchId, provider);
+    let reserved = false;
     try {
+      await this.store.reserve(seed);
+      reserved = true;
       const handle = await provider.beginDispatch(seed);
-      // Pin the provider instance in the shared registry as well as this
-      // coordinator. Flow publication capture resolves stage/commit through
-      // this dispatch ownership fence even after a provider reload.
-      const releaseProviderPin = this.registry.pinDispatch(seed.dispatchId, provider);
+      if (!this.#accepting || this.#disposed) {
+        await provider.abandonDispatch({
+          dispatchId: seed.dispatchId,
+          reservationId: seed.reservationId,
+          reason: "completion coordinator stopped admission during beginDispatch",
+          abandonedAt: this.#now(),
+        }).catch(() => undefined);
+        await this.store.releaseReservation(seed.target, seed.reservationId).catch(() => undefined);
+        releaseProviderPin();
+        return { durable: false };
+      }
       this.#dispatches.set(seed.dispatchId, { handle, seed, provider, releaseProviderPin });
       return { durable: true, handle };
     } catch (error) {
-      await this.store.releaseReservation(seed.target, seed.reservationId).catch(() => undefined);
+      if (reserved) {
+        await this.store.releaseReservation(seed.target, seed.reservationId).catch(() => undefined);
+      }
+      releaseProviderPin();
       throw error;
     }
   }
 
+  stopAdmission(): void {
+    this.#accepting = false;
+  }
+
   async requireNotification(input: CompletionNotificationRequirement): Promise<void> {
     if (!this.#dispatches.has(input.dispatchId)) return;
     const provider = this.#pinnedProvider(input.dispatchId);
@@ -368,6 +394,7 @@ export class CompletionDeliveryCoordinator {
   }
 
   dispose(): void {
+    this.#accepting = false;
     this.#disposed = true;
     this.#binding = undefined;
     this.#acceptedByHost.clear();
@@ -595,8 +622,10 @@ export class CompletionDeliveryCoordinator {
     if (pinned) return pinned.provider;
     const recovered = this.#recoveredProviderPins.get(dispatchId);
     if (recovered) return recovered.provider;
-    const provider = this.registry.providerForDispatch(dispatchId) ?? this.registry.current();
-    if (!provider) throw new Error("Completion durability provider became unavailable.");
+    const provider = this.registry.providerForDispatch(dispatchId);
+    if (!provider) {
+      throw new Error(`Completion dispatch ${dispatchId} has no pinned durability provider.`);
+    }
     return provider;
   }
 

package/src/completion-outbox/registry.ts

@@ -20,6 +20,7 @@ export class CompletionDurabilityRegistryImpl implements CompletionDurabilityReg
     provider: CompletionDurabilityProvider;
     owners: Set<symbol>;
   }>();
+  readonly #providerIdleWaiters = new Map<CompletionDurabilityProvider, Set<() => void>>();
 
   current(): CompletionDurabilityProvider | undefined {
     return this.#provider;
@@ -52,10 +53,24 @@ export class CompletionDurabilityRegistryImpl implements CompletionDurabilityReg
       released = true;
       const active = this.#dispatchPins.get(dispatchId);
       if (!active || active.provider !== provider || !active.owners.delete(owner)) return;
-      if (active.owners.size === 0) this.#dispatchPins.delete(dispatchId);
+      if (active.owners.size === 0) {
+        this.#dispatchPins.delete(dispatchId);
+        this.#resolveProviderIdle(provider);
+      }
     };
   }
 
+  waitForProviderIdle(provider: CompletionDurabilityProvider): Promise<void> {
+    if (![...this.#dispatchPins.values()].some((pin) => pin.provider === provider)) {
+      return Promise.resolve();
+    }
+    return new Promise<void>((resolve) => {
+      const waiters = this.#providerIdleWaiters.get(provider) ?? new Set<() => void>();
+      waiters.add(resolve);
+      this.#providerIdleWaiters.set(provider, waiters);
+    });
+  }
+
   register(provider: CompletionDurabilityProvider): () => void {
     if (!provider || typeof provider !== "object") {
       throw new TypeError("Completion durability provider must be an object.");
@@ -80,6 +95,14 @@ export class CompletionDurabilityRegistryImpl implements CompletionDurabilityReg
     return () => this.#listeners.delete(listener);
   }
 
+  #resolveProviderIdle(provider: CompletionDurabilityProvider): void {
+    if ([...this.#dispatchPins.values()].some((pin) => pin.provider === provider)) return;
+    const waiters = this.#providerIdleWaiters.get(provider);
+    if (!waiters) return;
+    this.#providerIdleWaiters.delete(provider);
+    for (const resolve of waiters) resolve();
+  }
+
   #notify(): void {
     const snapshot = this.snapshot();
     for (const listener of this.#listeners) {