pi-lsp-adapter 0.1.1 → 0.1.3

package/README.md

@@ -442,17 +442,20 @@ Run `/reload` in Pi after editing the extension.
 
 ## Release
 
-Publishing is tag-driven, but do not create release tags by hand. Use the release helper so `package.json` and `package-lock.json` are bumped before the matching semver tag is created. The GitHub Actions publish workflow is intentionally read-only: it verifies the tag against both version files and fails instead of patching tagged source during publish.
+Publishing is CI-driven. Do not create release tags by hand. To cut a release, make a normal commit that bumps `package.json` and `package-lock.json`; after that commit lands on `main` and CI passes, `.github/workflows/publish.yml` creates the matching semver tag and publishes to npm.
 
 npm publishing uses Trusted Publishing for `.github/workflows/publish.yml`, so no npm token secret is required. The npm package must have a Trusted Publisher configured for `nikmmd/pi-lsp-adapter` and workflow filename `publish.yml`.
 
 ```bash
-npm run release -- 0.1.2 --push
+npm version 0.1.2 --no-git-tag-version
+git add package.json package-lock.json
+git commit -m "chore: release v0.1.2"
+git push origin main
 ```
 
-Omit `--push` to create the release commit and tag locally, then push with the command printed by the helper.
+Non-release pushes to `main` also trigger the publish workflow, but it exits without publishing when the current `package.json` version already exists on npm.
 
-Stable tags such as `v0.1.0` publish with the npm `latest` dist-tag. Prerelease tags such as `v0.2.0-beta.1` publish with the npm `next` dist-tag.
+Stable versions such as `0.1.2` publish with the npm `latest` dist-tag. Prerelease versions such as `0.2.0-beta.1` publish with the npm `next` dist-tag.
 
 ## Troubleshooting
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-lsp-adapter",
-  "version": "0.1.1",
+  "version": "0.1.3",
   "description": "Pi extension that gives coding agents Language Server Protocol tools for diagnostics, hover, definitions, references, and symbol search",
   "author": "Nikmmd",
   "license": "MIT",
@@ -38,8 +38,7 @@
     "test:watch": "vitest",
     "typecheck": "tsc --noEmit",
     "format": "prettier --write .",
-    "format:check": "prettier --check .",
-    "release": "bash scripts/release.sh"
+    "format:check": "prettier --check ."
   },
   "pi": {
     "extensions": [

package/src/install/installers.ts

@@ -364,12 +364,29 @@ async function resolveExecutable(command: string, env: Record<string, string>, s
     return absolute;
   }
 
-  const pathEntries = (env.PATH ?? "").split(process.platform === "win32" ? ";" : ":").filter(Boolean);
+  const rawPath = env.PATH ?? "";
+
+  let pathEntries: string[];
+  if (process.platform === "win32" && (rawPath.includes("/c/") || rawPath.includes("/usr/"))) {
+    // Git Bash / MSYS / MinGW expose a POSIX-style, ":"-separated PATH.
+    pathEntries = rawPath.split(":").filter(Boolean);
+  } else {
+    pathEntries = rawPath.split(process.platform === "win32" ? ";" : ":").filter(Boolean);
+  }
+
   const extensions = process.platform === "win32" ? (env.PATHEXT ?? ".EXE;.CMD;.BAT;.COM").split(";") : [""];
 
   for (const directory of pathEntries) {
     for (const extension of extensions) {
-      const candidate = join(directory, `${command}${extension}`);
+      let normalized = directory;
+
+      // Convert an MSYS "/c/Users/foo" entry to "C:\Users\foo" for fs.access().
+      if (process.platform === "win32" && /^\/[a-zA-Z]\//.test(normalized)) {
+        const drive = normalized[1]!.toUpperCase();
+        normalized = `${drive}:\\${normalized.slice(3).replace(/\//g, "\\")}`;
+      }
+
+      const candidate = join(normalized, `${command}${extension}`);
       if (await isExecutable(candidate)) {
         return candidate;
       }

package/src/resolve/resolveServer.ts

@@ -192,7 +192,10 @@ function replaceCommandPlaceholders(value: string, placeholders: Record<string,
 function getInstallBinDir(install: InstalledServerMetadata | undefined): string | undefined {
   if (install?.binDir) return install.binDir;
   const commandPath = install?.resolvedCommand[0];
-  if (!commandPath || !commandPath.includes("/")) return undefined;
+  // A bare command name (e.g. "rust-analyzer") has no directory separator and
+  // yields no bin dir. Check for both "/" and "\\" so Windows-resolved system
+  // commands like "C:\\Users\\rockn\\go\\bin\\gopls.EXE" are handled too.
+  if (!commandPath || (!commandPath.includes("/") && !commandPath.includes("\\"))) return undefined;
   return dirname(commandPath);
 }
 

package/src/util/helpers.ts

@@ -22,6 +22,17 @@ export function normalizeProcessEnv(env: NodeJS.ProcessEnv): Record<string, stri
   for (const [key, value] of Object.entries(env)) {
     if (typeof value === "string") {
       normalized[key] = value;
+      // On Windows, process.env is case-insensitive but a plain copied object is
+      // not: Windows stores PATH as "Path", so downstream reads of env.PATH would
+      // be undefined. Mirror only PATH/PATHEXT to upper-case keys — uppercasing
+      // every key could break case-sensitive variables spawned tools expect
+      // (GOBIN, GOPATH, ...).
+      if (process.platform === "win32") {
+        const upper = key.toUpperCase();
+        if (upper === "PATH" || upper === "PATHEXT") {
+          normalized[upper] = value;
+        }
+      }
     }
   }
   return normalized;