pi-lens 4.4.3 → 4.4.4

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "4.4.3",
+	"version": "4.4.4",
 	"type": "module",
 	"description": "Real-time code feedback for pi — LSP, linters, formatters, type-checking, structural analysis & booboo",
 	"repository": {
@@ -20,10 +20,11 @@
 		"prepare": "npm run build:dist && node scripts/download-grammars.js --core --dest grammars && node scripts/setup-git-hooks.mjs && node scripts/stamp-package-lock.mjs && node scripts/warm-loader-cache.mjs",
 		"prepack": "node scripts/strip-dev-deps-for-pack.mjs --strip",
 		"postpack": "node scripts/strip-dev-deps-for-pack.mjs --restore",
-		"lint": "tsc --project tsconfig.json && npm run lint:js && npm run lint:js:tests",
+		"lint": "tsc --project tsconfig.json && npm run lint:js && npm run lint:js:tests && npm run lint:js:promises",
 		"lint:js": "oxlint --deny-warnings --import-plugin --promise-plugin -D block-scoped-var -D import/default -D import/namespace -D import/no-absolute-path -D import/no-empty-named-blocks -D import/no-named-as-default -D import/no-self-import -D no-extend-native -D no-extra-bind -D no-implied-eval -D no-new -D no-unexpected-multiline -D no-useless-constructor -D oxc/approx-constant -D oxc/misrefactored-assign-op -D oxc/no-accumulating-spread -D oxc/no-async-endpoint-handlers -D oxc/no-this-in-exported-function -D promise/no-callback-in-promise -D promise/no-multiple-resolved -D promise/no-new-statics -D promise/valid-params -D typescript/no-confusing-non-null-assertion -D typescript/no-extraneous-class -D typescript/no-unnecessary-type-constraint -D typescript/no-unsafe-enum-comparison -D unicorn/no-accessor-recursion -D unicorn/no-array-fill-with-reference-type -D unicorn/no-confusing-array-with -D unicorn/no-instanceof-builtins -D unicorn/prefer-array-flat-map -D unicorn/require-module-specifiers --ignore-pattern \"tests/**/*.ts\" --ignore-pattern \"tests/**/*.tsx\" --ignore-pattern \"**/*.d.mts\" --ignore-pattern \"tests/fixtures/autofix-smoke/**\" --ignore-pattern \"tests/fixtures/format-smoke/**\" --ignore-pattern \"tests/fixtures/tool-smoke/**\" --ignore-pattern \"tests/fixtures/call-graph/javascript/**\" --ignore-pattern \"tests/fixtures/function-facts/javascript-parameter.js\" .",
 		"lint:js:advisory": "node scripts/lint-js-advisory.mjs --deny-warnings --format unix -D correctness -D suspicious -D perf --import-plugin --promise-plugin --type-aware -A no-underscore-dangle -A no-await-in-loop -A unicorn/no-array-sort -A unicorn/consistent-function-scoping -A promise/no-promise-in-callback -A no-useless-call -A import/no-unassigned-import -A no-unmodified-loop-condition --ignore-pattern \"**/*.d.mts\" --ignore-pattern \"tests/fixtures/autofix-smoke/**\" --ignore-pattern \"tests/fixtures/format-smoke/**\" --ignore-pattern \"tests/fixtures/tool-smoke/**\" --ignore-pattern \"tests/fixtures/call-graph/javascript/**\" --ignore-pattern \"tests/fixtures/function-facts/javascript-parameter.js\" .",
 		"lint:js:tests": "node scripts/lint-js-advisory.mjs --deny-warnings --format unix --type-aware -A correctness -A suspicious -A perf --ignore-pattern \"tests/fixtures/**\" tests",
+		"lint:js:promises": "node scripts/lint-js-advisory.mjs --deny-warnings --format unix --type-aware -A all -D typescript/await-thenable -D typescript/no-floating-promises -D typescript/no-misused-promises clients mcp tools index.ts",
 		"depcruise:check": "depcruise --validate --config .dependency-cruiser.cjs --ignore-known .dependency-cruiser-known-violations.json --output-type err index.ts \"clients/**/*.ts\"",
 		"fmt": "oxfmt",
 		"fmt:check": "oxfmt --check",
@@ -113,6 +114,7 @@
 		"scripts/analyze-pi-lens-logs.mjs",
 		"scripts/install-selftest.mjs",
 		"scripts/lib/host-provided-deps.mjs",
+		"scripts/lib/latency-log-phases.mjs",
 		"scripts/lib/skills-predicate.mjs",
 		"scripts/lib/web-tree-sitter-dir.mjs",
 		"scripts/lib/warm-loader-cache.mjs",
@@ -124,8 +126,8 @@
 		"banner.png"
 	],
 	"dependencies": {
-		"@ast-grep/cli": "0.45.3",
-		"@ast-grep/napi": "^0.45.0",
+		"@ast-grep/cli": "0.50.0",
+		"@ast-grep/napi": "^0.50.0",
 		"js-yaml": "^5.2.2",
 		"minimatch": "^10.2.6",
 		"pidusage": "^4.0.1",
@@ -160,7 +162,7 @@
 		]
 	},
 	"allowScripts": {
-		"@ast-grep/cli@0.45.3": true,
+		"@ast-grep/cli@0.50.0": true,
 		"@google/genai@2.21.0": true,
 		"esbuild@0.28.2": true,
 		"fsevents@2.3.3": false,

package/scripts/download-grammars.js

@@ -172,11 +172,44 @@ function baseUrl(version) {
 function grammarUrl(version, filename) {
     return SOURCE_OVERRIDES[filename]?.url ?? `${baseUrl(version)}/${filename}`;
 }
-async function fetchGrammar(version, filename) {
-    const res = await fetch(grammarUrl(version, filename));
-    if (!res.ok)
-        throw new Error(`HTTP ${res.status} fetching ${filename}`);
-    return Buffer.from(await res.arrayBuffer());
+/**
+ * Abort a fetch that receives no bytes for this long, headers included; each
+ * chunk restarts the count, so a slow link that keeps delivering completes.
+ * Mirrors `GRAMMAR_STALL_MS` in clients/grammar-source.ts, which this script
+ * cannot import before the TS build; `tests/clients/grammar-source.test.ts`
+ * pins the two together (#4425).
+ */
+export const GRAMMAR_STALL_MS = 15_000;
+async function fetchGrammar(version, filename, stallMs = GRAMMAR_STALL_MS) {
+    const controller = new AbortController();
+    const timer = setTimeout(() => controller.abort(), stallMs);
+    try {
+        const res = await fetch(grammarUrl(version, filename), {
+            signal: controller.signal,
+        });
+        if (!res.ok)
+            throw new Error(`HTTP ${res.status} fetching ${filename}`);
+        const reader = res.body?.getReader();
+        if (!reader)
+            return Buffer.from(await res.arrayBuffer());
+        const chunks = [];
+        for (;;) {
+            const { done, value } = await reader.read();
+            if (done)
+                return Buffer.concat(chunks);
+            timer.refresh();
+            chunks.push(value);
+        }
+    }
+    catch (err) {
+        if (controller.signal.aborted) {
+            throw new Error(`no bytes arrived for ${stallMs} ms fetching ${filename}`);
+        }
+        throw err;
+    }
+    finally {
+        clearTimeout(timer);
+    }
 }
 /**
  * Download `filename` into `destDir` (if it isn't already verified), checking its
@@ -184,12 +217,12 @@ async function fetchGrammar(version, filename) {
  * integrity mismatch — a grammar whose bytes don't match the pinned manifest is
  * never written (guards CDN corruption / tampering / ABI drift).
  */
-async function downloadGrammar(destDir, filename, manifest) {
+export async function downloadGrammar(destDir, filename, manifest, stallMs = GRAMMAR_STALL_MS) {
     if (!needsDownload(destDir, filename, manifest)) {
         console.error(`  skip  ${filename} (verified)`);
         return;
     }
-    const buf = await fetchGrammar(manifest.version, filename);
+    const buf = await fetchGrammar(manifest.version, filename, stallMs);
     const actual = sha256(buf);
     const expected = manifest.grammars[filename];
     if (expected && actual !== expected) {

package/scripts/lib/latency-log-phases.mjs

@@ -0,0 +1,95 @@
+// Pure NDJSON latency-log phase parsing for scripts/compat-smoke-behavioral.mjs
+// (#476, Layer B).
+//
+// `clients/latency-logger.ts` writes one JSON object per line to
+// `~/.pi-lens/latency.log` (see `createNdjsonLogger`). Layer B launches real
+// `pi` processes and needs to assert (or assert the ABSENCE of) specific
+// `type: "phase"` entries that landed during a bounded time window — this
+// module is the pure parsing/filtering half, kept separate from the
+// file-reading/process-spawning orchestration so it is unit-testable without
+// touching the filesystem or spawning anything.
+
+/**
+ * Parse NDJSON text into an array of entries. Malformed lines (partial write,
+ * truncation mid-append) are skipped rather than throwing — the log is
+ * best-effort by construction (ndjson-logger.ts swallows write errors), so a
+ * single bad line must never abort the whole read.
+ *
+ * @param {string} text raw latency.log contents
+ * @returns {Array<Record<string, unknown>>}
+ */
+export function parseNdjsonEntries(text) {
+	const entries = [];
+	for (const line of text.split(/\r?\n/)) {
+		const trimmed = line.trim();
+		if (!trimmed) continue;
+		try {
+			const parsed = JSON.parse(trimmed);
+			if (parsed && typeof parsed === "object") entries.push(parsed);
+		} catch {
+			// partial/corrupt line — skip
+		}
+	}
+	return entries;
+}
+
+/**
+ * Filter entries to `type: "phase"` records with the given `phase` name,
+ * optionally restricted to entries whose `ts` (ISO timestamp) falls at or
+ * after `sinceIso`. Used to scope a check to "phases logged by THIS run" when
+ * the log file is long-lived and shared across sessions.
+ *
+ * @param {Array<Record<string, unknown>>} entries
+ * @param {string} phase
+ * @param {string} [sinceIso] ISO timestamp lower bound (inclusive)
+ */
+export function findPhaseEntries(entries, phase, sinceIso) {
+	const sinceMs = sinceIso ? Date.parse(sinceIso) : undefined;
+	return entries.filter((e) => {
+		if (e.type !== "phase" || e.phase !== phase) return false;
+		if (sinceMs === undefined) return true;
+		const ts = typeof e.ts === "string" ? Date.parse(e.ts) : Number.NaN;
+		return Number.isFinite(ts) && ts >= sinceMs;
+	});
+}
+
+/**
+ * True iff at least one `findPhaseEntries` match exists.
+ *
+ * @param {Array<Record<string, unknown>>} entries
+ * @param {string} phase
+ * @param {string} [sinceIso]
+ */
+export function phaseWasLogged(entries, phase, sinceIso) {
+	return findPhaseEntries(entries, phase, sinceIso).length > 0;
+}
+
+/**
+ * True iff NO phase in `phases` was logged since `sinceIso` — used to assert
+ * a degraded/skip path did NOT engage (e.g. heavyweight scans must be absent
+ * under subagent light mode).
+ *
+ * @param {Array<Record<string, unknown>>} entries
+ * @param {string[]} phases
+ * @param {string} [sinceIso]
+ */
+export function noPhasesLogged(entries, phases, sinceIso) {
+	return phases.every((phase) => !phaseWasLogged(entries, phase, sinceIso));
+}
+
+/**
+ * Number of entries (any type) whose `ts` falls at or after `sinceIso`.
+ * Positive control for the absence assertions: "no heavyweight phase logged"
+ * is only evidence when the run wrote SOMETHING to the log the smoke is
+ * reading — an empty or mis-located log made those pass vacuously (#2570).
+ *
+ * @param {Array<Record<string, unknown>>} entries
+ * @param {string} sinceIso ISO timestamp lower bound (inclusive)
+ */
+export function countEntriesSince(entries, sinceIso) {
+	const sinceMs = Date.parse(sinceIso);
+	return entries.filter((e) => {
+		const ts = typeof e.ts === "string" ? Date.parse(e.ts) : Number.NaN;
+		return Number.isFinite(ts) && ts >= sinceMs;
+	}).length;
+}