pi-lens 4.2.1 → 4.4.0

package/dist/clients/workspace-topology.js

@@ -1,389 +0,0 @@
-/**
- * Shared, memoized workspace-topology snapshot service (#806).
- *
- * Several subsystems each performed their own independent per-directory
- * marker walk (`.pi-lens.json` discovery in `project-lens-config.ts`,
- * governing-tsconfig discovery in `review-graph/tsconfig-paths.ts`,
- * workspace-manifest presence checks in `review-graph/workspace-modules.ts`)
- * — each with its own probe pattern and its own (or no) invalidation. In a
- * large monorepo the same directory chain got re-walked and re-stat'ed by
- * several subsystems per edit.
- *
- * This module is the single seam: `getDirectoryMarkers(dir)` collects ALL
- * markers a directory can carry in ONE `readdir` pass (not N `existsSync`
- * probes), cached per directory and invalidated by the directory's own
- * mtime (the pattern `project-lens-config.ts`'s `inDirDiscoveryCache`
- * established for #804). `findNearestDirWithMarker` layers the shared
- * upward-walk discipline (`walkUpDirs` + `isAtOrAboveHomeDir` ceiling, an
- * explicit depth cap with cap-trip latency logging — no silent truncation)
- * on top of that per-directory cache.
- *
- * `resetWorkspaceTopology()` is wired into the session-reset path
- * (`runtime-session.ts`'s `handleSessionStart`) so a directory's markers
- * (and every consumer's own downstream cache layered on top) are re-read
- * fresh on the next session, without a full process restart.
- *
- * #807 (second wave): `language-profile.ts`'s `resolveLanguageRootForFile`
- * and `startup-scan.ts`'s `findNearestProjectRoot` route their per-directory
- * marker checks through this module too — `findNearestDirWithAnyBasename`
- * for the former (a home-guarded, depth-capped, walk-cached generalization of
- * `findNearestDirWithMarker` for marker lists that aren't typed
- * `DirectoryMarkers` fields), and a direct `getDirectoryMarkers(dir)`
- * `entryNames` read for the latter (walk loop kept hand-written and
- * NOT home-guarded — see that function's docstring for why). This module
- * still only indexes per-directory MARKER PRESENCE; it does not decide what
- * "the project root" is — that policy (which markers count, what wins when
- * several qualify, whether a found root gets clamped back to the workspace)
- * stays with each resolver.
- */
-import * as fs from "node:fs";
-import * as os from "node:os";
-import * as path from "node:path";
-import { PROJECT_CONFIG_BASENAMES } from "./config-locations.js";
-import { logLatency } from "./latency-logger.js";
-import { isAtOrAboveHomeDir, nameMatchesMarkerGlob, walkUpDirs, } from "./path-utils.js";
-/** Depth cap on any upward marker walk — mirrors `findNearestMarkerRoot`'s bound. */
-const MAX_WALK_DEPTH = 64;
-/**
- * The project config basenames, canonical first — the SHARED table, not a
- * fourth copy of the pair (#2426 review round 2). `config-locations.ts` derives
- * it from the one location table the resolver walks, so a change there cannot
- * leave this marker index preferring a different file than the loaders do.
- */
-const PI_LENS_CONFIG_BASENAMES = PROJECT_CONFIG_BASENAMES;
-/** Per-directory marker cache — the shared seam every consumer reads through. */
-const dirMarkerCache = new Map();
-/** Downstream memo clears that must follow the topology index reset. */
-const topologyDerivedCacheResets = [];
-export function registerWorkspaceTopologyReset(reset) {
-    topologyDerivedCacheResets.push(reset);
-}
-const walkCache = new Map();
-const TOPOLOGY_MAX_DIR_ENTRIES = 256;
-const TOPOLOGY_MAX_WALK_ENTRIES = 512;
-const TOPOLOGY_IDLE_EVICT_MS_DEFAULT = 20 * 60_000;
-function topologyIdleEvictMs() {
-    const value = Number.parseInt(process.env.PI_LENS_WORKSPACE_TOPOLOGY_IDLE_EVICT_MS ?? "", 10);
-    return Number.isSafeInteger(value) && value > 0
-        ? value
-        : TOPOLOGY_IDLE_EVICT_MS_DEFAULT;
-}
-function deleteDirMarker(key) {
-    const entry = dirMarkerCache.get(key);
-    if (entry?.idleTimer)
-        clearTimeout(entry.idleTimer);
-    dirMarkerCache.delete(key);
-}
-function deleteWalk(key) {
-    const entry = walkCache.get(key);
-    if (entry?.idleTimer)
-        clearTimeout(entry.idleTimer);
-    walkCache.delete(key);
-}
-function touchDirMarker(key, entry) {
-    entry.lastUsedAt = Date.now();
-    if (entry.idleTimer)
-        clearTimeout(entry.idleTimer);
-    const stamp = entry.lastUsedAt;
-    entry.idleTimer = setTimeout(() => {
-        if (dirMarkerCache.get(key) === entry && entry.lastUsedAt === stamp)
-            deleteDirMarker(key);
-    }, topologyIdleEvictMs());
-    entry.idleTimer.unref?.();
-}
-function touchWalk(key, entry) {
-    entry.lastUsedAt = Date.now();
-    if (entry.idleTimer)
-        clearTimeout(entry.idleTimer);
-    const stamp = entry.lastUsedAt;
-    entry.idleTimer = setTimeout(() => {
-        if (walkCache.get(key) === entry && entry.lastUsedAt === stamp)
-            deleteWalk(key);
-    }, topologyIdleEvictMs());
-    entry.idleTimer.unref?.();
-}
-export function resetWorkspaceTopology() {
-    for (const key of dirMarkerCache.keys())
-        deleteDirMarker(key);
-    for (const key of walkCache.keys())
-        deleteWalk(key);
-    for (const reset of topologyDerivedCacheResets)
-        reset();
-}
-/**
- * Release cache eviction handles without discarding reusable entries.
- * One-shot cascades call this after marker discovery so cache residency does
- * not leave a process-liveness tail; the next cache use re-arms its timer.
- */
-export function releaseWorkspaceTopologyIdleTimers() {
-    for (const entry of dirMarkerCache.values()) {
-        if (entry.idleTimer !== undefined)
-            clearTimeout(entry.idleTimer);
-        entry.idleTimer = undefined;
-    }
-    for (const entry of walkCache.values()) {
-        if (entry.idleTimer !== undefined)
-            clearTimeout(entry.idleTimer);
-        entry.idleTimer = undefined;
-    }
-}
-function safeDirMtimeMs(dir) {
-    try {
-        return fs.statSync(dir).mtimeMs;
-    }
-    catch {
-        return -1;
-    }
-}
-function safeIsFile(filePath) {
-    try {
-        return fs.statSync(filePath).isFile();
-    }
-    catch {
-        return false;
-    }
-}
-/**
- * Single-pass marker scan for one directory: one `readdir` collects ALL
- * markers pi-lens subsystems care about, cached and invalidated by the
- * directory's own mtime (so an add/remove/rename inside `dir` — which bumps
- * the directory's mtime on every platform pi-lens supports — drops the
- * cached entry without a session restart).
- */
-export function getDirectoryMarkers(dir) {
-    const resolvedDir = path.resolve(dir);
-    const dirMtimeMs = safeDirMtimeMs(resolvedDir);
-    const cached = dirMarkerCache.get(resolvedDir);
-    if (cached && cached.dirMtimeMs === dirMtimeMs) {
-        touchDirMarker(resolvedDir, cached);
-        return cached.markers;
-    }
-    let entries = [];
-    try {
-        entries = fs.readdirSync(resolvedDir, { withFileTypes: true });
-    }
-    catch {
-        entries = [];
-    }
-    // `readdir`'s Dirent type does not follow symlinks (lstat semantics), so a
-    // symlinked marker file reports as neither file nor directory here. Track
-    // candidate names that exist as *some* dirent and resolve the handful of
-    // markers we actually care about with one confirming `stat` each — still
-    // a single directory listing, not N blind `existsSync` probes.
-    const present = new Set(entries.map((e) => e.name));
-    const fileNames = new Set(entries
-        .filter((entry) => entry.isFile() || entry.isSymbolicLink())
-        .map((entry) => entry.name));
-    const resolveMarker = (basename) => {
-        if (!present.has(basename))
-            return undefined;
-        const candidate = path.join(resolvedDir, basename);
-        return safeIsFile(candidate) ? candidate : undefined;
-    };
-    const piLensConfigPath = resolveMarker(PI_LENS_CONFIG_BASENAMES[0]) ??
-        resolveMarker(PI_LENS_CONFIG_BASENAMES[1]);
-    const markers = {
-        dir: resolvedDir,
-        dirMtimeMs,
-        entryNames: present,
-        entryFileNames: fileNames,
-        piLensConfigPath,
-        tsconfigPath: resolveMarker("tsconfig.json"),
-        packageJsonPath: resolveMarker("package.json"),
-        pnpmWorkspaceYamlPath: resolveMarker("pnpm-workspace.yaml"),
-        cargoTomlPath: resolveMarker("Cargo.toml"),
-        goWorkPath: resolveMarker("go.work"),
-        chartYamlPath: resolveMarker("Chart.yaml"),
-    };
-    const entry = { dirMtimeMs, markers, lastUsedAt: Date.now() };
-    const outgoing = dirMarkerCache.get(resolvedDir);
-    if (outgoing?.idleTimer !== undefined) {
-        clearTimeout(outgoing.idleTimer);
-        outgoing.idleTimer = undefined;
-    }
-    dirMarkerCache.set(resolvedDir, entry);
-    touchDirMarker(resolvedDir, entry);
-    while (dirMarkerCache.size > TOPOLOGY_MAX_DIR_ENTRIES) {
-        const victim = [...dirMarkerCache.entries()].sort(([, a], [, b]) => a.lastUsedAt - b.lastUsedAt)[0];
-        if (!victim)
-            break;
-        deleteDirMarker(victim[0]);
-    }
-    return markers;
-}
-function walkCacheKey(startDir, markerKey) {
-    return `${path.resolve(startDir)}\0${markerKey}`;
-}
-function walkStillFresh(dirMtimes) {
-    return dirMtimes.every(({ dir, mtimeMs }) => safeDirMtimeMs(dir) === mtimeMs);
-}
-/**
- * Shared core of the two nearest-marker walkers below: the cache check, the
- * home-guarded/depth-capped upward loop, per-directory mtime recording, and
- * the cache store live HERE once — callers supply only their cache-key
- * suffix, their match predicate over a directory's marker index, and the
- * identifying metadata for the cap-trip latency log. (Extracted for #812's
- * Sonar new-code duplication gate: the two walkers previously each carried
- * this skeleton verbatim.)
- */
-function walkToNearestMatch(startDir, cacheSuffix, matches, capMetadata, homeDir) {
-    const key = walkCacheKey(startDir, cacheSuffix);
-    const cached = walkCache.get(key);
-    if (cached && walkStillFresh(cached.dirMtimes)) {
-        touchWalk(key, cached);
-        return cached.dir;
-    }
-    const dirMtimes = [];
-    let found;
-    let depth = 0;
-    for (const dir of walkUpDirs(startDir)) {
-        if (isAtOrAboveHomeDir(dir, homeDir))
-            break;
-        if (depth >= MAX_WALK_DEPTH) {
-            logLatency({
-                type: "phase",
-                filePath: startDir,
-                phase: "workspace-topology-walk-cap",
-                durationMs: 0,
-                metadata: { ...capMetadata, depth, homeDir },
-            });
-            break;
-        }
-        const markers = getDirectoryMarkers(dir);
-        dirMtimes.push({ dir, mtimeMs: markers.dirMtimeMs });
-        if (matches(markers)) {
-            found = dir;
-            break;
-        }
-        depth += 1;
-    }
-    const entry = {
-        dir: found,
-        dirMtimes,
-        lastUsedAt: Date.now(),
-    };
-    const outgoing = walkCache.get(key);
-    if (outgoing?.idleTimer !== undefined) {
-        clearTimeout(outgoing.idleTimer);
-        outgoing.idleTimer = undefined;
-    }
-    walkCache.set(key, entry);
-    touchWalk(key, entry);
-    while (walkCache.size > TOPOLOGY_MAX_WALK_ENTRIES) {
-        const victim = [...walkCache.entries()].sort(([, a], [, b]) => a.lastUsedAt - b.lastUsedAt)[0];
-        if (!victim)
-            break;
-        deleteWalk(victim[0]);
-    }
-    return found;
-}
-/**
- * Walk up from `startDir` looking for the nearest directory whose marker
- * index has `markerKey` set (e.g. `"tsconfigPath"`, `"piLensConfigPath"`).
- * Shared walk discipline (AGENTS.md invariants):
- *   - Uses `walkUpDirs`, the single upward-climb primitive.
- *   - Never resolves at or above `$HOME` via `isAtOrAboveHomeDir`.
- *   - Depth-capped at `MAX_WALK_DEPTH`; a cap trip is logged as a latency
- *     phase (not silently truncated) so a pathological deep tree is visible.
- *
- * Cached per `(startDir, markerKey)`, invalidated when any visited
- * directory's mtime changes (the same "revalidate every dir on the path"
- * pattern `project-lens-config.ts`'s `discoveryCache` established).
- */
-export function findNearestDirWithMarker(startDir, markerKey, homeDir = os.homedir()) {
-    return walkToNearestMatch(startDir, markerKey, (markers) => Boolean(markers[markerKey]), { markerKey }, homeDir);
-}
-/**
- * Type-agnostic (file OR directory) `existsSync`-style presence check for
- * `basename` inside the directory `markers` describes. Single-segment names
- * (the common case) resolve against the shared per-directory `entryNames`
- * set — no extra `stat`. A multi-segment name (e.g. `"prisma/schema.prisma"`,
- * a nested path some `resolveLanguageRootForFile` marker lists use) falls
- * back to one confirming `existsSync` — the directory's own readdir doesn't
- * cover a grandchild, so this still costs one syscall for that shape, same
- * as the pre-#807 hand-rolled loops it replaces.
- */
-function hasBasenameMarker(markers, basename) {
-    if (basename.includes("/") || basename.includes("\\")) {
-        return fs.existsSync(path.join(markers.dir, basename));
-    }
-    if (basename.includes("*")) {
-        // `entryFileNames` is already files/symlinks-only, so matching the cached
-        // names via the shared marker-glob helper preserves the same semantics as
-        // the Dirent-filtering probes without re-reading the directory.
-        return [...markers.entryFileNames].some((entryName) => nameMatchesMarkerGlob(entryName, basename));
-    }
-    return markers.entryNames.has(basename);
-}
-/**
- * Walk up from `startDir` looking for the nearest directory containing ANY of
- * `basenames` (`existsSync`-style, type-agnostic presence — see
- * `hasBasenameMarker`). The generalized counterpart of
- * `findNearestDirWithMarker` for callers whose marker set is a per-call list
- * rather than one of `DirectoryMarkers`' typed fields (#807) — e.g.
- * `resolveLanguageRootForFile`'s per-language-kind root-marker lists. Shares
- * the exact same walk discipline (`walkUpDirs`, `isAtOrAboveHomeDir` ceiling,
- * `MAX_WALK_DEPTH` cap with the same cap-trip latency log) and is backed by
- * the same per-directory `getDirectoryMarkers` cache, so a directory chain
- * already visited for one marker set isn't re-`readdir`'d for another.
- *
- * Cached per `(startDir, basenames)`, invalidated the same way as
- * `findNearestDirWithMarker`.
- */
-export function findNearestDirWithAnyBasename(startDir, basenames, homeDir = os.homedir()) {
-    if (basenames.length === 0)
-        return undefined;
-    return walkToNearestMatch(startDir, `any:${basenames.join(String.fromCodePoint(1))}`, (markers) => basenames.some((basename) => hasBasenameMarker(markers, basename)), { basenames }, homeDir);
-}
-/**
- * `.pi-lens.json`/`pi-lens.json` directly IN `dir` — no upward walk. The
- * shared-index equivalent of `project-lens-config.ts`'s old private
- * `findPiLensConfigInDir` probe loop.
- */
-export function findPiLensConfigMarkerInDir(dir) {
-    const markers = getDirectoryMarkers(dir);
-    if (!markers.piLensConfigPath)
-        return undefined;
-    const stat = (() => {
-        try {
-            return fs.statSync(markers.piLensConfigPath);
-        }
-        catch {
-            return undefined;
-        }
-    })();
-    if (!stat?.isFile())
-        return undefined;
-    return {
-        path: markers.piLensConfigPath,
-        dir: markers.dir,
-        mtimeMs: stat.mtimeMs,
-        size: stat.size,
-    };
-}
-/**
- * Nearest directory (at or above `startDir`, home-guarded) that carries a
- * `tsconfig.json` marker. The shared-index equivalent of
- * `review-graph/tsconfig-paths.ts`'s old `findNearestContaining(key,
- * ["tsconfig.json"])` call.
- */
-export function findGoverningTsconfigDir(startDir, homeDir = os.homedir()) {
-    return findNearestDirWithMarker(startDir, "tsconfigPath", homeDir);
-}
-/**
- * Presence-only workspace manifest markers for `dir` — the shared-index
- * equivalent of `workspace-modules.ts`'s old `detectWorkspaceType` probe
- * (`pnpm-workspace.yaml` / `go.work` / `Cargo.toml` / `package.json`
- * `existsSync` calls). Callers still read + parse the manifest CONTENT
- * themselves (workspace globs, `[workspace]` section, `workspaces` field) —
- * this only answers "is the marker file present".
- */
-export function getWorkspaceManifestMarkers(dir) {
-    const markers = getDirectoryMarkers(dir);
-    return {
-        hasPnpmWorkspaceYaml: markers.pnpmWorkspaceYamlPath !== undefined,
-        hasGoWork: markers.goWorkPath !== undefined,
-        hasCargoToml: markers.cargoTomlPath !== undefined,
-        hasPackageJson: markers.packageJsonPath !== undefined,
-    };
-}

package/dist/clients/write-ordering-guard.js

@@ -1,65 +0,0 @@
-/**
- * Generic "only proceed if this token is >= the last-seen token for this
- * key" guard, for per-key caches fed by concurrent, possibly-out-of-order
- * writers.
- *
- * Same race class as #555 (`clients/lsp/client.ts`'s `isSupersededPush`
- * guard on `publishDiagnostics`): pi-lens deliberately allows concurrent
- * pipeline runs for the SAME file across DIFFERENT same-turn edits (dedupe
- * key is `filePath + contentHash`, not just `filePath` — see
- * `clients/runtime-tool-result.ts`). If an OLDER edit's pipeline is slower
- * than a NEWER edit's pipeline, the older edit's write can land after the
- * newer one and silently overwrite it — a per-key cache with no ordering
- * check serves the stale result as "current" until some later write (if
- * any) corrects it.
- *
- * This module extracts that guard shape into a small, reusable, non-
- * diagnostics-specific primitive so a second (or third) call site with the
- * same race doesn't need to re-derive or duplicate the check. `clients/lsp/
- * client.ts`'s already-merged #555 fix is inline and deliberately left
- * alone — this is additive, for new call sites (starting with
- * `clients/widget-state.ts`'s `recordDiagnostics`).
- *
- * A `undefined` token means "no ordering information available" — the write
- * is always allowed through and does not update the last-seen token (mirrors
- * the existing, deliberate version-less-server tradeoff in the LSP client:
- * callers that can't supply an ordering token aren't penalized).
- */
-export class WriteOrderingGuard {
-    lastSeen = new Map();
-    /**
-     * Returns `true` if a write with `token` for `key` should proceed, and
-     * `false` if it's superseded (a write with a higher token for the same
-     * key was already recorded) and should be dropped.
-     *
-     * On `true` with a defined `token`, records it as the new last-seen value
-     * for `key` — including on a tie (a write whose token matches the last
-     * recorded one is not superseded, and re-recording the same token is a
-     * no-op either way). The very first write for a key always proceeds
-     * (nothing to compare against yet).
-     */
-    shouldWrite(key, token) {
-        if (token === undefined)
-            return true;
-        const last = this.lastSeen.get(key);
-        if (last !== undefined && token < last)
-            return false;
-        this.lastSeen.set(key, token);
-        return true;
-    }
-    /** Allocate the next ordered position for a writer admitted without a token. */
-    nextToken(key) {
-        const last = this.lastSeen.get(key);
-        const next = (last ?? 0) + 1;
-        this.lastSeen.set(key, next);
-        return next;
-    }
-    /** Drop tracked ordering state for `key` (e.g. on cache eviction). */
-    delete(key) {
-        this.lastSeen.delete(key);
-    }
-    /** Drop all tracked ordering state. */
-    clear() {
-        this.lastSeen.clear();
-    }
-}