pi-lens 4.1.2 → 4.1.4

package/dist/clients/read-bridge.js

@@ -57,6 +57,7 @@
  * `_turnSummaryEmitCtx`), so flag changes take effect immediately.
  */
 /** Stable Symbol key — identical across module reloads in the same process. */
+import { registerProcessBridge } from "./process-bridge.js";
 import { captureReadContentBinding, } from "./read-guard.js";
 export const READ_BRIDGE_KEY = Symbol.for("pi-lens:read-bridge");
 /**
@@ -96,15 +97,12 @@ function isValidEntry(entry) {
 }
 /**
  * Mount the bridge singleton. Call once from inside the extension factory
- * (protected by the `_readBridgeRegistered` module-level flag).
- * Subsequent calls are no-ops.
+ * (protected by the `_readBridgeRegistered` module-level flag). Subsequent
+ * calls are no-ops (first-wins, `clients/process-bridge.ts` owns the mount
+ * body — see that module's header, #2437).
  */
 export function registerReadBridge(deps) {
-    // Use `in` check so the frozen non-configurable property doesn't throw
-    // on a redundant defineProperty attempt.
-    if (READ_BRIDGE_KEY in globalThis)
-        return;
-    const bridge = Object.freeze({
+    registerProcessBridge(READ_BRIDGE_KEY, () => ({
         version: 1,
         recordRead(entry) {
             // Validate the payload before doing anything else — this catches
@@ -114,8 +112,9 @@ export function registerReadBridge(deps) {
             if (!deps.isRecordable(entry.filePath))
                 return;
             const offset = entry.requestedOffset;
-            // When no limit is given treat the whole file as covered — the guard
-            // clips to the actual line count via its own file-length probe.
+            // When no limit is given treat the whole file as covered — the
+            // guard clips to the actual line count via its own file-length
+            // probe.
             const limit = entry.requestedLimit ?? Number.MAX_SAFE_INTEGER;
             const contentBinding = captureReadContentBinding(entry.filePath, offset, limit);
             deps.getReadGuard().recordRead({
@@ -127,21 +126,14 @@ export function registerReadBridge(deps) {
                 expandedByLsp: false,
                 turnIndex: deps.getTurnIndex(),
                 writeIndex: deps.peekWriteIndex(),
-                // Stamp the timestamp here, matching exactly how the internal read
-                // path works (runtime-tool-call.ts always uses Date.now()).
+                // Stamp the timestamp here, matching exactly how the internal
+                // read path works (runtime-tool-call.ts always uses Date.now()).
                 timestamp: Date.now(),
-                // Provenance: identifies this record as bridge-sourced in read-guard.log.
+                // Provenance: identifies this record as bridge-sourced in
+                // read-guard.log.
                 source: `bridge:${entry.consumer ?? "unknown"}`,
                 ...(contentBinding !== undefined && { contentBinding }),
             });
         },
-    });
-    // Register as non-writable, non-configurable so no subsequent code can
-    // silently overwrite the bridge (first-wins is the contract).
-    Object.defineProperty(globalThis, READ_BRIDGE_KEY, {
-        value: bridge,
-        writable: false,
-        configurable: false,
-        enumerable: false,
-    });
+    }));
 }

package/dist/clients/read-expansion.js

@@ -7,60 +7,23 @@
  * within the symbol pass without requiring the agent to have read every line.
  */
 import * as fs from "node:fs";
+import { extname } from "node:path";
 import { withBudget } from "./deadline-utils.js";
+import { EXTENSION_TO_GRAMMAR } from "./language-registry.js";
 /** Only expand reads smaller than this (lines). Larger reads don't benefit. */
 export const EXPANSION_LIMIT_LINES = 100;
 /** Don't expand to a symbol larger than this. */
 const EXPANDED_SIZE_CAP_LINES = 300;
 /** Async budget for tree-sitter parse + walk. */
 export const EXPANSION_BUDGET_MS = 200;
-/** File extensions we can parse — mirrors tree-sitter runner. */
-const EXT_TO_LANG = {
-    ".ts": "typescript",
-    ".mts": "typescript",
-    ".cts": "typescript",
-    ".tsx": "tsx",
-    ".js": "javascript",
-    ".mjs": "javascript",
-    ".cjs": "javascript",
-    ".jsx": "javascript",
-    ".py": "python",
-    ".go": "go",
-    ".rs": "rust",
-    ".rb": "ruby",
-    ".java": "java",
-    ".kt": "kotlin",
-    ".kts": "kotlin",
-    ".dart": "dart",
-    ".ex": "elixir",
-    ".exs": "elixir",
-    ".c": "c",
-    ".h": "c",
-    ".cc": "cpp",
-    ".cpp": "cpp",
-    ".cxx": "cpp",
-    ".c++": "cpp",
-    ".hh": "cpp",
-    ".hpp": "cpp",
-    ".hxx": "cpp",
-    ".cs": "csharp",
-    ".php": "php",
-    ".phtml": "php",
-    ".swift": "swift",
-    ".lua": "lua",
-    ".ml": "ocaml",
-    ".mli": "ocaml",
-    ".zig": "zig",
-    ".sh": "bash",
-    ".bash": "bash",
-};
 /**
- * Canonical set of source-code file extensions pi-lens understands, derived
- * from the same {@link EXT_TO_LANG} map the read-coverage path uses. Exported as
- * the single source of truth so language-spanning scanners cover every
- * supported language instead of a hardcoded subset (#262).
+ * The grammar this module would parse `filePath` with, or undefined when read
+ * expansion does not understand the extension. Exported so the
+ * language-identity golden snapshot can record this consumer's answer.
  */
-export const CODE_FILE_EXTENSIONS = Object.keys(EXT_TO_LANG);
+export function readExpansionLanguage(filePath) {
+    return EXTENSION_TO_GRAMMAR[extname(filePath).toLowerCase()];
+}
 /** AST node types considered "enclosing symbols" for coverage purposes. */
 const ENCLOSING_TYPES = {
     typescript: [
@@ -241,7 +204,7 @@ export async function tryExpandRead(filePath, requestedOffset, requestedLimit, t
                 return undefined;
             return { ...result, durationMs: Date.now() - startedAt };
         }
-        const languageId = EXT_TO_LANG[ext];
+        const languageId = readExpansionLanguage(filePath);
         if (!languageId)
             return undefined;
         const enclosingTypes = ENCLOSING_TYPES[languageId];

package/dist/clients/read-guard-logger.js

@@ -1,8 +1,9 @@
 import * as path from "node:path";
 import { isTestMode } from "./env-utils.js";
-import { getGlobalPiLensDir } from "./file-utils.js";
+import { getGlobalPiLensLogDir } from "./probe-home-state.js";
 import { createNdjsonLogger } from "./ndjson-logger.js";
-const READ_GUARD_LOG_DIR = getGlobalPiLensDir();
+import { normalizeFilePath } from "./path-utils.js";
+const READ_GUARD_LOG_DIR = getGlobalPiLensLogDir();
 const READ_GUARD_LOG_FILE = path.join(READ_GUARD_LOG_DIR, "read-guard.log");
 const READ_GUARD_LOG_BACKUP_FILE = path.join(READ_GUARD_LOG_DIR, "read-guard.log.1");
 const MAX_LOG_BYTES = Math.max(128 * 1024, Number.parseInt(process.env.PI_LENS_READ_GUARD_MAX_BYTES ?? "1048576", 10) ||
@@ -67,11 +68,13 @@ export function createReadGuardEditBatchSummary(args) {
     const resolvedSource = validIndexes(args.resolvedIndexes ?? []);
     const rejectedSource = (args.rejectedReasons ?? []).filter((entry) => Number.isInteger(entry.index) && entry.index >= 0);
     const appliedSource = validIndexes(args.appliedIndexes ?? []);
+    const alreadyAppliedSource = validIndexes(args.alreadyAppliedIndexes ?? []);
     const requestedIndexes = boundedEditIndexes(requestedSource);
     const resolvedIndexes = boundedEditIndexes(resolvedSource);
     const rejectedReasons = rejectedSource.slice(0, MAX_EDIT_BATCH_ITEMS);
     const rejectedIndexes = boundedEditIndexes(rejectedSource.map((entry) => entry.index));
     const appliedIndexes = boundedEditIndexes(appliedSource);
+    const alreadyAppliedIndexes = boundedEditIndexes(alreadyAppliedSource);
     const participantSource = (args.participantIds ?? []).filter((id) => typeof id === "string" && id.length > 0);
     const participantIds = [...new Set(participantSource)].slice(0, MAX_EDIT_BATCH_ITEMS);
     const commitStatus = args.commitStatus ?? "not_attempted";
@@ -98,6 +101,9 @@ export function createReadGuardEditBatchSummary(args) {
         appliedCount: appliedSource.length,
         appliedTotal: args.appliedTotal ?? appliedSource.length,
         appliedIndexes,
+        alreadyAppliedCount: alreadyAppliedSource.length,
+        alreadyAppliedTotal: args.alreadyAppliedTotal ?? alreadyAppliedSource.length,
+        alreadyAppliedIndexes,
         participantIds,
         participantTotal: args.participantTotal ?? participantSource.length,
         participantIdsTruncated: (args.participantTotal ?? participantSource.length) >
@@ -106,7 +112,9 @@ export function createReadGuardEditBatchSummary(args) {
             requestedIndexes.length ||
             (args.resolvedTotal ?? resolvedSource.length) > resolvedIndexes.length ||
             (args.rejectedTotal ?? rejectedSource.length) > rejectedIndexes.length ||
-            (args.appliedTotal ?? appliedSource.length) > appliedIndexes.length,
+            (args.appliedTotal ?? appliedSource.length) > appliedIndexes.length ||
+            (args.alreadyAppliedTotal ?? alreadyAppliedSource.length) >
+                alreadyAppliedIndexes.length,
         commitStatus,
         postEditStatus,
         terminalStatus,
@@ -132,6 +140,10 @@ export function shouldLogEvent(event) {
         event === "edit_preflight_blocked" ||
         event === "edit_partial_apply" ||
         event === "edit_partial_apply_skipped" ||
+        // #2402: pre-write batch rejections and recognized exact retries are the
+        // two new partial-apply outcomes; each is rare by construction.
+        event === "edit_partial_apply_rejected" ||
+        event === "edit_already_applied_retry" ||
         event === "edit_post_edit_pipeline_failed" ||
         event === "edit_batch_summary" ||
         event === "edit_batch_summary_overflow" ||
@@ -140,7 +152,18 @@ export function shouldLogEvent(event) {
         // READ_GUARD_MAX_RECORDS_PER_FILE overflow triggers one), so this trim
         // record bypasses the per-read verbosity gate — a live eviction
         // regression must be visible without PI_LENS_READ_GUARD_VERBOSE=1.
-        event === "read_cap_trimmed");
+        event === "read_cap_trimmed" ||
+        // #1918: the record-cap trim's population siblings — whole-file
+        // eviction under real pressure (file cap or an external delete) and
+        // the per-file edits-cap trim. Idle-timeout eviction is deliberately
+        // EXCLUDED from this event (see read-guard.ts's evictFile doc
+        // comment) — it's routine housekeeping, not a fault, and its
+        // per-file cardinality is unbounded in a healthy session. Same
+        // rarity argument as #1913 for the reasons that DO fire: each is
+        // rising-edge gated once per file per session, so always-on
+        // visibility costs nothing.
+        event === "read_file_evicted" ||
+        event === "edits_cap_trimmed");
 }
 const MAX_TELEMETRY_STRING = 512;
 const MAX_TELEMETRY_KEYS = 64;
@@ -192,7 +215,7 @@ export function logReadGuardEvent(entry) {
         return;
     }
     const rawMetadata = entry.correlationId
-        ? { ...(entry.metadata ?? {}), correlationId: entry.correlationId }
+        ? { ...entry.metadata, correlationId: entry.correlationId }
         : entry.metadata;
     const bounded = boundTelemetryValue(rawMetadata, "metadata", 0);
     const metadata = bounded.truncated && bounded.value && typeof bounded.value === "object"
@@ -205,7 +228,17 @@ export function logReadGuardEvent(entry) {
             ? bounded.value
             : undefined;
     const { correlationId: _correlationId, ...logEntry } = entry;
-    writer.log({ ts: new Date().toISOString(), ...logEntry, metadata });
+    // #2219 (the #2141 class): `filePath` reaches here from
+    // `runtime-tool-result.ts`'s raw `path.resolve()`/`path.isAbsolute()`
+    // arithmetic (never `normalizeFilePath`-passed), always a genuine file —
+    // this field carries no non-path sentinel. Normalize once at this single
+    // emit seam, matching `review-graph-logger.ts`'s `logReviewGraph`.
+    writer.log({
+        ts: new Date().toISOString(),
+        ...logEntry,
+        filePath: normalizeFilePath(logEntry.filePath),
+        metadata,
+    });
 }
 export function getReadGuardLogPath() {
     return READ_GUARD_LOG_FILE;