pi-lens 3.8.73 → 4.0.0

package/rules/tree-sitter-queries/java/no-double-checked-locking.yml

@@ -28,18 +28,20 @@ description: |
 
 query: |
   (if_statement
-    condition: (binary_expression
-      left: (identifier) @FIELD
-      operator: ("==")
-      right: ("null"))
+    condition: (condition
+      (binary_expression
+        left: (identifier) @FIELD
+        "=="
+        (null_literal) @NULL))
     consequence: (block
       (synchronized_statement
         body: (block
           (if_statement
-            condition: (binary_expression
-              left: (identifier) @FIELD2
-              operator: ("==")
-              right: ("null")))))))
+            condition: (condition
+              (binary_expression
+                left: (identifier) @FIELD2
+                "=="
+                (null_literal) @NULL2)))))))
 
 metavars:
   - FIELD

package/rules/tree-sitter-queries/java/no-field-shadowing.yml

@@ -27,7 +27,7 @@ description: |
 
 query: |
   (class_declaration
-    (extends_clause
+    superclass: (superclass
       (type_identifier) @PARENT)
     body: (class_body
       (field_declaration

package/rules/tree-sitter-queries/java/prepared-statement-valid-indices.yml

@@ -26,15 +26,14 @@ query: |
   (method_invocation
     name: (identifier) @METHOD (#match? @METHOD "^(setString|setInt|setLong|setDouble|setBoolean|getString|getInt|getLong|getDouble|getBoolean)$")
     arguments: (argument_list
-      (decimal_integer_literal) @INDEX) @ARGS)
+      (decimal_integer_literal) @INDEX
+      (#match? @INDEX "^0+$")) @ARGS)
 
 metavars:
   - METHOD
   - INDEX
   - ARGS
 
-post_filter: invalid_statement_index
-
 tags:
   - reliability
   - java

package/rules/tree-sitter-queries/java/resources-closed.yml

@@ -2,10 +2,10 @@
 # Detects resources that should be closed (pre-Java 7 style)
 id: resources-closed
 name: Resources Should Be Closed
-severity: error
+severity: warning
 category: reliability
 defect_class: correctness
-inline_tier: blocking
+inline_tier: warning
 language: java
 
 message: "Resource '{{RESOURCE}}' should be closed in finally block"

package/rules/tree-sitter-queries/java/springboot-default-package.yml

@@ -30,9 +30,12 @@ description: |
 query: |
   (class_declaration
     (modifiers
-      (annotation
-        name: (identifier) @ANNOT (#match? @ANNOT "^(SpringBootApplication|ComponentScan)$")))
-    name: (_) @CLASS)
+      [(marker_annotation
+        name: (identifier) @ANNOT)
+       (annotation
+        name: (identifier) @ANNOT)])
+    name: (_) @CLASS
+    (#match? @ANNOT "^(SpringBootApplication|ComponentScan)$"))
 
 metavars:
   - ANNOT

package/rules/tree-sitter-queries/java/switch-fall-through.yml

@@ -29,11 +29,13 @@ description: |
   ```
 
 query: |
-  (switch_statement
+  (switch_expression
     body: (switch_block
-      (switch_label) @LABEL
-      (expression_statement)*
-      (switch_label) @NEXT_LABEL))
+      (switch_block_statement_group
+        (switch_label) @LABEL
+        (expression_statement)+)
+      (switch_block_statement_group
+        (switch_label) @NEXT_LABEL)))
 
 metavars:
   - LABEL

package/rules/tree-sitter-queries/java/switch-non-case-labels.yml

@@ -27,10 +27,11 @@ description: |
   ```
 
 query: |
-  (switch_statement
+  (switch_expression
     body: (switch_block
-      (labeled_statement
-        (identifier) @LABEL) @LABELED_STMT))
+      (switch_block_statement_group
+        (labeled_statement
+          (identifier) @LABEL) @LABELED_STMT)))
 
 metavars:
   - LABEL

package/rules/tree-sitter-queries/java/tests-include-assertions.yml

@@ -2,10 +2,10 @@
 # Detects JUnit tests without assertions
 id: tests-include-assertions
 name: Tests Should Include Assertions
-severity: error
+severity: warning
 category: maintainability
 defect_class: correctness
-inline_tier: blocking
+inline_tier: warning
 language: java
 
 message: "Test method should include at least one assertion"
@@ -26,10 +26,11 @@ description: |
 query: |
   (method_declaration
     (modifiers
-      (annotation
-        name: (identifier) @TEST (#match? @TEST "^(Test|ParameterizedTest|RepeatedTest)$")))
+      (marker_annotation
+        name: (identifier) @TEST))
     name: (identifier) @NAME
-    body: (block) @BODY)
+    body: (block) @BODY
+    (#match? @TEST "^(Test|ParameterizedTest|RepeatedTest)$"))
 
 metavars:
   - TEST

package/rules/tree-sitter-queries/javascript/switch-case-termination-js.yml

@@ -26,16 +26,13 @@ description: |
   ```
 
 query: |
-  (switch_statement
-    body: (switch_body
-      (switch_case
-        consequence: (statement_block
-          (expression_statement) @LAST))
-      (switch_case) @NEXT))
+  (switch_body
+    (switch_case) @CASE
+    .
+    [(switch_case) (switch_default)])
 
 metavars:
-  - LAST
-  - NEXT
+  - CASE
 
 post_filter: no_terminating_statement
 

package/rules/tree-sitter-queries/javascript/switch-non-case-labels.yml

@@ -19,8 +19,9 @@ description: |
 query: |
   (switch_statement
     body: (switch_body
-      (labeled_statement
-        (statement_identifier) @LABEL) @LABELED))
+      (switch_case
+        (labeled_statement
+          (statement_identifier) @LABEL) @LABELED)))
 
 metavars:
   - LABEL

package/rules/tree-sitter-queries/kotlin/prepared-statement-indices.yml

@@ -21,17 +21,21 @@ description: |
 
 query: |
   (call_expression
-    (simple_identifier) @METHOD (#match? @METHOD "^(setString|setInt|setLong|getString|getInt|getLong)$")
-    (value_arguments
-      (integer_literal) @INDEX) @ARGS)
+    (navigation_expression
+      (simple_identifier)
+      (navigation_suffix
+        (simple_identifier) @METHOD))
+    (call_suffix
+      (value_arguments
+        (value_argument (integer_literal) @INDEX) @ARGS))
+    (#match? @METHOD "^(setString|setInt|setLong|getString|getInt|getLong)$")
+    (#eq? @INDEX "0"))
 
 metavars:
   - METHOD
   - INDEX
   - ARGS
 
-post_filter: invalid_jdbc_index
-
 tags:
   - reliability
   - kotlin

package/rules/tree-sitter-queries/php/this-in-static-context.yml

@@ -33,15 +33,15 @@ description: |
 
 query: |
   (method_declaration
-    (modifiers
-      "static")
+    (static_modifier)
     body: (compound_statement
-      ((variable_name) @THIS
-        (#eq? @THIS "$this"))))
+      (return_statement
+        (member_access_expression
+          object: ((variable_name) @THIS
+            (#eq? @THIS "$this"))))) )
 
 metavars:
   - THIS
-  - VAR
 
 tags:
   - reliability

package/rules/tree-sitter-queries/python/exit-signature-check.yml

@@ -28,18 +28,11 @@ description: |
 query: |
   (function_definition
     name: (identifier) @NAME (#eq? @NAME "__exit__")
-    parameters: (parameters
-      (_) @SELF
-      . (_) @PARAM1?
-      . (_) @PARAM2?
-      . (_) @PARAM3?))
+    parameters: (parameters) @PARAMS)
 
 metavars:
   - NAME
-  - SELF
-  - PARAM1
-  - PARAM2
-  - PARAM3
+  - PARAMS
 
 post_filter: exit_params_insufficient
 

package/rules/tree-sitter-queries/python/in-operator-unsupported.yml

@@ -25,12 +25,11 @@ query: |
   (comparison_operator
     (identifier) @OBJ
     "in"
-    (identifier) @TARGET)
+    (_) @TARGET)
   (comparison_operator
     (identifier) @OBJ
-    "not"
-    "in"
-    (identifier) @TARGET)
+    "not in"
+    (_) @TARGET)
 
 metavars:
   - OBJ

package/rules/tree-sitter-queries/python/no-super-torchscript.yml

@@ -17,19 +17,15 @@ description: |
   ✅ FIX: Use composition or avoid TorchScript for this class
 
 query: |
-  (function_definition
-    (decorator
-      (call
-        function: (identifier) @DEC (#match? @DEC "^(torch\.jit\.script|jit\.script)$")))
-    body: (block
-      (call
-        function: (identifier) @FUNC (#eq? @FUNC "super")) @CALL))
+  (call
+    function: (identifier) @FUNC (#eq? @FUNC "super")) @CALL
 
 metavars:
-  - DEC
   - FUNC
   - CALL
 
+post_filter: torchscript_super_call
+
 tags:
   - reliability
   - python

package/rules/tree-sitter-queries/python/notimplemented-boolean-context.yml

@@ -28,13 +28,9 @@ query: |
     condition: (identifier) @COND (#eq? @COND "NotImplemented"))
   (while_statement
     condition: (identifier) @COND (#eq? @COND "NotImplemented"))
-  (binary_operator
-    (identifier) @COND (#eq? @COND "NotImplemented")
-    ("and" | "or"))
   (boolean_operator
     (identifier) @COND (#eq? @COND "NotImplemented"))
-  (unary_operator
-    operator: ("not")
+  (not_operator
     argument: (identifier) @COND (#eq? @COND "NotImplemented"))
 
 metavars:

package/rules/tree-sitter-queries/python/python-empty-except.yml

@@ -21,7 +21,7 @@ description: |
 query: |
   (try_statement
     (except_clause
-      body: (block) @BODY))
+      (block) @BODY))
 
 metavars:
   - BODY

package/rules/tree-sitter-queries/python/return-in-init.yml

@@ -35,8 +35,6 @@ metavars:
   - RETURN
   - RETURN_VAL
 
-post_filter: has_return_value
-
 tags:
   - reliability
   - python-specific

package/rules/tree-sitter-queries/python/yield-return-outside-function.yml

@@ -28,9 +28,6 @@ query: |
   (module
     (expression_statement
       (yield) @STATEMENT))
-  (module
-    (expression_statement
-      (yield_expression) @STATEMENT))
   (module
     (return_statement) @STATEMENT)
 

package/rules/tree-sitter-queries/ruby/ruby-command-injection.yml

@@ -19,19 +19,8 @@ description: |
 query: |
   (call
     method: (identifier) @FN
+    (#match? @FN "^(system|exec|spawn|popen|capture3|capture2|capture2e)$")
     arguments: (argument_list) @ARGS)
-  (#match? @FN "^(system|exec|spawn|popen|capture3|capture2|capture2e)$")
-
-  (command
-    method: (identifier) @FN
-    argument: (_) @ARGS)
-  (#match? @FN "^(system|exec|spawn|popen)$")
-
-  (call_expression
-    receiver: (constant) @NS
-    method: (identifier) @FN
-    arguments: (argument_list) @ARGS)
-  (#match? @FN "^(system|exec|spawn|popen|capture3|capture2|capture2e)$")
 
 metavars:
   - FN

package/rules/tree-sitter-queries/ruby/ruby-eval.yml

@@ -17,7 +17,7 @@ description: |
   ✅ FIX: Use send(), const_get(), or other metaprogramming instead.
 
 query: |
-  (method_call
+  (call
     method: (identifier) @METHOD
     (#eq? @METHOD "eval")
     arguments: (argument_list) @ARGS)

package/rules/tree-sitter-queries/ruby/ruby-insecure-deserialization.yml

@@ -16,12 +16,12 @@ description: |
   ✅ FIX: use safe serialization formats and strict schema validation.
 
 query: |
-  (call_expression
+  (call
     receiver: (constant) @MOD
-    method: (identifier) @FN
-    arguments: (argument_list (_) @DATA)
     (#match? @MOD "^(Marshal|YAML|Psych)$")
-    (#match? @FN "^(load|unsafe_load)$"))
+    method: (identifier) @FN
+    (#match? @FN "^(load|unsafe_load)$")
+    arguments: (argument_list (_) @DATA))
 
 metavars:
   - MOD

package/rules/tree-sitter-queries/ruby/ruby-insecure-random.yml

@@ -16,19 +16,12 @@ description: |
   ✅ FIX: use SecureRandom.hex/base64/uuid.
 
 query: |
-  [
-    (call
-      method: (identifier) @FN
-      arguments: (argument_list) @ARGS)
-    (call_expression
-      receiver: (constant) @MOD
-      method: (identifier) @FN
-      arguments: (argument_list) @ARGS)
-  ]
-  (#match? @FN "^(rand|srand)$")
+  (call
+    method: (identifier) @FN
+    (#match? @FN "^(rand|srand)$")
+    arguments: (argument_list) @ARGS)
 
 metavars:
-  - MOD
   - FN
   - ARGS
 

package/rules/tree-sitter-queries/ruby/ruby-open-struct.yml

@@ -17,7 +17,7 @@ description: |
   ✅ FIX: Use Struct.new or a plain class with attr_accessor.
 
 query: |
-  (call_expression
+  (call
     receiver: (constant) @RECV
     (#eq? @RECV "OpenStruct")
     method: (identifier) @METHOD

package/rules/tree-sitter-queries/ruby/ruby-string-eval.yml

@@ -28,9 +28,8 @@ description: |
 query: |
   (call
     method: (identifier) @METHOD
-    arguments: (argument_list
-      [(string) (interpolated_string)] @ARG)
-    (#match? @METHOD "^(eval|class_eval|module_eval|instance_eval)$")) @CALL
+    (#match? @METHOD "^(eval|class_eval|module_eval|instance_eval)$")
+    arguments: (argument_list (string) @ARG)) @CALL
 
 metavars:
   - METHOD

package/rules/tree-sitter-queries/ruby/ruby-weak-hash.yml

@@ -16,12 +16,12 @@ description: |
   ✅ FIX: use Digest::SHA256 or stronger algorithms.
 
 query: |
-  (call_expression
-    receiver: (constant) @MOD
+  (call
+    receiver: (scope_resolution) @MOD
+    (#match? @MOD "^(Digest::MD5|Digest::SHA1)$")
     method: (identifier) @FN
+    (#match? @FN "^(hexdigest|digest|base64digest)$")
     arguments: (argument_list) @ARGS)
-  (#match? @MOD "^(Digest::MD5|Digest::SHA1)$")
-  (#match? @FN "^(hexdigest|digest|base64digest)$")
 
 metavars:
   - MOD

package/rules/tree-sitter-queries/rust/rust-lock-held-across-await.yml

@@ -20,12 +20,13 @@ query: |
     (let_declaration
       pattern: (identifier) @GUARD
       value: (await_expression
-        expression: (call_expression
+        (call_expression
           function: (field_expression
+            value: (_)
             field: (field_identifier) @LOCKFN))))
     (_)*
-    (await_expression) @LATER_AWAIT)
-  (#eq? @LOCKFN "lock")
+    (expression_statement (await_expression) @LATER_AWAIT)
+    (#eq? @LOCKFN "lock"))
 
 metavars:
   - GUARD

package/rules/tree-sitter-queries/tsx/no-nested-links.yml

@@ -18,15 +18,13 @@ query: |
   (jsx_element
     open_tag: (jsx_opening_element
       (identifier) @OUTER
-      (#eq? @OUTER "a"))
-    (jsx_element
-      open_tag: (jsx_opening_element
-        (identifier) @INNER
-        (#eq? @INNER "a"))))
+      (#eq? @OUTER "a"))) @OUTER_ELEMENT
 
 metavars:
   - OUTER
-  - INNER
+  - OUTER_ELEMENT
+
+post_filter: no_nested_anchor_chain
 
 tags:
   - correctness

package/rules/tree-sitter-queries/typescript/console-statement.yml

@@ -24,6 +24,17 @@ query: |
 
 post_filter: not_in_test_block  # skip test blocks — no-console-in-tests handles that case
 
+# Console output IS the point in a CLI script's own stdout contract and in a
+# logging implementation's console fallback/sink — flagging it there just
+# trains users to ignore the rule (#965). Application/library code outside
+# these paths still gets flagged.
+ignore_paths:
+  - "scripts/**"
+  - "bin/**"
+  - "**/logger.ts"
+  - "**/logger.js"
+  - "**/logger.mjs"
+
 metavars:
   - OBJ
   - METHOD

package/rules/tree-sitter-queries/typescript/duplicate-function-arg.yml

@@ -21,18 +21,13 @@ description: |
   ```
 
 query: |
-  (function_declaration
-    parameters: (formal_parameters
-      (identifier) @PARAM1
-      (identifier) @PARAM2))
-  (arrow_function
-    parameters: (formal_parameters
-      (identifier) @PARAM1
-      (identifier) @PARAM2))
+  (formal_parameters
+    (_ pattern: (_) @PARAM1)
+    (_ pattern: (_) @NAME))
 
 metavars:
   - PARAM1
-  - PARAM2
+  - NAME
 
 post_filter: same_param_name
 

package/rules/tree-sitter-queries/typescript/empty-switch-case.yml

@@ -8,11 +8,14 @@ defect_class: correctness
 inline_tier: blocking
 language: typescript
 
-message: "Switch case should not be empty"
+message: "Switch case is empty and shares no body with a following label"
 
 description: |
-  Empty switch cases are confusing and likely indicate incomplete
-  code. Add handling or remove the case.
+  A case with no body and no following label handles nothing — likely
+  incomplete code. Add handling or remove the case.
+
+  Grouped labels are not flagged: in `case 1: case 2: doWork();` the first
+  label deliberately shares the second's body.
 
   ✅ FIX: Add case body or remove
 
@@ -27,11 +30,10 @@ description: |
 query: |
   (switch_statement
     body: (switch_body
-      (switch_case
-        consequence: (statement_block) @BLOCK)))
+      (switch_case) @CASE))
 
 metavars:
-  - BLOCK
+  - CASE
 
 post_filter: is_empty_block
 
@@ -42,13 +44,15 @@ tags:
 
 examples:
   bad: |
-    case 1:  // BAD - empty
-    case 2:
+    case 1:
         doWork();
+        break;
+    case 2:  // BAD - empty, nothing follows it
 
   good: |
     case 1:
-        handleOne();  // GOOD
+    case 2:      // GOOD - grouped labels share the body below
+        doWork();
         break;
 
 has_fix: false

package/rules/tree-sitter-queries/typescript/infinite-loop.yml

@@ -24,10 +24,10 @@ description: |
 
 query: |
   (while_statement
-    condition: (true)
+    condition: (parenthesized_expression (true))
     body: (statement_block) @BODY)
   (for_statement
-    condition: (null)
+    condition: (empty_statement)
     body: (statement_block) @BODY)
 
 metavars:

package/rules/tree-sitter-queries/typescript/mixed-async-styles.yml

@@ -20,7 +20,16 @@ description: |
 
 query: |
   (function_declaration
-    (async_modifier)
+    "async"
+    body: (statement_block) @BODY)
+  (arrow_function
+    "async"
+    body: (statement_block) @BODY)
+  (method_definition
+    "async"
+    body: (statement_block) @BODY)
+  (function_expression
+    "async"
     body: (statement_block) @BODY)
 
 # Post-filter: Check if body contains both await and .then()

package/rules/tree-sitter-queries/typescript/switch-case-termination.yml

@@ -26,16 +26,13 @@ description: |
   ```
 
 query: |
-  (switch_statement
-    body: (switch_body
-      (switch_case
-        consequence: (statement_block
-          (expression_statement) @LAST))
-      (switch_case) @NEXT))
+  (switch_body
+    (switch_case) @CASE
+    .
+    [(switch_case) (switch_default)])
 
 metavars:
-  - LAST
-  - NEXT
+  - CASE
 
 post_filter: no_terminating_statement