pi-lens 3.8.39 → 3.8.41

package/rules/tree-sitter-queries/typescript/default-not-last.yml

@@ -0,0 +1,54 @@
+# Default Not Last
+# Detects default clauses that are not last
+id: default-not-last
+name: Default Clauses Should Be Last
+severity: error
+category: maintainability
+defect_class: correctness
+inline_tier: blocking
+language: typescript
+
+message: "default clause should be the last case"
+
+description: |
+  The default clause should always be the last case in a switch.
+  Having it before other cases is confusing and may cause bugs.
+
+  ✅ FIX: Move default to the end
+
+  ```typescript
+  switch (x) {
+      case 1: ...
+      default: ...  // GOOD - last
+  }
+  ```
+
+query: |
+  (switch_statement
+    body: (switch_body
+      (switch_default) @DEFAULT
+      (switch_case) @AFTER_CASE))
+
+metavars:
+  - DEFAULT
+  - AFTER_CASE
+
+tags:
+  - maintainability
+  - typescript
+  - confusing
+
+examples:
+  bad: |
+    switch (x) {
+        default: ...  // BAD - not last
+        case 1: ...
+    }
+
+  good: |
+    switch (x) {
+        case 1: ...
+        default: ...  // GOOD - last
+    }
+
+has_fix: false

package/rules/tree-sitter-queries/typescript/duplicate-function-arg.yml

@@ -0,0 +1,51 @@
+# Duplicate Function Argument
+# Detects duplicate parameter names
+id: duplicate-function-arg
+name: Function Argument Names Should Be Unique
+severity: error
+category: reliability
+defect_class: correctness
+inline_tier: blocking
+language: typescript
+
+message: "Duplicate parameter name '{{NAME}}'"
+
+description: |
+  Duplicate parameter names cause the last one to shadow earlier
+  ones, leading to confusing behavior. Use unique names.
+
+  ✅ FIX: Use unique parameter names
+
+  ```typescript
+  function add(a: number, b: number) { }  // GOOD
+  ```
+
+query: |
+  (function_declaration
+    parameters: (formal_parameters
+      (identifier) @PARAM1
+      (identifier) @PARAM2))
+  (arrow_function
+    parameters: (formal_parameters
+      (identifier) @PARAM1
+      (identifier) @PARAM2))
+
+metavars:
+  - PARAM1
+  - PARAM2
+
+post_filter: same_param_name
+
+tags:
+  - reliability
+  - typescript
+  - bugs
+
+examples:
+  bad: |
+    function add(a, a) { }  // BAD - duplicate
+
+  good: |
+    function add(a, b) { }  // GOOD - unique
+
+has_fix: false

package/rules/tree-sitter-queries/typescript/empty-switch-case.yml

@@ -0,0 +1,54 @@
+# Empty Switch Case
+# Detects empty switch cases
+id: empty-switch-case
+name: Switch Cases Should Not Be Empty
+severity: error
+category: reliability
+defect_class: correctness
+inline_tier: blocking
+language: typescript
+
+message: "Switch case should not be empty"
+
+description: |
+  Empty switch cases are confusing and likely indicate incomplete
+  code. Add handling or remove the case.
+
+  ✅ FIX: Add case body or remove
+
+  ```typescript
+  switch (x) {
+      case 1:
+          handleOne();  // GOOD
+          break;
+  }
+  ```
+
+query: |
+  (switch_statement
+    body: (switch_body
+      (switch_case
+        consequence: (statement_block) @BLOCK)))
+
+metavars:
+  - BLOCK
+
+post_filter: is_empty_block
+
+tags:
+  - reliability
+  - typescript
+  - bugs
+
+examples:
+  bad: |
+    case 1:  // BAD - empty
+    case 2:
+        doWork();
+
+  good: |
+    case 1:
+        handleOne();  // GOOD
+        break;
+
+has_fix: false

package/rules/tree-sitter-queries/typescript/infinite-loop.yml

@@ -0,0 +1,55 @@
+# Infinite Loop TypeScript
+# Detects potentially infinite loops
+id: infinite-loop
+name: Loops Should Not Be Infinite
+severity: error
+category: reliability
+defect_class: correctness
+inline_tier: blocking
+language: typescript
+
+message: "Loop appears to be infinite with no termination condition"
+
+description: |
+  while(true) or for(;;) without break/return creates infinite loops.
+  Ensure there's an exit condition.
+
+  ✅ FIX: Add break condition
+
+  ```typescript
+  while (running) {  // control flag
+      if (shouldStop()) break;
+  }
+  ```
+
+query: |
+  (while_statement
+    condition: (true)
+    body: (statement_block) @BODY)
+  (for_statement
+    condition: (null)
+    body: (statement_block) @BODY)
+
+metavars:
+  - BODY
+
+post_filter: no_break_or_return_in_body
+
+tags:
+  - reliability
+  - typescript
+  - bugs
+
+examples:
+  bad: |
+    while (true) {  // BAD
+        doWork();
+    }
+
+  good: |
+    while (true) {  // GOOD - has exit
+        if (done) break;
+        doWork();
+    }
+
+has_fix: false

package/rules/tree-sitter-queries/typescript/self-assignment.yml

@@ -0,0 +1,46 @@
+# Self Assignment
+# Detects variables assigned to themselves
+id: self-assignment
+name: Variables Should Not Be Self-Assigned
+severity: error
+category: reliability
+defect_class: correctness
+inline_tier: blocking
+language: typescript
+
+message: "'{{VAR}}' is assigned to itself"
+
+description: |
+  Self-assignment (x = x) has no effect and indicates a bug,
+  usually from typo or incomplete refactoring.
+
+  ✅ FIX: Fix the assignment or remove it
+
+  ```typescript
+  x = y;  // GOOD - actual intent
+  ```
+
+query: |
+  (assignment_expression
+    left: (identifier) @VAR
+    right: (identifier) @SAME
+    (#eq? @VAR @SAME))
+
+metavars:
+  - VAR
+  - SAME
+
+tags:
+  - reliability
+  - typescript
+  - bugs
+  - suspicious
+
+examples:
+  bad: |
+    x = x;  // BAD - no effect
+
+  good: |
+    x = y;  // GOOD - actual assignment
+
+has_fix: false

package/rules/tree-sitter-queries/typescript/switch-case-termination.yml

@@ -0,0 +1,64 @@
+# Switch Case Termination
+# Detects switch cases that don't properly terminate
+id: switch-case-termination
+name: Switch Cases Should End With Terminating Statement
+severity: error
+category: reliability
+defect_class: correctness
+inline_tier: blocking
+language: typescript
+
+message: "Switch case should end with break, return, throw, or continue"
+
+description: |
+  Switch cases that fall through to the next case cause bugs.
+  Each case should end with break, return, throw, or continue.
+  If fall-through is intentional, add a // fallthrough comment.
+
+  ✅ FIX: Add terminating statement
+
+  ```typescript
+  switch (x) {
+      case 1:
+          doSomething();
+          break;  // GOOD
+  }
+  ```
+
+query: |
+  (switch_statement
+    body: (switch_body
+      (switch_case
+        consequence: (statement_block
+          (expression_statement) @LAST))
+      (switch_case) @NEXT))
+
+metavars:
+  - LAST
+  - NEXT
+
+post_filter: no_terminating_statement
+
+tags:
+  - reliability
+  - typescript
+  - bugs
+
+examples:
+  bad: |
+    switch (x) {
+        case 1:
+            doSomething();  // BAD - falls through
+        case 2:
+            break;
+    }
+
+  good: |
+    switch (x) {
+        case 1:
+            return "one";  // GOOD - return terminates
+        case 2:
+            break;
+    }
+
+has_fix: false