pi-lens 3.8.29 → 3.8.31

package/CHANGELOG.md

@@ -4,6 +4,75 @@ All notable changes to pi-lens will be documented in this file.
 
 ## [Unreleased]
 
+## [3.8.31] - 2026-04-23
+
+### Fixed
+- **Duplicate inline feedback on edit arrays** — `tool_result` calls for the same file are now deduplicated within a turn using a `reportedThisTurn` set on `RuntimeCoordinator`, cleared on each `turn_start`; previously pi's sequential per-hunk `tool_result` firing caused the pipeline to re-run and feedback to repeat N times per edit array
+- **Double latency logging on pipeline completion** — removed redundant `logLatency` call in `pipeline.ts`; `runtime-tool-result.ts` already logs the outer `tool_result completed` with full duration including format, autofix, and cascade phases
+- **Modified range tracking broken for 3-digit+ line numbers** — `parseDiffRanges` regex changed from `\s+` to `\s*` to handle unpadded line numbers; the diff format right-pads to the file's max digit width so e.g. line 613 in a <1000-line file has no leading space and was silently dropped
+- **Stale gleam grammar entries** — removed dead `LANGUAGE_TO_GRAMMAR` and `getExtensionsForLanguage` entries for gleam; `tree-sitter-gleam.wasm` was never published in `tree-sitter-wasms@0.1.13`
+
+### Changed
+- **TypeBox 0.34.x → 1.x migration** — updated `package.json` dependency from `@sinclair/typebox` to `typebox ^1.0.0` and updated imports in `tools/lsp-navigation.ts`, `tools/ast-grep-search.ts`, and `tools/ast-grep-replace.ts` to match pi-mono 0.69.0
+
+## [3.8.30] - 2026-04-22
+
+### Fixed
+- **lsp_navigation permanently disabled** — removed stale `lens-lsp` flag check (flag was removed in 3.8.29) that caused every `lsp_navigation` call to short-circuit with `lsp_disabled`; tool now only gates on `--no-lsp`
+- **ast_grep_search / ast_grep_replace auto-install** — switched availability check from sync `isAvailable()` to async `ensureAvailable()` so the auto-installer triggers when `sg` is missing
+- **@ast-grep/cli postinstall skipped** — added `@ast-grep/cli` to `NEEDS_POSTINSTALL`; without it `--ignore-scripts` left ASCII stubs in place of `sg.exe` / `ast-grep.exe` on Windows
+- **Windows .exe binary lookup** — `getToolPath` now also probes the `.exe` extension on Windows, covering packages (like `@ast-grep/cli`) that place a `.exe` directly without a `.cmd` wrapper
+- **jscpd broken on Node 24** — pinned `jscpd` to `3.5.10`; v4 introduced a `reprism` dependency whose `lib/languages/` directory is absent from the published package
+- **TypeScript LSP using home dir as workspace root** — wrapped `TypeScriptServer` and `ESLintServer` roots with `IgnoreHomeRoot` so a `package.json` / eslint config in `~` can no longer hijacks the workspace root; fallback is the file's own directory
+- **CI npm publish runs without token** — gated `publish-npm` job and dry-run step on `NPM_TOKEN` secret being set
+- **Stale compiled .js triggered test failures** — rebuilt project; `secrets-scanner.js` and `project-index.js` were from before the env-var-name false-positive fix and line-number capture fix respectively
+- **ast_grep_search test mock** — updated test mock from `isAvailable` to `ensureAvailable` to match the new async availability check
+- **Stale LSP diagnostics in cascade** — cascade diagnostics now skip entries older than 240s, preventing false positives from earlier test injections bleeding across turns
+- **Biome check on Vue/Svelte** — biome-check-json was briefly skipped on `.vue`/`.svelte` but restored after confirming Biome 2.x has native support; the 3 blocking diagnostics were real lint findings, not parse errors
+- **Vue/Svelte TypeScript SDK** — extracted `findTsserverPath` helper and wired it into `VueServer` and `SvelteServer` `initializationOptions` so Vue/Svelte LSP servers find the correct `typescript.tsdk`
+- **Broken npm .cmd shims on Windows** — `launch.ts` now validates npm `.cmd` shims before spawning; if the target JS file doesn't exist the shim exits with code 1 after a 500ms startup window, pre-checking avoids the delay for all LSP servers on Windows
+- **Tree-sitter WASM path in hoisted installs** — `tree-sitter-client.ts` now resolves `web-tree-sitter/tree-sitter.wasm` via `createRequire` so Node walks `node_modules` ancestors correctly; fixes `ENOENT` crash in pnpm/monorepo layouts where the wasm is not nested under pi-lens's own `node_modules`
+- **Grammar directory lookups in hoisted installs** — `findGrammarsDir` uses the same `createRequire` fix to anchor `web-tree-sitter/grammars` and `tree-sitter-wasms/out` paths correctly in pnpm/monorepo layouts
+- **tree-sitter-gleam download 404** — removed `tree-sitter-gleam.wasm` from grammar downloads; the file was never published in `tree-sitter-wasms@0.1.13`
+- **Pipeline deduplication** — `handleToolResult` now deduplicates concurrent pipeline calls for the same file; the pi framework fires `tool_result` once per hunk in an Edit array, causing duplicate pipeline runs and doubled agent output
+
+### Changed
+- **Tuned false-positive thresholds across all runners** — reduced noise in `lens-booboo` and dispatch for all users:
+  - Added `FACT_SEVERITY_FILTER` (`error`/`warning` only) and `MIN_TREE_SITTER_HITS_PER_RULE = 3`
+  - Filtered entropy/AI-style warnings from complexity metrics
+  - Aligned complexity markdown headers with actual thresholds (`MI < 20`, `cognitive > 80`, `nesting > 8`)
+  - Raised `SEMANTIC_SIMILARITY_THRESHOLD` from `0.96` → `0.98` (aligned with dispatch similarity runner)
+  - Raised duplicate-string-literal `MIN_DUPLICATES` from `4` → `10`
+  - Unregistered `no-magic-numbers` and `high-entropy-string` fact rules globally
+
+### Removed
+- **Dead code across 32 files** — removed 51 sites of unused imports, locals, and parameters flagged by `tsc --noUnusedLocals --noUnusedParameters`:
+  - `clients/architect-client.ts`, `ast-grep-client.ts`, `biome-client.ts`, `complexity-client.ts`, `go-client.ts`, `rust-client.ts`, `scan-utils.ts`, `secrets-scanner.ts`, `subprocess-client.ts`, `test-runner-client.ts`, `tool-availability.ts`, `tree-sitter-cache.ts`, `tree-sitter-client.ts`, `type-coverage-client.ts`, `type-safety-client.ts`
+  - `clients/dispatch/dispatcher.ts`, `runners/ast-grep-napi.ts`, `runners/golangci-lint.ts`, `runners/index.ts`, `runners/python-slop.ts`, `runners/ts-lsp.ts`, `runners/utils/diagnostic-parsers.ts`
+  - `clients/lsp/client.ts`, `config.ts`, `interactive-install.ts`, `launch.ts`, `server.ts`
+  - `clients/pipeline.ts`, `review-graph/builder.ts`, `runner-tracker.ts`
+  - `commands/booboo.ts`, `index.ts`
+
+### Tests
+- **Pipeline regression tests** — `tests/clients/pipeline.test.ts` (11 tests): secrets blocking, format modification, LSP sync, dispatch blockers, autofix output, test runner skip, all-clear output
+- **Autofix helper tests** — `tests/clients/autofix-helpers.test.ts` (12 tests): config detection (eslint, stylelint, sqlfluff), malformed JSON handling, file change detection after command
+- **LSP lifecycle tests** — `tests/clients/lsp/lifecycle.test.ts` (4 tests): missing binary error, process spawn, immediate exit detection, process kill
+- **FormatService tests** — `tests/clients/format-service.test.ts` (11 tests): disabled/skip mode, no matching formatters, successful run with change detection, formatter failure, external modification detection, singleton behavior, state clearing, file tracking
+- **Dispatch integration tests** — `tests/clients/dispatch/integration.test.ts` (11 tests): `dispatchLintWithResult` empty results, result propagation, warnings-only; `shouldDispatch` for supported/unsupported; `getAvailableRunners` for supported/unsupported
+- **LSP client internals tests** — `tests/clients/lsp/client-internals.test.ts` (13 tests): `handleNotifyOpen` (first open, re-open, pending opens, clear diagnostics, skip when not alive), `handleNotifyChange` (didChange when open, fallback to didOpen, clear stale diagnostics, skip when not alive), `clientWaitForDiagnostics` (immediate resolve if cached, resolve via emitter, timeout, ignore other files)
+- **Runtime event flow test fix** — added missing `gatherCascadeDiagnostics` mock export to `tests/clients/runtime-event-flow.test.ts`
+- **LSP launch tests** — `tests/clients/lsp/launch.test.ts` (8 new tests): `isCmdShimValid` unit tests (target exists/missing, non-npm shim, unreadable file, `.mjs` extension), early `.cmd` shim rejection without spawning, `.ps1` bypass to `.cmd` sibling, `.ps1` fallback to direct `node <js>` execution
+- **Tree-sitter hoisted-install tests** — `tests/clients/tree-sitter-client-init.test.ts` (3 tests): wasm resolution via `require.resolve`, `locateFile` directory derivation, `findGrammarsDir` external package resolution
+
+### Refactored
+- **Extract `detectFileChangedAfterCommand`** — moved from `clients/pipeline.ts` to `clients/file-utils.ts` and exported for reuse/testing; imported back into `pipeline.ts`; `tests/clients/autofix-helpers.test.ts` now imports the real function instead of reimplementing a copy
+- **Export testable pipeline helpers** — exported `hasEslintConfig`, `hasStylelintConfig`, `hasSqlfluffConfig` from `clients/pipeline.ts` so config detection is testable
+- **Export LSP client internals** — exported `clientWaitForDiagnostics`, `handleNotifyOpen`, `handleNotifyChange`, and `LSPClientState` from `clients/lsp/client.ts` for direct testing with mocks
+- **Export `isCmdShimValid`** — exported from `clients/lsp/launch.ts` so the npm `.cmd` shim validator is unit-testable
+
+### CI
+- **Dead-code gate** — `lint-and-typecheck` job now runs `tsc --noUnusedLocals --noUnusedParameters --noEmit` alongside `--noEmit` so dead code regressions fail CI immediately
+
 ## [3.8.29] - 2026-04-21
 
 ### Added

package/clients/architect-client.ts

@@ -53,7 +53,6 @@ export interface FileArchitectResult {
 export class ArchitectClient {
 	private config: ArchitectConfig | null = null;
 	private isUserConfig: boolean = false;
-	private configPath: string | undefined;
 	private log: (msg: string) => void;
 
 	constructor(verbose = false) {
@@ -78,7 +77,6 @@ export class ArchitectClient {
 			try {
 				const content = fs.readFileSync(configPath, "utf-8");
 				this.config = this.parseYaml(content);
-				this.configPath = configPath;
 				this.isUserConfig = true;
 				this.log(`Loaded user architect config from ${configPath}`);
 				return true;
@@ -112,7 +110,6 @@ export class ArchitectClient {
 				try {
 					const content = fs.readFileSync(defaultPath, "utf-8");
 					this.config = this.parseYaml(content);
-					this.configPath = defaultPath;
 					this.isUserConfig = false;
 					this.log(
 						"Using default architect rules (create .pi-lens/architect.yaml to customize)",
@@ -387,5 +384,3 @@ export class ArchitectClient {
 }
 
 // --- Singleton ---
-
-const _instance: ArchitectClient | null = null;

package/clients/ast-grep-client.ts

@@ -22,13 +22,6 @@ import type {
 import { resolvePackagePath } from "./package-root.js";
 import { SgRunner } from "./sg-runner.js";
 
-const _getExtensionDir = () => {
-	if (typeof __dirname !== "undefined") {
-		return __dirname;
-	}
-	return ".";
-};
-
 // --- Client ---
 
 export class AstGrepClient {

package/clients/biome-client.ts

@@ -28,17 +28,6 @@ export interface BiomeDiagnostic {
 	fixable: boolean;
 }
 
-interface BiomeJsonDiagnostic {
-	message: string;
-	severity: "error" | "warning" | "info" | "hint";
-	category: string;
-	span?: {
-		start: { line: number; column: number };
-		end: { line: number; column: number };
-	};
-	advice?: Array<{ message: string }>;
-}
-
 // --- Client ---
 
 export class BiomeClient {

package/clients/complexity-client.ts

@@ -363,7 +363,6 @@ export class ComplexityClient {
 	 * Calculate max parameters across all functions
 	 */
 	private calculateMaxParams(functions: FunctionMetrics[]): number {
-		const _maxParams = 0;
 		// We stored function params in the metrics during analysis
 		// For now, estimate based on function length (longer functions often have more params)
 		return Math.min(

package/clients/dispatch/dispatcher.ts

@@ -627,7 +627,6 @@ export async function dispatchForFile(
 ): Promise<DispatchResult> {
 	const _overallStart = Date.now();
 	const allDiagnostics: Diagnostic[] = [];
-	const _fixed: Diagnostic[] = [];
 	let stopped = false;
 	const runnerLatencies: RunnerLatency[] = [];
 

package/clients/dispatch/integration.ts

@@ -81,11 +81,9 @@ import { missingErrorPropagationRule } from "./rules/missing-error-propagation.j
 import { passThroughWrappersRule } from "./rules/pass-through-wrappers.js";
 import { placeholderCommentsRule } from "./rules/placeholder-comments.js";
 import {
-	highEntropyStringRule,
 	highImportCouplingRule,
 	noBooleanParamsRule,
 	noComplexConditionalsRule,
-	noMagicNumbersRule,
 } from "./rules/quality-rules.js";
 import {
 	commentedCredentialsRule,
@@ -117,11 +115,9 @@ registerRule(corsWildcardRule);
 registerRule(dynamicRegexpRule);
 registerRule(maxSwitchCasesRule);
 registerRule(commentedCredentialsRule);
-registerRule(noMagicNumbersRule);
 registerRule(noBooleanParamsRule);
 registerRule(highImportCouplingRule);
 registerRule(noComplexConditionalsRule);
-registerRule(highEntropyStringRule);
 
 const sessionFacts = new FactStore();
 const sessionRunnerRegistry = new RunnerRegistry();
@@ -146,11 +142,9 @@ const FACT_RULE_IDS = new Set([
 	"dynamic-regexp",
 	"max-switch-cases",
 	"no-commented-credentials",
-	"no-magic-numbers",
 	"no-boolean-params",
 	"high-import-coupling",
 	"no-complex-conditionals",
-	"high-entropy-string",
 ]);
 const sessionSlopRuleCounts = new Map<string, number>();
 let sessionSlopDiagnosticCount = 0;

package/clients/dispatch/rules/sonar-rules.ts

@@ -34,7 +34,7 @@ function createSourceFile(filePath: string, content: string): ts.SourceFile {
 }
 
 function makeD(
-	id: string,
+	_id: string,
 	rule: string,
 	filePath: string,
 	line: number,
@@ -95,9 +95,10 @@ export const commentedOutCodeRule: FactRule = {
 			if (seen.has(r.pos)) continue;
 			seen.add(r.pos);
 			const text = content.slice(r.pos, r.end);
-			const inner = r.kind === ts.SyntaxKind.MultiLineCommentTrivia
-				? text.slice(2, -2)
-				: text.replace(/^\/\//gm, "");
+			const inner =
+				r.kind === ts.SyntaxKind.MultiLineCommentTrivia
+					? text.slice(2, -2)
+					: text.replace(/^\/\//gm, "");
 			if (!looksLikeCode(inner)) continue;
 			const { line } = sf.getLineAndCharacterOfPosition(r.pos);
 			diagnostics.push(
@@ -117,7 +118,7 @@ export const commentedOutCodeRule: FactRule = {
 
 // ---------- SN-002: duplicate string literals ----------
 
-const MIN_DUPLICATES = 4;
+const MIN_DUPLICATES = 10;
 const MIN_STRING_LENGTH = 5;
 // Skip common non-signal strings (string-enum values, HTTP verbs, primitives, etc.)
 const SKIP_STRINGS = new Set([
@@ -280,8 +281,9 @@ export const functionInLoopRule: FactRule = {
 
 		function visit(node: ts.Node) {
 			if (ts.isFunctionDeclaration(node) && isInsideLoop(node)) {
-				const { line, character } =
-					sf.getLineAndCharacterOfPosition(node.getStart(sf));
+				const { line, character } = sf.getLineAndCharacterOfPosition(
+					node.getStart(sf),
+				);
 				diagnostics.push(
 					makeD(
 						"function-in-loop",
@@ -393,8 +395,9 @@ export const dynamicRegexpRule: FactRule = {
 					!ts.isStringLiteral(firstArg) &&
 					!ts.isNoSubstitutionTemplateLiteral(firstArg)
 				) {
-					const { line, character } =
-						sf.getLineAndCharacterOfPosition(node.getStart(sf));
+					const { line, character } = sf.getLineAndCharacterOfPosition(
+						node.getStart(sf),
+					);
 					diagnostics.push(
 						makeD(
 							"dynamic-regexp",
@@ -430,12 +433,11 @@ export const maxSwitchCasesRule: FactRule = {
 
 		function visit(node: ts.Node) {
 			if (ts.isSwitchStatement(node)) {
-				const caseCount = node.caseBlock.clauses.filter(
-					ts.isCaseClause,
-				).length;
+				const caseCount = node.caseBlock.clauses.filter(ts.isCaseClause).length;
 				if (caseCount > MAX_SWITCH_CASES) {
-					const { line, character } =
-						sf.getLineAndCharacterOfPosition(node.getStart(sf));
+					const { line, character } = sf.getLineAndCharacterOfPosition(
+						node.getStart(sf),
+					);
 					diagnostics.push(
 						makeD(
 							"max-switch-cases",
@@ -477,7 +479,11 @@ export const commentedCredentialsRule: FactRule = {
 		const lines = content.split("\n");
 		for (let i = 0; i < lines.length; i++) {
 			const line = lines[i].trimStart();
-			if (!line.startsWith("//") && !line.startsWith("#") && !line.startsWith("*"))
+			if (
+				!line.startsWith("//") &&
+				!line.startsWith("#") &&
+				!line.startsWith("*")
+			)
 				continue;
 			for (const p of CREDENTIAL_PATTERNS) {
 				if (p.test(line)) {

package/clients/dispatch/runners/ast-grep-napi.ts

@@ -358,7 +358,7 @@ function getCandidatesForAll(
 function executeStructuredRule(
 	rootNode: any,
 	condition: YamlRuleCondition,
-	matches: unknown[] = [],
+	_matches: unknown[] = [],
 	depth = 0,
 ): unknown[] {
 	return findMatchingNodes(rootNode, condition, depth);

package/clients/dispatch/runners/golangci-lint.ts

@@ -13,15 +13,14 @@
 import * as fs from "node:fs";
 import * as path from "node:path";
 import { safeSpawnAsync } from "../../safe-spawn.js";
-import { stripAnsi } from "../../sanitize.js";
-import { tryLazyInstall } from "./utils/lazy-installer.js";
+import { PRIORITY } from "../priorities.js";
 import type {
 	Diagnostic,
 	DispatchContext,
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
-import { PRIORITY } from "../priorities.js";
+import { tryLazyInstall } from "./utils/lazy-installer.js";
 
 const GOLANGCI_CONFIGS = [
 	".golangci.yml",
@@ -117,8 +116,6 @@ const golangciRunner: RunnerDefinition = {
 			{ timeout: 60000, cwd },
 		);
 
-		const raw = stripAnsi(result.stdout + result.stderr);
-
 		if (result.status === 0) {
 			return { status: "succeeded", diagnostics: [], semantic: "none" };
 		}

package/clients/dispatch/runners/index.ts

@@ -7,49 +7,48 @@ import architectRunner from "./architect.js";
 import astGrepNapiRunner from "./ast-grep-napi.js";
 import biomeRunner from "./biome.js";
 import biomeCheckJsonRunner from "./biome-check.js";
+import cppCheckRunner from "./cpp-check.js";
+import credoRunner from "./credo.js";
+import dartAnalyzeRunner from "./dart-analyze.js";
+import dotnetBuildRunner from "./dotnet-build.js";
+import elixirCheckRunner from "./elixir-check.js";
 import eslintRunner from "./eslint.js";
+import factRulesRunner from "./fact-rules.js";
+import gleamCheckRunner from "./gleam-check.js";
 import goVetRunner from "./go-vet.js";
 import golangciRunner from "./golangci-lint.js";
+import hadolintRunner from "./hadolint.js";
+import htmlhintRunner from "./htmlhint.js";
+import javacRunner from "./javac.js";
+import ktlintRunner from "./ktlint.js";
 import lspRunner from "./lsp.js";
-import oxlintRunner from "./oxlint.js";
+import markdownlintRunner from "./markdownlint.js";
+import mypyRunner from "./mypy.js";
+import phpLintRunner from "./php-lint.js";
+import phpstanRunner from "./phpstan.js";
+import prettierCheckRunner from "./prettier-check.js";
+import prismaValidateRunner from "./prisma-validate.js";
+import psScriptAnalyzerRunner from "./psscriptanalyzer.js";
 import pyrightRunner from "./pyright.js";
 import pythonSlopRunner from "./python-slop.js";
 import rubocopRunner from "./rubocop.js";
 import ruffRunner from "./ruff.js";
 import rustClippyRunner from "./rust-clippy.js";
 import shellcheckRunner from "./shellcheck.js";
-import sqlfluffRunner from "./sqlfluff.js";
+import shfmtRunner from "./shfmt.js";
 // Import similarity runner
 import similarityRunner from "./similarity.js";
 import spellcheckRunner from "./spellcheck.js";
-import yamllintRunner from "./yamllint.js";
+import sqlfluffRunner from "./sqlfluff.js";
+import stylelintRunner from "./stylelint.js";
+import taploRunner from "./taplo.js";
+import tflintRunner from "./tflint.js";
 // Import tree-sitter runner
 import treeSitterRunner from "./tree-sitter.js";
 import tsLspRunner from "./ts-lsp.js";
 import typeSafetyRunner from "./type-safety.js";
-import markdownlintRunner from "./markdownlint.js";
-import mypyRunner from "./mypy.js";
-import stylelintRunner from "./stylelint.js";
-import shfmtRunner from "./shfmt.js";
-import factRulesRunner from "./fact-rules.js";
-import htmlhintRunner from "./htmlhint.js";
-import hadolintRunner from "./hadolint.js";
-import phpLintRunner from "./php-lint.js";
-import psScriptAnalyzerRunner from "./psscriptanalyzer.js";
-import prismaValidateRunner from "./prisma-validate.js";
-import ktlintRunner from "./ktlint.js";
-import tflintRunner from "./tflint.js";
-import taploRunner from "./taplo.js";
-import dartAnalyzeRunner from "./dart-analyze.js";
-import javacRunner from "./javac.js";
-import dotnetBuildRunner from "./dotnet-build.js";
+import yamllintRunner from "./yamllint.js";
 import zigCheckRunner from "./zig-check.js";
-import gleamCheckRunner from "./gleam-check.js";
-import credoRunner from "./credo.js";
-import elixirCheckRunner from "./elixir-check.js";
-import cppCheckRunner from "./cpp-check.js";
-import prettierCheckRunner from "./prettier-check.js";
-import phpstanRunner from "./phpstan.js";
 
 export function registerDefaultRunners(registry: RunnerRegistry): void {
 	// Register all runners (ordered by priority)

package/clients/dispatch/runners/python-slop.ts

@@ -10,15 +10,14 @@
  * Based on slop-code-bench: https://github.com/SprocketLab/slop-code-bench
  */
 
-import { spawnSync } from "node:child_process";
 import { safeSpawn } from "../../safe-spawn.js";
+import { PRIORITY } from "../priorities.js";
 import type {
 	Diagnostic,
 	DispatchContext,
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
-import { PRIORITY } from "../priorities.js";
 import {
 	createConfigFinder,
 	getSgCommand,

package/clients/dispatch/runners/similarity.ts

@@ -9,21 +9,21 @@ import * as nodeFs from "node:fs";
 import * as fs from "node:fs/promises";
 import * as path from "node:path";
 import { NativeRustCoreClient } from "../../native-rust-client.js";
-import { collectSourceFiles } from "../../source-filter.js";
 import {
 	buildProjectIndex,
 	findSimilarFunctions,
 	loadIndex,
 	type ProjectIndex,
 } from "../../project-index.js";
+import { collectSourceFiles } from "../../source-filter.js";
 import { buildStateMatrix, countTransitions } from "../../state-matrix.js";
+import { PRIORITY } from "../priorities.js";
 import type {
 	Diagnostic,
 	DispatchContext,
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
-import { PRIORITY } from "../priorities.js";
 
 // Singleton Rust client — initialised once, reused across runner invocations.
 const rustClient = new NativeRustCoreClient();
@@ -45,7 +45,7 @@ const USE_RUST = true;
 // ============================================================================
 
 const CONFIG = {
-	SIMILARITY_THRESHOLD: 0.96, // align with booboo: stricter to reduce boilerplate false positives
+	SIMILARITY_THRESHOLD: 0.98, // align with booboo: stricter to reduce boilerplate false positives
 	MIN_TRANSITIONS: 40, // stronger signal floor for structural comparisons
 	MIN_FUNCTION_LINES: 8, // Ignore tiny helpers/wrappers
 	MIN_FILE_CHARS: 140, // Skip tiny/trivial files early
@@ -82,19 +82,24 @@ const GENERIC_NAME_TOKENS = new Set([
 export function tokenizeFunctionName(name: string): string[] {
 	return name
 		.replace(/([a-z0-9])([A-Z])/g, "$1 $2")
-		.replace(/[_\-]+/g, " ")
+		.replace(/[_-]+/g, " ")
 		.toLowerCase()
 		.split(/\s+/)
 		.filter((t) => t.length >= 3);
 }
 
-export function hasMeaningfulNameOverlap(sourceName: string, targetName: string): boolean {
+export function hasMeaningfulNameOverlap(
+	sourceName: string,
+	targetName: string,
+): boolean {
 	const source = new Set(tokenizeFunctionName(sourceName));
 	const target = new Set(tokenizeFunctionName(targetName));
 	const shared = [...source].filter((token) => target.has(token));
 	if (shared.length === 0) return false;
 
-	const specificShared = shared.filter((token) => !GENERIC_NAME_TOKENS.has(token));
+	const specificShared = shared.filter(
+		(token) => !GENERIC_NAME_TOKENS.has(token),
+	);
 	if (specificShared.length > 0) return true;
 
 	// Fallback: allow overlap if there are at least two shared generic tokens.
@@ -127,7 +132,9 @@ const similarityRunner: RunnerDefinition = {
 
 		const lineCount = content.split(/\r?\n/).length;
 		if (lineCount > CONFIG.MAX_FILE_LINES) {
-			console.error(`[runner:similarity] skipped ${filePath} — file exceeds ${CONFIG.MAX_FILE_LINES} lines (${lineCount} lines)`);
+			console.error(
+				`[runner:similarity] skipped ${filePath} — file exceeds ${CONFIG.MAX_FILE_LINES} lines (${lineCount} lines)`,
+			);
 			return { status: "skipped", diagnostics: [], semantic: "none" };
 		}
 		if (
@@ -212,8 +219,14 @@ const similarityRunner: RunnerDefinition = {
 					continue;
 				}
 
-				const maxTransitions = Math.max(func.transitionCount, match.targetTransitionCount);
-				const minTransitions = Math.min(func.transitionCount, match.targetTransitionCount);
+				const maxTransitions = Math.max(
+					func.transitionCount,
+					match.targetTransitionCount,
+				);
+				const minTransitions = Math.min(
+					func.transitionCount,
+					match.targetTransitionCount,
+				);
 				if (minTransitions <= 0) continue;
 				if (maxTransitions / minTransitions > CONFIG.MAX_TRANSITION_RATIO) {
 					continue;
@@ -343,7 +356,10 @@ function extractArrowFunctions(
 		}
 
 		const func = decl.initializer;
-		if (!tsModule.isArrowFunction(func) && !tsModule.isFunctionExpression(func)) {
+		if (
+			!tsModule.isArrowFunction(func) &&
+			!tsModule.isFunctionExpression(func)
+		) {
 			continue;
 		}
 
@@ -470,44 +486,46 @@ async function runWithRust(
 	const diagnostics: Diagnostic[] = [];
 	const seenTargets = new Map<string, number>();
 	for (const m of matches.slice(0, maxSuggestions)) {
-			const similarityPct = Math.round(m.similarity * 100);
-			// source_id / target_id format: "path/to/file.ts::funcName@line"
-			const parseId = (id: string): { file: string; name: string; line: number } => {
-				const m = id.match(/^(.*)::([^@]+)@(\d+)$/);
-				if (!m) return { file: id, name: "?", line: 1 };
-				return {
-					file: m[1].replace(/\\/g, "/"),
-					name: m[2],
-					line: Number.parseInt(m[3], 10) || 1,
-				};
+		const similarityPct = Math.round(m.similarity * 100);
+		// source_id / target_id format: "path/to/file.ts::funcName@line"
+		const parseId = (
+			id: string,
+		): { file: string; name: string; line: number } => {
+			const m = id.match(/^(.*)::([^@]+)@(\d+)$/);
+			if (!m) return { file: id, name: "?", line: 1 };
+			return {
+				file: m[1].replace(/\\/g, "/"),
+				name: m[2],
+				line: Number.parseInt(m[3], 10) || 1,
 			};
-			const source = parseId(m.source_id);
-			const target = parseId(m.target_id);
-			if (!hasMeaningfulNameOverlap(source.name, target.name)) {
-				continue;
-			}
-			const targetKey = `${target.name}@${target.file}:${target.line}`;
-			const seenForTarget = seenTargets.get(targetKey) ?? 0;
-			if (seenForTarget >= CONFIG.MAX_PER_TARGET_NAME) {
-				continue;
-			}
-			seenTargets.set(targetKey, seenForTarget + 1);
-			const resolvedTarget = path.isAbsolute(target.file)
-				? target.file
-				: path.join(projectRoot, target.file);
-			if (!nodeFs.existsSync(resolvedTarget)) {
-				continue;
-			}
-			diagnostics.push({
-				id: `similarity-rust-${m.source_id}-${m.target_id}`,
-				tool: "similarity",
-				filePath,
-				line: source.line,
-				column: 1,
-				message: `Function '${source.name}' has ${similarityPct}% similarity to '${target.name}()' at ${target.file}:${target.line}. Consider reusing it if behavior is equivalent.`,
-				severity: "warning" as const,
-				semantic: "warning" as const,
-			});
+		};
+		const source = parseId(m.source_id);
+		const target = parseId(m.target_id);
+		if (!hasMeaningfulNameOverlap(source.name, target.name)) {
+			continue;
+		}
+		const targetKey = `${target.name}@${target.file}:${target.line}`;
+		const seenForTarget = seenTargets.get(targetKey) ?? 0;
+		if (seenForTarget >= CONFIG.MAX_PER_TARGET_NAME) {
+			continue;
+		}
+		seenTargets.set(targetKey, seenForTarget + 1);
+		const resolvedTarget = path.isAbsolute(target.file)
+			? target.file
+			: path.join(projectRoot, target.file);
+		if (!nodeFs.existsSync(resolvedTarget)) {
+			continue;
+		}
+		diagnostics.push({
+			id: `similarity-rust-${m.source_id}-${m.target_id}`,
+			tool: "similarity",
+			filePath,
+			line: source.line,
+			column: 1,
+			message: `Function '${source.name}' has ${similarityPct}% similarity to '${target.name}()' at ${target.file}:${target.line}. Consider reusing it if behavior is equivalent.`,
+			severity: "warning" as const,
+			semantic: "warning" as const,
+		});
 	}
 
 	return {
@@ -574,7 +592,9 @@ async function loadOrBuildIndex(
 	return index;
 }
 
-async function loadCachedIndex(projectRoot: string): Promise<ProjectIndex | null> {
+async function loadCachedIndex(
+	projectRoot: string,
+): Promise<ProjectIndex | null> {
 	const cached = indexCache.get(projectRoot);
 	if (cached) {
 		return cached;