pi-lens 3.8.25 → 3.8.26

package/CHANGELOG.md

@@ -4,6 +4,11 @@ All notable changes to pi-lens will be documented in this file.
 
 ## [Unreleased]
 
+## [3.8.26] - 2026-04-15
+
+### Fixed
+- **Silent crash on unhandled promise rejection** — the LSP crash guard's `unhandledRejection` handler was swallowing all non-ignorable rejections without rethrowing, causing silent process exits. The handler now rethrows so non-ignorable rejections surface as `uncaughtException` and are properly reported. Triggered most visibly when editing JSON files while Biome or another LSP server was active.
+
 ## [3.8.25] - 2026-04-13
 
 ### Changed

package/clients/dispatch/runners/architect.ts

@@ -47,7 +47,11 @@ const architectRunner: RunnerDefinition = {
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
 		const relPath = path.relative(ctx.cwd, ctx.filePath).replace(/\\/g, "/");
-		const content = readFileContent(ctx.filePath);
+		const contentFromFacts = ctx.facts.getFileFact<string | null>(
+			ctx.filePath,
+			"file.content",
+		);
+		const content = contentFromFacts ?? readFileContent(ctx.filePath);
 
 		if (!content) {
 			return { status: "skipped", diagnostics: [], semantic: "none" };

package/clients/dispatch/runners/ast-grep-napi.ts

@@ -423,10 +423,18 @@ const astGrepNapiRunner: RunnerDefinition = {
 		}
 
 		let content: string;
-		try {
-			content = fs.readFileSync(ctx.filePath, "utf-8");
-		} catch {
-			return { status: "skipped", diagnostics: [], semantic: "none" };
+		const contentFromFacts = ctx.facts.getFileFact<string | null>(
+			ctx.filePath,
+			"file.content",
+		);
+		if (contentFromFacts !== undefined && contentFromFacts !== null) {
+			content = contentFromFacts;
+		} else {
+			try {
+				content = fs.readFileSync(ctx.filePath, "utf-8");
+			} catch {
+				return { status: "skipped", diagnostics: [], semantic: "none" };
+			}
 		}
 
 		let root: import("@ast-grep/napi").SgRoot;

package/clients/dispatch/runners/tree-sitter.ts

@@ -519,13 +519,27 @@ const treeSitterRunner: RunnerDefinition = {
 		});
 
 		const diagnostics: Diagnostic[] = [];
+		const contentFromFacts = ctx.facts.getFileFact<string | null>(
+			filePath,
+			"file.content",
+		);
+		const contentOverride =
+			contentFromFacts !== undefined && contentFromFacts !== null
+				? contentFromFacts
+				: undefined;
 
 		// Run each query against the file
 		for (const query of effectiveQueries) {
 			try {
-				const matches = await client.runQueryOnFile(query, filePath, languageId, {
-					maxResults: 10,
-				});
+				const matches = await client.runQueryOnFile(
+					query,
+					filePath,
+					languageId,
+					{
+						maxResults: 10,
+					},
+					contentOverride,
+				);
 
 				for (const match of matches) {
 					// Get line/column from match (already 0-indexed from tree-sitter)

package/clients/lsp/client.ts

@@ -271,6 +271,7 @@ function installCrashGuard(): void {
 		if (isIgnorableLspRuntimeCrash(reason)) {
 			return;
 		}
+		throw reason instanceof Error ? reason : new Error(String(reason));
 	});
 }
 

package/clients/lsp/index.ts

@@ -31,6 +31,20 @@ export interface LSPState {
 }
 
 const BROKEN_RETRY_COOLDOWN_MS = 15_000;
+const OPTIONAL_LSP_RETRY_COOLDOWN_MS = 5 * 60_000;
+const OPTIONAL_LSP_SERVER_IDS = new Set(["biome-lsp"]);
+const NAV_CLIENT_WAIT_TIMEOUT_MS = Math.max(
+	0,
+	Number.parseInt(
+		process.env.PI_LENS_LSP_NAV_CLIENT_WAIT_MS ?? "700",
+		10,
+	) || 700,
+);
+const TOUCH_DEBOUNCE_MS = Math.max(
+	0,
+	Number.parseInt(process.env.PI_LENS_LSP_TOUCH_DEBOUNCE_MS ?? "1500", 10) ||
+		1500,
+);
 const SESSIONSTART_LOG_DIR = path.join(os.homedir(), ".pi-lens");
 const SESSIONSTART_LOG = path.join(SESSIONSTART_LOG_DIR, "sessionstart.log");
 
@@ -57,6 +71,12 @@ export class LSPService {
 	private workspaceProbeLogged = new Set<string>();
 	private warmStartLogged = new Set<string>();
 	private emitConsoleLspErrors = process.env.PI_LENS_CONSOLE_LSP === "1";
+	private optionalFailureLogged = new Set<string>();
+	private optionalDisabled = new Set<string>();
+	private recentTouches = new Map<
+		string,
+		{ fingerprint: string; touchedAt: number; clientScope: "primary" | "all" }
+	>();
 
 	constructor() {
 		this.state = {
@@ -67,11 +87,57 @@ export class LSPService {
 		};
 	}
 
+	private fingerprintContent(content: string): string {
+		if (content.length <= 96) {
+			return `${content.length}:${content}`;
+		}
+		return `${content.length}:${content.slice(0, 48)}:${content.slice(-48)}`;
+	}
+
+	private shouldSkipTouch(
+		filePath: string,
+		content: string,
+		clientScope: "primary" | "all",
+		waitForDiagnostics: boolean,
+	): boolean {
+		if (waitForDiagnostics || TOUCH_DEBOUNCE_MS <= 0) {
+			return false;
+		}
+
+		const key = `${normalizeMapKey(filePath)}:${clientScope}`;
+		const previous = this.recentTouches.get(key);
+		if (!previous) return false;
+
+		const now = Date.now();
+		if (now - previous.touchedAt > TOUCH_DEBOUNCE_MS) {
+			return false;
+		}
+
+		return previous.fingerprint === this.fingerprintContent(content);
+	}
+
+	private markTouched(
+		filePath: string,
+		content: string,
+		clientScope: "primary" | "all",
+	): void {
+		const key = `${normalizeMapKey(filePath)}:${clientScope}`;
+		this.recentTouches.set(key, {
+			fingerprint: this.fingerprintContent(content),
+			touchedAt: Date.now(),
+			clientScope,
+		});
+	}
+
 	/**
 	 * Get or create LSP client for a file
 	 * Prevents duplicate client creation via in-flight promise tracking
 	 */
-	async getClientForFile(filePath: string): Promise<SpawnedServer | undefined> {
+	async getClientForFile(
+		filePath: string,
+		maxWaitMs?: number,
+	): Promise<SpawnedServer | undefined> {
+		const withBudget = async (): Promise<SpawnedServer | undefined> => {
 		const servers = getServersForFileWithConfig(filePath);
 		if (servers.length === 0) return undefined;
 
@@ -105,6 +171,32 @@ export class LSPService {
 		});
 
 		return undefined;
+		};
+
+		if (!maxWaitMs || maxWaitMs <= 0) {
+			return withBudget();
+		}
+
+		const timeoutResult = await Promise.race<SpawnedServer | undefined>([
+			withBudget(),
+			new Promise<undefined>((resolve) =>
+				setTimeout(() => resolve(undefined), maxWaitMs),
+			),
+		]);
+
+		if (!timeoutResult) {
+			logLatency({
+				type: "phase",
+				phase: "lsp_client_wait_timeout",
+				filePath,
+				durationMs: maxWaitMs,
+				metadata: {
+					maxWaitMs,
+				},
+			});
+		}
+
+		return timeoutResult;
 	}
 
 	/**
@@ -131,6 +223,11 @@ export class LSPService {
 
 		const normalizedRoot = normalizeMapKey(root);
 		const key = `${server.id}:${normalizedRoot}`;
+		const isOptionalServer = OPTIONAL_LSP_SERVER_IDS.has(server.id);
+
+		if (isOptionalServer && this.optionalDisabled.has(key)) {
+			return undefined;
+		}
 
 		const existing = this.state.clients.get(key);
 		if (existing) {
@@ -228,6 +325,7 @@ export class LSPService {
 		filePath: string,
 		allowInstall: boolean,
 	): Promise<SpawnedServer | undefined> {
+		const isOptionalServer = OPTIONAL_LSP_SERVER_IDS.has(server.id);
 		const startedAt = Date.now();
 		logSessionStart(
 			`lsp spawn ${server.id}: start root=${root} policy=${server.installPolicy ?? "unknown"} install=${allowInstall ? "enabled" : "disabled"} file=${filePath}`,
@@ -258,6 +356,10 @@ export class LSPService {
 					};
 
 			this.state.clients.set(key, client);
+			if (isOptionalServer) {
+				this.optionalDisabled.delete(key);
+				this.optionalFailureLogged.delete(key);
+			}
 			logSessionStart(
 				`lsp spawn ${server.id}: success source=${spawned.source ?? server.installPolicy ?? "unknown"} (${Date.now() - startedAt}ms)`,
 			);
@@ -269,11 +371,16 @@ export class LSPService {
 			}
 			return { client, info: server };
 		} catch (err) {
-			logSessionStart(
-				`lsp spawn ${server.id}: failed (${Date.now() - startedAt}ms) error=${err instanceof Error ? err.message : String(err)}`,
-			);
+			if (!isOptionalServer || !this.optionalFailureLogged.has(key)) {
+				logSessionStart(
+					`lsp spawn ${server.id}: failed (${Date.now() - startedAt}ms) error=${err instanceof Error ? err.message : String(err)}`,
+				);
+				if (isOptionalServer) {
+					this.optionalFailureLogged.add(key);
+				}
+			}
 			const errorMsg = err instanceof Error ? err.message : String(err);
-			if (this.emitConsoleLspErrors) {
+			if (this.emitConsoleLspErrors && !isOptionalServer) {
 				if (errorMsg.includes("Timeout")) {
 					console.error(
 						`[lsp] ${server.id} timed out during initialization (${errorMsg}). The server may be downloading or the project is large. Skipping.`,
@@ -290,7 +397,13 @@ export class LSPService {
 					console.error(`[lsp] Failed to spawn ${server.id}:`, err);
 				}
 			}
-			this.state.broken.set(key, Date.now() + BROKEN_RETRY_COOLDOWN_MS);
+			this.state.broken.set(
+				key,
+				Date.now() + (isOptionalServer ? OPTIONAL_LSP_RETRY_COOLDOWN_MS : BROKEN_RETRY_COOLDOWN_MS),
+			);
+			if (isOptionalServer) {
+				this.optionalDisabled.add(key);
+			}
 			return undefined;
 		}
 	}
@@ -326,12 +439,14 @@ export class LSPService {
 		waitForDiagnostics = false,
 		source = "unknown",
 		useAllClients = false,
+		maxClientWaitMs?: number,
 	): Promise<void> {
 		const startedAt = Date.now();
 		const normalizedPath = normalizeMapKey(filePath);
+		const clientScope = useAllClients ? "all" : "primary";
 		const spawned = useAllClients
 			? await this.getClientsForFile(filePath)
-			: await this.getClientForFile(filePath).then((entry) =>
+			: await this.getClientForFile(filePath, maxClientWaitMs).then((entry) =>
 					entry ? [entry] : [],
 				);
 		if (spawned.length === 0) {
@@ -342,13 +457,32 @@ export class LSPService {
 				durationMs: Date.now() - startedAt,
 			metadata: {
 				serverCountReady: 0,
-				clientScope: useAllClients ? "all" : "primary",
+				clientScope,
 				failureKind: "no_clients",
 			},
 			});
 			return;
 		}
 
+		if (this.shouldSkipTouch(filePath, content, clientScope, waitForDiagnostics)) {
+			logLatency({
+				type: "phase",
+				phase: "lsp_touch_file",
+				filePath: normalizedPath,
+				durationMs: Date.now() - startedAt,
+				metadata: {
+					serverCountReady: spawned.length,
+					clientScope,
+					waitForDiagnostics,
+					source,
+					failureKind: "success",
+					skipped: true,
+					reason: "debounced_unchanged_content",
+				},
+			});
+			return;
+		}
+
 		const languageId = getLanguageId(filePath) ?? "plaintext";
 		await Promise.all(
 			spawned.map((entry) => entry.client.notify.open(filePath, content, languageId)),
@@ -362,6 +496,8 @@ export class LSPService {
 			);
 		}
 
+		this.markTouched(filePath, content, clientScope);
+
 		logLatency({
 			type: "phase",
 			phase: "lsp_touch_file",
@@ -369,7 +505,7 @@ export class LSPService {
 			durationMs: Date.now() - startedAt,
 			metadata: {
 				serverCountReady: spawned.length,
-				clientScope: useAllClients ? "all" : "primary",
+				clientScope,
 				waitForDiagnostics,
 				source,
 				failureKind: "success",
@@ -471,7 +607,10 @@ export class LSPService {
 	 * Navigation: go to definition
 	 */
 	async definition(filePath: string, line: number, character: number) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return [];
 		return spawned.client.definition(filePath, line, character);
 	}
@@ -485,7 +624,10 @@ export class LSPService {
 		character: number,
 		includeDeclaration = true,
 	) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return [];
 		return spawned.client.references(
 			filePath,
@@ -499,7 +641,10 @@ export class LSPService {
 	 * Navigation: hover info
 	 */
 	async hover(filePath: string, line: number, character: number) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return null;
 		return spawned.client.hover(filePath, line, character);
 	}
@@ -508,7 +653,10 @@ export class LSPService {
 	 * Navigation: signature help at cursor position
 	 */
 	async signatureHelp(filePath: string, line: number, character: number) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return null;
 		return spawned.client.signatureHelp(filePath, line, character);
 	}
@@ -517,7 +665,10 @@ export class LSPService {
 	 * Navigation: symbols in document
 	 */
 	async documentSymbol(filePath: string) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return [];
 		return spawned.client.documentSymbol(filePath);
 	}
@@ -527,7 +678,10 @@ export class LSPService {
 	 */
 	async workspaceSymbol(query: string, filePath?: string) {
 		if (filePath) {
-			const spawned = await this.getClientForFile(filePath);
+			const spawned = await this.getClientForFile(
+				filePath,
+				NAV_CLIENT_WAIT_TIMEOUT_MS,
+			);
 			if (!spawned) return [];
 			return spawned.client.workspaceSymbol(query);
 		}
@@ -592,7 +746,10 @@ export class LSPService {
 		endLine: number,
 		endCharacter: number,
 	) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return [];
 		return spawned.client.codeAction(
 			filePath,
@@ -612,7 +769,10 @@ export class LSPService {
 		character: number,
 		newName: string,
 	) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return null;
 		return spawned.client.rename(filePath, line, character, newName);
 	}
@@ -621,7 +781,10 @@ export class LSPService {
 	 * Navigation: go to implementation
 	 */
 	async implementation(filePath: string, line: number, character: number) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return [];
 		return spawned.client.implementation(filePath, line, character);
 	}
@@ -634,7 +797,10 @@ export class LSPService {
 		line: number,
 		character: number,
 	) {
-		const spawned = await this.getClientForFile(filePath);
+		const spawned = await this.getClientForFile(
+			filePath,
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return [];
 		return spawned.client.prepareCallHierarchy(filePath, line, character);
 	}
@@ -643,7 +809,10 @@ export class LSPService {
 	 * Navigation: find incoming calls (callers)
 	 */
 	async incomingCalls(item: import("./client.js").LSPCallHierarchyItem) {
-		const spawned = await this.getClientForFile(uriToPath(item.uri));
+		const spawned = await this.getClientForFile(
+			uriToPath(item.uri),
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return [];
 		return spawned.client.incomingCalls(item);
 	}
@@ -652,7 +821,10 @@ export class LSPService {
 	 * Navigation: find outgoing calls (callees)
 	 */
 	async outgoingCalls(item: import("./client.js").LSPCallHierarchyItem) {
-		const spawned = await this.getClientForFile(uriToPath(item.uri));
+		const spawned = await this.getClientForFile(
+			uriToPath(item.uri),
+			NAV_CLIENT_WAIT_TIMEOUT_MS,
+		);
 		if (!spawned) return [];
 		return spawned.client.outgoingCalls(item);
 	}

package/clients/lsp/server.ts

@@ -124,23 +124,35 @@ async function launchWithDirectOrPackageManager(
 	args: string[],
 	options: { cwd: string; env?: NodeJS.ProcessEnv; allowInstall?: boolean },
 ): Promise<{ process: LSPProcess; source: "direct" | "package-manager" } | undefined> {
+	let lastDirectError: unknown;
+
 	for (const command of directCommands) {
 		try {
 			const process = await launchLSP(command, args, options);
 			return { process, source: "direct" };
 		} catch (error) {
-			if (!isCommandNotFoundError(error)) {
-				throw error;
-			}
+			lastDirectError = error;
 		}
 	}
 
-	const process = await launchViaPackageManagerWithPolicy(packageName, args, {
-		cwd: options.cwd,
-		allowInstall: options.allowInstall,
-	});
-	if (!process) return undefined;
-	return { process, source: "package-manager" };
+	try {
+		const process = await launchViaPackageManagerWithPolicy(packageName, args, {
+			cwd: options.cwd,
+			allowInstall: options.allowInstall,
+		});
+		if (!process) {
+			if (lastDirectError && !isCommandNotFoundError(lastDirectError)) {
+				throw lastDirectError;
+			}
+			return undefined;
+		}
+		return { process, source: "package-manager" };
+	} catch (packageManagerError) {
+		if (lastDirectError && !isCommandNotFoundError(lastDirectError)) {
+			throw lastDirectError;
+		}
+		throw packageManagerError;
+	}
 }
 
 type InitializationConfig = Record<string, unknown>;

package/clients/tree-sitter-client.ts

@@ -283,6 +283,7 @@ export class TreeSitterClient {
 	async parseFile(
 		filePath: string,
 		languageId: string,
+		contentOverride?: string,
 	): Promise<TreeSitterTree | null> {
 		this.dbg(`Parsing ${filePath} with language ${languageId}`);
 		const parser = await this.getParser(languageId);
@@ -292,7 +293,7 @@ export class TreeSitterClient {
 		}
 
 		try {
-			const content = fs.readFileSync(filePath, "utf-8");
+			const content = contentOverride ?? fs.readFileSync(filePath, "utf-8");
 			this.dbg(`File content length: ${content.length}`);
 
 			// Check cache first
@@ -469,6 +470,7 @@ export class TreeSitterClient {
 		filePath: string,
 		languageId: string,
 		options: { maxResults?: number } = {},
+		contentOverride?: string,
 	): Promise<StructuralMatch[]> {
 		if (!this.initialized) {
 			const ok = await this.init();
@@ -493,6 +495,7 @@ export class TreeSitterClient {
 			queryDef.id,
 			compiled.postFilter,
 			compiled.postFilterParams,
+			contentOverride,
 		);
 
 		const maxResults = options.maxResults ?? 50;
@@ -727,8 +730,9 @@ export class TreeSitterClient {
 		postFilter?: string,
 		// biome-ignore lint/suspicious/noExplicitAny: Post filter params
 		postFilterParams?: any,
+		contentOverride?: string,
 	): Promise<StructuralMatch[]> {
-		const tree = await this.parseFile(filePath, languageId);
+		const tree = await this.parseFile(filePath, languageId, contentOverride);
 		if (!tree) return [];
 
 		const matches: StructuralMatch[] = [];

package/index.ts

@@ -59,6 +59,11 @@ function dbg(msg: string) {
 let _verbose = false;
 const runtime = new RuntimeCoordinator();
 const _lspConfigInitializedCwds = new Set<string>();
+const LSP_TOOLCALL_NAV_TOUCH_BUDGET_MS = Math.max(
+	0,
+	Number.parseInt(process.env.PI_LENS_TOOLCALL_NAV_TOUCH_MS ?? "700", 10) ||
+		700,
+);
 
 function log(msg: string) {
 	if (_verbose) console.error(`[pi-lens] ${msg}`);
@@ -576,8 +581,17 @@ pi.on("tool_call", async (event, ctx) => {
 	if (shouldAutoTouch) {
 		try {
 			const fileContent = nodeFs.readFileSync(filePath, "utf-8");
+			const maxClientWaitMs =
+				toolName === "lsp_navigation" ? LSP_TOOLCALL_NAV_TOUCH_BUDGET_MS : undefined;
 			void getLSPService()
-				.touchFile(filePath, fileContent, false, `tool_call:${toolName}`)
+				.touchFile(
+					filePath,
+					fileContent,
+					false,
+					`tool_call:${toolName}`,
+					false,
+					maxClientWaitMs,
+				)
 				.catch((err) => dbg(`lsp auto-touch failed for ${filePath}: ${err}`));
 		} catch {
 			// Best effort only; never block tool calls.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "3.8.25",
+	"version": "3.8.26",
 	"type": "module",
 	"description": "Real-time code feedback for pi — LSP, linters, formatters, type-checking, structural analysis & booboo",
 	"repository": {