pi-lens 3.8.24 → 3.8.25

package/CHANGELOG.md

@@ -4,6 +4,15 @@ All notable changes to pi-lens will be documented in this file.
 
 ## [Unreleased]
 
+## [3.8.25] - 2026-04-13
+
+### Changed
+- **Go LSP PATH augmentation on Windows** — LSP subprocess PATH now includes common Go install directories (`C:\Program Files\Go\bin`, `C:\Go\bin`) to prevent `gopls` startup/runtime failures when `go` is not in inherited shell PATH.
+- **Similarity runner cold-start behavior** — similarity now skips fast when no cached project index exists and for tiny/trivial files, reducing write/edit pipeline tail latency and eliminating frequent 30s timeout noise in scratch-file workflows.
+
+### Fixed
+- **Non-git workspace commit lookup noise** — metrics snapshot commit detection now pre-checks repository context before invoking Git, preventing `fatal: not a git repository` terminal noise in non-repo folders.
+
 ## [3.8.24] - 2026-04-12
 
 ### Changed

package/clients/dispatch/runners/similarity.ts

@@ -9,8 +9,8 @@ import * as nodeFs from "node:fs";
 import * as fs from "node:fs/promises";
 import * as path from "node:path";
 import * as ts from "typescript";
-import { EXCLUDED_DIRS } from "../../file-utils.js";
 import { NativeRustCoreClient } from "../../native-rust-client.js";
+import { collectSourceFiles } from "../../source-filter.js";
 import {
 	buildProjectIndex,
 	findSimilarFunctions,
@@ -40,6 +40,7 @@ const CONFIG = {
 	SIMILARITY_THRESHOLD: 0.96, // align with booboo: stricter to reduce boilerplate false positives
 	MIN_TRANSITIONS: 40, // stronger signal floor for structural comparisons
 	MIN_FUNCTION_LINES: 8, // Ignore tiny helpers/wrappers
+	MIN_FILE_CHARS: 140, // Skip tiny/trivial files early
 	MAX_TRANSITION_RATIO: 1.8, // Skip pairs with highly mismatched complexity/size
 	MAX_SUGGESTIONS: 3, // Max 3 suggestions per file
 	MAX_PER_TARGET_NAME: 1, // Avoid one-to-many spam for the same target utility
@@ -115,12 +116,26 @@ const similarityRunner: RunnerDefinition = {
 			return { status: "skipped", diagnostics: [], semantic: "none" };
 		}
 
+		const lineCount = content.split(/\r?\n/).length;
+		if (
+			content.trim().length < CONFIG.MIN_FILE_CHARS ||
+			lineCount < CONFIG.MIN_FUNCTION_LINES + 2 ||
+			!/(\bfunction\b|=>)/.test(content)
+		) {
+			return { status: "skipped", diagnostics: [], semantic: "none" };
+		}
+
 		// Find project root and load index
 		const projectRoot = await findProjectRoot(filePath);
 		if (!projectRoot) {
 			return { status: "skipped", diagnostics: [], semantic: "none" };
 		}
 
+		const cachedIndex = await loadCachedIndex(projectRoot);
+		if (!cachedIndex || cachedIndex.entries.size === 0) {
+			return { status: "skipped", diagnostics: [], semantic: "none" };
+		}
+
 		// ── Rust fast-path ─────────────────────────────────────────────────────
 		// Try Rust for file scanning + similarity detection. If the Rust binary
 		// is available, use it. On any failure, fall through to the pure-TS path.
@@ -139,10 +154,7 @@ const similarityRunner: RunnerDefinition = {
 		}
 		// ── TypeScript fallback ─────────────────────────────────────────────────
 
-		const index = await loadOrBuildIndex(projectRoot);
-		if (!index || index.entries.size === 0) {
-			return { status: "skipped", diagnostics: [], semantic: "none" };
-		}
+		const index = cachedIndex;
 
 		// Parse the file
 		const sourceFile = ts.createSourceFile(
@@ -512,30 +524,42 @@ async function loadOrBuildIndex(
 	}
 
 	// Build new index
-	const { glob } = await import("glob");
-	// Build ignore patterns from centralized EXCLUDED_DIRS
-	const ignorePatterns = [
-		...EXCLUDED_DIRS.map((d) => `**/${d}/**`),
-		"**/*.test.ts",
-		"**/*.spec.ts",
-		"**/*.poc.test.ts",
-	];
-	const files = await glob("**/*.ts", {
-		cwd: projectRoot,
-		ignore: ignorePatterns,
+	const absoluteFiles = collectSourceFiles(projectRoot, {
+		extensions: [".ts"],
+	}).filter((filePath) => {
+		const normalized = filePath.replace(/\\/g, "/");
+		return (
+			!normalized.endsWith(".test.ts") &&
+			!normalized.endsWith(".spec.ts") &&
+			!normalized.endsWith(".poc.test.ts")
+		);
 	});
 
-	if (files.length === 0) {
+	if (absoluteFiles.length === 0) {
 		return null;
 	}
 
-	const absoluteFiles = files.map((f) => path.join(projectRoot, f));
 	const index = await buildProjectIndex(projectRoot, absoluteFiles);
 
 	indexCache.set(projectRoot, index);
 	return index;
 }
 
+async function loadCachedIndex(projectRoot: string): Promise<ProjectIndex | null> {
+	const cached = indexCache.get(projectRoot);
+	if (cached) {
+		return cached;
+	}
+
+	const existing = await loadIndex(projectRoot);
+	if (!existing) {
+		return null;
+	}
+
+	indexCache.set(projectRoot, existing);
+	return existing;
+}
+
 // ============================================================================
 // Testing Helper
 // ============================================================================

package/clients/lsp/launch.ts

@@ -35,6 +35,8 @@ function buildAugmentedPath(basePath?: string): string {
 		candidates.push(path.join(userProfile, ".cargo", "bin"));
 		candidates.push(path.join(userProfile, "go", "bin"));
 	}
+	candidates.push(path.join("C:\\", "Program Files", "Go", "bin"));
+	candidates.push(path.join("C:\\", "Go", "bin"));
 	candidates.push(path.join("C:\\", "Ruby34-x64", "bin"));
 	candidates.push(path.join("C:\\", "Ruby33-x64", "bin"));
 

package/clients/metrics-history.ts

@@ -45,10 +45,30 @@ const MAX_HISTORY_PER_FILE = 20;
 
 // --- Git Helpers ---
 
+/**
+ * Check whether cwd is inside a Git worktree.
+ */
+function isInsideGitRepo(startDir: string): boolean {
+	let dir = path.resolve(startDir);
+	while (true) {
+		if (fs.existsSync(path.join(dir, ".git"))) {
+			return true;
+		}
+		const parent = path.dirname(dir);
+		if (parent === dir) break;
+		dir = parent;
+	}
+	return false;
+}
+
 /**
  * Get current git commit hash (short)
  */
 function getCurrentCommit(): string {
+	if (!isInsideGitRepo(process.cwd())) {
+		return "unknown";
+	}
+
 	try {
 		return execSync("git rev-parse --short HEAD", {
 			encoding: "utf-8",

package/clients/runtime-session.ts

@@ -10,13 +10,13 @@ import { getKnipIgnorePatterns } from "./file-utils.js";
 import type { GoClient } from "./go-client.js";
 import type { JscpdClient } from "./jscpd-client.js";
 import type { KnipClient } from "./knip-client.js";
+import { canRunStartupHeavyScans } from "./language-policy.js";
 import {
 	detectProjectLanguageProfile,
 	getDefaultStartupTools,
 	hasLanguage,
 	isLanguageConfigured,
 } from "./language-profile.js";
-import { canRunStartupHeavyScans } from "./language-policy.js";
 import type { MetricsClient } from "./metrics-client.js";
 import {
 	buildProjectIndex,
@@ -64,7 +64,10 @@ interface SessionStartDeps {
 
 type StartupMode = "full" | "minimal" | "quick";
 
-function isCommandAvailable(command: string, args: string[] = ["--version"]): boolean {
+function isCommandAvailable(
+	command: string,
+	args: string[] = ["--version"],
+): boolean {
 	const result = safeSpawn(command, args, { timeout: 5000 });
 	return !result.error && result.status === 0;
 }
@@ -97,7 +100,9 @@ function getLanguageInstallHints(
 	};
 
 	if (hasStrongSignal("go") && !isCommandAvailable("gopls")) {
-		hints.push("Go detected: install gopls (`go install golang.org/x/tools/gopls@latest`).");
+		hints.push(
+			"Go detected: install gopls (`go install golang.org/x/tools/gopls@latest`).",
+		);
 	}
 	if (hasStrongSignal("rust") && !isCommandAvailable("rust-analyzer")) {
 		hints.push(
@@ -174,6 +179,25 @@ export async function handleSessionStart(
 		delete process.env.PI_LENS_DISABLE_LSP_INSTALL;
 	}
 
+	const hasWorkspaceCwd = typeof ctxCwd === "string" && ctxCwd.length > 0;
+	const cwd = ctxCwd ?? process.cwd();
+	if (quickMode) {
+		runtime.projectRoot = cwd;
+		const quickTools: string[] = [];
+		if (getFlag("lens-lsp") && !getFlag("no-lsp")) {
+			quickTools.push("LSP Service");
+		}
+		log(`Active tools: ${quickTools.join(", ")}`);
+		dbg(
+			`session_start tools: ${quickTools.join(", ") || "deferred (quick mode)"}`,
+		);
+		dbg(
+			"session_start: quick mode active - skipping slow tool probes, language profiling, preinstall, scans, and error debt baseline",
+		);
+		dbg(`session_start total: ${Date.now() - sessionStartMs}ms`);
+		return;
+	}
+
 	const tools: string[] = [];
 	if (getFlag("lens-lsp") && !getFlag("no-lsp")) {
 		tools.push("LSP Service");
@@ -200,17 +224,6 @@ export async function handleSessionStart(
 		}
 	}
 
-	const hasWorkspaceCwd = typeof ctxCwd === "string" && ctxCwd.length > 0;
-	const cwd = ctxCwd ?? process.cwd();
-	if (quickMode) {
-		runtime.projectRoot = cwd;
-		dbg(
-			"session_start: quick mode active - skipping language profiling, preinstall, scans, and error debt baseline",
-		);
-		dbg(`session_start total: ${Date.now() - sessionStartMs}ms`);
-		return;
-	}
-
 	const startupScan = resolveStartupScanContext(cwd);
 	const scanRoot = startupScan.projectRoot ?? cwd;
 	const useScanRootForSignals =
@@ -236,18 +249,20 @@ export async function handleSessionStart(
 	}
 
 	const lensLspEnabled = !!getFlag("lens-lsp") && !getFlag("no-lsp");
-	const startupDefaults = getDefaultStartupTools(languageProfile).filter((tool) => {
-		if (
-			(tool === "typescript-language-server" || tool === "pyright") &&
-			!lensLspEnabled
-		) {
-			return false;
-		}
-		if (tool === "ruff" && getFlag("no-autofix-ruff")) {
-			return false;
-		}
-		return true;
-	});
+	const startupDefaults = getDefaultStartupTools(languageProfile).filter(
+		(tool) => {
+			if (
+				(tool === "typescript-language-server" || tool === "pyright") &&
+				!lensLspEnabled
+			) {
+				return false;
+			}
+			if (tool === "ruff" && getFlag("no-autofix-ruff")) {
+				return false;
+			}
+			return true;
+		},
+	);
 
 	if (!allowBootstrapTasks) {
 		dbg("session_start: skipping tool preinstall (startup mode)");
@@ -369,7 +384,9 @@ export async function handleSessionStart(
 		runtime.markStartupScanInFlight(name, sessionGeneration);
 		void task()
 			.then(() => {
-				dbg(`session_start task ${name}: success (${Date.now() - startedAt}ms)`);
+				dbg(
+					`session_start task ${name}: success (${Date.now() - startedAt}ms)`,
+				);
 			})
 			.catch((err) => {
 				dbg(`session_start: ${name} background scan failed: ${err}`);
@@ -391,7 +408,9 @@ export async function handleSessionStart(
 		dbg(
 			`session_start: skipping heavy scans (${startupScan.reason ?? "unknown"})`,
 		);
-		dbg(`session_start: skipping TODO scan (${startupScan.reason ?? "unknown"})`);
+		dbg(
+			`session_start: skipping TODO scan (${startupScan.reason ?? "unknown"})`,
+		);
 	} else {
 		const canRunJsTsHeavyScans = canRunStartupHeavyScans(
 			languageProfile,
@@ -401,9 +420,7 @@ export async function handleSessionStart(
 		if (canRunJsTsHeavyScans) {
 			scanNames.push("knip", "jscpd", "ast-grep exports", "project index");
 		}
-		dbg(
-			`session_start: launching background scans (${scanNames.join(", ")})`,
-		);
+		dbg(`session_start: launching background scans (${scanNames.join(", ")})`);
 
 		runStartupTask("todo", async () => {
 			if (!runtime.isCurrentSession(sessionGeneration)) return;
@@ -458,10 +475,9 @@ export async function handleSessionStart(
 			runStartupTask("jscpd", async () => {
 				if (await jscpdClient.ensureAvailable()) {
 					if (!runtime.isCurrentSession(sessionGeneration)) return;
-					const cached = cacheManager.readCache<ReturnType<JscpdClient["scan"]>>(
-						"jscpd",
-						analysisRoot,
-					);
+					const cached = cacheManager.readCache<
+						ReturnType<JscpdClient["scan"]>
+					>("jscpd", analysisRoot);
 					if (cached) {
 						if (!runtime.isCurrentSession(sessionGeneration)) return;
 						dbg("session_start jscpd: cache hit");
@@ -527,7 +543,9 @@ export async function handleSessionStart(
 						);
 					} else {
 						if (!runtime.isCurrentSession(sessionGeneration)) return;
-						dbg(`session_start: skipped project index (${tsFiles.length} files)`);
+						dbg(
+							`session_start: skipped project index (${tsFiles.length} files)`,
+						);
 					}
 				}
 			});

package/commands/booboo.ts

@@ -369,33 +369,13 @@ export async function handleBooboo(
 	// Runner 3: Semantic similarity
 	await tracker.run("semantic similarity (Amain)", async () => {
 		try {
-			const { glob } = await import("glob");
-			const sourceFiles = await glob("**/*.ts", {
-				cwd: targetPath,
-				ignore: [
-					"**/node_modules/**",
-					"**/*.test.ts",
-					"**/*.test.tsx",
-					"**/*.spec.ts",
-					"**/*.spec.tsx",
-					"**/*.poc.test.ts",
-					"**/*.poc.test.tsx",
-					"**/test-utils.ts",
-					"**/test-*.ts",
-					"**/__tests__/**",
-					"**/tests/**",
-					"**/dist/**",
-				],
-			});
+			const absoluteFiles = collectSourceFiles(targetPath, {
+				extensions: [".ts"],
+			}).filter(shouldIncludeFile);
 
-			if (sourceFiles.length === 0) {
+			if (absoluteFiles.length === 0) {
 				return { findings: 0, status: "done" };
 			}
-
-			// Filter out test files using centralized exclusion
-			const absoluteFiles = sourceFiles
-				.map((f) => path.join(targetPath, f))
-				.filter(shouldIncludeFile);
 			const index = await buildProjectIndex(targetPath, absoluteFiles);
 			const topPairs = findTopSimilarPairs(index, 10);
 

package/index.ts

@@ -13,7 +13,6 @@ import {
 	getLatencyReports,
 	resetDispatchBaselines,
 } from "./clients/dispatch/integration.js";
-import { extractFunctions } from "./clients/dispatch/runners/similarity.js";
 import { resetFormatService } from "./clients/format-service.js";
 import { evaluateGitGuard, isGitCommitOrPushAttempt } from "./clients/git-guard.js";
 import { ensureTool } from "./clients/installer/index.js";
@@ -506,7 +505,8 @@ pi.on("session_start", async (event, ctx) => {
 			testRunnerClient,
 			goClient,
 			rustClient,
-			ensureTool,
+			ensureTool: async (name: string) =>
+				(await import("./clients/installer/index.js")).ensureTool(name),
 			cleanStaleTsBuildInfo,
 			resetDispatchBaselines,
 			resetLSPService,
@@ -594,6 +594,9 @@ pi.on("tool_call", async (event, ctx) => {
 		const baseline = complexityClient.analyzeFile(filePath);
 		if (baseline) {
 			runtime.complexityBaselines.set(filePath, baseline);
+			const { captureSnapshot } = await import(
+				"./clients/metrics-history.js"
+			);
 			captureSnapshot(filePath, {
 				maintainabilityIndex: baseline.maintainabilityIndex,
 				cognitiveComplexity: baseline.cognitiveComplexity,
@@ -659,6 +662,8 @@ pi.on("tool_call", async (event, ctx) => {
 						ts.ScriptTarget.Latest,
 						true,
 					);
+					const { extractFunctions } = await import("./clients/dispatch/runners/similarity.js");
+					const { findSimilarFunctions } = await import("./clients/project-index.js");
 					const newFunctions = extractFunctions(sourceFile, newContent);
 					const simWarnings: string[] = [];
 					let simHintsTruncated = false;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "3.8.24",
+	"version": "3.8.25",
 	"type": "module",
 	"description": "Real-time code feedback for pi — LSP, linters, formatters, type-checking, structural analysis & booboo",
 	"repository": {