pi-lens 3.8.21 → 3.8.23

package/clients/dispatch/rules/placeholder-comments.ts

@@ -0,0 +1,47 @@
+import { isTestFile } from "../../file-utils.js";
+import type { FactRule } from "../fact-provider-types.js";
+import type { CommentSummary } from "../facts/comment-facts.js";
+import type { Diagnostic } from "../types.js";
+
+const PLACEHOLDER_PATTERNS = [
+  /add\s+more\s+validation/i,
+  /handle\s+(additional|more)\s+cases?/i,
+  /can\s+be\s+extended\s+in\s+the\s+future/i,
+  /extend\s+this\s+(logic|function|method|handler|module)/i,
+  /customize\s+this\s+(logic|behavior|function|method|handler)/i,
+  /future\s+enhancement/i,
+  /implement\s+.+\s+here/i,
+];
+
+export const placeholderCommentsRule: FactRule = {
+  id: "placeholder-comments",
+  requires: ["file.comments"],
+  appliesTo(ctx) {
+    return /\.tsx?$/.test(ctx.filePath) && !isTestFile(ctx.filePath);
+  },
+  evaluate(ctx, store) {
+    const comments = store.getFileFact<CommentSummary[]>(ctx.filePath, "file.comments");
+    if (!comments) return [];
+
+    const diagnostics: Diagnostic[] = [];
+    for (const comment of comments) {
+      const matched = PLACEHOLDER_PATTERNS.some((pattern) => pattern.test(comment.text));
+      if (!matched) continue;
+
+      diagnostics.push({
+        id: `placeholder-comments:${ctx.filePath}:${comment.line}:1`,
+        tool: "placeholder-comments",
+        filePath: ctx.filePath,
+        line: comment.line,
+        column: 1,
+        severity: "warning",
+        semantic: "warning",
+        rule: "placeholder-comments",
+        message:
+          "Placeholder comment detected. Prefer comments that describe current behavior over future intent.",
+      });
+    }
+
+    return diagnostics;
+  },
+};

package/clients/dispatch/runners/architect.ts

@@ -17,6 +17,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 import { readFileContent } from "./utils.js";
 
 // Module-level singleton — loadConfig once per cwd, not on every file write
@@ -40,7 +41,7 @@ function getClient(cwd: string): ArchitectClient {
 const architectRunner: RunnerDefinition = {
 	id: "architect",
 	appliesTo: ["jsts", "python", "go", "rust", "cxx", "shell", "cmake"],
-	priority: 40,
+	priority: PRIORITY.ARCHITECTURE,
 	enabledByDefault: true,
 	skipTestFiles: true, // Skip test files - rules can be noisy there
 

package/clients/dispatch/runners/ast-grep-napi.ts

@@ -17,6 +17,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 import {
 	calculateRuleComplexity,
 	hasUnsupportedConditions,
@@ -389,7 +390,7 @@ function getAllNodes(node: any, currentDepth: number): unknown[] {
 const astGrepNapiRunner: RunnerDefinition = {
 	id: "ast-grep-napi",
 	appliesTo: ["jsts"],
-	priority: 15,
+	priority: PRIORITY.SPECIALIZED_ANALYSIS,
 	enabledByDefault: true,
 	skipTestFiles: true,
 

package/clients/dispatch/runners/biome-check.ts

@@ -18,6 +18,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 const BIOME_CONFIGS = ["biome.json", "biome.jsonc"];
 
@@ -52,12 +53,16 @@ interface BiomeDiagnostic {
 	tags?: string[];
 }
 
-function parseBiomeJson(raw: string, filePath: string): Diagnostic[] {
+function parseBiomeJson(
+	raw: string,
+	filePath: string,
+): { diagnostics: Diagnostic[]; parseError?: string } {
 	try {
 		const result = JSON.parse(raw);
 		const diagnostics: BiomeDiagnostic[] = result.diagnostics || [];
 
-		return diagnostics.map((d) => ({
+		return {
+			diagnostics: diagnostics.map((d) => ({
 			id: `biome:${d.category}:${d.location.start.line}`,
 			message: d.message,
 			filePath,
@@ -67,16 +72,20 @@ function parseBiomeJson(raw: string, filePath: string): Diagnostic[] {
 			semantic: d.severity === "error" ? "blocking" : ("warning" as const),
 			tool: "biome",
 			rule: d.category,
-		}));
-	} catch {
-		return [];
+			})),
+		};
+	} catch (err) {
+		return {
+			diagnostics: [],
+			parseError: err instanceof Error ? err.message : String(err),
+		};
 	}
 }
 
 const biomeCheckJsonRunner: RunnerDefinition = {
 	id: "biome-check-json",
 	appliesTo: ["jsts"],
-	priority: 10,
+	priority: PRIORITY.FORMAT_AND_LINT_PRIMARY,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
@@ -122,13 +131,36 @@ const biomeCheckJsonRunner: RunnerDefinition = {
 			{ timeout: 30000, cwd },
 		);
 
-		const diagnostics =
+		const parsed =
 			checkResult.status === 0 || checkResult.status === 1
 				? parseBiomeJson(
 						checkResult.stdout || checkResult.stderr || "",
 						ctx.filePath,
 					)
-				: [];
+				: { diagnostics: [] as Diagnostic[] };
+
+		if (parsed.parseError) {
+			const raw = checkResult.stdout || checkResult.stderr || "";
+			const preview = raw.replace(/\s+/g, " ").slice(0, 160);
+			return {
+				status: "failed",
+				diagnostics: [
+					{
+						id: "biome:parse-error:1",
+						message: `Biome JSON parse failed: ${parsed.parseError}${preview ? ` (output preview: ${preview})` : ""}`,
+						filePath: ctx.filePath,
+						line: 1,
+						column: 1,
+						severity: "warning",
+						semantic: "warning",
+						tool: "biome",
+					},
+				],
+				semantic: "warning",
+			};
+		}
+
+		const diagnostics = parsed.diagnostics;
 
 		// Step 2: Auto-fix (silently)
 		await safeSpawnAsync(

package/clients/dispatch/runners/biome.ts

@@ -10,13 +10,14 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 import { createBiomeParser } from "./utils/diagnostic-parsers.js";
 import { biome } from "./utils/runner-helpers.js";
 
 const biomeRunner: RunnerDefinition = {
 	id: "biome-lint",
 	appliesTo: ["jsts", "json"],
-	priority: 10,
+	priority: PRIORITY.FORMAT_AND_LINT_PRIMARY,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {

package/clients/dispatch/runners/eslint.ts

@@ -17,6 +17,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 const ESLINT_CONFIGS = [
 	".eslintrc",
@@ -75,7 +76,10 @@ interface EslintFileResult {
 	messages: EslintMessage[];
 }
 
-function parseEslintJson(raw: string, filePath: string): Diagnostic[] {
+function parseEslintJson(
+	raw: string,
+	filePath: string,
+): { diagnostics: Diagnostic[]; parseError?: string } {
 	try {
 		const results: EslintFileResult[] = JSON.parse(raw);
 		const diagnostics: Diagnostic[] = [];
@@ -98,16 +102,19 @@ function parseEslintJson(raw: string, filePath: string): Diagnostic[] {
 			}
 		}
 
-		return diagnostics;
-	} catch {
-		return [];
+		return { diagnostics };
+	} catch (err) {
+		return {
+			diagnostics: [],
+			parseError: err instanceof Error ? err.message : String(err),
+		};
 	}
 }
 
 const eslintRunner: RunnerDefinition = {
 	id: "eslint",
 	appliesTo: ["jsts"],
-	priority: 12,
+	priority: PRIORITY.LINT_SECONDARY,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
@@ -166,7 +173,28 @@ const eslintRunner: RunnerDefinition = {
 			return { status: "succeeded", diagnostics: [], semantic: "none" };
 		}
 
-		const diagnostics = parseEslintJson(raw, ctx.filePath);
+		const parsed = parseEslintJson(raw, ctx.filePath);
+		if (parsed.parseError && raw.trim().length > 0) {
+			const preview = raw.replace(/\s+/g, " ").slice(0, 160);
+			return {
+				status: "failed",
+				diagnostics: [
+					{
+						id: "eslint:parse-error:1",
+						message: `ESLint JSON parse failed: ${parsed.parseError}${preview ? ` (output preview: ${preview})` : ""}`,
+						filePath: ctx.filePath,
+						line: 1,
+						column: 1,
+						severity: "warning",
+						semantic: "warning",
+						tool: "eslint",
+					},
+				],
+				semantic: "warning",
+			};
+		}
+
+		const diagnostics = parsed.diagnostics;
 		if (diagnostics.length === 0) {
 			return { status: "succeeded", diagnostics: [], semantic: "none" };
 		}

package/clients/dispatch/runners/go-vet.ts

@@ -12,11 +12,12 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 const goVetRunner: RunnerDefinition = {
 	id: "go-vet",
 	appliesTo: ["go"],
-	priority: 15,
+	priority: PRIORITY.SPECIALIZED_ANALYSIS,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {

package/clients/dispatch/runners/golangci-lint.ts

@@ -21,6 +21,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 const GOLANGCI_CONFIGS = [
 	".golangci.yml",
@@ -82,7 +83,7 @@ function parseGolangciJson(raw: string, filePath: string): Diagnostic[] {
 const golangciRunner: RunnerDefinition = {
 	id: "golangci-lint",
 	appliesTo: ["go"],
-	priority: 20,
+	priority: PRIORITY.GENERAL_ANALYSIS,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {

package/clients/dispatch/runners/index.ts

@@ -2,7 +2,7 @@
  * Runner definitions for pi-lens dispatch system
  */
 
-import { registerRunner } from "../dispatcher.js";
+import type { RunnerRegistry } from "../types.js";
 import architectRunner from "./architect.js";
 import astGrepNapiRunner from "./ast-grep-napi.js";
 import biomeRunner from "./biome.js";
@@ -28,29 +28,31 @@ import treeSitterRunner from "./tree-sitter.js";
 import tsLspRunner from "./ts-lsp.js";
 import typeSafetyRunner from "./type-safety.js";
 
-// Register all runners (ordered by priority)
-// Unified LSP runner for all languages (TypeScript, Python, Go, Rust, etc.) - priority 4
-registerRunner(lspRunner); // Unified LSP type-checking for all languages (priority 4)
-registerRunner(tsLspRunner); // TypeScript type-checking (priority 5) - fallback when --lens-lsp disabled
-registerRunner(pyrightRunner); // Python type-checking (priority 5) - fallback when --lens-lsp disabled
-registerRunner(biomeCheckJsonRunner); // Biome check with JSON output for diagnostic capture (priority 9)
-// DISABLED in post-write dispatch - ast-grep-napi can crash. Enabled via /lens-booboo plan only.
-registerRunner(astGrepNapiRunner); // TS/JS structural analysis via NAPI (priority 15, post-write disabled)
-registerRunner(biomeRunner); // Biome formatting/linting (priority 10)
-registerRunner(treeSitterRunner); // Tree-sitter structural analysis (priority 14)
-registerRunner(ruffRunner); // Python linting (priority 10)
-registerRunner(pythonSlopRunner); // Python slop via CLI (priority 25)
-registerRunner(typeSafetyRunner); // Type safety checks (priority 20)
-registerRunner(shellcheckRunner); // Shell script linting (priority 20)
-// DISABLED: registerRunner(astGrepRunner); // Replaced by ast-grep-napi for dispatch
-// CLI ast-grep kept for ast_grep_search/ast_grep_replace tools only
-registerRunner(similarityRunner); // Semantic reuse detection (priority 35)
-registerRunner(architectRunner); // Architectural rules (priority 40)
-registerRunner(eslintRunner); // ESLint (priority 12, jsts, config-gated)
-registerRunner(golangciRunner); // golangci-lint (priority 20, go, config-gated)
-registerRunner(rubocopRunner); // RuboCop lint (priority 10, ruby)
-registerRunner(spellcheckRunner); // Spellcheck for markdown/docs (priority 30)
-registerRunner(yamllintRunner); // YAML lint (priority 22)
-registerRunner(sqlfluffRunner); // SQL lint (priority 24)
-registerRunner(goVetRunner); // Go analysis (priority 50)
-registerRunner(rustClippyRunner); // Rust analysis (priority 50)
+export function registerDefaultRunners(registry: RunnerRegistry): void {
+	// Register all runners (ordered by priority)
+	// Unified LSP runner for all languages (TypeScript, Python, Go, Rust, etc.) - priority 4
+	registry.register(lspRunner); // Unified LSP type-checking for all languages (priority 4)
+	registry.register(tsLspRunner); // TypeScript type-checking (priority 5) - fallback when --lens-lsp disabled
+	registry.register(pyrightRunner); // Python type-checking (priority 5) - fallback when --lens-lsp disabled
+	registry.register(biomeCheckJsonRunner); // Biome check with JSON output for diagnostic capture (priority 9)
+	// DISABLED in post-write dispatch - ast-grep-napi can crash. Enabled via /lens-booboo plan only.
+	registry.register(astGrepNapiRunner); // TS/JS structural analysis via NAPI (priority 15, post-write disabled)
+	registry.register(biomeRunner); // Biome formatting/linting (priority 10)
+	registry.register(treeSitterRunner); // Tree-sitter structural analysis (priority 14)
+	registry.register(ruffRunner); // Python linting (priority 10)
+	registry.register(pythonSlopRunner); // Python slop via CLI (priority 25)
+	registry.register(typeSafetyRunner); // Type safety checks (priority 20)
+	registry.register(shellcheckRunner); // Shell script linting (priority 20)
+	// DISABLED: registerRunner(astGrepRunner); // Replaced by ast-grep-napi for dispatch
+	// CLI ast-grep kept for ast_grep_search/ast_grep_replace tools only
+	registry.register(similarityRunner); // Semantic reuse detection (priority 35)
+	registry.register(architectRunner); // Architectural rules (priority 40)
+	registry.register(eslintRunner); // ESLint (priority 12, jsts, config-gated)
+	registry.register(golangciRunner); // golangci-lint (priority 20, go, config-gated)
+	registry.register(rubocopRunner); // RuboCop lint (priority 10, ruby)
+	registry.register(spellcheckRunner); // Spellcheck for markdown/docs (priority 30)
+	registry.register(yamllintRunner); // YAML lint (priority 22)
+	registry.register(sqlfluffRunner); // SQL lint (priority 24)
+	registry.register(goVetRunner); // Go analysis (priority 50)
+	registry.register(rustClippyRunner); // Rust analysis (priority 50)
+}

package/clients/dispatch/runners/lsp.ts

@@ -21,10 +21,38 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 import { readFileContent } from "./utils.js";
 
 const LSP_MAX_FILE_BYTES = RUNTIME_CONFIG.pipeline.lspMaxFileBytes;
 const LSP_MAX_FILE_LINES = RUNTIME_CONFIG.pipeline.lspMaxFileLines;
+const MAX_CODE_ACTION_LOOKUPS = 6;
+const MAX_CODE_ACTION_TITLES = 3;
+
+function normalizeActionTitle(title: string): string {
+	return title.replace(/\s+/g, " ").trim();
+}
+
+function buildCodeActionSuggestion(
+	actions: import("../../lsp/client.js").LSPCodeAction[],
+): string | undefined {
+	if (!actions.length) return undefined;
+	const quickFixes = actions.filter((action) =>
+		action.kind?.startsWith("quickfix"),
+	);
+	if (!quickFixes.length) return undefined;
+
+	const titles = Array.from(
+		new Set(
+			quickFixes
+				.map((action) => normalizeActionTitle(action.title))
+				.filter((title) => title.length > 0),
+		),
+	).slice(0, MAX_CODE_ACTION_TITLES);
+
+	if (!titles.length) return undefined;
+	return `LSP quick fixes: ${titles.join("; ")}`;
+}
 
 const lspRunner: RunnerDefinition = {
 	id: "lsp",
@@ -42,7 +70,7 @@ const lspRunner: RunnerDefinition = {
 		"css",
 		"yaml",
 	],
-	priority: 4, // Run before everything (even ts-lsp was priority 5)
+	priority: PRIORITY.LSP_PRIMARY,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
@@ -125,9 +153,35 @@ const lspRunner: RunnerDefinition = {
 
 		// Convert LSP diagnostics to our format
 		// Defensive: filter out malformed diagnostics that may lack range
-		const diagnostics: Diagnostic[] = lspDiags
-			.filter((d) => d.range?.start?.line !== undefined)
-			.map((d) => ({
+		const validLspDiags = lspDiags.filter((d) => d.range?.start?.line !== undefined);
+		const fixSuggestionByIndex = new Map<number, string>();
+
+		const blockingDiagIndexes = validLspDiags
+			.map((d, idx) => ({ d, idx }))
+			.filter(({ d }) => d.severity === 1)
+			.slice(0, MAX_CODE_ACTION_LOOKUPS);
+
+		for (const { d, idx } of blockingDiagIndexes) {
+			try {
+				const start = d.range.start;
+				const end = d.range.end ?? d.range.start;
+				const actions = await lspService.codeAction(
+					ctx.filePath,
+					start.line,
+					start.character,
+					end.line,
+					end.character,
+				);
+				const suggestion = buildCodeActionSuggestion(actions);
+				if (suggestion) {
+					fixSuggestionByIndex.set(idx, suggestion);
+				}
+			} catch {
+				// Best-effort enrichment only; base diagnostics remain authoritative.
+			}
+		}
+
+		const diagnostics: Diagnostic[] = validLspDiags.map((d, idx) => ({
 				id: `lsp:${d.code ?? "unknown"}:${d.range.start.line}`,
 				message: d.message,
 				filePath: diagnosticPath,
@@ -143,6 +197,8 @@ const lspRunner: RunnerDefinition = {
 							: "none",
 				tool: "lsp",
 				code: String(d.code ?? ""),
+				fixable: fixSuggestionByIndex.has(idx),
+				fixSuggestion: fixSuggestionByIndex.get(idx),
 			}));
 
 		const hasErrors = diagnostics.some((d) => d.semantic === "blocking");

package/clients/dispatch/runners/oxlint.ts

@@ -14,6 +14,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker } from "./utils/runner-helpers.js";
 
 const oxlint = createAvailabilityChecker("oxlint", ".exe");
@@ -21,7 +22,7 @@ const oxlint = createAvailabilityChecker("oxlint", ".exe");
 const oxlintRunner: RunnerDefinition = {
 	id: "oxlint",
 	appliesTo: ["jsts"],
-	priority: 12,
+	priority: PRIORITY.LINT_SECONDARY,
 	enabledByDefault: false, // Opt-in: may conflict with ESLint in existing projects
 	skipTestFiles: true,
 

package/clients/dispatch/runners/pyright.ts

@@ -16,6 +16,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 import { createAvailabilityChecker } from "./utils/runner-helpers.js";
 
 const pyright = createAvailabilityChecker("pyright", ".exe");
@@ -23,7 +24,7 @@ const pyright = createAvailabilityChecker("pyright", ".exe");
 const pyrightRunner: RunnerDefinition = {
 	id: "pyright",
 	appliesTo: ["python"],
-	priority: 5, // Higher priority than ruff (10) - type errors are more important
+	priority: PRIORITY.LSP_FALLBACK,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {

package/clients/dispatch/runners/python-slop.ts

@@ -18,6 +18,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 import {
 	createConfigFinder,
 	getSgCommand,
@@ -29,7 +30,7 @@ const findSlopConfig = createConfigFinder("python-slop-rules");
 const pythonSlopRunner: RunnerDefinition = {
 	id: "python-slop",
 	appliesTo: ["python"],
-	priority: 25, // Between pyright (5) and ruff (10)
+	priority: PRIORITY.PYTHON_SLOP,
 	enabledByDefault: true,
 	skipTestFiles: true, // Slop rules can be noisy in test files
 

package/clients/dispatch/runners/rubocop.ts

@@ -18,6 +18,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 function findRubocop(cwd: string): { cmd: string; args: string[] } {
 	// Prefer bundle exec if Gemfile exists
@@ -93,7 +94,7 @@ function parseRubocopJson(raw: string, filePath: string): Diagnostic[] {
 const rubocopRunner: RunnerDefinition = {
 	id: "rubocop",
 	appliesTo: ["ruby"],
-	priority: 10,
+	priority: PRIORITY.FORMAT_AND_LINT_PRIMARY,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {

package/clients/dispatch/runners/ruff.ts

@@ -14,6 +14,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 import { parseRuffOutput } from "./utils/diagnostic-parsers.js";
 import { createAvailabilityChecker } from "./utils/runner-helpers.js";
 
@@ -55,7 +56,7 @@ function parseRuffJson(raw: string, filePath: string): Diagnostic[] {
 const ruffRunner: RunnerDefinition = {
 	id: "ruff-lint",
 	appliesTo: ["python"],
-	priority: 10,
+	priority: PRIORITY.FORMAT_AND_LINT_PRIMARY,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {

package/clients/dispatch/runners/rust-clippy.ts

@@ -15,11 +15,12 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 const rustClippyRunner: RunnerDefinition = {
 	id: "rust-clippy",
 	appliesTo: ["rust"],
-	priority: 15,
+	priority: PRIORITY.SPECIALIZED_ANALYSIS,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {

package/clients/dispatch/runners/shellcheck.ts

@@ -30,6 +30,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 const shellcheck = createAvailabilityChecker("shellcheck", ".exe");
 
@@ -129,7 +130,7 @@ function parseShellcheckOutput(raw: string, filePath: string): Diagnostic[] {
 const shellcheckRunner: RunnerDefinition = {
 	id: "shellcheck",
 	appliesTo: ["shell"],
-	priority: 20,
+	priority: PRIORITY.GENERAL_ANALYSIS,
 	enabledByDefault: true,
 	skipTestFiles: false, // Shell scripts in test directories should still be checked
 

package/clients/dispatch/runners/similarity.ts

@@ -24,6 +24,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 // Singleton Rust client — initialised once, reused across runner invocations.
 const rustClient = new NativeRustCoreClient();
@@ -97,7 +98,7 @@ export function hasMeaningfulNameOverlap(sourceName: string, targetName: string)
 const similarityRunner: RunnerDefinition = {
 	id: "similarity",
 	appliesTo: ["jsts"], // TypeScript/JavaScript only for MVP
-	priority: 35, // After ts-lsp, before ast-grep
+	priority: PRIORITY.SIMILARITY,
 	enabledByDefault: true,
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {

package/clients/dispatch/runners/spellcheck.ts

@@ -27,6 +27,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 const typos = createAvailabilityChecker("typos", ".exe");
 
@@ -91,7 +92,7 @@ function parseTyposOutput(raw: string, filePath: string): Diagnostic[] {
 const spellcheckRunner: RunnerDefinition = {
 	id: "spellcheck",
 	appliesTo: ["markdown"],
-	priority: 30, // Run after code quality checks (biome=10, slop=25)
+	priority: PRIORITY.DOC_QUALITY,
 	enabledByDefault: true,
 	skipTestFiles: false, // Check docs in test files too
 

package/clients/dispatch/runners/sqlfluff.ts

@@ -9,6 +9,7 @@ import type {
 	RunnerDefinition,
 	RunnerResult,
 } from "../types.js";
+import { PRIORITY } from "../priorities.js";
 
 const sqlfluff = createAvailabilityChecker("sqlfluff", ".exe");
 
@@ -90,7 +91,7 @@ function parseSqlfluffOutput(raw: string, filePath: string): Diagnostic[] {
 const sqlfluffRunner: RunnerDefinition = {
 	id: "sqlfluff",
 	appliesTo: ["sql"],
-	priority: 24,
+	priority: PRIORITY.SQL_LINT,
 	enabledByDefault: true,
 	skipTestFiles: false,