pi-lens 3.6.3 → 3.6.4

package/clients/dependency-checker.js

@@ -1,325 +0,0 @@
-/**
- * Dependency Checker for pi-local
- *
- * Real-time circular dependency detection.
- * Caches the dependency graph and only re-scans when imports change.
- * Runs in the tool_result hook like ast-grep and Biome.
- *
- * Requires: npm install -D madge
- * Docs: https://github.com/pahen/madge
- */
-import * as fs from "node:fs";
-import * as path from "node:path";
-import { safeSpawn } from "./safe-spawn.js";
-// --- Client ---
-export class DependencyChecker {
-    constructor(verbose = false) {
-        this.available = null;
-        // Cache: file path -> its imports
-        this.importCache = new Map();
-        // Circular deps: last known circular deps
-        this.lastCircular = [];
-        // Files that are part of a circular dependency
-        this.circularFiles = new Set();
-        this.log = verbose
-            ? (msg) => console.error(`[deps] ${msg}`)
-            : () => { };
-    }
-    /**
-     * Check if madge is available, auto-install if not
-     */
-    async ensureAvailable() {
-        // Fast path: already checked
-        if (this.available !== null)
-            return this.available;
-        // Check if available in PATH
-        const result = safeSpawn("madge", ["--version"], {
-            timeout: 5000,
-        });
-        this.available = !result.error && result.status === 0;
-        if (this.available) {
-            this.log(`Madge found: ${result.stdout?.trim()}`);
-            return true;
-        }
-        // Auto-install via pi-lens installer
-        this.log("Madge not found, attempting auto-install...");
-        const { ensureTool } = await import("./installer/index.js");
-        const installedPath = await ensureTool("madge");
-        if (installedPath) {
-            this.log(`Madge auto-installed: ${installedPath}`);
-            this.available = true;
-            return true;
-        }
-        this.log("Madge auto-install failed");
-        return false;
-    }
-    /**
-     * Check if madge is available (legacy sync method)
-     * Prefer ensureAvailable() for auto-install behavior
-     */
-    isAvailable() {
-        if (this.available !== null)
-            return this.available;
-        const result = safeSpawn("npx", ["madge", "--version"], {
-            timeout: 5000,
-        });
-        this.available = !result.error && result.status === 0;
-        if (this.available) {
-            this.log("Madge available for dependency checking");
-        }
-        return this.available;
-    }
-    /**
-     * Check if a file is part of a circular dependency (from cache)
-     */
-    isInCircular(filePath) {
-        const normalized = path.resolve(filePath);
-        return this.circularFiles.has(normalized);
-    }
-    /**
-     * Get circular deps for a specific file
-     */
-    getCircularForFile(filePath) {
-        const normalized = path.resolve(filePath);
-        const deps = [];
-        for (const dep of this.lastCircular) {
-            if (dep.file === normalized || dep.path.includes(normalized)) {
-                // Add the other files in the cycle
-                for (const f of dep.path) {
-                    if (f !== normalized) {
-                        deps.push(path.relative(process.cwd(), f));
-                    }
-                }
-            }
-        }
-        return Array.from(new Set(deps));
-    }
-    /**
-     * Extract imports from a TypeScript/JavaScript file
-     */
-    extractImports(filePath) {
-        const content = fs.readFileSync(filePath, "utf-8");
-        const imports = new Set();
-        // Match import statements: import ... from '...'
-        const importPattern = /(?:import|export)\s+(?:.*?\s+from\s+)?['"]([^'"]+)['"]/g;
-        const requirePattern = /require\s*\(\s*['"]([^'"]+)['"]\s*\)/g;
-        let match;
-        while ((match = importPattern.exec(content)) !== null) {
-            if (match[1].startsWith(".")) {
-                imports.add(match[1]);
-            }
-        }
-        while ((match = requirePattern.exec(content)) !== null) {
-            if (match[1].startsWith(".")) {
-                imports.add(match[1]);
-            }
-        }
-        return imports;
-    }
-    /**
-     * Check if imports have changed for a file
-     */
-    importsChanged(filePath) {
-        const normalized = path.resolve(filePath);
-        if (!fs.existsSync(normalized)) {
-            this.importCache.delete(normalized);
-            return true;
-        }
-        const stat = fs.statSync(normalized);
-        const cached = this.importCache.get(normalized);
-        // Fast path: timestamp hasn't changed
-        if (cached && cached.timestamp >= stat.mtimeMs) {
-            return false;
-        }
-        // Compare actual imports
-        const newImports = this.extractImports(normalized);
-        const hasChanged = !cached || !this.setsEqual(cached.imports, newImports);
-        // Update cache
-        this.importCache.set(normalized, {
-            imports: newImports,
-            timestamp: stat.mtimeMs,
-        });
-        return hasChanged;
-    }
-    /**
-     * Check if two sets have the same elements
-     */
-    setsEqual(a, b) {
-        if (a.size !== b.size)
-            return false;
-        for (const item of a) {
-            if (!b.has(item))
-                return false;
-        }
-        return true;
-    }
-    /**
-     * Quick circular dependency check using DFS on cached graph.
-     * Only re-runs full madge check when imports change.
-     */
-    checkFile(filePath, cwd) {
-        const normalized = path.resolve(filePath);
-        // Return early for non-existent files without running availability check
-        if (!fs.existsSync(normalized)) {
-            return {
-                hasCircular: false,
-                circular: [],
-                checked: false,
-                cacheHit: false,
-            };
-        }
-        if (!this.isAvailable()) {
-            return {
-                hasCircular: false,
-                circular: [],
-                checked: false,
-                cacheHit: false,
-            };
-        }
-        const projectRoot = cwd || process.cwd();
-        // Check if imports changed
-        const importsChanged = this.importsChanged(normalized);
-        if (!importsChanged) {
-            // Return cached result
-            return {
-                hasCircular: this.circularFiles.has(normalized),
-                circular: this.lastCircular.filter((d) => d.file === normalized || d.path.includes(normalized)),
-                checked: true,
-                cacheHit: true,
-            };
-        }
-        this.log(`Imports changed for ${path.basename(filePath)}, checking dependencies...`);
-        // Run madge on the specific file (fast)
-        try {
-            const result = safeSpawn("npx", [
-                "madge",
-                "--circular",
-                "--extensions",
-                "ts,tsx,js,jsx",
-                "--json",
-                normalized,
-            ], {
-                timeout: 15000,
-                cwd: projectRoot,
-            });
-            const output = result.stdout || "[]";
-            const parsed = JSON.parse(output);
-            // Madge --circular --json returns array of cycle arrays: [["a.ts", "b.ts"], ...]
-            const cycles = Array.isArray(parsed) ? parsed : [];
-            const circular = [];
-            const circularFiles = new Set();
-            for (const cycle of cycles) {
-                const resolvedPaths = cycle.map((f) => path.resolve(projectRoot, f));
-                for (const f of resolvedPaths) {
-                    circularFiles.add(f);
-                }
-                circular.push({
-                    file: resolvedPaths[0],
-                    path: resolvedPaths,
-                });
-            }
-            this.lastCircular = circular;
-            this.circularFiles = circularFiles;
-            return {
-                hasCircular: circular.length > 0,
-                circular: circular.filter((d) => d.file === normalized || d.path.includes(normalized)),
-                checked: true,
-                cacheHit: false,
-            };
-        }
-        catch (err) {
-            this.log(`Check error: ${err.message}`);
-            return {
-                hasCircular: false,
-                circular: [],
-                checked: false,
-                cacheHit: false,
-            };
-        }
-    }
-    /**
-     * Format circular dependency warning for LLM
-     */
-    formatWarning(filePath, deps) {
-        if (deps.length === 0)
-            return "";
-        const filename = path.basename(filePath);
-        const depNames = deps.map((d) => path.basename(d));
-        let output = `[Circular Deps] ${filename} is in a cycle:\n`;
-        output += `  ${filename} ↔ ${depNames.join(", ")}\n`;
-        output += `\n  Consider extracting shared code to a separate module.\n`;
-        return output;
-    }
-    /**
-     * Full project scan (for /check-deps command)
-     */
-    scanProject(cwd) {
-        const projectRoot = cwd || process.cwd();
-        // Return early for non-existent or empty directories
-        if (!fs.existsSync(projectRoot)) {
-            return { circular: [], count: 0 };
-        }
-        const entries = fs.readdirSync(projectRoot);
-        const hasSourceFiles = entries.some((e) => /\.(ts|tsx|js|jsx)$/.test(e) && !e.endsWith(".d.ts"));
-        if (!hasSourceFiles) {
-            return { circular: [], count: 0 };
-        }
-        if (!this.isAvailable()) {
-            return { circular: [], count: 0 };
-        }
-        try {
-            const result = safeSpawn("npx", [
-                "madge",
-                "--circular",
-                "--extensions",
-                "ts,tsx,js,jsx",
-                "--json",
-                projectRoot,
-            ], {
-                timeout: 30000,
-                cwd: projectRoot,
-            });
-            const output = result.stdout || "{}";
-            const data = JSON.parse(output);
-            const circular = [];
-            const circularFiles = new Set();
-            for (const [file, deps] of Object.entries(data)) {
-                if (Array.isArray(deps) && deps.length > 0) {
-                    const resolvedFile = path.resolve(file);
-                    circularFiles.add(resolvedFile);
-                    circular.push({
-                        file: resolvedFile,
-                        path: [resolvedFile, ...deps.map((d) => path.resolve(d))],
-                    });
-                }
-            }
-            this.lastCircular = circular;
-            this.circularFiles = circularFiles;
-            return { circular, count: circular.length };
-        }
-        catch (err) {
-            this.log(`Scan error: ${err.message}`);
-            return { circular: [], count: 0 };
-        }
-    }
-    /**
-     * Format full scan results
-     */
-    formatScanResult(circular) {
-        if (circular.length === 0)
-            return "";
-        // Group by cycle to avoid duplicate entries
-        const seen = new Set();
-        let output = `[Circular Deps] ${circular.length} cycle(s) found:\n`;
-        for (const dep of circular) {
-            const cycleKey = dep.path.sort().join("→");
-            if (seen.has(cycleKey))
-                continue;
-            seen.add(cycleKey);
-            const names = dep.path.map((p) => path.relative(process.cwd(), p));
-            output += `  • ${names.join(" → ")}\n`;
-        }
-        output += "\n  Consider extracting shared code to break cycles.\n";
-        return output;
-    }
-}

package/clients/dependency-checker.test.js

@@ -1,60 +0,0 @@
-import { afterEach, beforeEach, describe, expect, it } from "vitest";
-import { DependencyChecker } from "./dependency-checker.js";
-import { setupTestEnvironment } from "./test-utils.js";
-describe("DependencyChecker", () => {
-    let client;
-    let tmpDir;
-    let cleanup;
-    beforeEach(() => {
-        client = new DependencyChecker();
-        ({ tmpDir, cleanup } = setupTestEnvironment("pi-lens-dep-test-"));
-    });
-    afterEach(() => {
-        cleanup();
-    });
-    describe("isAvailable", () => {
-        it("should check madge availability", () => {
-            const available = client.isAvailable();
-            expect(typeof available).toBe("boolean");
-        });
-    });
-    describe("checkFile", () => {
-        it("should return no circular deps for non-existent files", () => {
-            const result = client.checkFile("/nonexistent/file.ts");
-            expect(result.hasCircular).toBe(false);
-            expect(result.circular).toEqual([]);
-        });
-        it("should return correct structure when not available", () => {
-            const mockChecker = new DependencyChecker();
-            if (mockChecker.isAvailable())
-                return; // Skip if available
-            const result = mockChecker.checkFile("/some/file.ts");
-            expect(result).toHaveProperty("hasCircular");
-            expect(result).toHaveProperty("circular");
-            expect(result).toHaveProperty("checked");
-        });
-    });
-    describe("scanProject", () => {
-        it("should return correct structure", () => {
-            const mockChecker = new DependencyChecker();
-            // When not available, should still return expected structure
-            const result = mockChecker.scanProject(tmpDir);
-            expect(result).toHaveProperty("circular");
-            expect(result).toHaveProperty("count");
-            expect(Array.isArray(result.circular)).toBe(true);
-        });
-    });
-    describe("formatWarning", () => {
-        it("should format circular dependency warning", () => {
-            const circularDeps = ["b.ts", "c.ts", "a.ts"];
-            const formatted = client.formatWarning("a.ts", circularDeps);
-            expect(formatted).toContain("cycle");
-            expect(formatted).toContain("a.ts");
-        });
-        it("should show the circular path", () => {
-            const circularDeps = ["b.ts", "a.ts"];
-            const formatted = client.formatWarning("a.ts", circularDeps);
-            expect(formatted).toContain("b.ts");
-        });
-    });
-});

package/clients/dependency-checker.test.ts

@@ -1,71 +0,0 @@
-import { afterEach, beforeEach, describe, expect, it } from "vitest";
-import { DependencyChecker } from "./dependency-checker.js";
-import { setupTestEnvironment } from "./test-utils.js";
-
-describe("DependencyChecker", () => {
-	let client: DependencyChecker;
-	let tmpDir: string;
-	let cleanup: () => void;
-
-	beforeEach(() => {
-		client = new DependencyChecker();
-		({ tmpDir, cleanup } = setupTestEnvironment("pi-lens-dep-test-"));
-	});
-
-	afterEach(() => {
-		cleanup();
-	});
-
-	describe("isAvailable", () => {
-		it("should check madge availability", () => {
-			const available = client.isAvailable();
-			expect(typeof available).toBe("boolean");
-		});
-	});
-
-	describe("checkFile", () => {
-		it("should return no circular deps for non-existent files", () => {
-			const result = client.checkFile("/nonexistent/file.ts");
-			expect(result.hasCircular).toBe(false);
-			expect(result.circular).toEqual([]);
-		});
-
-		it("should return correct structure when not available", () => {
-			const mockChecker = new DependencyChecker();
-			if (mockChecker.isAvailable()) return; // Skip if available
-
-			const result = mockChecker.checkFile("/some/file.ts");
-			expect(result).toHaveProperty("hasCircular");
-			expect(result).toHaveProperty("circular");
-			expect(result).toHaveProperty("checked");
-		});
-	});
-
-	describe("scanProject", () => {
-		it("should return correct structure", () => {
-			const mockChecker = new DependencyChecker();
-			// When not available, should still return expected structure
-			const result = mockChecker.scanProject(tmpDir);
-			expect(result).toHaveProperty("circular");
-			expect(result).toHaveProperty("count");
-			expect(Array.isArray(result.circular)).toBe(true);
-		});
-	});
-
-	describe("formatWarning", () => {
-		it("should format circular dependency warning", () => {
-			const circularDeps = ["b.ts", "c.ts", "a.ts"];
-			const formatted = client.formatWarning("a.ts", circularDeps);
-
-			expect(formatted).toContain("cycle");
-			expect(formatted).toContain("a.ts");
-		});
-
-		it("should show the circular path", () => {
-			const circularDeps = ["b.ts", "a.ts"];
-			const formatted = client.formatWarning("a.ts", circularDeps);
-
-			expect(formatted).toContain("b.ts");
-		});
-	});
-});