pi-lens 3.3.0 → 3.6.0

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "3.3.0",
+	"version": "3.6.0",
 	"type": "module",
 	"description": "pi extension for real-time code quality — 31 LSP servers, tree-sitter structural analysis, AST pattern matching, auto-install for TypeScript/Python tooling, duplicate detection, complexity metrics, and inline blockers with comprehensive /lens-booboo reports",
 	"repository": {

package/rules/ast-grep-rules/rules/no-architecture-violation.yml

@@ -9,7 +9,10 @@ note: |
   BAD: import { User } from '../models/user';
   GOOD: import { User } from '../types/user';
 rule:
-  pattern: import { $$$ } from "$PATH"
-constraints:
-  PATH:
-    regex: ".*models.*|.*database.*|.*prisma.*"
+  any:
+    - pattern: import { $$$ } from "../models/$_"
+    - pattern: import { $$$ } from "../../models/$_"
+    - pattern: import { $$$ } from "../database/$_"
+    - pattern: import { $$$ } from "../../database/$_"
+    - pattern: import { $$$ } from "../prisma/$_"
+    - pattern: import { $$$ } from "../../prisma/$_"

package/rules/ast-grep-rules/rules/no-single-char-var.yml

@@ -6,7 +6,7 @@ note: |
   Single-character variable names reduce readability.
   Exception: loop counters (i, j, k, n) and underscore (_) are acceptable.
 rule:
-  pattern: const $VAR = $VALUE
-constraints:
-  VAR:
+  kind: variable_declarator
+  has:
+    kind: identifier
     regex: "^[a-df-hm-z]$"  # Excludes i, j, k, n

package/rules/ast-grep-rules/slop-patterns.yml

@@ -23,19 +23,27 @@ rule:
   kind: while_statement
   pattern: "while ($I < $ARR.length) { $$$ }"
 ---
-id: ts-manual-min-max
-language: typescript
-severity: warning
-message: Manual min/max logic - use Math.min() or Math.max()
-metadata:
-  weight: 3
-  category: slop
-rule:
-  kind: if_statement
-  any:
-  - pattern: "if ($A > $B) { $M = $A; } else { $M = $B; }"
-  - pattern: "if ($A < $B) { $M = $A; } else { $M = $B; }"
----
+# DISABLED: Complex block patterns don't match with current ast-grep-napi runner
+# Requires implementation support for multi-statement patterns with blocks
+# Consider migrating to tree-sitter for better structural matching
+# id: ts-manual-min-max
+# language: typescript
+# severity: warning
+# message: Manual min/max logic - use Math.min() or Math.max()
+# metadata:
+#   weight: 3
+#   category: slop
+# rule:
+#   any:
+#   # Pattern for MAX: if (a > b) result = a else result = b
+#   - pattern: "if ($A > $B) { $M = $A; } else { $M = $B; }"
+#   # Pattern for MIN: if (a < b) result = a else result = b  
+#   - pattern: "if ($A < $B) { $M = $A; } else { $M = $B; }"
+#   # Pattern for MAX (reversed): if (a < b) result = b else result = a
+#   - pattern: "if ($A < $B) { $M = $B; } else { $M = $A; }"
+#   # Pattern for MIN (reversed): if (a > b) result = b else result = a
+#   - pattern: "if ($A > $B) { $M = $B; } else { $M = $A; }"
+# ---
 id: ts-array-map-ceremony
 language: typescript
 severity: warning
@@ -129,17 +137,18 @@ rule:
   - pattern: "if ($X === null || $X === undefined) { return null; }"
   - pattern: "if ($X == null) { return null; }"
 ---
-id: ts-optional-chain-opportunity
-language: typescript
-severity: warning
-message: obj && obj.prop && obj.prop.nested - use optional chaining obj?.prop?.nested
-metadata:
-  weight: 3
-  category: slop
-rule:
-  kind: binary_expression
-  pattern: "$A && $A.$B && $A.$B.$C"
----
+# DISABLED: Duplicate of prefer-optional-chain.yml which has more comprehensive patterns
+# id: ts-optional-chain-opportunity
+# language: typescript
+# severity: warning
+# message: obj && obj.prop && obj.prop.nested - use optional chaining obj?.prop?.nested
+# metadata:
+#   weight: 3
+#   category: slop
+# rule:
+#   kind: binary_expression
+#   pattern: "$A && $A.$B && $A.$B.$C"
+# ---
 id: ts-explicit-undefined-check
 language: typescript
 severity: warning
@@ -189,19 +198,20 @@ rule:
   kind: call_expression
   pattern: "$ARR.filter($F).map($G)"
 ---
-id: ts-unnecessary-ternary-boolean
-language: typescript
-severity: warning
-message: cond ? true : false - use Boolean(cond) or cond directly
-metadata:
-  weight: 2
-  category: slop
-rule:
-  kind: conditional_expression
-  any:
-  - pattern: "$COND ? true : false"
-  - pattern: "$COND ? false : true"
----
+# DISABLED: Pattern doesn't match with current ast-grep-napi runner
+# The AST representation of boolean literals differs from string patterns
+# id: ts-unnecessary-ternary-boolean
+# language: typescript
+# severity: warning
+# message: cond ? true : false - use Boolean(cond) or cond directly
+# metadata:
+#   weight: 2
+#   category: slop
+# rule:
+#   any:
+#     - pattern: "$COND ? true : false"
+#     - pattern: "$COND ? false : true"
+# ---
 id: ts-typeof-equality
 language: typescript
 severity: warning
@@ -232,12 +242,32 @@ metadata:
   weight: 2
   category: slop
 rule:
-  kind: call_expression
   pattern: "$ARR.slice()"
   not:
-    has:
-      kind: arguments
+    pattern: "$ARR.slice($START)"
 ---
+# DISABLED: nthChild is unsupported - need to rewrite without it
+# id: ts-parseint-no-radix
+# language: typescript
+# severity: warning
+# message: parseInt(x) without radix - use parseInt(x, 10)
+# metadata:
+#   weight: 2
+#   category: slop
+# rule:
+#   kind: call_expression
+#   all:
+#   - has:
+#       kind: identifier
+#       regex: ^parseInt$
+#   - has:
+#       kind: arguments
+#       not:
+#         has:
+#           nthChild:
+#             position: 2
+# ---
+# Rewritten rule using pattern matching instead of nthChild:
 id: ts-parseint-no-radix
 language: typescript
 severity: warning
@@ -246,17 +276,9 @@ metadata:
   weight: 2
   category: slop
 rule:
-  kind: call_expression
-  all:
-  - has:
-      kind: identifier
-      regex: ^parseInt$
-  - has:
-      kind: arguments
-      not:
-        has:
-          nthChild:
-            position: 2
+  pattern: "parseInt($X)"
+  not:
+    pattern: "parseInt($X, $RADIX)"
 ---
 id: ts-isnan-check
 language: typescript
@@ -304,17 +326,18 @@ rule:
   kind: call_expression
   pattern: "$FN.bind(this)"
 ---
-id: ts-empty-array-check
-language: typescript
-severity: warning
-message: arr.length === 0 - use !arr.length or arr.length (truthiness)
-metadata:
-  weight: 2
-  category: slop
-rule:
-  kind: binary_expression
-  pattern: "$ARR.length === 0"
----
+# DISABLED: Debatable value - arr.length === 0 is often clearer than !arr.length
+# id: ts-empty-array-check
+# language: typescript
+# severity: warning
+# message: arr.length === 0 - use !arr.length or arr.length (truthiness)
+# metadata:
+#   weight: 2
+#   category: slop
+# rule:
+#   kind: binary_expression
+#   pattern: "$ARR.length === 0"
+# ---
 id: ts-array-every-some
 language: typescript
 severity: warning

package/skills/ast-grep/SKILL.md

@@ -62,6 +62,40 @@ class $CLASS($$$BASE):
     $$$BODY
 ```
 
+## Testing Tips
+
+**Workflow: Search → Dry-run → Apply**
+
+```typescript
+// Step 1: Verify pattern matches what you expect
+ast_grep_search
+  pattern: "console.log($MSG)"
+  lang: typescript
+  paths: ["src/"]
+// → Check the matches are correct
+
+// Step 2: Then do dry-run replace
+ast_grep_replace
+  pattern: "console.log($MSG)"
+  rewrite: "logger.debug($MSG)"
+  lang: typescript
+  paths: ["src/"]
+  apply: false
+
+// Step 3: Finally apply
+// apply: true
+```
+
+**Metavariable selection guide:**
+| Use | Pattern | Matches |
+|-----|---------|---------|
+| Single arg | `console.log($MSG)` | `console.log("hi")` |
+| Multiple args | `console.log($$$ARGS)` | `console.log("hi", obj, 42)` |
+| Single node | `const $X = $Y` | `const x = 1` |
+| Many nodes | `const $X = $$$REST` | `const x = 1 + 2 + 3` |
+
+**Indentation doesn't matter:** ast-grep normalizes whitespace, so tabs vs spaces work the same.
+
 ## Examples
 
 ```typescript
@@ -86,7 +120,12 @@ ast_grep_search
 ## Common Failures
 
 ```typescript
-// ❌ INVALID: Incomplete
+// ❌ INVALID: Multiple AST nodes (missing parentheses)
+pattern: "it\"test name\""
+// ✅ VALID: Single AST node with metavariable
+pattern: "it($TEST)"
+
+// ❌ INVALID: Incomplete code
 pattern: "function $NAME("
 // ✅ VALID: Complete code
 pattern: "function $NAME($$$PARAMS) { $$$BODY }"
@@ -102,6 +141,8 @@ pattern: "console.log(.*)"
 pattern: "console.log($$$ARGS)"
 ```
 
+**Error: "Multiple AST nodes detected"** → Your pattern has multiple code fragments. Use metavariables like `$TEST` instead of literal text in quotes.
+
 **Fallback:** If pattern fails twice → `grep -rn "pattern" src/`
 
 **Debug:** https://ast-grep.github.io/playground.html

package/skills/lsp-navigation/SKILL.md

@@ -0,0 +1,62 @@
+---
+name: lsp-navigation
+description: Navigate code with IDE features - definitions, references, types, call hierarchy. Use as PRIMARY for code intelligence.
+---
+
+# LSP Navigation
+
+Use `lsp_navigation` as **PRIMARY** for code intelligence. Do NOT use grep/glob/ast-grep first.
+
+**Requires:** `--lens-lsp` flag
+
+## When to Use (Code Intelligence)
+
+| Question | Operation | Parameters |
+|----------|-----------|------------|
+| "Where is this defined?" | `definition` | filePath, line, character |
+| "Find all usages" | `references` | filePath, line, character |
+| "What type is this?" | `hover` | filePath, line, character |
+| "What symbols in this file?" | `documentSymbol` | filePath |
+| "Find symbol across project" | `workspaceSymbol` | filePath, query |
+| "Who implements this interface?" | `implementation` | filePath, line, character |
+| "Who calls this function?" | `prepareCallHierarchy` → `incomingCalls` | filePath, line, character |
+| "What does this function call?" | `prepareCallHierarchy` → `outgoingCalls` | filePath, line, character |
+
+## Call Hierarchy Pattern
+
+```typescript
+// Step 1: Prepare (get the callable item)
+const items = await lsp_navigation({
+  operation: "prepareCallHierarchy",
+  filePath: "src/api.ts",
+  line: 42,
+  character: 10
+});
+
+// Step 2: Get callers (who calls this function)
+const callers = await lsp_navigation({
+  operation: "incomingCalls",
+  filePath: "src/api.ts",
+  callHierarchyItem: items[0]
+});
+
+// Step 2: Get callees (what this function calls)
+const callees = await lsp_navigation({
+  operation: "outgoingCalls",
+  filePath: "src/api.ts",
+  callHierarchyItem: items[0]
+});
+```
+
+## When NOT to Use LSP
+
+| Task | Use Instead | Why |
+|------|-------------|-----|
+| Find patterns (console.log) | `ast_grep_search` | Pattern matching |
+| Find text/TODOs | `grep` | Text search |
+| Find files by name | `glob` | File discovery |
+| Read file content | `read` | Direct access |
+
+## Golden Rule
+
+**Code intelligence → LSP first. Text/pattern search → grep/ast-grep.**

package/tsconfig.json

@@ -10,5 +10,5 @@
 		"types": ["node"]
 	},
 	"include": ["**/*.ts"],
-	"exclude": ["node_modules", "test-lsp-files"]
+	"exclude": ["node_modules", "test-lsp-files", "_trigger-test.ts"]
 }

package/rules/ast-grep-rules/rules/no-console-log.yml

@@ -1,10 +0,0 @@
-id: no-console-log
-language: TypeScript
-message: "console.log found — remove or replace with proper logging"
-severity: warning
-note: |
-  console.log statements should not be left in production code.
-  Use a proper logging framework or remove before committing.
-  Grade 2.8 — low complexity, improved production quality.
-rule:
-  pattern: console.log($$$ARGS)

package/rules/ast-grep-rules/rules/no-default-export.yml

@@ -1,19 +0,0 @@
-id: no-default-export
-message: >-
-  Use named exports instead of default exports.
-  Named exports improve grep-ability: agents can precisely locate
-  `export const Foo` and all `import { Foo } from` usages.
-severity: info
-language: typescript
-rule:
-  pattern: export default $X
-note: |
-  Named exports make code searchable for agents and humans.
-
-  Before:
-    export default function helper() { }
-
-  After:
-    export function helper() { }
-
-  Exception: Entry points (index.ts) typically require default exports.