pi-lens 3.3.0 → 3.3.1

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 All notable changes to pi-lens will be documented in this file.
 
+## [3.3.1] - 2026-04-02
+
+### Fixed
+- **LSP spawn `EINVAL` on Windows** — `.cmd` files (e.g. `vscode-json-language-server.cmd`) found via npm global lookup were spawned without `shell: true`, causing `EINVAL` from `CreateProcess`. The `needsShell` recomputation for npm global paths incorrectly treated `.cmd` the same as `.exe`. Fixed in both primary and fallback spawn paths.
+- **Unhandled `EINVAL` rejection** — LSP error handlers only caught `ENOENT` (binary not found). `EINVAL` (binary found but can't execute directly) now caught alongside `ENOENT` in both `launchLSP` and `launchViaPackageManager`.
+
+---
+
 ## [3.3.0] - 2026-04-02
 
 ### Removed

package/clients/lsp/launch.js

@@ -149,8 +149,11 @@ export async function launchLSP(command, args = [], options = {}) {
         if (npmGlobalPath) {
             spawnCommand = npmGlobalPath;
             // Recompute needsShell for npm global path
-            const globalHasExt = /\.(exe|cmd|bat)$/i.test(spawnCommand);
-            needsShell = isWindows && (spawnCommand.includes(" ") || !globalHasExt);
+            needsShell =
+                isWindows &&
+                    (spawnCommand.includes(" ") ||
+                        /\.(cmd|bat)$/i.test(spawnCommand) ||
+                        !/\.(exe|cmd|bat)$/i.test(spawnCommand));
         }
     }
     let proc;
@@ -166,8 +169,10 @@ export async function launchLSP(command, args = [], options = {}) {
             if (npmGlobalPath && npmGlobalPath !== spawnCommand) {
                 console.error(`[lsp] Trying npm global: ${npmGlobalPath}`);
                 // Recompute needsShell for npm global path
-                const globalHasExt = /\.(exe|cmd|bat)$/i.test(npmGlobalPath);
-                const needsShellGlobal = isWindows && (npmGlobalPath.includes(" ") || !globalHasExt);
+                const needsShellGlobal = isWindows &&
+                    (npmGlobalPath.includes(" ") ||
+                        /\.(cmd|bat)$/i.test(npmGlobalPath) ||
+                        !/\.(exe|cmd|bat)$/i.test(npmGlobalPath));
                 proc = trySpawn(npmGlobalPath, args, cwd, env, needsShellGlobal);
             }
             else {
@@ -192,7 +197,7 @@ export async function launchLSP(command, args = [], options = {}) {
         let settled = false;
         // Attach error handler that can reject for immediate errors
         proc.on("error", (err) => {
-            if (!settled && err.code === "ENOENT") {
+            if (!settled && (err.code === "ENOENT" || err.code === "EINVAL")) {
                 settled = true;
                 reject(new Error(`LSP server binary not found: ${command}. ` +
                     `Install it or check your PATH.`));
@@ -254,7 +259,7 @@ export async function launchViaPackageManager(packageName, args = [], options =
         await new Promise((resolve, reject) => {
             let settled = false;
             proc.on("error", (err) => {
-                if (!settled && err.code === "ENOENT") {
+                if (!settled && (err.code === "ENOENT" || err.code === "EINVAL")) {
                     settled = true;
                     reject(new Error(`Package manager not found for: ${packageName}. ` +
                         `Install Node.js or check your PATH.`));

package/clients/lsp/launch.ts

@@ -205,8 +205,11 @@ export async function launchLSP(
 		if (npmGlobalPath) {
 			spawnCommand = npmGlobalPath;
 			// Recompute needsShell for npm global path
-			const globalHasExt = /\.(exe|cmd|bat)$/i.test(spawnCommand);
-			needsShell = isWindows && (spawnCommand.includes(" ") || !globalHasExt);
+			needsShell =
+				isWindows &&
+				(spawnCommand.includes(" ") ||
+					/\.(cmd|bat)$/i.test(spawnCommand) ||
+					!/\.(exe|cmd|bat)$/i.test(spawnCommand));
 		}
 	}
 
@@ -225,9 +228,11 @@ export async function launchLSP(
 			if (npmGlobalPath && npmGlobalPath !== spawnCommand) {
 				console.error(`[lsp] Trying npm global: ${npmGlobalPath}`);
 				// Recompute needsShell for npm global path
-				const globalHasExt = /\.(exe|cmd|bat)$/i.test(npmGlobalPath);
 				const needsShellGlobal =
-					isWindows && (npmGlobalPath.includes(" ") || !globalHasExt);
+					isWindows &&
+					(npmGlobalPath.includes(" ") ||
+						/\.(cmd|bat)$/i.test(npmGlobalPath) ||
+						!/\.(exe|cmd|bat)$/i.test(npmGlobalPath));
 				proc = trySpawn(npmGlobalPath, args, cwd, env, needsShellGlobal);
 			} else {
 				throw err;
@@ -256,7 +261,7 @@ export async function launchLSP(
 
 		// Attach error handler that can reject for immediate errors
 		proc.on("error", (err: Error & { code?: string }) => {
-			if (!settled && err.code === "ENOENT") {
+			if (!settled && (err.code === "ENOENT" || err.code === "EINVAL")) {
 				settled = true;
 				reject(
 					new Error(
@@ -346,7 +351,7 @@ export async function launchViaPackageManager(
 			let settled = false;
 
 			proc.on("error", (err: Error & { code?: string }) => {
-				if (!settled && err.code === "ENOENT") {
+				if (!settled && (err.code === "ENOENT" || err.code === "EINVAL")) {
 					settled = true;
 					reject(
 						new Error(

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "3.3.0",
+	"version": "3.3.1",
 	"type": "module",
 	"description": "pi extension for real-time code quality — 31 LSP servers, tree-sitter structural analysis, AST pattern matching, auto-install for TypeScript/Python tooling, duplicate detection, complexity metrics, and inline blockers with comprehensive /lens-booboo reports",
 	"repository": {