pi-lens 2.2.3 → 2.2.4

package/clients/dispatch/dispatcher.js

@@ -13,6 +13,7 @@
  * - OutputSemantic: How to display (blocking, warning, silent, etc.)
  * - BaselineStore: Track pre-existing issues for delta mode
  */
+import * as fs from "node:fs";
 import { detectFileKind } from "../file-kinds.js";
 // --- In-Memory Baseline Store ---
 export function createBaselineStore() {
@@ -31,6 +32,8 @@ export function createBaselineStore() {
 }
 // --- Runner Registry ---
 const globalRegistry = new Map();
+// Track last-run mtime per file+runner to skip unchanged files
+const lastRunMtimes = new Map(); // key: `${runnerId}:${filePath}` -> mtimeMs
 export function registerRunner(runner) {
     if (globalRegistry.has(runner.id)) {
         console.error(`[dispatch] Duplicate runner: ${runner.id}`);
@@ -41,17 +44,31 @@ export function registerRunner(runner) {
 export function getRunner(id) {
     return globalRegistry.get(id);
 }
-export function getRunnersForKind(kind) {
+export function getRunnersForKind(kind, filePath) {
     if (!kind)
         return [];
     const runners = [];
+    const isTestFile = filePath ? isTest(filePath) : false;
     for (const runner of globalRegistry.values()) {
+        // Skip runners that shouldn't run on test files
+        if (isTestFile && runner.skipTestFiles)
+            continue;
         if (runner.appliesTo.includes(kind) || runner.appliesTo.length === 0) {
             runners.push(runner);
         }
     }
     return runners.sort((a, b) => a.priority - b.priority);
 }
+function isTest(filePath) {
+    const normalized = filePath.replace(/\\/g, "/");
+    return (normalized.includes(".test.") ||
+        normalized.includes(".spec.") ||
+        normalized.includes("/test/") ||
+        normalized.includes("/tests/") ||
+        normalized.includes("__tests__/") ||
+        normalized.includes("test-utils") ||
+        normalized.startsWith("test-"));
+}
 export function listRunners() {
     return Array.from(globalRegistry.values());
 }
@@ -206,6 +223,22 @@ export async function dispatchForFile(ctx, groups) {
 }
 // --- Run Single Runner ---
 async function runRunner(ctx, runner, defaultSemantic) {
+    // Skip if file unchanged (optimization for expensive runners)
+    if (runner.skipIfUnchanged) {
+        const cacheKey = `${runner.id}:${ctx.filePath}`;
+        try {
+            const stats = fs.statSync(ctx.filePath);
+            const lastMtime = lastRunMtimes.get(cacheKey);
+            if (lastMtime && stats.mtimeMs <= lastMtime) {
+                return { status: "skipped", diagnostics: [], semantic: "none" };
+            }
+            // Update mtime after run (below)
+            lastRunMtimes.set(cacheKey, stats.mtimeMs);
+        }
+        catch {
+            // File doesn't exist or stat failed, continue with run
+        }
+    }
     try {
         const result = await runner.run(ctx);
         return {

package/clients/dispatch/dispatcher.ts

@@ -14,6 +14,7 @@
  * - BaselineStore: Track pre-existing issues for delta mode
  */
 
+import * as fs from "node:fs";
 import type { FileKind } from "../file-kinds.js";
 import { detectFileKind } from "../file-kinds.js";
 
@@ -51,6 +52,9 @@ export function createBaselineStore(): BaselineStore {
 
 const globalRegistry = new Map<string, RunnerDefinition>();
 
+// Track last-run mtime per file+runner to skip unchanged files
+const lastRunMtimes = new Map<string, number>(); // key: `${runnerId}:${filePath}` -> mtimeMs
+
 export function registerRunner(runner: RunnerDefinition): void {
 	if (globalRegistry.has(runner.id)) {
 		console.error(`[dispatch] Duplicate runner: ${runner.id}`);
@@ -65,10 +69,16 @@ export function getRunner(id: string): RunnerDefinition | undefined {
 
 export function getRunnersForKind(
 	kind: FileKind | undefined,
+	filePath?: string,
 ): RunnerDefinition[] {
 	if (!kind) return [];
 	const runners: RunnerDefinition[] = [];
+	const isTestFile = filePath ? isTest(filePath) : false;
+
 	for (const runner of globalRegistry.values()) {
+		// Skip runners that shouldn't run on test files
+		if (isTestFile && runner.skipTestFiles) continue;
+
 		if (runner.appliesTo.includes(kind) || runner.appliesTo.length === 0) {
 			runners.push(runner);
 		}
@@ -76,6 +86,19 @@ export function getRunnersForKind(
 	return runners.sort((a, b) => a.priority - b.priority);
 }
 
+function isTest(filePath: string): boolean {
+	const normalized = filePath.replace(/\\/g, "/");
+	return (
+		normalized.includes(".test.") ||
+		normalized.includes(".spec.") ||
+		normalized.includes("/test/") ||
+		normalized.includes("/tests/") ||
+		normalized.includes("__tests__/") ||
+		normalized.includes("test-utils") ||
+		normalized.startsWith("test-")
+	);
+}
+
 export function listRunners(): RunnerDefinition[] {
 	return Array.from(globalRegistry.values());
 }
@@ -288,6 +311,22 @@ async function runRunner(
 	runner: RunnerDefinition,
 	defaultSemantic: OutputSemantic,
 ): Promise<RunnerResult> {
+	// Skip if file unchanged (optimization for expensive runners)
+	if (runner.skipIfUnchanged) {
+		const cacheKey = `${runner.id}:${ctx.filePath}`;
+		try {
+			const stats = fs.statSync(ctx.filePath);
+			const lastMtime = lastRunMtimes.get(cacheKey);
+			if (lastMtime && stats.mtimeMs <= lastMtime) {
+				return { status: "skipped", diagnostics: [], semantic: "none" };
+			}
+			// Update mtime after run (below)
+			lastRunMtimes.set(cacheKey, stats.mtimeMs);
+		} catch {
+			// File doesn't exist or stat failed, continue with run
+		}
+	}
+
 	try {
 		const result = await runner.run(ctx);
 		return {

package/clients/dispatch/runners/ast-grep.js

@@ -13,6 +13,7 @@ const astGrepRunner = {
     appliesTo: ["jsts", "python", "go", "rust", "cxx"],
     priority: 30,
     enabledByDefault: false,
+    skipTestFiles: true, // Many rules are noisy in tests
     async run(ctx) {
         // Check if ast-grep is available
         const check = spawnSync("sg", ["--version"], {

package/clients/dispatch/runners/ast-grep.ts

@@ -21,6 +21,7 @@ const astGrepRunner: RunnerDefinition = {
 	appliesTo: ["jsts", "python", "go", "rust", "cxx"],
 	priority: 30,
 	enabledByDefault: false,
+	skipTestFiles: true, // Many rules are noisy in tests
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
 		// Check if ast-grep is available

package/clients/dispatch/runners/type-safety.js

@@ -12,6 +12,7 @@ const typeSafetyRunner = {
     appliesTo: ["jsts"],
     priority: 20,
     enabledByDefault: true,
+    skipIfUnchanged: true, // Skip type-coverage if file unchanged
     async run(ctx) {
         // Only check TypeScript files
         if (!ctx.filePath.match(/\.tsx?$/)) {

package/clients/dispatch/runners/type-safety.ts

@@ -20,6 +20,7 @@ const typeSafetyRunner: RunnerDefinition = {
 	appliesTo: ["jsts"],
 	priority: 20,
 	enabledByDefault: true,
+	skipIfUnchanged: true, // Skip type-coverage if file unchanged
 
 	async run(ctx: DispatchContext): Promise<RunnerResult> {
 		// Only check TypeScript files

package/clients/dispatch/types.ts

@@ -96,6 +96,10 @@ export interface RunnerDefinition {
 	appliesTo: readonly FileKind[];
 	priority: number;
 	enabledByDefault: boolean;
+	/** Skip this runner for test files (false positive reduction) */
+	skipTestFiles?: boolean;
+	/** Skip if file unchanged since last run (check mtime) */
+	skipIfUnchanged?: boolean;
 	/** Check if runner should run */
 	when?: (ctx: DispatchContext) => Promise<boolean> | boolean;
 	/** Execute the runner */

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "2.2.3",
+	"version": "2.2.4",
 	"type": "module",
 	"description": "Real-time code quality feedback for pi — TypeScript LSP, Biome, ast-grep, Ruff, complexity metrics, duplicate detection. Includes automated fix loop (/lens-booboo-fix) and interactive architectural refactoring (/lens-booboo-refactor) with browser-based interviews.",
 	"repository": {