pi-lens 2.0.8 → 2.0.9

package/clients/ast-grep-client.ts

@@ -354,12 +354,14 @@ message: found
 			}
 
 			return result_groups;
-		} catch {
+		} catch (err) { void err;
 			return [];
 		} finally {
 			try {
 				require("node:fs").rmSync(ruleDir, { recursive: true, force: true });
-			} catch (err) { void err; }
+			} catch (err) {
+				void err;
+			}
 		}
 	}
 
@@ -435,7 +437,9 @@ message: found
 		} finally {
 			try {
 				require("node:fs").rmSync(ruleDir, { recursive: true, force: true });
-			} catch (err) { void err; }
+			} catch (err) {
+				void err;
+			}
 		}
 
 		return exports;
@@ -484,7 +488,7 @@ message: found
 					const parsed = JSON.parse(stdout);
 					const matches = Array.isArray(parsed) ? parsed : [parsed];
 					resolve({ matches });
-				} catch {
+				} catch (err) { void err;
 					resolve({ matches: [], error: "Failed to parse output" });
 				}
 			});
@@ -595,7 +599,7 @@ message: found
 				}
 				return diagnostics;
 			}
-		} catch {
+		} catch (err) { void err;
 			// Not a JSON array, try ndjson format (legacy)
 		}
 
@@ -607,7 +611,7 @@ message: found
 				const item: AstGrepJsonDiagnostic = JSON.parse(line);
 				const diag = this.parseDiagnostic(item, resolvedFilterFile);
 				if (diag) diagnostics.push(diag);
-			} catch {
+			} catch (err) { void err;
 				// Skip unparseable lines
 			}
 		}

package/clients/biome-client.ts

@@ -313,7 +313,7 @@ export class BiomeClient {
 			if (content === formatted) return "";
 
 			return this.computeDiff(content, formatted);
-		} catch {
+		} catch (err) { void err;
 			return "";
 		}
 	}
@@ -368,7 +368,7 @@ export class BiomeClient {
 			}
 
 			return diagnostics;
-		} catch {
+		} catch (err) { void err;
 			this.log("Failed to parse biome JSON output");
 			return [];
 		}

package/clients/go-client.ts

@@ -79,7 +79,9 @@ export class GoClient {
 						return p;
 					}
 				}
-			} catch (err) { void err; }
+			} catch (err) {
+				void err;
+			}
 		}
 
 		return null;

package/clients/jscpd-client.ts

@@ -120,7 +120,9 @@ export class JscpdClient {
 		} finally {
 			try {
 				fs.rmSync(outDir, { recursive: true, force: true });
-			} catch (err) { void err; }
+			} catch (err) {
+				void err;
+			}
 		}
 	}
 
@@ -168,7 +170,7 @@ export class JscpdClient {
 			}));
 
 			return { success: true, clones, duplicatedLines, totalLines, percentage };
-		} catch {
+		} catch (err) { void err;
 			return {
 				success: false,
 				clones: [],

package/clients/knip-client.ts

@@ -241,7 +241,7 @@ export class KnipClient {
 				unlistedDeps,
 				summary: `Found ${issues.length} issues`,
 			};
-		} catch {
+		} catch (err) { void err;
 			this.log("Failed to parse knip JSON output");
 			return {
 				success: false,

package/clients/ruff-client.ts

@@ -64,7 +64,7 @@ export class RuffClient {
 			if (this.ruffAvailable) {
 				this.log(`Ruff found: ${result.stdout.trim()}`);
 			}
-		} catch {
+		} catch (err) { void err;
 			this.ruffAvailable = false;
 		}
 
@@ -147,9 +147,7 @@ export class RuffClient {
 				.split("\n")
 				.filter((l) => l.startsWith("+") || l.startsWith("-")).length;
 			return `[Ruff Format] ${diffLines} line(s) would change — run 'ruff format ${path.basename(filePath)}' to fix`;
-		} catch {
-			return "";
-		}
+		} catch (err) { void err; return ""; } // Intentionally return empty string on diff failure
 	}
 
 	/**
@@ -318,7 +316,7 @@ export class RuffClient {
 			}
 
 			return diagnostics;
-		} catch {
+		} catch (err) { void err;
 			this.log("Failed to parse ruff JSON output");
 			return [];
 		}

package/clients/rust-client.ts

@@ -95,7 +95,9 @@ export class RustClient {
 						return p;
 					}
 				}
-			} catch (err) { void err; }
+			} catch (err) {
+				void err;
+			}
 		}
 
 		return null;
@@ -265,7 +267,9 @@ export class RustClient {
 						});
 					}
 				}
-			} catch (err) { void err; } // Skip non-JSON lines
+			} catch (err) {
+				void err;
+			} // Skip non-JSON lines
 		}
 
 		return diags;

package/clients/subprocess-client.ts

@@ -84,7 +84,7 @@ export abstract class SubprocessClient<T extends Diagnostic> {
 			} else {
 				this.log(`${this.toolName} not available`);
 			}
-		} catch {
+		} catch (err) { void err;
 			this.available = false;
 		}
 

package/clients/test-runner-client.ts

@@ -262,7 +262,7 @@ export class TestRunnerClient {
 					this.availableRunners.set(`${cwd}:pytest:config`, true);
 					return { runner: "pytest", config: RUNNERS.pytest };
 				}
-			} catch {
+			} catch (err) { void err;
 				// package.json parse error
 			}
 		}
@@ -291,7 +291,7 @@ export class TestRunnerClient {
 						return files.some((f) =>
 							new RegExp(cf.replace(/\*/g, ".*")).test(f),
 						);
-					} catch {
+					} catch (err) { void err;
 						return false;
 					}
 				}
@@ -315,7 +315,9 @@ export class TestRunnerClient {
 				this.log("Detected pytest globally");
 				return { runner: "pytest", config: RUNNERS.pytest };
 			}
-		} catch (err) { void err; }
+		} catch (err) {
+			void err;
+		}
 
 		return null;
 	}
@@ -364,7 +366,7 @@ export class TestRunnerClient {
 							this.log(`Found test file: ${testPath}`);
 							return { testFile: testPath, runner: detected.runner };
 						}
-					} catch {
+					} catch (err) { void err;
 						// Directory not readable
 					}
 				}
@@ -545,7 +547,7 @@ export class TestRunnerClient {
 				failures,
 				duration: 0, // Vitest JSON doesn't include duration in this format
 			};
-		} catch {
+		} catch (err) { void err;
 			// If JSON parsing fails, check for basic pass/fail indicators
 			const failed = stdout.includes("FAIL") || stderr.includes("FAIL");
 			return this.emptyResult(
@@ -617,7 +619,7 @@ export class TestRunnerClient {
 				failures,
 				duration: 0,
 			};
-		} catch {
+		} catch (err) { void err;
 			const failed = stdout.includes("FAIL") || stderr.includes("FAIL");
 			return this.emptyResult(
 				testFile,

package/clients/type-coverage-client.test.ts

@@ -9,7 +9,9 @@ describe("TypeCoverageClient", () => {
 
 	beforeEach(() => {
 		client = new TypeCoverageClient();
-		({ tmpDir: _tmpDir, cleanup } = setupTestEnvironment("pi-lens-typecoverage-test-"));
+		({ tmpDir: _tmpDir, cleanup } = setupTestEnvironment(
+			"pi-lens-typecoverage-test-",
+		));
 	});
 
 	afterEach(() => {

package/clients/typescript-client.ts

@@ -81,7 +81,7 @@ function loadCompilerOptions(tsconfigPath: string): ts.CompilerOptions {
 		if (parsed.errors.length) return DEFAULT_COMPILER_OPTIONS;
 		// Always set skipLibCheck to avoid noise from node_modules
 		return { ...parsed.options, skipLibCheck: true };
-	} catch {
+	} catch (err) { void err;
 		return DEFAULT_COMPILER_OPTIONS;
 	}
 }

package/index.ts

@@ -281,14 +281,14 @@ export default function (pi: ExtensionAPI) {
 							if (trimmed.startsWith("[")) {
 								try {
 									return JSON.parse(trimmed);
-								} catch {
+								} catch (err) { void err;
 									return [];
 								}
 							}
 							return raw.split("\n").flatMap((l: string) => {
 								try {
 									return [JSON.parse(l)];
-								} catch {
+								} catch (err) { void err;
 									return [];
 								}
 							});
@@ -661,10 +661,6 @@ export default function (pi: ExtensionAPI) {
 			type: "agent",
 			note: "Add this.log('Error: ' + err.message) to the catch block",
 		},
-		"silent-failure": {
-			type: "agent",
-			note: "Add this.log('Error: ' + err.message) or rethrow",
-		},
 		"no-console-log": {
 			type: "agent",
 			note: "Remove or replace with class logger method",
@@ -833,7 +829,7 @@ export default function (pi: ExtensionAPI) {
 					: raw.split("\n").flatMap((l: string) => {
 							try {
 								return [JSON.parse(l)];
-							} catch {
+							} catch (err) { void err;
 								return [];
 							}
 						});
@@ -1241,8 +1237,18 @@ export default function (pi: ExtensionAPI) {
 			report += `|-------|-------|------------|\n`;
 			for (const [grade, count] of Object.entries(gradeCount)) {
 				const pct = ((count / results.length) * 100).toFixed(1);
-				const gradeIcons: Record<string, string> = { A: "🟢", B: "🟡", C: "🟠", D: "🔴" };
-				const gradeThresholds: Record<string, number> = { A: 80, B: 60, C: 40, D: 20 };
+				const gradeIcons: Record<string, string> = {
+					A: "🟢",
+					B: "🟡",
+					C: "🟠",
+					D: "🔴",
+				};
+				const gradeThresholds: Record<string, number> = {
+					A: 80,
+					B: 60,
+					C: 40,
+					D: 20,
+				};
 				const icon = gradeIcons[grade] ?? "⚫";
 				const threshold = gradeThresholds[grade] ?? 0;
 				report += `| ${icon} ${grade} (MI ≥ ${threshold}) | ${count} | ${pct}% |\n`;
@@ -1683,9 +1689,10 @@ export default function (pi: ExtensionAPI) {
 	const preWriteHints = new Map<string, string>();
 
 	pi.on("tool_call", async (event, _ctx) => {
-		const filePath = (isToolCallEventType("write", event) || isToolCallEventType("edit", event))
-			? (event.input as { path: string }).path
-			: undefined;
+		const filePath =
+			isToolCallEventType("write", event) || isToolCallEventType("edit", event)
+				? (event.input as { path: string }).path
+				: undefined;
 
 		if (!filePath) return;
 
@@ -2113,7 +2120,7 @@ export default function (pi: ExtensionAPI) {
 				for (const [name, file] of newExports) {
 					cachedExports.set(name, file);
 				}
-			} catch {
+			} catch (err) { void err;
 				// ast-grep not available, skip
 			}
 		}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "2.0.8",
+	"version": "2.0.9",
 	"description": "Real-time code feedback for pi — TypeScript LSP, Biome, ast-grep, Ruff, TODO scanner, dead code, duplicate detection, type coverage",
 	"repository": {
 		"type": "git",

package/rules/ast-grep-rules/rules/empty-catch.yml

@@ -4,13 +4,16 @@ message: "Empty catch block — handle or log the error"
 severity: warning
 note: |
   Silently swallowing errors makes debugging impossible.
-  At minimum, log the error. Ideally, handle it properly.
+  Catches with return statements, assignments, or error propagation are acceptable.
 rule:
-  all:
-    - kind: catch_clause
-    - has:
-        kind: statement_block
-        not:
-          has:
-            kind: expression_statement
-            stopBy: end
+  kind: catch_clause
+  has:
+    kind: statement_block
+    not:
+      has:
+        any:
+          - kind: expression_statement   # this.log(...), void err, etc.
+          - kind: return_statement       # return defaultValue
+          - kind: throw_statement        # rethrow
+          - kind: variable_declaration   # const x = ...
+          - kind: assignment_expression  # x = ...

package/rules/ast-grep-rules/rules/silent-failure.yml

@@ -1,14 +0,0 @@
-id: silent-failure
-language: TypeScript
-message: "Silent failure detected — log or rethrow the error"
-severity: warning
-note: |
-  Empty catch blocks swallow errors silently.
-  Always log the error or rethrow it to aid debugging.
-rule:
-  kind: catch_clause
-  has:
-    kind: statement_block
-    not:
-      has:
-        kind: throw_statement