pi-lens 2.0.37 → 2.0.39

package/clients/typescript-client.ts

@@ -323,31 +323,53 @@ export class TypeScriptClient {
 		};
 	}
 
+	private withPosition<T>(
+		filePath: string,
+		line: number,
+		character: number,
+		cb: (
+			normalized: string,
+			position: number,
+			ls: ts.LanguageService,
+		) => T | undefined,
+	): T | [] {
+		const resolved = this.resolvePosition(filePath, line, character);
+		if (!resolved) return [];
+		const { normalized, position, ls } = resolved;
+		return cb(normalized, position, ls) ?? [];
+	}
+
 	/**
 	 * Go to definition
 	 */
 	getDefinition(filePath: string, line: number, character: number): Location[] {
-		const resolved = this.resolvePosition(filePath, line, character);
-		if (!resolved) return [];
-		const { normalized, position, ls } = resolved;
-		const definitions = ls.getDefinitionAtPosition(normalized, position);
-		if (!definitions) return [];
-
-		return definitions.map((def) => {
-			if (def.textSpan) {
-				const defFile = def.fileName || normalized;
-				const defContent = this.fileContents.get(defFile) || "";
-				if (defContent) {
-					const lines = defContent.substring(0, def.textSpan.start).split("\n");
-					return {
-						file: defFile,
-						line: lines.length - 1,
-						character: lines[lines.length - 1].length,
-					};
-				}
-			}
-			return { file: def.fileName, line: 0, character: 0 };
-		});
+		return this.withPosition(
+			filePath,
+			line,
+			character,
+			(normalized, position, ls) => {
+				const definitions = ls.getDefinitionAtPosition(normalized, position);
+				if (!definitions) return undefined;
+
+				return definitions.map((def) => {
+					if (def.textSpan) {
+						const defFile = def.fileName || normalized;
+						const defContent = this.fileContents.get(defFile) || "";
+						if (defContent) {
+							const lines = defContent
+								.substring(0, def.textSpan.start)
+								.split("\n");
+							return {
+								file: defFile,
+								line: lines.length - 1,
+								character: lines[lines.length - 1].length,
+							};
+						}
+					}
+					return { file: def.fileName, line: 0, character: 0 };
+				});
+			},
+		) as Location[];
 	}
 
 	/**
@@ -358,24 +380,32 @@ export class TypeScriptClient {
 		line: number,
 		character: number,
 	): Location[] {
-		const resolved = this.resolvePosition(filePath, line, character);
-		if (!resolved) return [];
-		const { normalized, position, ls } = resolved;
-		const defs = ls.getTypeDefinitionAtPosition(normalized, position);
-		if (!defs) return [];
-		return this.toLocations(defs, normalized);
+		return this.withPosition(
+			filePath,
+			line,
+			character,
+			(normalized, position, ls) => {
+				const defs = ls.getTypeDefinitionAtPosition(normalized, position);
+				if (!defs) return undefined;
+				return this.toLocations(defs, normalized);
+			},
+		) as Location[];
 	}
 
 	/**
 	 * Find references
 	 */
 	getReferences(filePath: string, line: number, character: number): Location[] {
-		const resolved = this.resolvePosition(filePath, line, character);
-		if (!resolved) return [];
-		const { normalized, position, ls } = resolved;
-		const references = ls.getReferencesAtPosition(normalized, position);
-		if (!references) return [];
-		return this.toLocations(references);
+		return this.withPosition(
+			filePath,
+			line,
+			character,
+			(normalized, position, ls) => {
+				const references = ls.getReferencesAtPosition(normalized, position);
+				if (!references) return undefined;
+				return this.toLocations(references);
+			},
+		) as Location[];
 	}
 
 	/** Map TS definition/reference entries to Location objects. */
@@ -442,16 +472,24 @@ export class TypeScriptClient {
 		line: number,
 		character: number,
 	): CompletionItem[] {
-		const resolved = this.resolvePosition(filePath, line, character);
-		if (!resolved) return [];
-		const { normalized, position, ls } = resolved;
-		const completions = ls.getCompletionsAtPosition(normalized, position, {});
-		if (!completions) return [];
-		return completions.entries.slice(0, 50).map((entry) => ({
-			name: entry.name,
-			kind: this.completionKind(entry.kind),
-			sortText: entry.sortText,
-		}));
+		return this.withPosition(
+			filePath,
+			line,
+			character,
+			(normalized, position, ls) => {
+				const completions = ls.getCompletionsAtPosition(
+					normalized,
+					position,
+					{},
+				);
+				if (!completions) return undefined;
+				return completions.entries.slice(0, 50).map((entry) => ({
+					name: entry.name,
+					kind: this.completionKind(entry.kind),
+					sortText: entry.sortText,
+				}));
+			},
+		) as CompletionItem[];
 	}
 
 	/**
@@ -462,15 +500,19 @@ export class TypeScriptClient {
 		line: number,
 		character: number,
 	): Location[] {
-		const resolved = this.resolvePosition(filePath, line, character);
-		if (!resolved) return [];
-		const { normalized, position, ls } = resolved;
-		const implementations = ls.getImplementationAtPosition(
-			normalized,
-			position,
-		);
-		if (!implementations) return [];
-		return this.toLocations(implementations);
+		return this.withPosition(
+			filePath,
+			line,
+			character,
+			(normalized, position, ls) => {
+				const implementations = ls.getImplementationAtPosition(
+					normalized,
+					position,
+				);
+				if (!implementations) return undefined;
+				return this.toLocations(implementations);
+			},
+		) as Location[];
 	}
 
 	/**

package/default-architect.yaml

@@ -0,0 +1,87 @@
+# .pi-lens/architect.yaml
+# Architectural rules for your project
+# Copy to your project root as .pi-lens/architect.yaml and customize.
+#
+# Structure is language-agnostic — regex patterns in must_not are language-specific.
+
+version: "1.1"
+
+# =============================================================================
+# LANGUAGE-AGNOSTIC RULES (The "Universal Truths")
+# =============================================================================
+
+rules:
+  # --- CI & Environment Safety ---
+  - pattern: "**/*.{ts,tsx,js,jsx,py,go,rs,java,cpp}"
+    must_not:
+      - pattern: "[a-zA-Z]:\\\\(?:Users|Program Files|Windows|Temp)\\\\"
+        message: "No absolute Windows paths — breaks CI and cross-platform builds."
+      - pattern: "\\/(?:home|Users|usr|etc|var)\\/[a-zA-Z0-9_\\-]+\\/"
+        message: "Potential absolute Unix path detected — use relative paths or path.join()."
+      - pattern: 'https?://localhost:[0-9]+'
+        message: "No hardcoded localhost URLs — use environment variables or a config service."
+
+  # --- Complexity & Technical Debt ---
+  - pattern: "**/*.{ts,tsx,js,jsx,py,go,rs}"
+    max_lines: 3000
+    must_not:
+      - pattern: '(?:\s{8,}.*\n){5,}'
+        message: "Deep nesting detected (4+ levels). Refactor into smaller functions to reduce cognitive load."
+      - pattern: '(?:(?:\/\/|#).*\n){10,}'
+        message: "Large block of commented-out code detected. This is dead code — delete it and rely on Git history."
+
+  # --- Reliability & Fragility ---
+  - pattern: "**/*.{ts,tsx,js,jsx,py,go,rs}"
+    must_not:
+      - pattern: '(?:catch|except)\s*\(?.*?\)?\s*\{\s*\}'
+        message: "No empty catch/except blocks. Swallowing errors makes debugging impossible — at least log the error."
+      - pattern: '\b(password|secret|api_?key|token|private_?key)\b\s*[:=]\s*["\'][^"\']{8,}["\']'
+        message: "No hardcoded secrets — use environment variables or a secrets manager."
+
+# =============================================================================
+# JS/TS-SPECIFIC RULES (Node.js & Frontend)
+# =============================================================================
+
+  # --- Type Safety ---
+  - pattern: "**/*.{ts,tsx}"
+    must_not:
+      - pattern: ':\s*any\b|as\s+any\b'
+        message: "No 'any' types — use 'unknown' or define a proper interface to maintain type safety."
+    must:
+      - "Use strict TypeScript mode"
+
+  # --- Configuration & IO ---
+  - pattern: "**/services/**/*.ts|**/domain/**/*.ts"
+    must_not:
+      - pattern: 'process\.env'
+        message: "Domain/Service logic must not read env vars directly — inject config via constructor or a config service."
+      - pattern: 'console\.(log|warn|error)'
+        message: "Core logic should use a structured logger, not console.log."
+
+  # --- Async Patterns ---
+  - pattern: "**/*.{ts,tsx,js,jsx}"
+    must_not:
+      - pattern: '\.then\('
+        message: "Prefer async/await over .then() chains for better readability and error handling."
+
+# =============================================================================
+# PYTHON-SPECIFIC RULES
+# =============================================================================
+
+  # --- Clean Python ---
+  - pattern: "**/*.py"
+    must_not:
+      - pattern: 'print\('
+        message: "No print() statements in production code — use the 'logging' module."
+      - pattern: 'global\s+[a-zA-Z_]'
+        message: "No 'global' keyword — global state makes code untestable and unpredictable."
+      - pattern: 'def\s+[a-zA-Z0-9_]+\(.*?=\s*\[\]'
+        message: "No mutable default arguments (e.g., x=[]). Use 'x=None' and initialize inside the function."
+
+  # --- Python Reliability ---
+  - pattern: "**/*.py"
+    must_not:
+      - pattern: 'except:\s*pass|except\s+Exception:\s*pass'
+        message: "Do not use bare 'except: pass'. Explicitly catch specific exceptions and log them."
+      - pattern: 'eval\(|exec\('
+        message: "No eval() or exec() — these are security risks and architectural anti-patterns."