pi-lens 2.0.25 → 2.0.26

package/index.ts

@@ -662,6 +662,26 @@ export default function (pi: ExtensionAPI) {
 			type: "skip",
 			note: "Renaming requires understanding all variable scopes.",
 		},
+		"no-process-env": {
+			type: "skip",
+			note: "Using process.env directly makes code untestable. Use DI or a config module.",
+		},
+		"no-param-reassign": {
+			type: "agent",
+			note: "Create a new variable instead of reassigning the parameter.",
+		},
+		"no-single-char-var": {
+			type: "skip",
+			note: "Renaming requires understanding the variable's purpose.",
+		},
+		"switch-without-default": {
+			type: "agent",
+			note: "Add a default case to handle unexpected values.",
+		},
+		"no-architecture-violation": {
+			type: "skip",
+			note: "Layer boundary violations require architectural decisions.",
+		},
 	};
 
 	// Derived from RULE_ACTIONS — used to suppress architectural rules from inline hard stops.

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "2.0.25",
+	"version": "2.0.26",
 	"description": "Real-time code quality feedback for pi — TypeScript LSP, Biome, ast-grep, Ruff, complexity metrics, duplicate detection. Includes automated fix loop (/lens-booboo-fix) and interactive architectural refactoring (/lens-booboo-refactor) with browser-based interviews.",
 	"repository": {
 		"type": "git",

package/rules/ast-grep-rules/rules/no-architecture-violation.yml

@@ -0,0 +1,15 @@
+id: no-architecture-violation
+language: TypeScript
+message: "Forbidden import — layer boundary violation: importing from database/model layer"
+severity: error
+note: |
+  This import crosses an architectural layer boundary.
+  Use dependency injection or a shared types/interfaces module instead.
+  
+  BAD: import { User } from '../models/user';
+  GOOD: import { User } from '../types/user';
+rule:
+  pattern: import { $$$ } from "$PATH"
+constraints:
+  PATH:
+    regex: ".*models.*|.*database.*|.*prisma.*"

package/rules/ast-grep-rules/rules/no-param-reassign.yml

@@ -0,0 +1,16 @@
+id: no-param-reassign
+language: TypeScript
+message: "Do not reassign function parameters — create a new variable instead"
+severity: warning
+note: |
+  Reassigning parameters makes code harder to debug and reason about.
+  It can cause unexpected side effects when the caller's reference changes.
+  Create a new variable with a descriptive name instead.
+  
+  BAD: function update(user) { user = { ...user, active: true }; }
+  GOOD: function update(user) { const updated = { ...user, active: true }; }
+rule:
+  pattern: |
+    function $FUNC($PARAM, $$$) {
+      $PARAM = $VALUE
+    }

package/rules/ast-grep-rules/rules/no-process-env.yml

@@ -0,0 +1,18 @@
+id: no-process-env
+language: TypeScript
+message: "Do not access process.env directly — use dependency injection or a config module"
+severity: error
+note: |
+  Direct process.env access makes code untestable and tightly coupled to the
+  runtime environment. Use a configuration service or DI container instead.
+  
+  BAD: const dbUrl = process.env.DATABASE_URL;
+  GOOD: constructor(private config: ConfigService) {}
+        const dbUrl = this.config.get('DATABASE_URL');
+  
+  Grade 2.0 — critical architectural violation for testability.
+rule:
+  any:
+    - pattern: process.env.$KEY
+    - pattern: process.env[$KEY]
+    - pattern: Deno.env.get($KEY)

package/rules/ast-grep-rules/rules/no-single-char-var.yml

@@ -0,0 +1,12 @@
+id: no-single-char-var
+language: TypeScript
+message: "Avoid single-character variable names — use descriptive names"
+severity: info
+note: |
+  Single-character variable names reduce readability.
+  Exception: loop counters (i, j, k) in short loops are acceptable.
+rule:
+  pattern: const $VAR = $VALUE
+constraints:
+  VAR:
+    regex: "^[a-z]$"

package/rules/ast-grep-rules/rules/switch-without-default.yml

@@ -0,0 +1,12 @@
+id: switch-without-default
+language: TypeScript
+message: "Switch statement is missing a default case"
+severity: warning
+note: |
+  Every switch should have a default case. Without it, new enum values won't be caught at runtime.
+rule:
+  all:
+    - pattern: switch ($EXPR) { $$$CASES }
+    - not:
+        has:
+          pattern: "default: $$$"