pi-lens 1.3.2 → 1.3.3

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 All notable changes to pi-lens will be documented in this file.
 
+## [1.4.0] - 2026-03-23
+
+### Added
+- **Design smell rules**: New `long-method`, `long-parameter-list`, and `large-class` rules for structural quality checks.
+- **`/design-review` command**: Analyze files for design smells. Usage: `/design-review [path]`
+
+### Changed
+- **Improved ast-grep tool descriptions**: Better pattern guidance to prevent overly broad searches.
+
 ## [1.3.0] - 2026-03-23
 
 ### Changed

package/README.md

@@ -70,6 +70,7 @@ Example:
 | `/dead-code` | Find unused exports/files/dependencies (requires knip) |
 | `/check-deps` | Circular dependency scan (requires madge) |
 | `/format [file|--all]` | Apply Biome formatting |
+| `/design-review [path]` | Analyze files for design smells (long methods, large classes, etc.) |
 
 ### On-demand tools
 
@@ -136,6 +137,9 @@ Each rule includes a `message` and `note` that are shown in diagnostics, so the
 **Patterns**
 `no-console-log`, `no-alert`, `no-delete-operator`, `no-shadow`, `no-star-imports`, `switch-needs-default`
 
+**Design Smells**
+`long-method`, `long-parameter-list`, `large-class`
+
 ---
 
 ## External dependencies summary

package/clients/ast-grep-client.ts

@@ -411,7 +411,7 @@ export class AstGrepClient {
     return null;
   }
 
-  private getRuleDescription(ruleId: string): RuleDescription | undefined {
+  getRuleDescription(ruleId: string): RuleDescription | undefined {
     const descriptions = this.loadRuleDescriptions();
     return descriptions.get(ruleId);
   }

package/index.ts

@@ -187,6 +187,88 @@ export default function (pi: ExtensionAPI) {
 		},
 	});
 
+	pi.registerCommand("design-review", {
+		description:
+			"Analyze files for design smells (long methods, large classes, deep nesting). Usage: /design-review [path]",
+		handler: async (args, ctx) => {
+			if (!astGrepClient.isAvailable()) {
+				ctx.ui.notify(
+					"ast-grep not installed. Run: npm i -D @ast-grep/cli",
+					"error",
+				);
+				return;
+			}
+
+			const targetPath = args.trim() || ctx.cwd || process.cwd();
+			ctx.ui.notify("🔍 Analyzing design smells...", "info");
+
+			const configPath = path.join(
+				typeof __dirname !== "undefined" ? __dirname : ".",
+				"rules",
+				"ast-grep-rules",
+				".sgconfig.yml",
+			);
+
+			try {
+				const result = require("node:child_process").spawnSync("npx", [
+					"sg",
+					"scan",
+					"--config", configPath,
+					"--json",
+					targetPath,
+				], {
+					encoding: "utf-8",
+					timeout: 30000,
+					shell: true,
+				});
+
+				const output = result.stdout || result.stderr || "";
+				if (!output.trim() || result.status !== 1) {
+					ctx.ui.notify("✓ No design smells found", "info");
+					return;
+				}
+
+				let issues: Array<{line: number; rule: string; message: string}> = [];
+				const lines = output.split("\n").filter((l: string) => l.trim());
+
+				for (const line of lines) {
+					try {
+						const item = JSON.parse(line);
+						const ruleId = item.ruleId || item.name || "unknown";
+						const ruleDesc = astGrepClient.getRuleDescription?.(ruleId);
+						const message = ruleDesc?.message || item.message || ruleId;
+						const lineNum = item.labels?.[0]?.range?.start?.line || 
+							item.spans?.[0]?.range?.start?.line || 0;
+
+						issues.push({
+							line: lineNum + 1,
+							rule: ruleId,
+							message: message,
+						});
+					} catch {
+						// Skip unparseable lines
+					}
+				}
+
+				if (issues.length === 0) {
+					ctx.ui.notify("✓ No design smells found", "info");
+					return;
+				}
+
+				let report = `[Design Review] ${issues.length} design smell(s) found:\n`;
+				for (const issue of issues.slice(0, 20)) {
+					report += `  L${issue.line}: ${issue.rule} — ${issue.message}\n`;
+				}
+				if (issues.length > 20) {
+					report += `  ... and ${issues.length - 20} more\n`;
+				}
+				ctx.ui.notify(report, "info");
+			} catch (err: any) {
+				ctx.ui.notify(`Design review failed: ${err.message}`, "error");
+			}
+		},
+	});
+
 	pi.registerCommand("format", {
 		description:
 			"Apply Biome formatting to files. Usage: /format [file-path] or /format --all",

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "1.3.2",
+	"version": "1.3.3",
 	"description": "Real-time code feedback for pi — TypeScript LSP, Biome, ast-grep, Ruff, TODO scanner, dead code, duplicate detection, type coverage",
 	"repository": {
 		"type": "git",

package/rules/ast-grep-rules/rules/large-class.yml

@@ -0,0 +1,9 @@
+id: large-class
+language: TypeScript
+message: "Large class detected — consider splitting responsibilities"
+severity: hint
+note: |
+  Classes with more than 20 methods are harder to maintain.
+  Consider extracting related functionality into separate classes.
+rule:
+  kind: class_declaration

package/rules/ast-grep-rules/rules/long-method.yml

@@ -0,0 +1,9 @@
+id: long-method
+language: TypeScript
+message: "Long method detected — consider extracting smaller functions"
+severity: hint
+note: |
+  Methods over 50 lines are harder to test and maintain.
+  Consider extracting logical chunks into helper functions.
+rule:
+  kind: function_declaration

package/rules/ast-grep-rules/rules/long-parameter-list.yml

@@ -0,0 +1,9 @@
+id: long-parameter-list
+language: TypeScript
+message: "Function has many parameters — consider using an options object"
+severity: hint
+note: |
+  Functions with more than 4 parameters are hard to call and remember.
+  Consider grouping related params into an options object or configuration.
+rule:
+  kind: formal_parameters