pi-lens 1.3.12 → 1.3.14

package/clients/complexity-client.ts

@@ -291,6 +291,17 @@ export class ComplexityClient {
       warnings.push(`High entropy (${metrics.codeEntropy.toFixed(1)} bits) — follow project conventions`);
     }
 
+    // Comments ratio (>30% = excessive comments, AI slop signal)
+    const totalLines = metrics.linesOfCode + metrics.commentLines;
+    if (totalLines > 10 && metrics.commentLines / totalLines > 0.3) {
+      warnings.push(`Excessive comments (${Math.round(metrics.commentLines / totalLines * 100)}%) — remove obvious comments`);
+    }
+
+    // Verbose code (long functions with low complexity = overly verbose)
+    if (metrics.avgFunctionLength > 30 && metrics.cyclomaticComplexity < 3) {
+      warnings.push(`Verbose code (avg ${Math.round(metrics.avgFunctionLength)} lines, low complexity) — simplify or extract`);
+    }
+
     return warnings;
   }
 

package/index.ts

@@ -217,10 +217,10 @@ export default function (pi: ExtensionAPI) {
 
 	pi.registerCommand("lens-booboo", {
 		description:
-			"Code review: design smells + complexity metrics. Usage: /lens-booboo [path]",
+			"Full codebase review: design smells, complexity, AI slop detection, TODOs, dead code, duplicates, type coverage. Usage: /lens-booboo [path]",
 		handler: async (args, ctx) => {
 			const targetPath = args.trim() || ctx.cwd || process.cwd();
-			ctx.ui.notify("🔍 Running code review...", "info");
+			ctx.ui.notify("🔍 Running full codebase review...", "info");
 
 			const parts: string[] = [];
 
@@ -304,8 +304,9 @@ export default function (pi: ExtensionAPI) {
 				}
 			}
 
-			// Part 3: Complexity metrics
+			// Part 3: Complexity metrics + AI slop detection
 			const results: import("./clients/complexity-client.js").FileComplexity[] = [];
+			const aiSlopIssues: string[] = [];
 
 			const scanDir = (dir: string) => {
 				if (!require("node:fs").existsSync(dir)) return;
@@ -320,6 +321,15 @@ export default function (pi: ExtensionAPI) {
 						const metrics = complexityClient.analyzeFile(fullPath);
 						if (metrics) {
 							results.push(metrics);
+
+							// Check AI slop indicators per file
+							const warnings = complexityClient.checkThresholds(metrics);
+							if (warnings.length > 0) {
+								aiSlopIssues.push(`  ${metrics.filePath}:`);
+								for (const w of warnings) {
+									aiSlopIssues.push(`    ⚠ ${w}`);
+								}
+							}
 						}
 					}
 				}
@@ -355,9 +365,40 @@ export default function (pi: ExtensionAPI) {
 					if (highCognitive.length > 5) summary += `    ... and ${highCognitive.length - 5} more\n`;
 				}
 
+				// Add AI slop issues
+				if (aiSlopIssues.length > 0) {
+					summary += `\n[AI Slop Indicators]\n${aiSlopIssues.join("\n")}`;
+				}
+
 				parts.push(summary);
 			}
 
+			// Part 4: TODOs scan
+			const todoResult = todoScanner.scanDirectory(targetPath);
+			const todoReport = todoScanner.formatResult(todoResult);
+			if (todoReport) parts.push(todoReport);
+
+			// Part 5: Dead code (knip)
+			if (knipClient.isAvailable()) {
+				const knipResult = knipClient.analyze(targetPath);
+				const knipReport = knipClient.formatResult(knipResult);
+				if (knipReport) parts.push(knipReport);
+			}
+
+			// Part 6: Code duplication
+			if (jscpdClient.isAvailable()) {
+				const jscpdResult = jscpdClient.scan(targetPath);
+				const jscpdReport = jscpdClient.formatResult(jscpdResult);
+				if (jscpdReport) parts.push(jscpdReport);
+			}
+
+			// Part 7: Type coverage
+			if (typeCoverageClient.isAvailable()) {
+				const tcResult = typeCoverageClient.scan(targetPath);
+				const tcReport = typeCoverageClient.formatResult(tcResult);
+				if (tcReport) parts.push(tcReport);
+			}
+
 			if (parts.length === 0) {
 				ctx.ui.notify("✓ Code review clean", "info");
 			} else {
@@ -711,10 +752,24 @@ export default function (pi: ExtensionAPI) {
 
 			const diags = tsClient.getDiagnostics(filePath);
 			if (diags.length > 0) {
-				lspOutput += `\n\n[TypeScript] ${diags.length} issue(s):\n`;
-				for (const d of diags.slice(0, 10)) {
-					const label = d.severity === 2 ? "Warning" : "Error";
-					lspOutput += `  [${label}] L${d.range.start.line + 1}: ${d.message}\n`;
+				// Separate unused imports (TS6133, TS6196) from other diagnostics
+				const unusedImports = diags.filter(d => d.code === 6133 || d.code === 6196);
+				const otherDiags = diags.filter(d => d.code !== 6133 && d.code !== 6196);
+
+				if (unusedImports.length > 0) {
+					lspOutput += `\n\n[Unused Imports] ${unusedImports.length} imported but never used:\n`;
+					for (const d of unusedImports.slice(0, 10)) {
+						lspOutput += `  L${d.range.start.line + 1}: ${d.message}\n`;
+					}
+					lspOutput += `  → Remove unused imports to reduce noise\n`;
+				}
+
+				if (otherDiags.length > 0) {
+					lspOutput += `\n\n[TypeScript] ${otherDiags.length} issue(s):\n`;
+					for (const d of otherDiags.slice(0, 10)) {
+						const label = d.severity === 2 ? "Warning" : "Error";
+						lspOutput += `  [${label}] L${d.range.start.line + 1}: ${d.message}\n`;
+					}
 				}
 			}
 		}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-lens",
-	"version": "1.3.12",
+	"version": "1.3.14",
 	"description": "Real-time code feedback for pi — TypeScript LSP, Biome, ast-grep, Ruff, TODO scanner, dead code, duplicate detection, type coverage",
 	"repository": {
 		"type": "git",

package/rules/ast-grep-rules/rules/magic-numbers.yml

@@ -0,0 +1,9 @@
+id: magic-numbers
+language: TypeScript
+message: "Magic number detected — use a named constant"
+severity: hint
+note: |
+  Hardcoded numbers make code harder to understand and maintain.
+  Extract to a named constant with a descriptive name.
+rule:
+  kind: number

package/rules/ast-grep-rules/rules/silent-failure.yml

@@ -0,0 +1,14 @@
+id: silent-failure
+language: TypeScript
+message: "Silent failure detected — log or rethrow the error"
+severity: warning
+note: |
+  Empty catch blocks swallow errors silently.
+  Always log the error or rethrow it to aid debugging.
+rule:
+  kind: catch_clause
+  has:
+    kind: statement_block
+    not:
+      has:
+        kind: throw_statement