pi-lean-dimension 0.1.0 → 0.2.0

package/node_modules/pi-lean-portal/__tests__/cookie-persistence.test.ts

@@ -1,196 +1,36 @@
-/**
- * Cookie Persistence Integration Test — end-to-end validation of Bug A
- * (router loads storage state) and Bug B (plugin saves state on re-navigate).
- *
- * Uses a live Chromium browser against a local HTTP test server that serves
- * a page with a cookie-based consent dialog. The test:
- *
- * 1. Navigates with a named profile — dialog visible
- * 2. Clicks "Accept All" — sets a consent cookie
- * 3. Navigates again with the same profile — dialog should NOT reappear
- *    because `_persistState` saves the cookie to disk before closing the
- *    old context, and the returned state is passed to the new context
- *    via the in-memory fallback (options?.storageState ?? savedState).
- *
- * Auto-skips the entire suite when Playwright Chromium is not installed.
- */
-
-import { describe, it, expect, beforeAll, afterAll } from "vitest";
+import { existsSync } from "node:fs";
 import { chromium } from "playwright";
+import { describe, beforeAll, afterAll } from "vitest";
 import { ChromiumPlugin } from "../backends/chromium/index.js";
-import {
-	startTestServer,
-	COOKIE_PERSISTENCE_HTML,
-} from "./helpers/test-server.js";
-import {
-	loadStorageState,
-	deleteStorageState,
-} from "../core/shared/storage-state.js";
-import { sessionManager } from "../core/shared/session-manager.js";
-
-// ─── Chromium availability check — skip gracefully if absent ───────
-
-let chromiumAvailable = false;
-try {
-	chromium.executablePath();
-	chromiumAvailable = true;
-} catch {
-	chromiumAvailable = false;
-}
-
-const describeIfChromium = chromiumAvailable ? describe : describe.skip;
+import { startCookiePersistenceServer } from "./helpers/test-server.js";
+import { runPersistenceSuite } from "./helpers/persistence-suite.js";
 
-// ─── Test fixture HTML ─────────────────────────────────────────────
-
-/**
- * A page that shows a consent dialog when no cookie is present, and hides
- * it when the "consent=accepted" cookie exists. Clicking "Accept All" sets
- * the cookie and hides the dialog via JS.
- *
- * See ``COOKIE_PERSISTENCE_HTML`` in ``helpers/test-server.ts``.
- */
-
-// ─── Test Server Setup (always runs, server is cheap to start/stop) ─
+const describeIfAvailable = (() => {
+	try {
+		return existsSync(chromium.executablePath()) ? describe : describe.skip;
+	} catch {
+		return describe.skip;
+	}
+})();
 
 let serverUrl: string;
 let stopServer: () => Promise<void>;
 
 beforeAll(async () => {
-	const server = await startTestServer((req, res) => {
-		const url = new URL(req.url ?? "/", "http://localhost");
-		if (url.pathname === "/") {
-			res.writeHead(200, { "Content-Type": "text/html; charset=utf-8" });
-			res.end(COOKIE_PERSISTENCE_HTML);
-		} else {
-			res.writeHead(404, { "Content-Type": "text/html; charset=utf-8" });
-			res.end("404");
-		}
-	});
-	serverUrl = server.url;
-	stopServer = server.stop;
+	const s = await startCookiePersistenceServer();
+	serverUrl = s.url;
+	stopServer = s.stop;
 });
-
 afterAll(async () => {
 	await stopServer();
 });
 
-// ─── ChromiumPlugin Create Helper ─────────────────────────────────
-
-async function createPlugin(): Promise<ChromiumPlugin> {
-	const p = new ChromiumPlugin();
-	await p.init({});
-	return p;
-}
-
-const NAV_TIMEOUT = 30_000;
-const TASK_ID = "cookie-persistence";
-
-// ═════════════════════════════════════════════════════════════════
-// Tests — only run if Chromium is available
-// ═════════════════════════════════════════════════════════════════
-
-describeIfChromium(
-	"Cookie persistence across navigations",
-	() => {
-		const TEST_PROFILE = `cookie-persistence-test-${Date.now()}`;
-
-		let plugin: ChromiumPlugin;
-
-		beforeAll(async () => {
-			plugin = await createPlugin();
-		});
-
-		afterAll(async () => {
-			await plugin.cleanupAll().catch(() => {});
-			deleteStorageState(TEST_PROFILE);
-		});
-
-		it("navigates with a named profile — consent dialog is visible", async () => {
-			const nav = await plugin.navigate(serverUrl, TASK_ID, NAV_TIMEOUT, {
-				profileName: TEST_PROFILE,
-				profileMode: "named",
-			});
-			expect(nav.success).toBe(true);
-			expect(nav.title).toContain("Cookie Persistence Test");
-			expect(nav.snapshot).toContain("Consent");
-			expect(nav.snapshot).toContain("Accept All");
-		});
-
-		it("clicks Accept All — cookie set, consent dialog closes", async () => {
-			const snap = await plugin.snapshot(TASK_ID);
-			expect(snap.success).toBe(true);
-
-			// Find "Accept All" button in the snapshot and extract its @e ref
-			const btnMatch = snap.snapshot.match(/@(e\d+)\b.*?button.*?Accept All/);
-			expect(btnMatch).toBeTruthy();
-			if (!btnMatch) return;
-
-			const ref = `@${btnMatch[1]!}`;
-			const clickResult = await plugin.click(TASK_ID, ref);
-			expect(clickResult.success).toBe(true);
-
-			// Verify dialog is gone from snapshot
-			if (clickResult.snapshot) {
-				expect(clickResult.snapshot).not.toContain("Consent");
-			}
-		});
-
-		it("creates session and sets persistState (simulating the router's setup)", async () => {
-			// In production, router.navigate() creates the session and sets
-			// persistState & profileName before calling plugin.navigate().
-			// Since we're testing the plugin directly, we simulate this setup.
-			sessionManager.createSession(TASK_ID, "chromium");
-			const session = sessionManager.getSession(TASK_ID);
-			expect(session).toBeDefined();
-			if (session) {
-				session.persistState = true;
-				session.profileName = TEST_PROFILE;
-			}
-		});
-
-		it("navigates again with same profile — consent dialog does NOT reappear", async () => {
-			// This navigate triggers getOrCreateContext, which:
-			//   1. Calls _persistState → saves cookies to disk, returns state object
-			//   2. Closes old context
-			//   3. Uses savedState as fallback for the new context's storageState
-			// The cookie set during step 2 is thus available for the new context.
-			const nav = await plugin.navigate(serverUrl, TASK_ID, NAV_TIMEOUT, {
-				profileName: TEST_PROFILE,
-				profileMode: "named",
-			});
-			expect(nav.success).toBe(true);
-
-			// Consent dialog should NOT be present — cookies were restored
-			// from the in-memory fallback (savedState returned by _persistState).
-			expect(nav.snapshot).not.toContain("Consent");
-			expect(nav.snapshot).not.toContain("Accept All");
-		});
-
-		it("storage-state.json exists on disk with the consent cookie", async () => {
-			const state = loadStorageState(TEST_PROFILE);
-			expect(state).not.toBeNull();
-			expect(state!.cookies.length).toBeGreaterThan(0);
-
-			const consentCookie = state!.cookies.find(
-				(c) => c.name === "consent" && c.value === "accepted",
-			);
-			expect(consentCookie).toBeDefined();
-		});
-
-		it("third navigate also has no consent dialog (full disk-path round-trip)", async () => {
-			// The state saved to disk during the second navigate (test 4's
-			// _persistState call) is now available. The in-memory fallback
-			// returns it again, and the disk copy exists for the router to load.
-			const nav = await plugin.navigate(serverUrl, TASK_ID, NAV_TIMEOUT, {
-				profileName: TEST_PROFILE,
-				profileMode: "named",
-			});
-			expect(nav.success).toBe(true);
-
-			// Dialog should still be absent
-			expect(nav.snapshot).not.toContain("Consent");
-			expect(nav.snapshot).not.toContain("Accept All");
-		});
+runPersistenceSuite(describeIfAvailable, {
+	name: "chromium",
+	getServerUrl: () => serverUrl,
+	createPlugin: async () => {
+		const p = new ChromiumPlugin();
+		await p.init({});
+		return p;
 	},
-	120_000,
-);
+});

package/node_modules/pi-lean-portal/__tests__/fetch-backend.test.ts

@@ -7,7 +7,7 @@
  */
 
 import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import { webFetch, cleanupFetchTempFiles } from "../core/fetch-backend";
+import { webFetch, cleanupFetchTempFiles } from "../core/fetch-backend.js";
 
 // ─── Setup / Teardown ────────────────────────────────────────
 

package/node_modules/pi-lean-portal/__tests__/firefox-py-persistence.test.ts

@@ -1,192 +1,29 @@
-/**
- * Firefox-Py Cookie Persistence Integration Test — end-to-end validation
- * of cross-process storage-state flow for the Python adapter / firefox-py bridge.
- *
- * Uses a live Firefox browser via the Firefox-Py bridge against a local
- * HTTP test server that serves a page with a cookie-based consent dialog.
- *
- * Auto-skips the entire suite when Python/firefox-py prerequisites are
- * unavailable.
- */
-
-import { describe, it, expect, beforeAll, afterAll } from "vitest";
-import { resolve } from "node:path";
-import { existsSync } from "node:fs";
-import { spawnSync } from "node:child_process";
-
+import { describe, beforeAll, afterAll } from "vitest";
 import { PythonPluginAdapter } from "../backends/python-adapter.js";
-import {
-	startTestServer,
-	COOKIE_PERSISTENCE_HTML,
-} from "./helpers/test-server.js";
-import {
-	loadStorageState,
-	deleteStorageState,
-} from "../core/shared/storage-state.js";
-import { sessionManager } from "../core/shared/session-manager.js";
-
-// ─── Paths ──────────────────────────────────────────────────────────
-
-const BRIDGE_SCRIPT = resolve(__dirname, "../backends/firefox-py/bridge.py");
-const PYTHON_PATH = resolve(
-	__dirname,
-	"../backends/python-base/.venv/bin/python3",
-);
-
-// ─── Prerequisites check — skip gracefully if absent ────────────────
-
-const prerequisitesMet = (() => {
-	if (!existsSync(PYTHON_PATH)) return false;
-	if (!existsSync(BRIDGE_SCRIPT)) return false;
-	const result = spawnSync(PYTHON_PATH, ["--version"], {
-		stdio: "ignore",
-		timeout: 5_000,
-	});
-	if (result.status !== 0) return false;
-
-	// Quick check: can we import playwright AND is Firefox installed?
-	const check = spawnSync(
-		PYTHON_PATH,
-		[
-			"-c",
-			"from playwright.sync_api import sync_playwright; " +
-				"p = sync_playwright().start(); " +
-				"import os; ok = os.path.exists(p.firefox.executable_path); " +
-				"p.stop(); print('ok' if ok else 'no')",
-		],
-		{ stdio: "pipe", timeout: 10_000 },
-	);
-	return check.status === 0 && check.stdout.toString().trim() === "ok";
-})();
-
-const describeIfAvailable = prerequisitesMet ? describe : describe.skip;
-
-// ─── Test Server Setup (always runs, server is cheap to start/stop) ─
-
-let serverUrl: string;
-let stopServer: () => Promise<void>;
+import { createPyBackendTestHarness } from "./helpers/create-py-backend-harness.js";
+import { startCookiePersistenceServer } from "./helpers/test-server.js";
+import { runPersistenceSuite } from "./helpers/persistence-suite.js";
 
+const { bridgeScript, pythonPath, prerequisitesMet } =
+	createPyBackendTestHarness("firefox-py", { engine: "firefox" });
+let serverUrl: string, stopServer: () => Promise<void>;
 beforeAll(async () => {
-	const server = await startTestServer((req, res) => {
-		const url = new URL(req.url ?? "/", "http://localhost");
-		if (url.pathname === "/") {
-			res.writeHead(200, { "Content-Type": "text/html; charset=utf-8" });
-			res.end(COOKIE_PERSISTENCE_HTML);
-		} else {
-			res.writeHead(404, { "Content-Type": "text/html; charset=utf-8" });
-			res.end("404");
-		}
-	});
-	serverUrl = server.url;
-	stopServer = server.stop;
+	const s = await startCookiePersistenceServer();
+	serverUrl = s.url;
+	stopServer = s.stop;
 });
-
 afterAll(async () => {
 	await stopServer();
 });
-
-const NAV_TIMEOUT = 30_000;
-const TASK_ID = "firefox-py-persistence";
-
-// ═════════════════════════════════════════════════════════════════
-// Tests — only run if Firefox + Python prerequisites are met
-// ═════════════════════════════════════════════════════════════════
-
-describeIfAvailable(
-	"Firefox-Py cookie persistence across navigations",
-	() => {
-		const TEST_PROFILE = `firefox-py-persist-${Date.now()}`;
-
-		let plugin: PythonPluginAdapter;
-
-		beforeAll(async () => {
-			plugin = new PythonPluginAdapter("firefox-py-persist", {
-				bridgeScript: BRIDGE_SCRIPT,
-				pythonPath: PYTHON_PATH,
-			});
-			await plugin.init();
-		});
-
-		afterAll(async () => {
-			await plugin.cleanupAll().catch(() => {});
-			deleteStorageState(TEST_PROFILE);
-		});
-
-		it("navigates with a named profile — consent dialog is visible", async () => {
-			const nav = await plugin.navigate(serverUrl, TASK_ID, NAV_TIMEOUT, {
-				profileName: TEST_PROFILE,
-				profileMode: "named",
-			});
-			expect(nav.success).toBe(true);
-			expect(nav.title).toContain("Cookie Persistence Test");
-			expect(nav.snapshot).toContain("Consent");
-			expect(nav.snapshot).toContain("Accept All");
-		});
-
-		it("clicks Accept All — cookie set, consent dialog closes", async () => {
-			const snap = await plugin.snapshot(TASK_ID);
-			expect(snap.success).toBe(true);
-
-			// Find "Accept All" button in the snapshot and extract its @e ref
-			const btnMatch = snap.snapshot.match(/@(e\d+)\b.*?button.*?Accept All/);
-			expect(btnMatch).toBeTruthy();
-			if (!btnMatch) return;
-
-			const ref = `@${btnMatch[1]!}`;
-			const clickResult = await plugin.click(TASK_ID, ref);
-			expect(clickResult.success).toBe(true);
-
-			// Verify dialog is gone from snapshot
-			if (clickResult.snapshot) {
-				expect(clickResult.snapshot).not.toContain("Consent");
-			}
-		});
-
-		it("creates session and sets persistState (simulating the router's setup)", async () => {
-			sessionManager.createSession(TASK_ID, "firefox-py-persist");
-			const session = sessionManager.getSession(TASK_ID);
-			expect(session).toBeDefined();
-			if (session) {
-				session.persistState = true;
-				session.profileName = TEST_PROFILE;
-			}
-		});
-
-		it("navigates again with same profile — consent dialog does NOT reappear", async () => {
-			const nav = await plugin.navigate(serverUrl, TASK_ID, NAV_TIMEOUT, {
-				profileName: TEST_PROFILE,
-				profileMode: "named",
-			});
-			expect(nav.success).toBe(true);
-
-			// Consent dialog should NOT be present — cookies survived in-context
-			expect(nav.snapshot).not.toContain("Consent");
-			expect(nav.snapshot).not.toContain("Accept All");
-		});
-
-		it("storage-state.json exists on disk with the consent cookie", async () => {
-			const state = loadStorageState(TEST_PROFILE);
-			expect(state).not.toBeNull();
-			expect(state!.cookies.length).toBeGreaterThan(0);
-
-			const consentCookie = state!.cookies.find(
-				(c: { name: string; value: string }) =>
-					c.name === "consent" && c.value === "accepted",
-			);
-			expect(consentCookie).toBeDefined();
-		});
-
-		it("third navigate also has no consent dialog (persistence confirmed)", async () => {
-			const nav = await plugin.navigate(serverUrl, TASK_ID, NAV_TIMEOUT, {
-				profileName: TEST_PROFILE,
-				profileMode: "named",
-			});
-			expect(nav.success).toBe(true);
-
-			// Dialog should still be absent
-			expect(nav.snapshot).not.toContain("Consent");
-			expect(nav.snapshot).not.toContain("Accept All");
-		});
+runPersistenceSuite(prerequisitesMet ? describe : describe.skip, {
+	name: "firefox-py",
+	getServerUrl: () => serverUrl,
+	createPlugin: async () => {
+		const p = new PythonPluginAdapter("firefox-py-persist", {
+			bridgeScript,
+			pythonPath,
+		});
+		await p.init();
+		return p;
 	},
-	120_000,
-);
+});

package/node_modules/pi-lean-portal/__tests__/firefox-py.test.ts

@@ -1,107 +1,23 @@
-/**
- * Contract tests for the Firefox-Py backend — validates that the
- * PythonPluginAdapter + Firefox-Py bridge satisfies the BrowserPlugin
- * contract against a real browser.
- *
- * This test file instantiates a PythonPluginAdapter pointing at the
- * Firefox-Py bridge script and runs both structural and behavioral
- * contract tests.  The Python subprocess is managed by the adapter;
- * no manual setup is needed beyond having Playwright Firefox installed
- * in the Python virtual environment.
- *
- * Prerequisites:
- *   - Python venv at backends/python-base/.venv with playwright installed
- *   - Playwright Firefox browsers installed (playwright install firefox)
- */
-
-import { resolve } from "node:path";
-import { existsSync } from "node:fs";
-import { spawnSync } from "node:child_process";
-
 import { PythonPluginAdapter } from "../backends/python-adapter.js";
 import { runContractTests } from "./helpers/plugin-contract.js";
+import { createPyBackendTestHarness } from "./helpers/create-py-backend-harness.js";
 
-// ─── Paths ──────────────────────────────────────────────────────────
-
-const BRIDGE_SCRIPT = resolve(__dirname, "../backends/firefox-py/bridge.py");
-
-const PYTHON_PATH = resolve(
-	__dirname,
-	"../backends/python-base/.venv/bin/python3",
-);
-
-// ─── Environment check ───────────────────────────────────────────────
-
-const pythonAvailable = (() => {
-	if (!existsSync(PYTHON_PATH)) return false;
-	const result = spawnSync(PYTHON_PATH, ["--version"], {
-		stdio: "ignore",
-		timeout: 5_000,
-	});
-	return result.status === 0;
-})();
-
-const bridgeExists = existsSync(BRIDGE_SCRIPT);
-
-const firefoxAvailable = (() => {
-	if (!PYTHON_PATH) return false;
-	try {
-		const result = spawnSync(
-			PYTHON_PATH,
-			[
-				"-c",
-				"from playwright.sync_api import sync_playwright; " +
-					"p = sync_playwright().start(); " +
-					"import os; print(os.path.exists(p.firefox.executable_path)); " +
-					"p.stop()",
-			],
-			{ stdio: "pipe", timeout: 10_000 },
-		);
-		return result.status === 0 && result.stdout.toString().trim() === "True";
-	} catch {
-		return false;
-	}
-})();
-
-// ─── Plugin factory ─────────────────────────────────────────────────
-
-/**
- * Create a PythonPluginAdapter that drives the Firefox-Py bridge.
- *
- * The adapter is lazy — the Python subprocess won't start until the
- * first operation.  We pass the venv Python path so the bridge has
- * access to playwright and the shared pi_browser_bridge library.
- */
-function createFirefoxPyPlugin(): PythonPluginAdapter {
-	return new PythonPluginAdapter("firefox-py", {
-		bridgeScript: BRIDGE_SCRIPT,
-		pythonPath: PYTHON_PATH,
-		// Firefox-Py supports everything except AbortSignal
-		capabilities: {
-			supportsFullPageScreenshot: true,
-			supportsConsoleCapture: true,
-			supportsJavaScriptEvaluate: true,
-			supportsBotDetection: true,
-			supportsDialogAutoDismissal: true,
-			supportsAbortSignal: false,
-			engine: "firefox",
-		},
-	});
-}
-
-// ─── Run contract tests ──────────────────────────────────────────────
-
-// Skip the entire suite if prerequisites aren't met (CI without
-// Playwright installed, local dev without venv, etc.)
-const describeIfAvailable =
-	pythonAvailable && bridgeExists && firefoxAvailable
-		? describe
-		: describe.skip;
+const { bridgeScript, pythonPath, describeIfAvailable } =
+	createPyBackendTestHarness("firefox-py", { engine: "firefox" });
 
 describeIfAvailable("Firefox-Py contract tests", () => {
-	runContractTests("firefox-py", createFirefoxPyPlugin, {
-		realBrowser: true,
-		navigateTimeout: 30_000,
-		navigationSettle: true,
-	});
+	runContractTests(
+		"firefox-py",
+		() =>
+			new PythonPluginAdapter("firefox-py", {
+				bridgeScript,
+				pythonPath,
+				capabilities: {
+					supportsFullPageScreenshot: true,
+					supportsJavaScriptEvaluate: true,
+					engine: "firefox",
+				},
+			}),
+		{ realBrowser: true, navigateTimeout: 30_000, navigationSettle: true },
+	);
 });

package/node_modules/pi-lean-portal/__tests__/firefox.test.ts

@@ -1,28 +1,12 @@
-/**
- * FirefoxPlugin contract tests.
- *
- * Runs the shared `runContractTests` suite against the Node Firefox backend.
- * Skips automatically when Playwright Firefox is unavailable (no browser installed).
- */
-
 import { existsSync } from "node:fs";
 import { firefox } from "playwright";
 import { describe } from "vitest";
 import { runContractTests } from "./helpers/plugin-contract.js";
 import { FirefoxPlugin } from "../backends/firefox/index.js";
 
-function createFirefoxPlugin(): FirefoxPlugin {
-	return new FirefoxPlugin();
-}
-
-// Skip the entire suite if Playwright Firefox isn't installed.
-// We must check the file exists on disk — executablePath() returns a
-// path even when the browser hasn't been installed.
 const describeIfAvailable = (() => {
 	try {
-		const ffPath = firefox.executablePath();
-		if (!existsSync(ffPath)) return describe.skip;
-		return describe;
+		return existsSync(firefox.executablePath()) ? describe : describe.skip;
 	} catch {
 		return describe.skip;
 	}
@@ -31,7 +15,7 @@ const describeIfAvailable = (() => {
 describeIfAvailable(
 	"FirefoxPlugin contract tests",
 	() => {
-		runContractTests("firefox", createFirefoxPlugin, {
+		runContractTests("firefox", () => new FirefoxPlugin(), {
 			realBrowser: true,
 			navigateTimeout: 30_000,
 			navigationSettle: true,