pi-langfuse 1.5.9 → 1.5.11

package/index.ts

@@ -8,7 +8,7 @@
  */
 
 import { basename } from "node:path";
-import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
 
 import { state, resetRunState, runWithSession, setCurrentSession } from "./src/state.js";
 import { ensureConfig, promptForConfig, loadConfig } from "./src/config.js";
@@ -16,7 +16,7 @@ import { shutdownRuntime } from "./src/langfuse.js";
 import { handleLangfusePrivacyCommand, handleLangfuseStatusCommand, handleLangfuseTestCommand } from "./src/commands.js";
 import { getMessageFromEvent, extractAssistantOutput, getCapturePolicy } from "./src/utils.js";
 import { applyCapturePolicy } from "./src/capture-policy.js";
-import { startAgentRun, finishAgentRun } from "./src/handlers/agent.js";
+import { startAgentRun, finishAgentRun, recordSystemPrompt } from "./src/handlers/agent.js";
 import { startTurnObservation, finishTurnObservation } from "./src/handlers/turn.js";
 import {
   startGeneration,
@@ -74,10 +74,18 @@ export default async function (pi: ExtensionAPI) {
     },
   });
 
-  const getSessionId = (ctx?: any) => {
+  const getSessionId = (ctx?: unknown): string | undefined => {
     try {
-      const sessionFile = ctx?.sessionManager?.getSessionFile?.();
-      return sessionFile ? basename(sessionFile, ".jsonl") : undefined;
+      const sessionManager = (ctx as ExtensionContext | undefined)?.sessionManager;
+      const sessionId = sessionManager?.getSessionId?.();
+      if (typeof sessionId === "string" && sessionId) {
+        return sessionId;
+      }
+
+      const sessionFile = sessionManager?.getSessionFile?.();
+      return typeof sessionFile === "string" && sessionFile
+        ? basename(sessionFile, ".jsonl")
+        : undefined;
     } catch {
       return undefined;
     }
@@ -104,6 +112,9 @@ export default async function (pi: ExtensionAPI) {
     if (!state.agentState?.root) {
       await startAgentRun(event, ctx);
     }
+    // The system prompt is only final here: before_agent_start handlers that
+    // run after this extension may still rewrite it.
+    await recordSystemPrompt(ctx);
   }));
 
   pi.on("turn_start", async (event, ctx) => withSession(ctx, async () => {

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "pi-langfuse",
-	"version": "1.5.9",
+	"version": "1.5.11",
 	"description": "Langfuse extension for Pi coding agent",
 	"repository": {
 		"type": "git",

package/src/handlers/agent.ts

@@ -54,15 +54,6 @@ export async function startAgentRun(event: Record<string, unknown>, ctx: any) {
       state.currentProvider = ctx.model.provider || "";
     }
 
-    let systemPrompt = undefined;
-    try {
-      if (ctx.getSystemPrompt) {
-        systemPrompt = await ctx.getSystemPrompt();
-      }
-    } catch {
-      // Ignore if getSystemPrompt is not available or fails
-    }
-
     const rawPromptInput = shapePayload({
       prompt: event.prompt,
       images: event.images,
@@ -79,7 +70,6 @@ export async function startAgentRun(event: Record<string, unknown>, ctx: any) {
           ...(state.currentProvider ? { provider: state.currentProvider } : {}),
           sessionId: state.currentSessionId || undefined,
         },
-        systemPrompt: systemPrompt ? truncate(String(systemPrompt), getLimits().maxString) : undefined,
       },
       getCapturePolicy(),
     );
@@ -106,10 +96,7 @@ export async function startAgentRun(event: Record<string, unknown>, ctx: any) {
           "pi-agent",
             {
               input: captured.input,
-              metadata: {
-                ...(captured.metadata ?? {}),
-                ...(captured.systemPrompt ? { systemPrompt: captured.systemPrompt } : {}),
-              },
+              metadata: captured.metadata ?? {},
             },
           { asType: "agent" },
         ),
@@ -124,6 +111,49 @@ export async function startAgentRun(event: Record<string, unknown>, ctx: any) {
   }
 }
 
+/**
+ * Records the effective system prompt on the root agent observation.
+ *
+ * Deliberately called from `agent_start` rather than `before_agent_start`:
+ * during `before_agent_start` the extension runner hands each handler the
+ * prompt as it stands mid-chain, so extensions registered after this one
+ * (e.g. inline factories that rewrite the system prompt) are not reflected
+ * yet. By `agent_start` the session has applied the final override, and
+ * `ctx.getSystemPrompt()` returns the prompt actually sent to the model.
+ */
+export async function recordSystemPrompt(ctx: any) {
+  const root = state.agentState?.root;
+  if (state.isTracingDisabled || !root) {
+    return;
+  }
+
+  let systemPrompt = undefined;
+  try {
+    if (ctx.getSystemPrompt) {
+      systemPrompt = await ctx.getSystemPrompt();
+    }
+  } catch {
+    // Ignore if getSystemPrompt is not available or fails
+  }
+  if (!systemPrompt) {
+    return;
+  }
+
+  const captured = applyCapturePolicy(
+    { systemPrompt: truncate(String(systemPrompt), getLimits().maxString) },
+    getCapturePolicy(),
+  );
+  if (!captured.systemPrompt) {
+    return;
+  }
+
+  try {
+    root.update({ metadata: { systemPrompt: captured.systemPrompt } });
+  } catch (e) {
+    console.warn("\u{1F4CA} Langfuse: Failed to record system prompt", e);
+  }
+}
+
 export async function finishAgentRun(event: Record<string, unknown> = {}) {
   if (!state.agentState?.root) {
     resetRunState();

package/src/langfuse.ts

@@ -219,6 +219,9 @@ async function flushPendingScores(rt: LangfuseRuntime, signal: AbortSignal): Pro
 
   while (pendingScores.length > 0) {
     const scores = pendingScores.slice(0, MAX_SCORE_BATCH_SIZE);
+    for (const score of scores) {
+      score.id ??= randomUUID();
+    }
     try {
       const errors = await ingestBatch(
         rt,

package/src/types.ts

@@ -60,6 +60,7 @@ export interface LangfuseScoreClient {
 }
 
 export interface PendingScore {
+  id?: string;
   traceId?: string;
   sessionId?: string;
   observationId?: string;

package/types/pi-coding-agent.d.ts

@@ -1,4 +1,11 @@
 declare module "@earendil-works/pi-coding-agent" {
+  export interface ExtensionContext {
+    sessionManager?: {
+      getSessionId?: () => unknown;
+      getSessionFile?: () => unknown;
+    };
+  }
+
   export interface ExtensionAPI {
     on(event: string, handler: (event: any, ctx: any) => unknown): void;
     registerCommand(