pi-keyboard 0.1.1 → 0.1.3

package/features/keyboard.feature

@@ -58,8 +58,8 @@ Feature: Pi Keyboard Lighting Indicator
     Given a user has submitted a prompt or the agent is executing a turn
     When the agent starts thinking or executing tools
     Then the keyboard state machine updates to "thinking"
-    And the keyboard lighting is set to blue color
-    And the effect mode is set to breathing
+    And the transition is buffered with a gentle intermediate ramp to avoid abrupt visual changes
+    And the keyboard lighting is set to softened oceanic blue breathing
     And the update is applied with --no-save in memory
 
   Scenario: Pi transitions to need approval state with yellow blinking light
@@ -96,6 +96,14 @@ Feature: Pi Keyboard Lighting Indicator
     Then the unread status is cleared
     And the keyboard state machine transitions to "thinking"
 
+  Scenario: Orphaned unread record from an unexpectedly-exited session is cleaned up
+    Given a session had an unread chat state and then exited unexpectedly (crash / kill)
+    And that session's process is no longer alive, leaving an orphaned unread record
+    When a new session starts and sweeps the registry
+    Then the orphaned unread record is removed
+    And it no longer contributes to the green unread light
+    And a live unread session still keeps its green light
+
   Scenario: Target lighting zone selection
     Given the user configures the target zone
     When the zone is set to "matrix"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-keyboard",
-  "version": "0.1.1",
+  "version": "0.1.3",
   "description": "Dynamic VIA/QMK keyboard RGB lighting indicator reflecting Pi states (idle, thinking, unread, need-approval, error)",
   "author": "Frad LEE <fradser@gmail.com>",
   "license": "MIT",
@@ -36,4 +36,4 @@
     "@earendil-works/pi-coding-agent": "*",
     "@earendil-works/pi-tui": "*"
   }
-}
+}

package/src/driver.ts

@@ -22,7 +22,7 @@ export function resolveCliPath(customPath?: string): string {
 
   const standardPaths = [
     join(homedir(), ".local", "bin", "via-rgb"),
-    "/opt/homebrew/bin/via-rgb",
+    "/opt/homebrew/bin", "via-rgb",
     "/usr/local/bin/via-rgb",
   ];
 
@@ -42,6 +42,8 @@ export interface HardwareApplyResult {
   error?: string;
 }
 
+const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
+
 export async function applyKeyboardState(
   state: KeyboardState,
   config: KeyboardConfig,
@@ -71,7 +73,27 @@ export async function applyKeyboardState(
 
   const task = async (): Promise<HardwareApplyResult> => {
     try {
-      // Set color, effect, speed, brightness in memory
+      // If state specifies smooth ramp (e.g. thinking blue), apply a gentle buffered transition
+      if (def.smoothRamp) {
+        const intermediateSat = Math.round(def.sat * 0.6);
+        const intermediateBrightness = Math.round(targetBrightness * 0.9);
+        const rampArgs = [
+          ...baseArgs,
+          "set",
+          "-b",
+          String(intermediateBrightness),
+          "-e",
+          String(def.effect),
+          "-s",
+          "100",
+          "-c",
+          `${def.hue} ${intermediateSat}`,
+        ];
+        await execFileAsync(cli, rampArgs, { timeout: 3000 });
+        await sleep(150); // 150ms graceful transition buffer
+      }
+
+      // Set final color, effect, speed, brightness in memory
       const setArgs = [
         ...baseArgs,
         "set",

package/src/global-sessions.ts

@@ -13,6 +13,10 @@ export interface SessionGlowRecord {
 }
 
 export function getRegistryDir(): string {
+  // Test seam: allow pointing at an isolated registry so tests never touch the
+  // real ~/.pi/agent/directory-sessions directory.
+  const override = process.env.PI_DIRECTORY_SESSIONS_DIR;
+  if (override) return override;
   return path.join(os.homedir(), ".pi", "agent", "directory-sessions");
 }
 
@@ -81,6 +85,57 @@ export function removeSessionGlowState(cwd: string, sessionId: string): void {
   }
 }
 
+/**
+ * Sweeps the whole registry and removes glow records whose owning process is no
+ * longer alive. Sessions that exit unexpectedly (crash, SIGKILL, terminal closed
+ * without a clean session_shutdown) never run removeSessionGlowState, so their
+ * leftover unread (settled) records would otherwise pile up and keep the green
+ * light on. Called at session start to clear that residue before evaluating.
+ *
+ * Deliberately cleans only dead-process records: a genuinely live session that
+ * is still unread keeps its glow record (and green light). No time-based expiry.
+ */
+export function pruneOrphanedGlowStates(): number {
+  const baseDir = getRegistryDir();
+  if (!fs.existsSync(baseDir)) return 0;
+
+  let removed = 0;
+  try {
+    const dirEntries = fs.readdirSync(baseDir, { withFileTypes: true });
+    for (const dirEntry of dirEntries) {
+      if (!dirEntry.isDirectory()) continue;
+      const subDirPath = path.join(baseDir, dirEntry.name);
+      let sessionFiles: string[] = [];
+      try {
+        sessionFiles = fs.readdirSync(subDirPath);
+      } catch {
+        continue;
+      }
+
+      for (const file of sessionFiles) {
+        if (!file.endsWith(".json")) continue;
+        const filePath = path.join(subDirPath, file);
+        try {
+          const content = fs.readFileSync(filePath, "utf-8");
+          const record = JSON.parse(content) as SessionGlowRecord;
+          if (!record || typeof record !== "object" || typeof record.pid !== "number") continue;
+          if (!isProcessAlive(record.pid)) {
+            try {
+              fs.unlinkSync(filePath);
+              removed++;
+            } catch {}
+          }
+        } catch {
+          // Ignore unreadable / non-glow files (all .json in the shared dir)
+        }
+      }
+    }
+  } catch {
+    // Best-effort sweep
+  }
+  return removed;
+}
+
 export interface GlobalStateSummary {
   effectiveState: KeyboardState;
   hasAnyUnread: boolean;

package/src/state-machine.ts

@@ -2,6 +2,7 @@ import crypto from "node:crypto";
 import { applyKeyboardState } from "./driver";
 import {
   evaluateGlobalLightingState,
+  pruneOrphanedGlowStates,
   removeSessionGlowState,
   writeSessionGlowState,
   type GlobalStateSummary,
@@ -114,6 +115,11 @@ export class KeyboardStateMachine {
     this.isProcessing = false;
     this.hasUnreadChat = false;
     this.hasFatalError = false;
+    // Clean up unread (settled) glow records left behind by sessions that exited
+    // unexpectedly (crash / kill / terminal closed). Without this their leftover
+    // unread would pile up and keep the green light on. Only dead-process records
+    // are removed; a live unread session keeps its glow state.
+    pruneOrphanedGlowStates();
     await this.syncAndEvaluate("idle");
   }
 

package/src/types.ts

@@ -20,6 +20,7 @@ export interface KeyboardStateDefinition {
   brightness: number;
   pattern: KeyboardPattern;
   blinkCount?: number;
+  smoothRamp?: boolean;
 }
 
 export interface KeyboardConfig {
@@ -45,7 +46,7 @@ export const KEYBOARD_STATE_DEFINITIONS: Record<KeyboardState, KeyboardStateDefi
     hue: 0,
     sat: 0, // White
     effect: 2, // Breathing
-    speed: 100,
+    speed: 90,
     brightness: 180,
     pattern: "breathing",
   },
@@ -54,22 +55,23 @@ export const KEYBOARD_STATE_DEFINITIONS: Record<KeyboardState, KeyboardStateDefi
     label: "Green Breathing (Unread Chat)",
     labelZh: "绿色 呼吸灯 (未读消息)",
     hue: 85, // Green
-    sat: 255,
+    sat: 240,
     effect: 2, // Breathing
-    speed: 150,
-    brightness: 220,
+    speed: 130,
+    brightness: 210,
     pattern: "breathing",
   },
   thinking: {
     state: "thinking",
     label: "Blue Breathing (Thinking)",
     labelZh: "蓝色 呼吸灯 (正在思考/执行)",
-    hue: 170, // Blue
-    sat: 255,
+    hue: 165, // Calm oceanic blue (softened from harsh 170)
+    sat: 210, // Softened saturation (non-glaring)
     effect: 2, // Breathing
-    speed: 200,
-    brightness: 255,
+    speed: 120, // Calmed, gentle cadence (softened from 200)
+    brightness: 195, // Balanced ambient level (smooth from 180)
     pattern: "breathing",
+    smoothRamp: true,
   },
   need_approval: {
     state: "need_approval",