pi-interview 0.8.3 → 0.8.4

package/README.md

@@ -40,7 +40,7 @@ Restart pi to load the extension.
 - **Path Normalization**: Handles shell-escaped paths (`\ `) and macOS screenshot filenames (narrow no-break space before AM/PM)
 - **Generate & Review Options**: Single/multi-select questions, including rich-option questions with inline content blocks, show "✦ Generate more" (appends new choices) and "↻ Review options" (reviews options and rewrites the question for clarity) buttons powered by an LLM
 - **Ask About an Option**: Single/multi options, including rich options with inline content blocks, can open an inline assistant panel with prompt chips, freeform follow-up questions, provider/model overrides under Advanced, and actions like pinning analysis or applying a suggested rewrite
-- **Option Clarifications**: Plain string single/multi options can reveal a separate inline `Optional clarification...` field when selected, letting users attach a short note to a choice without using `Ask`
+- **Option Clarifications**: Single/multi options, including rich options with inline content blocks, can reveal a separate inline `Optional clarification...` field when selected, letting users attach a short note to a choice without using `Ask`
 - **Tool Discoverability (pi v0.59+)**: Registers a `promptSnippet` so `interview` remains eligible for inclusion in pi's default `Available tools` prompt section
 - **Themes**: Built-in default + optional light/dark + custom theme CSS
 

package/form/script.js

@@ -556,13 +556,6 @@
     return resolved;
   }
 
-  function questionCanClarifyOption(question) {
-    return (question.type === "single" || question.type === "multi")
-      && Array.isArray(question.options)
-      && question.options.length > 0
-      && question.options.every((option) => typeof option === "string");
-  }
-
   function isChoiceResponseValue(value) {
     return value && typeof value === "object" && !Array.isArray(value) && typeof value.option === "string";
   }
@@ -647,10 +640,6 @@
       .filter((value) => value && value !== "__other__");
   }
 
-  function syncChoiceNotesWithSelection(question) {
-    if (!questionCanClarifyOption(question)) return;
-  }
-
   function isRichOption(option) {
     return typeof option === "object" && option !== null && "label" in option;
   }
@@ -1436,7 +1425,7 @@
   }
 
   function createOptionNoteInput(question, optionLabel, isSelected) {
-    if (!questionCanClarifyOption(question) || !isSelected) return null;
+    if (!questionSupportsOptionInsights(question) || !isSelected) return null;
 
     const wrap = document.createElement("div");
     wrap.className = "option-note-wrap";
@@ -1491,7 +1480,6 @@
     input.id = `q-${question.id}-${optionIndex}`;
 
     input.addEventListener("change", () => {
-      syncChoiceNotesWithSelection(question);
       debounceSave();
       if (question.type === "multi") {
         updateDoneState(question.id);
@@ -3348,7 +3336,7 @@
         const otherValue = getOtherValue(id).trim();
         return otherValue ? { option: otherValue } : "";
       }
-      const note = questionCanClarifyOption(question) ? getChoiceNote(id, selected.value) : "";
+      const note = questionSupportsOptionInsights(question) ? getChoiceNote(id, selected.value) : "";
       return note ? { option: selected.value, note } : { option: selected.value };
     }
     if (question.type === "multi") {
@@ -3359,7 +3347,7 @@
           const otherValue = getOtherValue(id).trim();
           return otherValue ? { option: otherValue } : null;
         }
-        const note = questionCanClarifyOption(question) ? getChoiceNote(id, input.value) : "";
+        const note = questionSupportsOptionInsights(question) ? getChoiceNote(id, input.value) : "";
         return note ? { option: input.value, note } : { option: input.value };
       }).filter((value) => value && value.option);
     }
@@ -3432,7 +3420,7 @@
           );
           if (input) {
             input.checked = true;
-            if (questionCanClarifyOption(question) && choiceValue.note) {
+            if (questionSupportsOptionInsights(question) && choiceValue.note) {
               setChoiceNote(question.id, choiceValue.option, choiceValue.note);
             }
           } else {
@@ -3469,7 +3457,7 @@
           );
           if (input) {
             input.checked = true;
-            if (questionCanClarifyOption(question) && choiceValue.note) {
+            if (questionSupportsOptionInsights(question) && choiceValue.note) {
               setChoiceNote(question.id, choiceValue.option, choiceValue.note);
             }
           } else if (choiceValue.option) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-interview",
-  "version": "0.8.3",
+  "version": "0.8.4",
   "description": "Interactive interview form extension for pi coding agent",
   "author": "Nico Bailon",
   "license": "MIT",

package/schema.ts

@@ -82,9 +82,11 @@ function normalizeOptionLevelRecommendations(question: Question): void {
 
 	const recommendedOptions: RichOption[] = [];
 	const convictions = new Set<"strong" | "slight">();
+	const richOptions: RichOption[] = [];
 
 	for (const option of question.options) {
 		if (!isRichOption(option)) continue;
+		richOptions.push(option);
 		if (option.conviction !== undefined && option.recommended !== true) {
 			throw new Error(
 				`Question "${question.id}" option "${option.label}": conviction requires recommended`
@@ -113,6 +115,11 @@ function normalizeOptionLevelRecommendations(question: Question): void {
 		);
 	}
 
+	for (const option of richOptions) {
+		delete option.recommended;
+		delete option.conviction;
+	}
+
 	const recommendedLabels = recommendedOptions.map((option) => option.label);
 	question.recommended = question.type === "single" ? recommendedLabels[0] : recommendedLabels;
 	const conviction = convictions.values().next().value;