pi-interview 0.8.1 → 0.8.2

package/form/script.js

@@ -529,6 +529,33 @@
     return typeof option === "string" ? option : option.label;
   }
 
+  function normalizeRecommendationMatchText(value) {
+    return value.normalize("NFC").trim();
+  }
+
+  function resolveRecommendedLabels(recommended, options) {
+    if (!recommended || !Array.isArray(options)) return [];
+
+    const labelsByNormalized = new Map();
+    options.forEach((option) => {
+      const label = getOptionLabel(option);
+      const normalized = normalizeRecommendationMatchText(label);
+      if (!normalized || labelsByNormalized.has(normalized)) return;
+      labelsByNormalized.set(normalized, label);
+    });
+
+    const resolved = [];
+    const candidates = Array.isArray(recommended) ? recommended : [recommended];
+    candidates.forEach((candidate) => {
+      if (typeof candidate !== "string") return;
+      const match = labelsByNormalized.get(normalizeRecommendationMatchText(candidate));
+      if (match && !resolved.includes(match)) {
+        resolved.push(match);
+      }
+    });
+    return resolved;
+  }
+
   function questionCanClarifyOption(question) {
     return (question.type === "single" || question.type === "multi")
       && Array.isArray(question.options)
@@ -629,11 +656,12 @@
   }
 
   function syncRecommendations(question, options) {
-    const optionLabels = options.map((option) => getOptionLabel(option));
     if (!question.recommended) return;
+    const resolvedRecommended = resolveRecommendedLabels(question.recommended, options);
 
     if (question.type === "single") {
-      if (typeof question.recommended === "string" && optionLabels.includes(question.recommended)) {
+      if (resolvedRecommended.length > 0) {
+        question.recommended = resolvedRecommended[0];
         return;
       }
       delete question.recommended;
@@ -647,15 +675,12 @@
       return;
     }
 
-    const nextRecommended = (Array.isArray(question.recommended)
-      ? question.recommended
-      : [question.recommended]).filter((option) => optionLabels.includes(option));
-    if (nextRecommended.length === 0) {
+    if (resolvedRecommended.length === 0) {
       delete question.recommended;
       delete question.conviction;
       return;
     }
-    question.recommended = nextRecommended;
+    question.recommended = resolvedRecommended;
   }
 
   function makeClientId(prefix = "id") {
@@ -1481,12 +1506,7 @@
     text.className = "option-item-label";
     text.textContent = optionLabel;
 
-    const recommended = question.recommended;
-    const recommendedList = Array.isArray(recommended)
-      ? recommended
-      : recommended
-        ? [recommended]
-        : [];
+    const recommendedList = resolveRecommendedLabels(question.recommended, question.options || []);
     const shouldPreselect = recommendedList.length > 0 && question.conviction !== "slight";
 
     if (recommendedList.includes(optionLabel)) {
@@ -3567,9 +3587,7 @@
     }
   }
 
-  // Pre-populate form from saved interview answers
   function populateFromSavedAnswers(savedAnswers) {
-    // Convert ResponseItem[] to Record for existing populateForm()
     const valueMap = {};
     savedAnswers.forEach((ans) => {
       const question = questions.find((q) => q.id === ans.id);
@@ -3579,7 +3597,6 @@
     });
     populateForm(valueMap);
 
-    // Restore attachments to attachPathState
     savedAnswers.forEach((ans) => {
       if (ans.attachments && ans.attachments.length > 0) {
         attachPathState.set(ans.id, [...ans.attachments]);
@@ -3595,7 +3612,6 @@
       }
     });
 
-    // Restore image paths for image-type questions
     savedAnswers.forEach((ans) => {
       const question = questions.find((q) => q.id === ans.id);
       if (question?.type === "image" && ans.value) {
@@ -3608,7 +3624,6 @@
       }
     });
 
-    // Update done states for multi-select
     questions.forEach((q) => {
       if (q.type === "multi") {
         updateDoneState(q.id);
@@ -3627,13 +3642,13 @@
       const reader = new FileReader();
       reader.onload = () => {
         if (typeof reader.result !== "string") {
-          reject(new Error("Failed to read file"));
+          reject(new Error(`Failed to read file: unexpected FileReader result type ${typeof reader.result}`));
           return;
         }
         const parts = reader.result.split(",");
         resolve(parts[1] || "");
       };
-      reader.onerror = () => reject(new Error("Failed to read file"));
+      reader.onerror = () => reject(new Error(reader.error?.message || "Failed to read file"));
       reader.readAsDataURL(file);
     });
   }
@@ -3674,7 +3689,6 @@
     return { responses, images };
   }
 
-  // Save interview snapshot
   async function saveInterview(options = {}) {
     const { submitted = false } = options;
 
@@ -3759,8 +3773,6 @@
         return;
       }
 
-      // Auto-save on successful submit (fire-and-forget)
-      // Note: data is window.__INTERVIEW_DATA__, result is server response
       if (data.autoSaveOnSubmit !== false) {
         saveInterview({ submitted: true });
       }

package/index.ts

@@ -18,7 +18,7 @@ import {
 	type AskModelOption,
 	type OptionInsightResult,
 } from "./server.js";
-import { getOptionLabel, isRichOption, validateQuestions, sanitizeLLMJSON, type OptionValue, type QuestionsFile } from "./schema.js";
+import { getOptionLabel, isRichOption, validateQuestions, sanitizeLLMJSON, type OptionValue, type Question, type QuestionsFile } from "./schema.js";
 import { loadSettings, type InterviewThemeSettings } from "./settings.js";
 
 interface GlimpseWindow {
@@ -715,28 +715,100 @@ function hasAnswerValue(value: ResponseItem["value"]): boolean {
 	return typeof value === "string" && value.trim() !== "";
 }
 
-function formatResponses(responses: ResponseItem[]): string {
-	if (responses.length === 0) return "(none)";
-	return responses
-		.map((resp) => {
-			const value = formatResponseValue(resp.value);
-			let line = `- ${resp.id}: ${value}`;
-			if (resp.attachments && resp.attachments.length > 0) {
-				line += ` [attachments: ${resp.attachments.join(", ")}]`;
+function hasResponseContent(response: ResponseItem): boolean {
+	return hasAnswerValue(response.value) || !!response.attachments?.length;
+}
+
+function summarizeResponseValue(question: Question, response: ResponseItem): string {
+	if (question.type === "image") {
+		if (Array.isArray(response.value)) {
+			return response.value.length === 1 ? "1 image attached" : `${response.value.length} images attached`;
+		}
+		if (typeof response.value === "string" && response.value.trim() !== "") {
+			return "1 image attached";
+		}
+	}
+
+	if (hasAnswerValue(response.value)) {
+		return String(formatResponseValue(response.value));
+	}
+
+	if (response.attachments?.length) {
+		return response.attachments.length === 1 ? "1 attachment included" : `${response.attachments.length} attachments included`;
+	}
+
+	return "";
+}
+
+interface AgentResponseItem {
+	id: string;
+	question: string;
+	type: Question["type"];
+	value: ResponseItem["value"];
+	attachments?: string[];
+}
+
+export function buildAnsweredAgentResponseItems(
+	responses: ResponseItem[],
+	questions: Question[],
+): AgentResponseItem[] {
+	const responseById = new Map<string, ResponseItem>();
+	for (const response of responses) {
+		if (!response || typeof response.id !== "string") continue;
+		responseById.set(response.id, response);
+	}
+
+	return questions
+		.map((question) => {
+			const response = responseById.get(question.id);
+			if (!response || !hasResponseContent(response)) return null;
+			return {
+				id: question.id,
+				question: question.question,
+				type: question.type,
+				value: response.value,
+				attachments: response.attachments?.length ? [...response.attachments] : undefined,
+			} satisfies AgentResponseItem;
+		})
+		.filter((item): item is AgentResponseItem => item !== null);
+}
+
+export function formatAnsweredResponsesForAgent(
+	responses: ResponseItem[],
+	questions: Question[],
+): string {
+	const answeredItems = buildAnsweredAgentResponseItems(responses, questions);
+	if (answeredItems.length === 0) return "(none)";
+	const questionById = new Map(questions.map((question) => [question.id, question]));
+	const responseById = new Map(responses.map((response) => [response.id, response]));
+
+	const summary = answeredItems
+		.map((item) => {
+			const question = questionById.get(item.id);
+			const response = responseById.get(item.id);
+			if (!question || !response) {
+				return `- ${item.question}`;
+			}
+			let line = `- ${item.question}: ${summarizeResponseValue(question, response)}`;
+			if (item.attachments?.length) {
+				line += ` [attachments: ${item.attachments.join(", ")}]`;
 			}
 			return line;
 		})
 		.join("\n");
+
+	const json = JSON.stringify(answeredItems, null, 2);
+	return `${summary}\n\nStructured response data:\n\n\`\`\`json\n${json}\n\`\`\``;
 }
 
 function hasAnyAnswers(responses: ResponseItem[]): boolean {
 	if (!responses || responses.length === 0) return false;
-	return responses.some((resp) => !!resp && resp.value != null && hasAnswerValue(resp.value));
+	return responses.some((resp) => !!resp && hasResponseContent(resp));
 }
 
 function filterAnsweredResponses(responses: ResponseItem[]): ResponseItem[] {
 	if (!responses) return [];
-	return responses.filter((resp) => !!resp && resp.value != null && hasAnswerValue(resp.value));
+	return responses.filter((resp) => !!resp && hasResponseContent(resp));
 }
 
 export default function (pi: ExtensionAPI) {
@@ -855,21 +927,21 @@ export default function (pi: ExtensionAPI) {
 
 					let text = "";
 					if (status === "completed") {
-						text = `User completed the interview form.\n\nResponses:\n${formatResponses(responses)}`;
+						text = `User completed the interview form.\n\nAnswered responses:\n${formatAnsweredResponsesForAgent(responses, questionsData.questions)}`;
 					} else if (status === "cancelled") {
 						if (cancelReason === "stale") {
 							text =
 								"Interview session ended due to lost heartbeat.\n\nQuestions saved to: ~/.pi/interview-recovery/";
 						} else if (hasAnyAnswers(responses)) {
 							const answered = filterAnsweredResponses(responses);
-							text = `User cancelled the interview with partial responses:\n${formatResponses(answered)}\n\nProceed with these inputs and use your best judgment for unanswered questions.`;
+							text = `User cancelled the interview with partial responses.\n\nAnswered responses:\n${formatAnsweredResponsesForAgent(answered, questionsData.questions)}\n\nProceed with these inputs and use your best judgment for unanswered questions.`;
 						} else {
 							text = "User skipped the interview without providing answers. Proceed with your best judgment - use recommended options where specified, make reasonable choices elsewhere. Don't ask for clarification unless absolutely necessary.";
 						}
 					} else if (status === "timeout") {
 						if (hasAnyAnswers(responses)) {
 							const answered = filterAnsweredResponses(responses);
-							text = `Interview form timed out after ${timeoutSeconds} seconds.\n\nPartial responses before timeout:\n${formatResponses(answered)}\n\nQuestions saved to: ~/.pi/interview-recovery/\n\nProceed with these inputs and use your best judgment for unanswered questions.`;
+							text = `Interview form timed out after ${timeoutSeconds} seconds.\n\nAnswered responses before timeout:\n${formatAnsweredResponsesForAgent(answered, questionsData.questions)}\n\nQuestions saved to: ~/.pi/interview-recovery/\n\nProceed with these inputs and use your best judgment for unanswered questions.`;
 						} else {
 							text = `Interview form timed out after ${timeoutSeconds} seconds.\n\nQuestions saved to: ~/.pi/interview-recovery/`;
 						}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-interview",
-  "version": "0.8.1",
+  "version": "0.8.2",
   "description": "Interactive interview form extension for pi coding agent",
   "author": "Nico Bailon",
   "license": "MIT",

package/server.ts

@@ -432,12 +432,41 @@ function ensureQuestionId(
 	return { ok: true, question };
 }
 
-function syncRecommendations(question: Question, options: OptionValue[]): void {
+function normalizeRecommendationMatchText(value: string): string {
+	return value.normalize("NFC").trim();
+}
+
+function resolveRecommendedLabels(
+	recommended: Question["recommended"],
+	options: OptionValue[]
+): string[] {
+	if (!recommended) return [];
 	const optionLabels = options.map((option) => getOptionLabel(option));
+	const labelsByNormalized = new Map<string, string>();
+	for (const label of optionLabels) {
+		const normalized = normalizeRecommendationMatchText(label);
+		if (!normalized || labelsByNormalized.has(normalized)) continue;
+		labelsByNormalized.set(normalized, label);
+	}
+
+	const resolved: string[] = [];
+	for (const candidate of Array.isArray(recommended) ? recommended : [recommended]) {
+		if (typeof candidate !== "string") continue;
+		const match = labelsByNormalized.get(normalizeRecommendationMatchText(candidate));
+		if (match && !resolved.includes(match)) {
+			resolved.push(match);
+		}
+	}
+	return resolved;
+}
+
+function syncRecommendations(question: Question, options: OptionValue[]): void {
 	if (!question.recommended) return;
+	const resolvedRecommended = resolveRecommendedLabels(question.recommended, options);
 
 	if (question.type === "single") {
-		if (typeof question.recommended === "string" && optionLabels.includes(question.recommended)) {
+		if (resolvedRecommended.length > 0) {
+			question.recommended = resolvedRecommended[0];
 			return;
 		}
 		delete question.recommended;
@@ -451,15 +480,12 @@ function syncRecommendations(question: Question, options: OptionValue[]): void {
 		return;
 	}
 
-	const nextRecommended = (Array.isArray(question.recommended)
-		? question.recommended
-		: [question.recommended]).filter((option) => optionLabels.includes(option));
-	if (nextRecommended.length === 0) {
+	if (resolvedRecommended.length === 0) {
 		delete question.recommended;
 		delete question.conviction;
 		return;
 	}
-	question.recommended = nextRecommended;
+	question.recommended = resolvedRecommended;
 }
 
 function makeOptionKey(): string {
@@ -924,9 +950,7 @@ function recommendedIndicatorHtml(q: Question): string {
 }
 
 function savedAnswerItemHtml(text: string, q: Question): string {
-	const recs = Array.isArray(q.recommended)
-		? q.recommended
-		: q.recommended ? [q.recommended] : [];
+	const recs = q.options ? resolveRecommendedLabels(q.recommended, q.options) : [];
 	const indicator = recs.includes(text) ? " " + recommendedIndicatorHtml(q) : "";
 	return escapeHtml(text) + indicator;
 }