pi-interactive-shell 0.5.0 → 0.5.2

package/CHANGELOG.md

@@ -2,6 +2,17 @@
 
 All notable changes to the `pi-interactive-shell` extension will be documented in this file.
 
+## [0.5.2] - 2026-01-23
+
+### Fixed
+- **npx installation missing files** - The install script had a hardcoded file list that was missing 4 critical files (`key-encoding.ts`, `types.ts`, `tool-schema.ts`, `reattach-overlay.ts`). Now reads from `package.json`'s `files` array as the single source of truth, ensuring all files are always copied.
+- **Broken symlink handling** - Fixed skill symlink creation failing when a broken symlink already existed at the target path. `existsSync()` returns `false` for broken symlinks, causing the old code to skip removal. Now unconditionally attempts removal, correctly handling broken symlinks.
+
+## [0.5.1] - 2026-01-22
+
+### Fixed
+- **Prevent overlay stacking** - Starting a new `interactive_shell` session or using `/attach` while an overlay is already open now returns an error instead of causing undefined behavior with stacked/stuck overlays.
+
 ## [0.5.0] - 2026-01-22
 
 ### Changed

package/index.ts

@@ -8,6 +8,9 @@ import { translateInput } from "./key-encoding.js";
 import { TOOL_NAME, TOOL_LABEL, TOOL_DESCRIPTION, toolParameters, type ToolParams } from "./tool-schema.js";
 import { formatDuration, formatDurationMs } from "./types.js";
 
+// Track whether an overlay is currently open to prevent stacking
+let overlayOpen = false;
+
 export default function interactiveShellExtension(pi: ExtensionAPI) {
 	pi.on("session_shutdown", () => {
 		sessionManager.killAll();
@@ -370,12 +373,24 @@ export default function interactiveShellExtension(pi: ExtensionAPI) {
 			const config = loadConfig(effectiveCwd);
 			const isHandsFree = mode === "hands-free";
 
+			// Prevent starting a new overlay while one is already open
+			if (overlayOpen) {
+				return {
+					content: [{ type: "text", text: "An interactive shell overlay is already open. Wait for it to close or kill the active session before starting a new one." }],
+					isError: true,
+					details: { error: "overlay_already_open" },
+				};
+			}
+
 			// Generate sessionId early so it's available immediately
 			const generatedSessionId = isHandsFree ? generateSessionId(name) : undefined;
 
 			// For hands-free mode: non-blocking - return immediately with sessionId
 			// Agent can then query status/output via sessionId and kill when done
 			if (isHandsFree && generatedSessionId) {
+				// Mark overlay as open
+				overlayOpen = true;
+
 				// Start overlay but don't await - it runs in background
 				const overlayPromise = ctx.ui.custom<InteractiveShellResult>(
 					(tui, theme, _kb, done) =>
@@ -421,12 +436,14 @@ export default function interactiveShellExtension(pi: ExtensionAPI) {
 
 				// Handle overlay completion in background (cleanup when user closes)
 				overlayPromise.then((result) => {
+					overlayOpen = false;
 					// Session already handles cleanup via finishWith* methods
 					// This just ensures the promise doesn't cause unhandled rejection
 					if (result.userTookOver) {
 						// User took over - session continues interactively
 					}
 				}).catch(() => {
+					overlayOpen = false;
 					// Ignore errors - session cleanup handles this
 				});
 
@@ -448,6 +465,7 @@ export default function interactiveShellExtension(pi: ExtensionAPI) {
 			}
 
 			// Interactive mode: blocking - wait for overlay to close
+			overlayOpen = true;
 			onUpdate?.({
 				content: [{ type: "text", text: `Opening: ${command}` }],
 				details: {
@@ -457,7 +475,9 @@ export default function interactiveShellExtension(pi: ExtensionAPI) {
 				},
 			});
 
-			const result = await ctx.ui.custom<InteractiveShellResult>(
+			let result: InteractiveShellResult;
+			try {
+				result = await ctx.ui.custom<InteractiveShellResult>(
 				(tui, theme, _kb, done) =>
 					new InteractiveShellOverlay(
 						tui,
@@ -532,6 +552,9 @@ export default function interactiveShellExtension(pi: ExtensionAPI) {
 					},
 				},
 			);
+			} finally {
+				overlayOpen = false;
+			}
 
 			let summary: string;
 			if (result.backgrounded) {
@@ -569,6 +592,12 @@ export default function interactiveShellExtension(pi: ExtensionAPI) {
 	pi.registerCommand("attach", {
 		description: "Reattach to a background shell session",
 		handler: async (args, ctx) => {
+			// Prevent reattaching while another overlay is open
+			if (overlayOpen) {
+				ctx.ui.notify("An overlay is already open. Close it first.", "error");
+				return;
+			}
+
 			const sessions = sessionManager.list();
 
 			if (sessions.length === 0) {
@@ -601,25 +630,30 @@ export default function interactiveShellExtension(pi: ExtensionAPI) {
 			}
 
 			const config = loadConfig(ctx.cwd);
-			await ctx.ui.custom<InteractiveShellResult>(
-				(tui, theme, _kb, done) =>
-					new ReattachOverlay(
-						tui,
-						theme,
-						{ id: session.id, command: session.command, reason: session.reason, session: session.session },
-						config,
-						done,
-					),
-				{
-					overlay: true,
-					overlayOptions: {
-						width: `${config.overlayWidthPercent}%`,
-						maxHeight: `${config.overlayHeightPercent}%`,
-						anchor: "center",
-						margin: 1,
+			overlayOpen = true;
+			try {
+				await ctx.ui.custom<InteractiveShellResult>(
+					(tui, theme, _kb, done) =>
+						new ReattachOverlay(
+							tui,
+							theme,
+							{ id: session.id, command: session.command, reason: session.reason, session: session.session },
+							config,
+							done,
+						),
+					{
+						overlay: true,
+						overlayOptions: {
+							width: `${config.overlayWidthPercent}%`,
+							maxHeight: `${config.overlayHeightPercent}%`,
+							anchor: "center",
+							margin: 1,
+						},
 					},
-				},
-			);
+				);
+			} finally {
+				overlayOpen = false;
+			}
 		},
 	});
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-interactive-shell",
-  "version": "0.5.0",
+  "version": "0.5.2",
   "description": "Run AI coding agents as foreground subagents in pi TUI overlays with hands-free monitoring",
   "type": "module",
   "bin": {

package/scripts/install.js

@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 
-import { existsSync, mkdirSync, cpSync, symlinkSync, unlinkSync, readFileSync } from "node:fs";
+import { existsSync, mkdirSync, cpSync, symlinkSync, unlinkSync, readFileSync, statSync } from "node:fs";
 import { join, dirname } from "node:path";
 import { homedir } from "node:os";
 import { execSync } from "node:child_process";
@@ -24,36 +24,34 @@ function main() {
 	log(`Creating ${EXTENSION_DIR}`);
 	mkdirSync(EXTENSION_DIR, { recursive: true });
 
-	// Files to copy
-	const files = [
-		"package.json",
-		"index.ts",
-		"config.ts",
-		"overlay-component.ts",
-		"pty-session.ts",
-		"session-manager.ts",
-		"README.md",
-		"SKILL.md",
-		"CHANGELOG.md",
-	];
+	// Read files list from package.json (single source of truth)
+	// Include package.json itself (npm auto-includes it but it's not in the files array)
+	const files = ["package.json", ...(pkg.files || [])];
 
-	// Copy files
-	for (const file of files) {
-		const src = join(packageRoot, file);
-		const dest = join(EXTENSION_DIR, file);
-		if (existsSync(src)) {
-			cpSync(src, dest);
-			log(`Copied ${file}`);
+	// Copy files and directories
+	for (const rawEntry of files) {
+		// Normalize: remove trailing slashes for consistent handling
+		const entry = rawEntry.replace(/\/+$/, "");
+		const src = join(packageRoot, entry);
+		const dest = join(EXTENSION_DIR, entry);
+
+		if (!existsSync(src)) {
+			continue;
 		}
-	}
 
-	// Copy scripts directory
-	const scriptsDir = join(packageRoot, "scripts");
-	const destScriptsDir = join(EXTENSION_DIR, "scripts");
-	if (existsSync(scriptsDir)) {
-		mkdirSync(destScriptsDir, { recursive: true });
-		cpSync(scriptsDir, destScriptsDir, { recursive: true });
-		log("Copied scripts/");
+		try {
+			const stat = statSync(src);
+			if (stat.isDirectory()) {
+				mkdirSync(dest, { recursive: true });
+				cpSync(src, dest, { recursive: true });
+				log(`Copied ${entry}/`);
+			} else {
+				cpSync(src, dest);
+				log(`Copied ${entry}`);
+			}
+		} catch (error) {
+			log(`Warning: Could not copy ${entry}: ${error.message}`);
+		}
 	}
 
 	// Run npm install in extension directory
@@ -72,8 +70,12 @@ function main() {
 	const skillTarget = join(EXTENSION_DIR, "SKILL.md");
 
 	try {
-		if (existsSync(skillLink)) {
+		// Remove existing entry if present (handles regular files, symlinks, and broken symlinks)
+		// Note: existsSync returns false for broken symlinks, so we unconditionally try unlink
+		try {
 			unlinkSync(skillLink);
+		} catch (e) {
+			if (e.code !== "ENOENT") throw e;
 		}
 		symlinkSync(skillTarget, skillLink);
 		log("Skill symlink created");