pi-hermes-memory 0.7.12 → 0.7.13

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-hermes-memory",
-  "version": "0.7.12",
+  "version": "0.7.13",
   "description": "🧠 Persistent memory + 🔍 session search + 🛡️ secret scanning for Pi. Token-aware policy-only memory by default, SQLite FTS5 search, auto-consolidation, procedural skills. 368 tests. Ported from Hermes agent.",
   "type": "module",
   "main": "src/index.ts",

package/src/store/memory-lookup.ts

@@ -0,0 +1,15 @@
+export function normalizeMemoryLookupText(text: string): string {
+  let normalized = text.trim();
+  if (!normalized) return "";
+
+  const firstNonEmptyLine = normalized
+    .split(/\r?\n/)
+    .map((line) => line.trim())
+    .find((line) => line.length > 0);
+  if (firstNonEmptyLine) normalized = firstNonEmptyLine;
+
+  normalized = normalized.replace(/^\S+\s+\[[^\]]+\]\s+/u, "");
+  normalized = normalized.replace(/^(\[[^\]]+\])\s+\1(\s+|$)/, "$1 ");
+
+  return normalized.trim();
+}

package/src/store/memory-store.ts

@@ -15,6 +15,7 @@ import * as fs from "node:fs/promises";
 import * as path from "node:path";
 import * as os from "node:os";
 import { scanContent } from "./content-scanner.js";
+import { normalizeMemoryLookupText } from "./memory-lookup.js";
 import {
   ENTRY_DELIMITER,
   DEFAULT_MEMORY_CHAR_LIMIT,
@@ -117,32 +118,8 @@ export class MemoryStore {
     correctedTo?: string;
     project?: string;
   }): Promise<MemoryResult> {
-    content = content.trim();
-    if (!content) return { success: false, error: "Content cannot be empty." };
-
-    const scanError = scanContent(content);
-    if (scanError) return { success: false, error: scanError };
-
-    const categoryTag = "[" + options.category + "]";
-    const parts = [categoryTag + " " + content];
-    if (options.failureReason) parts.push("Failed: " + options.failureReason);
-    if (options.toolState) parts.push("Tool state: " + options.toolState);
-    if (options.correctedTo) parts.push("Corrected to: " + options.correctedTo);
-    if (options.project) parts.push("Project: " + options.project);
-
-    const failureText = parts.join(" — ");
-    const today = new Date().toISOString().split("T")[0];
-    const encoded = this.encodeEntry(failureText, today, today);
-
-    this.failureEntries.push(encoded);
-    await this.saveToDisk("failure");
-
-    return {
-      success: true,
-      target: "failure",
-      message: "Failure memory saved: " + options.category,
-      entry_count: this.failureEntries.length,
-    };
+    const failureText = this.buildFailureMemoryText(content, options);
+    return this._add("failure", failureText, undefined, 1, "Failure memory saved: " + options.category);
   }
 
   getFailureEntries(maxAgeDays = 7): string[] {
@@ -158,7 +135,13 @@ export class MemoryStore {
       .map((entry) => this.stripMetadata(entry));
   }
 
-  private async _add(target: "memory" | "user" | "failure", content: string, signal?: AbortSignal, _retriesLeft = 1): Promise<MemoryResult> {
+  private async _add(
+    target: "memory" | "user" | "failure",
+    content: string,
+    signal?: AbortSignal,
+    _retriesLeft = 1,
+    addedMessage = "Entry added.",
+  ): Promise<MemoryResult> {
     content = content.trim();
     if (!content) return { success: false, error: "Content cannot be empty." };
 
@@ -194,7 +177,7 @@ export class MemoryStore {
             // CRITICAL: reload from disk — child process modified files, our arrays are stale
             await this.loadFromDisk();
             // Retry the add exactly once (retriesLeft = 0 means no more consolidation)
-            return this._add(target, content, signal, _retriesLeft - 1);
+            return this._add(target, content, signal, _retriesLeft - 1, addedMessage);
           }
         } catch {
           // Consolidation failed — fall through to error
@@ -207,7 +190,7 @@ export class MemoryStore {
     this.setEntries(target, entries);
     await this.saveToDisk(target);
 
-    return this.successResponse(target, "Entry added.");
+    return this.successResponse(target, addedMessage);
   }
 
   private async fifoEvictAndAdd(
@@ -253,7 +236,7 @@ export class MemoryStore {
   }
 
   async replace(target: "memory" | "user" | "failure", oldText: string, newContent: string): Promise<MemoryResult> {
-    oldText = oldText.trim();
+    oldText = normalizeMemoryLookupText(oldText);
     newContent = newContent.trim();
     if (!oldText) return { success: false, error: "old_text cannot be empty." };
     if (!newContent) return { success: false, error: "new_content cannot be empty. Use 'remove' to delete entries." };
@@ -299,18 +282,18 @@ export class MemoryStore {
   }
 
   async remove(target: "memory" | "user" | "failure", oldText: string): Promise<MemoryResult> {
-    oldText = oldText.trim();
+    oldText = normalizeMemoryLookupText(oldText);
     if (!oldText) return { success: false, error: "old_text cannot be empty." };
 
     const entries = this.entriesFor(target);
-    const matches = entries.filter((e) => e.includes(oldText));
+    const matches = entries.filter((e) => this.stripMetadata(e).includes(oldText));
 
     if (matches.length === 0) return { success: false, error: `No entry matched '${oldText}'.` };
     if (matches.length > 1 && new Set(matches).size > 1) {
       return {
         success: false,
         error: `Multiple entries matched '${oldText}'. Be more specific.`,
-        matches: matches.map((e) => e.slice(0, 80) + (e.length > 80 ? "..." : "")),
+        matches: matches.map((e) => this.stripMetadata(e).slice(0, 80) + (this.stripMetadata(e).length > 80 ? "..." : "")),
       };
     }
 
@@ -392,6 +375,23 @@ export class MemoryStore {
     return this.decodeEntry(text).text;
   }
 
+  private buildFailureMemoryText(content: string, options: {
+    category: MemoryCategory;
+    failureReason?: string;
+    toolState?: string;
+    correctedTo?: string;
+    project?: string;
+  }): string {
+    const trimmedContent = content.trim();
+    const categoryTag = "[" + options.category + "]";
+    const parts = [categoryTag + " " + trimmedContent];
+    if (options.failureReason) parts.push("Failed: " + options.failureReason);
+    if (options.toolState) parts.push("Tool state: " + options.toolState);
+    if (options.correctedTo) parts.push("Corrected to: " + options.correctedTo);
+    if (options.project) parts.push("Project: " + options.project);
+    return parts.join(" — ");
+  }
+
   private successResponse(target: "memory" | "user" | "failure", message?: string): MemoryResult {
     const entries = this.entriesFor(target);
     const current = this.charCount(target);
@@ -401,7 +401,6 @@ export class MemoryStore {
     const resp: MemoryResult = {
       success: true,
       target,
-      entries,
       usage: `${pct}% — ${current}/${limit} chars`,
       entry_count: entries.length,
     };

package/src/store/sqlite-memory-store.ts

@@ -1,5 +1,6 @@
 import { DatabaseManager } from './db.js';
 import { isFts5QueryError, normalizeFts5Query } from './fts-query.js';
+import { normalizeMemoryLookupText } from './memory-lookup.js';
 import type { MemoryCategory } from '../types.js';
 
 const MEMORY_SELECT_COLUMNS = `
@@ -421,10 +422,12 @@ export function replaceSyncedMemories(
   },
 ): SqliteMemoryUpdateResult {
   const db = dbManager.getDb();
+  const normalizedOldText = normalizeMemoryLookupText(oldText);
+  if (!normalizedOldText) return { matched: 0, updated: 0, entries: [] };
   const params: unknown[] = [];
   const conditions = buildScopeConditions(params, updates.target, updates.project ?? undefined);
   conditions.push(`content LIKE ? ESCAPE '\\'`);
-  params.push(`%${escapeLikePattern(oldText)}%`);
+  params.push(`%${escapeLikePattern(normalizedOldText)}%`);
 
   const rows = db.prepare(`
     SELECT ${MEMORY_SELECT_COLUMNS}
@@ -490,10 +493,12 @@ export function removeSyncedMemories(
   options: SqliteMemoryRemoveOptions,
 ): SqliteMemoryRemoveResult {
   const db = dbManager.getDb();
+  const normalizedOldText = normalizeMemoryLookupText(oldText);
+  if (!normalizedOldText) return { matched: 0, removed: 0 };
   const params: unknown[] = [];
   const conditions = buildScopeConditions(params, options.target, options.project ?? undefined);
   conditions.push(`content LIKE ? ESCAPE '\\'`);
-  params.push(`%${escapeLikePattern(oldText)}%`);
+  params.push(`%${escapeLikePattern(normalizedOldText)}%`);
 
   const matchingIds = db.prepare(`
     SELECT id