pi-hermes-memory 0.6.8 → 0.7.0

package/src/store/db.ts

@@ -51,9 +51,11 @@ export class DatabaseManager {
       db.exec(SCHEMA_SQL);
     }
 
-    // Extra safety: always ensure the legacy memories columns exist, even when
-    // schema execution succeeds (idempotent on upgraded DBs).
+    // Extra safety: always ensure legacy memories columns exist, then migrate
+    // legacy CHECK(target IN ('memory','user')) constraints to include 'failure'.
     this.ensureMemoriesColumns(db);
+    this.migrateLegacyMemoriesTargetConstraint(db);
+    this.rebuildMemoryFts(db);
 
     return db;
   }
@@ -85,6 +87,56 @@ export class DatabaseManager {
     }
   }
 
+  private migrateLegacyMemoriesTargetConstraint(db: Database.Database): void {
+    const tableSqlRow = db.prepare("SELECT sql FROM sqlite_master WHERE type='table' AND name='memories'").get() as { sql?: string } | undefined;
+    const tableSql = tableSqlRow?.sql ?? '';
+    if (!tableSql) return;
+
+    // Legacy schema allowed only memory/user. New schema must allow failure too.
+    const hasLegacyTargetCheck = /target\s+TEXT\s+NOT\s+NULL\s+CHECK\s*\(\s*target\s+IN\s*\(\s*'memory'\s*,\s*'user'\s*\)\s*\)/i.test(tableSql);
+    if (!hasLegacyTargetCheck) return;
+
+    const tx = db.transaction(() => {
+      db.exec('PRAGMA foreign_keys = OFF');
+
+      db.exec(`
+        CREATE TABLE memories_new (
+          id INTEGER PRIMARY KEY AUTOINCREMENT,
+          project TEXT,
+          target TEXT NOT NULL CHECK (target IN ('memory', 'user', 'failure')),
+          category TEXT CHECK (category IN ('failure', 'correction', 'insight', 'preference', 'convention', 'tool-quirk')),
+          content TEXT NOT NULL,
+          failure_reason TEXT,
+          tool_state TEXT,
+          corrected_to TEXT,
+          created DATE NOT NULL,
+          last_referenced DATE NOT NULL
+        );
+      `);
+
+      db.exec(`
+        INSERT INTO memories_new (id, project, target, category, content, failure_reason, tool_state, corrected_to, created, last_referenced)
+        SELECT id, project, target, category, content, failure_reason, tool_state, corrected_to, created, last_referenced
+        FROM memories;
+      `);
+
+      db.exec('DROP TABLE memories');
+      db.exec('ALTER TABLE memories_new RENAME TO memories');
+
+      db.exec('PRAGMA foreign_keys = ON');
+    });
+
+    tx();
+  }
+
+  private rebuildMemoryFts(db: Database.Database): void {
+    const ftsTable = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name='memory_fts'").get() as { name?: string } | undefined;
+    if (!ftsTable) return;
+
+    // Keep FTS index consistent after table rebuild/migrations.
+    db.exec("INSERT INTO memory_fts(memory_fts) VALUES('rebuild')");
+  }
+
   /**
    * Close the database connection.
    */

package/src/store/memory-store.ts

@@ -424,13 +424,19 @@ export class MemoryStore {
     }
   }
 
-  /** Atomic write: temp file + fs.rename() — same crash-safety as Hermes. */
+  /**
+   * Atomic write: temp file + fs.rename().
+   * Creates temp files in the same directory as the target to avoid
+   * cross-device rename errors (EXDEV) when os.tmpdir() is on a different
+   * drive than the memory directory (common on Windows).
+   */
   private async saveToDisk(target: "memory" | "user" | "failure"): Promise<void> {
     const filePath = this.pathFor(target);
     const entries = this.entriesFor(target);
     const content = entries.length ? entries.join(ENTRY_DELIMITER) : "";
 
-    const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "pi-memory-"));
+    // Use the memory directory for temp files so rename stays on the same device
+    const tmpDir = await fs.mkdtemp(path.join(this.memoryDir, ".tmp-"));
     const tmpPath = path.join(tmpDir, "write.tmp");
 
     try {
@@ -440,7 +446,7 @@ export class MemoryStore {
       try { await fs.unlink(tmpPath); } catch { /* ignore */ }
       throw err;
     } finally {
-      try { await fs.rmdir(tmpDir); } catch { /* ignore */ }
+      try { await fs.rm(tmpDir, { recursive: true, force: true }); } catch { /* ignore */ }
     }
   }
 }

package/src/store/skill-store.ts

@@ -283,10 +283,14 @@ export class SkillStore {
 
   // ─── Internal helpers ───
 
-  /** Atomic write: temp file + rename (same crash-safety as MemoryStore) */
+  /**
+   * Atomic write: temp file + rename.
+   * Creates temp files in the skills directory to avoid cross-device
+   * rename errors (EXDEV) on Windows when os.tmpdir() is on a different drive.
+   */
   private async atomicWrite(fileName: string, content: string): Promise<void> {
     const filePath = path.join(this.skillsDir, fileName);
-    const tmpDir = await fs.mkdtemp(path.join(os.tmpdir(), "pi-skill-"));
+    const tmpDir = await fs.mkdtemp(path.join(this.skillsDir, ".tmp-"));
     const tmpPath = path.join(tmpDir, "write.tmp");
 
     try {
@@ -296,7 +300,7 @@ export class SkillStore {
       try { await fs.unlink(tmpPath); } catch { /* ignore */ }
       throw err;
     } finally {
-      try { await fs.rmdir(tmpDir); } catch { /* ignore */ }
+      try { await fs.rm(tmpDir, { recursive: true, force: true }); } catch { /* ignore */ }
     }
   }
 }

package/src/types.ts

@@ -5,6 +5,8 @@
 import type { TextContent } from "@mariozechner/pi-ai";
 
 export interface MemoryConfig {
+  /** Prompt memory mode. Default: policy-only */
+  memoryMode: "policy-only" | "legacy-inject";
   /** Max chars for MEMORY.md (agent notes). Default: 5000 */
   memoryCharLimit: number;
   /** Max chars for USER.md (user profile). Default: 5000 */
@@ -13,6 +15,8 @@ export interface MemoryConfig {
   projectCharLimit: number;
   /** Turns between background auto-reviews. Default: 10 */
   nudgeInterval: number;
+  /** Recent conversation messages included in background review. 0 = all. Default: 0 */
+  reviewRecentMessages?: number;
   /** Enable background learning loop. Default: true */
   reviewEnabled: boolean;
   /** Flush memories before compaction. Default: true */
@@ -21,8 +25,12 @@ export interface MemoryConfig {
   flushOnShutdown: boolean;
   /** Minimum user turns before flush triggers. Default: 6 */
   flushMinTurns: number;
+  /** Recent conversation messages included in session flush. 0 = all. Default: 0 */
+  flushRecentMessages?: number;
   /** Override memory directory. Default: ~/.pi/agent/memory */
   memoryDir?: string;
+  /** Directory for project-scoped memory (relative to ~/.pi/agent). Default: "projects-memory" */
+  projectsMemoryDir?: string;
   /** Auto-consolidate when memory is full instead of returning error. Default: true */
   autoConsolidate: boolean;
   /** Detect user corrections and trigger immediate memory save. Default: true */

package/docs/0.7/TAGGED-SESSION-SKILL-REVIEW.md

@@ -1,112 +0,0 @@
-# v0.7 Proposal: Tagged Session Review → Skill Creation
-
-## Why
-
-Community feedback highlighted a real gap:
-- quick correction capture is useful,
-- but **durable behavior should be promoted to skills intentionally**,
-- and that flow should be reviewable in the TUI.
-
-## Goal
-
-Add a deterministic review workflow:
-1. collect candidate learnings from session messages,
-2. review them in a TUI modal,
-3. promote selected items into a draft skill,
-4. save via existing `skill` tool.
-
-## Non-goals
-
-- Auto-creating skills without user review.
-- Replacing core memory entirely.
-- Requiring git history for extraction.
-
-## UX (Target)
-
-### Command
-- `/memory-review-candidates`
-
-### Modal flow
-1. **Candidate list** (tag, source session, snippet, confidence)
-2. Actions per candidate: `approve`, `reject`, `edit`, `merge with...`
-3. Multi-select candidates and choose `Create skill draft`
-4. Draft editor with sections:
-   - `## When to Use`
-   - `## Procedure`
-   - `## Pitfalls`
-   - `## Verification`
-5. Save with `skill.create`
-
-## Candidate Sources
-
-Priority order:
-1. Explicit message tags from Pi sessions (when available)
-2. Heuristic extraction from conversation patterns:
-   - repeated corrections,
-   - multi-step successful runs,
-   - repeated tool sequences,
-   - resolved failures with clear fix.
-
-## Data Model (SQLite)
-
-New table (proposal): `memory_candidates`
-
-Columns:
-- `id` INTEGER PK
-- `session_id` TEXT
-- `message_id` TEXT
-- `project` TEXT
-- `tag` TEXT
-- `snippet` TEXT
-- `rationale` TEXT
-- `status` TEXT CHECK (`pending`,`approved`,`rejected`,`promoted`)
-- `created_at` TEXT
-- `updated_at` TEXT
-- `promoted_skill` TEXT NULL
-
-## Integration with Existing System
-
-- Keep current memory + failure capture.
-- Add a **promotion path** from memory/candidates to skills.
-- Use existing `skill` tool as persistence layer.
-- Use existing `session_search`/indexing infra for candidate discovery context.
-
-## Rollout Plan
-
-### Phase 1: Candidate staging (no modal)
-- Create `memory_candidates` table
-- Add extraction + `/memory-candidates` list command
-- Add approve/reject commands
-
-### Phase 2: TUI review modal
-- Interactive candidate triage in one place
-- Batch select + merge + edit
-
-### Phase 3: Skill draft + save
-- Generate skill draft from approved candidates
-- Edit + save with `skill.create`
-
-### Phase 4: Quality controls
-- duplicate candidate suppression
-- confidence thresholds
-- weekly reminder: pending candidates review
-
-## Success Criteria
-
-- Lower noisy memory growth in `MEMORY.md`
-- Higher percentage of reusable knowledge landing in `skills/`
-- Fewer repeated correction loops across sessions
-- Users report that learning feels intentional, not "whack-a-mole"
-
-## Open Questions
-
-1. Should candidates be extracted turn-by-turn or session-end only?
-2. Should approved candidates auto-expire if not promoted in N days?
-3. Should skill drafts include linked source message IDs for traceability?
-4. Should project scope be default-on with optional cross-project merge mode?
-
-## Notes
-
-This proposal complements (not replaces) core memory.
-Memory remains fast capture; skills remain durable procedure.
-The new modal creates the missing bridge between them.