pi-hermes-memory 0.6.5 → 0.6.6

package/docs/0.6/CHANGELOG.md

@@ -1,3 +1,28 @@
+# v0.6.6 Changelog
+
+## Bug Fixes
+
+### Fix legacy SQLite upgrade error: `no such column: category`
+
+Some users upgrading from older versions had an existing `sessions.db` with a legacy
+`memories` table that did not include v0.6 failure-memory columns. During schema init,
+creating `idx_memories_category` failed and `/memory-index-sessions` crashed with:
+
+`❌ Session indexing failed: no such column: category`
+
+Fix:
+
+- Added automatic legacy schema migration in `DatabaseManager`
+- Detects missing `memories` columns and adds them idempotently:
+  - `category`
+  - `failure_reason`
+  - `tool_state`
+  - `corrected_to`
+- Retries schema initialization after migration
+- Added regression test: `should migrate legacy memories table without category column`
+
+---
+
 # v0.6.5 Changelog
 
 ## Bug Fixes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-hermes-memory",
-  "version": "0.6.5",
+  "version": "0.6.6",
   "description": "🧠 Persistent memory + 🔍 session search + 🛡️ secret scanning for Pi. SQLite FTS5 search across every conversation, auto-consolidation, memory aging, procedural skills. 272 tests. Ported from Hermes agent.",
   "type": "module",
   "main": "src/index.ts",

package/src/store/db.ts

@@ -38,11 +38,53 @@ export class DatabaseManager {
     db.pragma('foreign_keys = ON');
 
     // Create tables and triggers
-    db.exec(SCHEMA_SQL);
+    try {
+      db.exec(SCHEMA_SQL);
+    } catch (err) {
+      if (!this.isLegacyMemoriesCategoryError(err)) {
+        throw err;
+      }
+
+      // Legacy DB from pre-v0.6 can have memories table without the category
+      // and failure metadata columns. Add missing columns, then retry schema.
+      this.ensureMemoriesColumns(db);
+      db.exec(SCHEMA_SQL);
+    }
+
+    // Extra safety: always ensure the legacy memories columns exist, even when
+    // schema execution succeeds (idempotent on upgraded DBs).
+    this.ensureMemoriesColumns(db);
 
     return db;
   }
 
+  private isLegacyMemoriesCategoryError(err: unknown): boolean {
+    if (!(err instanceof Error)) return false;
+    const msg = err.message.toLowerCase();
+    return msg.includes('no such column: category') || msg.includes('memories(category)');
+  }
+
+  private ensureMemoriesColumns(db: Database.Database): void {
+    const tableExists = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name='memories'").get() as { name: string } | undefined;
+    if (!tableExists) return;
+
+    const columns = db.prepare('PRAGMA table_info(memories)').all() as { name: string }[];
+    const names = new Set(columns.map((c) => c.name));
+
+    if (!names.has('category')) {
+      db.exec('ALTER TABLE memories ADD COLUMN category TEXT');
+    }
+    if (!names.has('failure_reason')) {
+      db.exec('ALTER TABLE memories ADD COLUMN failure_reason TEXT');
+    }
+    if (!names.has('tool_state')) {
+      db.exec('ALTER TABLE memories ADD COLUMN tool_state TEXT');
+    }
+    if (!names.has('corrected_to')) {
+      db.exec('ALTER TABLE memories ADD COLUMN corrected_to TEXT');
+    }
+  }
+
   /**
    * Close the database connection.
    */