pi-hermes-memory 0.6.4 → 0.6.6

package/docs/0.6/CHANGELOG.md

@@ -0,0 +1,57 @@
+# v0.6.6 Changelog
+
+## Bug Fixes
+
+### Fix legacy SQLite upgrade error: `no such column: category`
+
+Some users upgrading from older versions had an existing `sessions.db` with a legacy
+`memories` table that did not include v0.6 failure-memory columns. During schema init,
+creating `idx_memories_category` failed and `/memory-index-sessions` crashed with:
+
+`❌ Session indexing failed: no such column: category`
+
+Fix:
+
+- Added automatic legacy schema migration in `DatabaseManager`
+- Detects missing `memories` columns and adds them idempotently:
+  - `category`
+  - `failure_reason`
+  - `tool_state`
+  - `corrected_to`
+- Retries schema initialization after migration
+- Added regression test: `should migrate legacy memories table without category column`
+
+---
+
+# v0.6.5 Changelog
+
+## Bug Fixes
+
+### Auto-review no longer blocks interactive chat (#10)
+
+The background auto-review was `await`ing `pi.exec()` inside the `turn_end` handler, which
+blocked the chat from responding while the review subprocess ran. Fixed by making the
+review subprocess fire-and-forget — the turn_end handler returns immediately, and the
+subprocess completes asynchronously.
+
+- `pi.exec()` is no longer awaited — handler returns immediately
+- `reviewInProgress` guard resets in `.then()` / `.catch()` callbacks
+- Overlapping reviews are still prevented by the guard
+- Notifications are delivered via `.then()` callback once the subprocess completes
+
+### Auto-review failures on Windows no longer show errors (#9)
+
+On Windows git-bash, `pi exec` subprocesses could exit with code 1 producing
+`[hermes] auto-review failed (exit=1): unknown error` messages every few turns. Fixed by
+making auto-review truly best-effort — non-zero exit codes and spawn errors are silently
+ignored.
+
+- Suppressed error notifications for non-zero exit codes
+- Suppressed error notifications for subprocess failures (timeout, signal, spawn)
+- The next review cycle will retry automatically
+
+### Crash safety
+
+- Snapshot-building code (`getBranch()`, message parsing) is wrapped in a minimal try/catch
+  to handle expired sessions gracefully
+- Early return resets `reviewInProgress` guard to unblock future reviews

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-hermes-memory",
-  "version": "0.6.4",
+  "version": "0.6.6",
   "description": "🧠 Persistent memory + 🔍 session search + 🛡️ secret scanning for Pi. SQLite FTS5 search across every conversation, auto-consolidation, memory aging, procedural skills. 272 tests. Ported from Hermes agent.",
   "type": "module",
   "main": "src/index.ts",

package/src/handlers/background-review.ts

@@ -66,10 +66,10 @@ export function setupBackgroundReview(
     toolCallsSinceReview = 0;
     reviewInProgress = true;
 
+    // Build conversation snapshot from session entries (crash-safe)
+    let parts: string[] = [];
     try {
-      // Build conversation snapshot from session entries
       const entries = ctx.sessionManager.getBranch();
-      const parts: string[] = [];
 
       for (const entry of entries) {
         if (entry.type !== "message") continue;
@@ -79,56 +79,72 @@ export function setupBackgroundReview(
         const prefix = msg.role === "user" ? "[USER]" : "[ASSISTANT]";
         parts.push(`${prefix}: ${text}`);
       }
-      if (parts.length < 4) return; // Not enough conversation to review
-
-      const currentMemory = store.getMemoryEntries().join("\n§\n");
-      const currentUser = store.getUserEntries().join("\n§\n");
-      const currentProject = projectStore ? projectStore.getMemoryEntries().join("\n§\n") : null;
-
-      const reviewPrompt = [
-        COMBINED_REVIEW_PROMPT,
-        "",
-        "--- Current Memory ---",
-        currentMemory || "(empty)",
-        "",
-        "--- Current User Profile ---",
-        currentUser || "(empty)",
-      ];
-
-      if (currentProject !== null) {
-        reviewPrompt.push(
-          "",
-          "--- Current Project Memory ---",
-          currentProject || "(empty)",
-        );
-      }
+    } catch {
+      reviewInProgress = false;
+      return; // Session expired or empty — nothing to review
+    }
+    if (parts.length < 4) {
+      reviewInProgress = false;
+      return; // Not enough conversation to review
+    }
 
+    const currentMemory = store.getMemoryEntries().join("\n§\n");
+    const currentUser = store.getUserEntries().join("\n§\n");
+    const currentProject = projectStore ? projectStore.getMemoryEntries().join("\n§\n") : null;
+
+    const reviewPrompt = [
+      COMBINED_REVIEW_PROMPT,
+      "",
+      "--- Current Memory ---",
+      currentMemory || "(empty)",
+      "",
+      "--- Current User Profile ---",
+      currentUser || "(empty)",
+    ];
+
+    if (currentProject !== null) {
       reviewPrompt.push(
         "",
-        "--- Conversation to Review ---",
-        parts.join("\n\n"),
+        "--- Current Project Memory ---",
+        currentProject || "(empty)",
       );
+    }
 
-      const result = await pi.exec("pi", ["-p", "--no-session", reviewPrompt.join("\n")], {
-        signal: ctx.signal,
-        timeout: 120000,
-      });
-
-      if (result.code === 0 && result.stdout) {
-        const output = result.stdout.trim();
-        if (output && !output.toLowerCase().includes("nothing to save")) {
-          ctx.ui.notify("💾 Memory auto-reviewed and updated", "info");
+    reviewPrompt.push(
+      "",
+      "--- Conversation to Review ---",
+      parts.join("\n\n"),
+    );
+
+    // Fire-and-forget: do NOT await. The review runs in a subprocess;
+    // blocking turn_end would freeze the interactive chat.
+    // Notifications are delivered via .then() once the subprocess completes.
+    //
+    // We intentionally omit ctx.signal — the signal is tied to the turn
+    // lifetime and would abort the subprocess before it finishes now that
+    // we're not awaiting. The timeout (120s) provides its own safety net.
+    const reviewPromise = pi.exec("pi", ["-p", "--no-session", reviewPrompt.join("\n")], {
+      signal: undefined,
+      timeout: 120000,
+    });
+
+    reviewPromise
+      .then((result) => {
+        reviewInProgress = false;
+        if (result.code === 0 && result.stdout) {
+          const output = result.stdout.trim();
+          if (output && !output.toLowerCase().includes("nothing to save")) {
+            ctx.ui.notify("💾 Memory auto-reviewed and updated", "info");
+          }
         }
-      } else {
-        ctx.ui.notify(
-          `[hermes] auto-review failed (exit=${result.code}): ${result.stderr?.slice(0, 200) || "unknown error"}`,
-          "error",
-        );
-      }
-    } catch (err) {
-      ctx.ui.notify(`[hermes] auto-review error: ${String(err).slice(0, 200)}`, "error");
-    } finally {
-      reviewInProgress = false;
-    }
+        // Auto-review is best-effort. Non-zero exits are silently skipped —
+        // common on Windows where pi CLI may resolve differently. The next
+        // review cycle will retry.
+      })
+      .catch(() => {
+        // Best-effort: subprocess failures (timeout, signal, spawn errors)
+        // are silently ignored. The next review cycle will retry.
+        reviewInProgress = false;
+      });
   });
 }

package/src/store/db.ts

@@ -38,11 +38,53 @@ export class DatabaseManager {
     db.pragma('foreign_keys = ON');
 
     // Create tables and triggers
-    db.exec(SCHEMA_SQL);
+    try {
+      db.exec(SCHEMA_SQL);
+    } catch (err) {
+      if (!this.isLegacyMemoriesCategoryError(err)) {
+        throw err;
+      }
+
+      // Legacy DB from pre-v0.6 can have memories table without the category
+      // and failure metadata columns. Add missing columns, then retry schema.
+      this.ensureMemoriesColumns(db);
+      db.exec(SCHEMA_SQL);
+    }
+
+    // Extra safety: always ensure the legacy memories columns exist, even when
+    // schema execution succeeds (idempotent on upgraded DBs).
+    this.ensureMemoriesColumns(db);
 
     return db;
   }
 
+  private isLegacyMemoriesCategoryError(err: unknown): boolean {
+    if (!(err instanceof Error)) return false;
+    const msg = err.message.toLowerCase();
+    return msg.includes('no such column: category') || msg.includes('memories(category)');
+  }
+
+  private ensureMemoriesColumns(db: Database.Database): void {
+    const tableExists = db.prepare("SELECT name FROM sqlite_master WHERE type='table' AND name='memories'").get() as { name: string } | undefined;
+    if (!tableExists) return;
+
+    const columns = db.prepare('PRAGMA table_info(memories)').all() as { name: string }[];
+    const names = new Set(columns.map((c) => c.name));
+
+    if (!names.has('category')) {
+      db.exec('ALTER TABLE memories ADD COLUMN category TEXT');
+    }
+    if (!names.has('failure_reason')) {
+      db.exec('ALTER TABLE memories ADD COLUMN failure_reason TEXT');
+    }
+    if (!names.has('tool_state')) {
+      db.exec('ALTER TABLE memories ADD COLUMN tool_state TEXT');
+    }
+    if (!names.has('corrected_to')) {
+      db.exec('ALTER TABLE memories ADD COLUMN corrected_to TEXT');
+    }
+  }
+
   /**
    * Close the database connection.
    */