pi-hermes-memory 0.6.3 → 0.6.5

package/docs/0.6/CHANGELOG.md

@@ -0,0 +1,32 @@
+# v0.6.5 Changelog
+
+## Bug Fixes
+
+### Auto-review no longer blocks interactive chat (#10)
+
+The background auto-review was `await`ing `pi.exec()` inside the `turn_end` handler, which
+blocked the chat from responding while the review subprocess ran. Fixed by making the
+review subprocess fire-and-forget — the turn_end handler returns immediately, and the
+subprocess completes asynchronously.
+
+- `pi.exec()` is no longer awaited — handler returns immediately
+- `reviewInProgress` guard resets in `.then()` / `.catch()` callbacks
+- Overlapping reviews are still prevented by the guard
+- Notifications are delivered via `.then()` callback once the subprocess completes
+
+### Auto-review failures on Windows no longer show errors (#9)
+
+On Windows git-bash, `pi exec` subprocesses could exit with code 1 producing
+`[hermes] auto-review failed (exit=1): unknown error` messages every few turns. Fixed by
+making auto-review truly best-effort — non-zero exit codes and spawn errors are silently
+ignored.
+
+- Suppressed error notifications for non-zero exit codes
+- Suppressed error notifications for subprocess failures (timeout, signal, spawn)
+- The next review cycle will retry automatically
+
+### Crash safety
+
+- Snapshot-building code (`getBranch()`, message parsing) is wrapped in a minimal try/catch
+  to handle expired sessions gracefully
+- Early return resets `reviewInProgress` guard to unblock future reviews

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-hermes-memory",
-  "version": "0.6.3",
+  "version": "0.6.5",
   "description": "🧠 Persistent memory + 🔍 session search + 🛡️ secret scanning for Pi. SQLite FTS5 search across every conversation, auto-consolidation, memory aging, procedural skills. 272 tests. Ported from Hermes agent.",
   "type": "module",
   "main": "src/index.ts",

package/src/handlers/background-review.ts

@@ -66,10 +66,10 @@ export function setupBackgroundReview(
     toolCallsSinceReview = 0;
     reviewInProgress = true;
 
+    // Build conversation snapshot from session entries (crash-safe)
+    let parts: string[] = [];
     try {
-      // Build conversation snapshot from session entries
       const entries = ctx.sessionManager.getBranch();
-      const parts: string[] = [];
 
       for (const entry of entries) {
         if (entry.type !== "message") continue;
@@ -79,56 +79,72 @@ export function setupBackgroundReview(
         const prefix = msg.role === "user" ? "[USER]" : "[ASSISTANT]";
         parts.push(`${prefix}: ${text}`);
       }
-      if (parts.length < 4) return; // Not enough conversation to review
-
-      const currentMemory = store.getMemoryEntries().join("\n§\n");
-      const currentUser = store.getUserEntries().join("\n§\n");
-      const currentProject = projectStore ? projectStore.getMemoryEntries().join("\n§\n") : null;
-
-      const reviewPrompt = [
-        COMBINED_REVIEW_PROMPT,
-        "",
-        "--- Current Memory ---",
-        currentMemory || "(empty)",
-        "",
-        "--- Current User Profile ---",
-        currentUser || "(empty)",
-      ];
-
-      if (currentProject !== null) {
-        reviewPrompt.push(
-          "",
-          "--- Current Project Memory ---",
-          currentProject || "(empty)",
-        );
-      }
+    } catch {
+      reviewInProgress = false;
+      return; // Session expired or empty — nothing to review
+    }
+    if (parts.length < 4) {
+      reviewInProgress = false;
+      return; // Not enough conversation to review
+    }
 
+    const currentMemory = store.getMemoryEntries().join("\n§\n");
+    const currentUser = store.getUserEntries().join("\n§\n");
+    const currentProject = projectStore ? projectStore.getMemoryEntries().join("\n§\n") : null;
+
+    const reviewPrompt = [
+      COMBINED_REVIEW_PROMPT,
+      "",
+      "--- Current Memory ---",
+      currentMemory || "(empty)",
+      "",
+      "--- Current User Profile ---",
+      currentUser || "(empty)",
+    ];
+
+    if (currentProject !== null) {
       reviewPrompt.push(
         "",
-        "--- Conversation to Review ---",
-        parts.join("\n\n"),
+        "--- Current Project Memory ---",
+        currentProject || "(empty)",
       );
+    }
 
-      const result = await pi.exec("pi", ["-p", "--no-session", reviewPrompt.join("\n")], {
-        signal: ctx.signal,
-        timeout: 120000,
-      });
-
-      if (result.code === 0 && result.stdout) {
-        const output = result.stdout.trim();
-        if (output && !output.toLowerCase().includes("nothing to save")) {
-          ctx.ui.notify("💾 Memory auto-reviewed and updated", "info");
+    reviewPrompt.push(
+      "",
+      "--- Conversation to Review ---",
+      parts.join("\n\n"),
+    );
+
+    // Fire-and-forget: do NOT await. The review runs in a subprocess;
+    // blocking turn_end would freeze the interactive chat.
+    // Notifications are delivered via .then() once the subprocess completes.
+    //
+    // We intentionally omit ctx.signal — the signal is tied to the turn
+    // lifetime and would abort the subprocess before it finishes now that
+    // we're not awaiting. The timeout (120s) provides its own safety net.
+    const reviewPromise = pi.exec("pi", ["-p", "--no-session", reviewPrompt.join("\n")], {
+      signal: undefined,
+      timeout: 120000,
+    });
+
+    reviewPromise
+      .then((result) => {
+        reviewInProgress = false;
+        if (result.code === 0 && result.stdout) {
+          const output = result.stdout.trim();
+          if (output && !output.toLowerCase().includes("nothing to save")) {
+            ctx.ui.notify("💾 Memory auto-reviewed and updated", "info");
+          }
         }
-      } else {
-        ctx.ui.notify(
-          `[hermes] auto-review failed (exit=${result.code}): ${result.stderr?.slice(0, 200) || "unknown error"}`,
-          "error",
-        );
-      }
-    } catch (err) {
-      ctx.ui.notify(`[hermes] auto-review error: ${String(err).slice(0, 200)}`, "error");
-    } finally {
-      reviewInProgress = false;
-    }
+        // Auto-review is best-effort. Non-zero exits are silently skipped —
+        // common on Windows where pi CLI may resolve differently. The next
+        // review cycle will retry.
+      })
+      .catch(() => {
+        // Best-effort: subprocess failures (timeout, signal, spawn errors)
+        // are silently ignored. The next review cycle will retry.
+        reviewInProgress = false;
+      });
   });
 }

package/src/handlers/learn-memory.ts

@@ -29,17 +29,28 @@ export function registerLearnMemoryCommand(pi: ExtensionAPI): void {
         lines.push("  ║           📦 What Gets Saved                 ║");
         lines.push("  ╚══════════════════════════════════════════════╝");
         lines.push("");
-        lines.push("  Type            │ File         │ Limit");
-        lines.push("  ────────────────┼──────────────┼────────────");
-        lines.push("  🧠 Memory       │ MEMORY.md    │ 5,000 chars");
-        lines.push("  👤 User Profile │ USER.md      │ 5,000 chars");
-        lines.push("  📚 Skills       │ skills/*.md  │ Unlimited");
-        lines.push("  💾 Extended     │ sessions.db  │ Unlimited");
-        lines.push("");
-        lines.push("  Memory: Facts — env details, project conventions, tool quirks");
-        lines.push("  User:   Who you are — name, preferences, communication style");
-        lines.push("  Skills: Procedures — how to debug, deploy, test");
+        lines.push("  Type            │ File          │ Limit");
+        lines.push("  ────────────────┼───────────────┼────────────");
+        lines.push("  🧠 Memory       │ MEMORY.md     │ 5,000 chars");
+        lines.push("  👤 User Profile │ USER.md       │ 5,000 chars");
+        lines.push("  ⚠️  Failures     │ failures.md   │ 10,000 chars");
+        lines.push("  📚 Skills       │ skills/*.md   │ Unlimited");
+        lines.push("  💾 Extended     │ sessions.db   │ Unlimited");
+        lines.push("");
+        lines.push("  Memory:   Facts — env details, project conventions, tool quirks");
+        lines.push("  User:     Who you are — name, preferences, communication style");
+        lines.push("  Failures: What didn't work — corrections, failures, insights");
+        lines.push("  Skills:   Procedures — how to debug, deploy, test");
         lines.push("  Extended: Searchable memories beyond the core limit");
+        lines.push("");
+        lines.push("  Memory Categories:");
+        lines.push("  ─────────────────");
+        lines.push("  [failure]      What was tried but didn't work");
+        lines.push("  [correction]   User corrected the agent");
+        lines.push("  [insight]      Learning from experience");
+        lines.push("  [preference]   User preference");
+        lines.push("  [convention]   Project convention");
+        lines.push("  [tool-quirk]   Tool-specific knowledge");
       }
 
       if (section.startsWith("🔧")) {
@@ -50,6 +61,7 @@ export function registerLearnMemoryCommand(pi: ExtensionAPI): void {
         lines.push("");
         lines.push("  memory (add/replace/remove)");
         lines.push("    Save, update, or delete memories");
+        lines.push("    Targets: memory, user, failure, project");
         lines.push("");
         lines.push("  skill (create/view/patch/edit/delete)");
         lines.push("    Save reusable procedures");
@@ -59,6 +71,8 @@ export function registerLearnMemoryCommand(pi: ExtensionAPI): void {
         lines.push("");
         lines.push("  memory_search");
         lines.push("    Search extended memory store (unlimited)");
+        lines.push("    Filters: project, target, category");
+        lines.push("    Categories: failure, correction, insight, preference, convention, tool-quirk");
       }
 
       if (section.startsWith("📋")) {
@@ -86,6 +100,7 @@ export function registerLearnMemoryCommand(pi: ExtensionAPI): void {
         lines.push("     • Environment facts (\"macOS M1\", \"Node 20\")");
         lines.push("     • Corrections (\"don't use npm — use pnpm\")");
         lines.push("     • Project conventions (\"monorepo with turborepo\")");
+        lines.push("     • Failures (\"tried localStorage — XSS vulnerability\")");
         lines.push("");
         lines.push("  ❌ DON'T save:");
         lines.push("     • Task progress (\"finished implementing auth\")");
@@ -99,12 +114,13 @@ export function registerLearnMemoryCommand(pi: ExtensionAPI): void {
         lines.push("  ║          🔄 How Memory Flows                 ║");
         lines.push("  ╚══════════════════════════════════════════════╝");
         lines.push("");
-        lines.push("  1. Session starts     → Core memory injected");
+        lines.push("  1. Session starts     → Core memory + recent failures injected");
         lines.push("  2. During conversation → Agent saves via memory tool");
         lines.push("  3. Every 10 turns     → Background review saves items");
-        lines.push("  4. On correction      → Immediate save");
-        lines.push("  5. When full          → Auto-consolidation merges");
-        lines.push("  6. Session ends       → Final flush");
+        lines.push("  4. On correction      → Immediate save as [correction] category");
+        lines.push("  5. On failure         → Saves what failed + why");
+        lines.push("  6. When full          → Auto-consolidation merges");
+        lines.push("  7. Session ends       → Final flush");
       }
 
       if (section.startsWith("🏗️")) {
@@ -117,6 +133,7 @@ export function registerLearnMemoryCommand(pi: ExtensionAPI): void {
         lines.push("  ┌─────────────────────────────────────┐");
         lines.push("  │ MEMORY.md — Facts, conventions      │");
         lines.push("  │ USER.md   — Who you are             │");
+        lines.push("  │ failures.md — Recent failures (7d)  │");
         lines.push("  │ Project memory — When cwd matches   │");
         lines.push("  └─────────────────────────────────────┘");
         lines.push("");
@@ -124,6 +141,7 @@ export function registerLearnMemoryCommand(pi: ExtensionAPI): void {
         lines.push("  ┌─────────────────────────────────────┐");
         lines.push("  │ session_search(\"auth flow\")         │");
         lines.push("  │ memory_search(\"testing patterns\")   │");
+        lines.push("  │ memory_search(\"auth\", cat:\"failure\")│");
         lines.push("  └─────────────────────────────────────┘");
       }