pi-herdr-agents 0.1.2 → 0.1.3

package/docs/orchestrated-review-workflow-plan.md

@@ -317,13 +317,18 @@ The full bounded `RunEnvelope` exists exactly once, inside the single terminal e
 ```text
 approved
 started
+reader_checkout_ready | reader_checkout_retained | reader_checkout_disposed
 agent_started
+agent_completed
 agent_result
+pane_close_failed
 workflow_log
 completed | failed | cancelled | interrupted
 delivery
 ```
 
+`agent_completed` records the observed child exit, session availability, final assistant-text length, and (when present) final stop reason before the corresponding `agent_result` records the workflow-facing success or failure envelope.
+
 `delivery` follows the terminal event and contains only its terminal-event ID/state, target parent session, attempt time, and `sent | failed` delivery status. It never duplicates the task result. Evidence readers obtain the result from the referenced terminal event. Do not add mutable snapshots, locks, leases, backups, call caching, or replay.
 
 One process-global owner records the run ID, canonical project identity, lifecycle gate, Worker, and private child handles. `/new`, `/resume`, and `/fork` cannot start a second workflow while this owner exists; cancellation names the run ID and must match the current canonical project identity. On same-process `/reload`, the owner and Worker continue, and completion selects the latest extension API once. On full startup, scan only direct child directories under the current project's `.pi/plans/` and inspect only each journal's last valid event. A `delivery` event carries its referenced terminal state, a terminal event is already settled, and a non-terminal running event with no live process-global owner receives one `interrupted` terminal event. Do not recurse, restart, clean, or expose history UI.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-herdr-agents",
-  "version": "0.1.2",
+  "version": "0.1.3",
   "description": "Asynchronous Pi subagents and approved review workflows in Herdr, with optional isolated Git worktrees",
   "keywords": [
     "pi-package",

package/pi-extension/subagents/index.ts

@@ -85,6 +85,7 @@ import {
 
 import {
 	findLastAssistantMessage,
+	inspectFinalAssistantMessage,
 	findObservedSessionRuntime,
 	getNewEntries,
 	seedSubagentSessionFile,
@@ -3033,18 +3034,43 @@ export default function subagentsExtension(pi: ExtensionAPI) {
 			if (childController.signal.aborted || watched.error === "cancelled") {
 				return workflowFailure("cancelled", "Workflow cancelled.");
 			}
-			const childEntries = existsSync(sessionFile)
+			const sessionExists = existsSync(sessionFile);
+			const childEntries = sessionExists
 				? getNewEntries(sessionFile, 0)
 				: [];
-			const summary = findLastAssistantMessage(childEntries);
-			if (watched.exitCode !== 0 || watched.errorMessage || !summary) {
+			const finalAssistant = inspectFinalAssistantMessage(childEntries);
+			journal.append("agent_completed", {
+				id,
+				role: roleName,
+				sessionFile,
+				sessionExists,
+				exitCode: watched.exitCode,
+				...(watched.errorMessage
+					? { errorMessage: watched.errorMessage }
+					: {}),
+				finalAssistantContentLength: finalAssistant.contentLength,
+				...(finalAssistant.stopReason
+					? { finalAssistantStopReason: finalAssistant.stopReason }
+					: {}),
+			});
+			if (watched.exitCode !== 0 || watched.errorMessage) {
 				return workflowFailure(
 					"child_error",
 					watched.errorMessage ??
-						summary ??
 						`Workflow child exited with code ${watched.exitCode}`,
 				);
 			}
+			if (!finalAssistant.text) {
+				return workflowFailure(
+					"empty_completion",
+					`Workflow child completed without assistant text${
+						finalAssistant.stopReason
+							? ` (stopReason: ${finalAssistant.stopReason})`
+							: ""
+					}.`,
+				);
+			}
+			const summary = finalAssistant.text;
 			const observed = findObservedSessionRuntime(childEntries);
 			const observedModel =
 				observed.provider && observed.modelId

package/pi-extension/subagents/session.ts

@@ -136,6 +136,39 @@ export function findObservedSessionRuntime(entries: SessionEntry[]): ObservedSes
   return observed;
 }
 
+export interface FinalAssistantMessage {
+  text: string | null;
+  contentLength: number;
+  stopReason?: string;
+}
+
+/** Inspect only the final assistant message for workflow completion evidence. */
+export function inspectFinalAssistantMessage(
+  entries: SessionEntry[],
+): FinalAssistantMessage {
+  for (let i = entries.length - 1; i >= 0; i--) {
+    const entry = entries[i];
+    if (entry.type !== "message") continue;
+    const msg = entry as MessageEntry;
+    if (msg.message.role !== "assistant") continue;
+
+    const texts = msg.message.content
+      .filter(
+        (block) =>
+          block.type === "text" && typeof block.text === "string",
+      )
+      .map((block) => block.text as string);
+    const text = texts.join("\n");
+    const stopReason = (msg.message as { stopReason?: unknown }).stopReason;
+    return {
+      text: text.trim() ? text : null,
+      contentLength: text.length,
+      ...(typeof stopReason === "string" ? { stopReason } : {}),
+    };
+  }
+  return { text: null, contentLength: 0 };
+}
+
 export function findLastAssistantMessage(entries: SessionEntry[]): string | null {
   for (let i = entries.length - 1; i >= 0; i--) {
     const entry = entries[i];