pi-hashline-edit-pro 7.0.0 → 7.1.0

package/src/outline/render.ts

@@ -1,14 +1,18 @@
 import { DEFAULT_MAX_BYTES } from "@earendil-works/pi-coding-agent";
+import { HASH_SEP } from "../hashline";
 import { clipLine } from "../utils";
 import type { OutlineSymbol } from "./parsers";
 
 const DEFAULT_MAX_ROWS = 400;
 const DEFAULT_MAX_DEPTH = 6;
-const MAX_DETAIL_CHARS = 60;
 const PREVIEW_HEAD_LINES = 20;
 const PREVIEW_TAIL_LINES = 10;
 const PREVIEW_LINE_CHARS = 200;
 
+function formatMoreLines(count: number): string {
+	return `... (${count} more ${count === 1 ? "line" : "lines"})`;
+}
+
 export interface OutlineRow {
 	line: number;
 	anchor: string;
@@ -20,6 +24,7 @@ export interface OutlineRender {
 	rows: OutlineRow[];
 	servedHashes: string[];
 	truncated: boolean;
+	complete: boolean;
 }
 
 export interface SymbolOutlineInput {
@@ -43,64 +48,118 @@ export interface PreviewOutlineInput {
 	maxBytes?: number;
 }
 
-function servedHashesOf(rows: OutlineRow[]): string[] {
-	return [...new Set(rows.map((row) => row.anchor))];
+interface OutlineBudget {
+	output: string[];
+	rows: OutlineRow[];
+	servedHashes: string[];
+	maxRows: number;
+	maxBytes: number;
+	bytes: number;
+	truncated: boolean;
+	truncation?: "rows" | "bytes";
+	skipped: number;
+}
+
+function startBudget(header: string, maxRows: number, maxBytes: number): OutlineBudget {
+	return { output: [header], rows: [], servedHashes: [], maxRows, maxBytes, bytes: Buffer.byteLength(header, "utf-8") + 1, truncated: false, skipped: 0 };
+}
+
+function pushLine(budget: OutlineBudget, text: string): boolean {
+	const size = Buffer.byteLength(text, "utf-8") + 1;
+	if (budget.bytes + size > budget.maxBytes) return false;
+	budget.bytes += size;
+	budget.output.push(text);
+	return true;
+}
+
+function markTruncated(budget: OutlineBudget, cause: "rows" | "bytes"): void {
+	budget.truncated = true;
+	if (budget.truncation === undefined) budget.truncation = cause;
+}
+
+function isComplete(budget: OutlineBudget): boolean {
+	return !budget.truncated && budget.skipped === 0 && budget.servedHashes.length === budget.rows.length;
+}
+
+type EmitOutcome = "emitted" | "skipped" | "stopped";
+
+function emitRow(budget: OutlineBudget, hashes: string[], lines: string[], line: number, text: string): EmitOutcome {
+	const anchor = hashes[line - 1];
+	if (anchor === undefined) {
+		budget.skipped += 1;
+		return "skipped";
+	}
+	if (budget.rows.length >= budget.maxRows) {
+		markTruncated(budget, "rows");
+		return "stopped";
+	}
+	if (!pushLine(budget, `${anchor}${HASH_SEP}${text}`)) {
+		markTruncated(budget, "bytes");
+		return "stopped";
+	}
+	budget.rows.push({ line, anchor, text });
+	if (text === (lines[line - 1] ?? "")) budget.servedHashes.push(anchor);
+	return "emitted";
 }
 
-function countSymbols(symbols: OutlineSymbol[]): number {
+function countSymbolRows(
+	symbols: OutlineSymbol[],
+	depth: number,
+	maxDepth: number,
+	hashes: string[],
+	seenLines: Set<number>,
+): number {
 	let total = 0;
 	for (const symbol of symbols) {
-		total += 1;
-		if (symbol.children) total += countSymbols(symbol.children);
+		const children = symbol.children ?? [];
+		if (seenLines.has(symbol.startLine)) {
+			if (children.length > 0 && depth < maxDepth) total += countSymbolRows(children, depth + 1, maxDepth, hashes, seenLines);
+			continue;
+		}
+		seenLines.add(symbol.startLine);
+		if (hashes[symbol.startLine - 1] !== undefined) total += 1;
+		if (children.length === 0 || depth >= maxDepth) continue;
+		total += countSymbolRows(children, depth + 1, maxDepth, hashes, seenLines);
 	}
 	return total;
 }
 
-function symbolLabel(symbol: OutlineSymbol, depth: number): string {
-	const indent = "  ".repeat(depth);
-	const name = symbol.name.length > 0 ? ` ${symbol.name}` : "";
-	const detail = symbol.detail !== undefined && symbol.detail.length > 0
-		? ` ${symbol.detail.length > MAX_DETAIL_CHARS ? `${symbol.detail.slice(0, MAX_DETAIL_CHARS - 3)}...` : symbol.detail}`
-		: "";
-	const children = symbol.children !== undefined && symbol.children.length > 0 ? ` (${symbol.children.length} children)` : "";
-	const span = symbol.endLine - symbol.startLine + 1;
-	return `${indent}${symbol.type}${name}${detail}${children}${span > 1 ? ` [limit ${span}]` : ""}`;
-}
-
 export function renderSymbolOutline(input: SymbolOutlineInput): OutlineRender {
-	const maxRows = input.maxRows ?? DEFAULT_MAX_ROWS;
-	const maxDepth = input.maxDepth ?? DEFAULT_MAX_DEPTH;
-	const maxBytes = input.maxBytes ?? DEFAULT_MAX_BYTES;
 	const header = `=== ${input.displayPath}${input.languageName !== undefined ? ` (${input.languageName})` : ""} — ${input.totalLines} lines ===`;
-	const rows: OutlineRow[] = [];
-	const output: string[] = [header];
-	let bytes = Buffer.byteLength(header, "utf-8") + 1;
-	let truncated = false;
-
-	const addRow = (line: number, text: string): boolean => {
-		const anchor = input.hashes[line - 1];
-		if (anchor === undefined) return true;
-		const rendered = `${anchor}│${text}`;
-		const size = Buffer.byteLength(rendered, "utf-8") + 1;
-		if (rows.length >= maxRows || bytes + size > maxBytes) {
-			truncated = true;
-			return false;
-		}
-		bytes += size;
-		output.push(rendered);
-		rows.push({ line, anchor, text });
-		return true;
-	};
+	const budget = startBudget(header, input.maxRows ?? DEFAULT_MAX_ROWS, input.maxBytes ?? DEFAULT_MAX_BYTES);
+	const maxDepth = input.maxDepth ?? DEFAULT_MAX_DEPTH;
+	const seenLines = new Set<number>();
 
 	const walk = (symbols: OutlineSymbol[], depth: number): boolean => {
 		for (const symbol of symbols) {
-			const contentLine = symbol.endLine === symbol.startLine ? input.lines[symbol.startLine - 1] : undefined;
-			const text = contentLine === undefined ? symbolLabel(symbol, depth) : clipLine(contentLine, PREVIEW_LINE_CHARS);
-			if (!addRow(symbol.startLine, text)) return false;
+			if (seenLines.has(symbol.startLine)) {
+				const children = symbol.children ?? [];
+				if (children.length > 0) {
+					if (depth < maxDepth) {
+						if (!walk(children, depth + 1)) return false;
+					} else if (!pushLine(budget, `[${children.length} nested]`)) {
+						markTruncated(budget, "bytes");
+						return false;
+					}
+				}
+				continue;
+			}
+			seenLines.add(symbol.startLine);
+			const text = clipLine(input.lines[symbol.startLine - 1] ?? "", PREVIEW_LINE_CHARS);
+			const outcome = emitRow(budget, input.hashes, input.lines, symbol.startLine, text);
+			if (outcome === "stopped") return false;
+			const span = symbol.endLine - symbol.startLine + 1;
+			if (outcome === "emitted" && span > 1 && !pushLine(budget, `[limit ${span}]`)) {
+				markTruncated(budget, "bytes");
+				return false;
+			}
 			const children = symbol.children ?? [];
 			if (children.length === 0) continue;
 			if (depth >= maxDepth) {
-				output.push(`${"  ".repeat(depth + 1)}(${children.length} nested items)`);
+				if (!pushLine(budget, `[${children.length} nested]`)) {
+					markTruncated(budget, "bytes");
+					return false;
+				}
 				continue;
 			}
 			if (!walk(children, depth + 1)) return false;
@@ -109,62 +168,75 @@ export function renderSymbolOutline(input: SymbolOutlineInput): OutlineRender {
 	};
 
 	walk(input.symbols, 0);
-	if (truncated) {
-		output.push(`... (${countSymbols(input.symbols) - rows.length} more symbols)`);
+	if (budget.truncated) {
+		const remaining = countSymbolRows(input.symbols, 0, maxDepth, input.hashes, new Set<number>()) - budget.rows.length;
+		const more = remaining > 0 ? ` (${remaining} more ${remaining === 1 ? "symbol" : "symbols"})` : "";
+		const cause = budget.truncation === "rows" ? "row cap" : "byte budget";
+		if (budget.rows.length === 0) {
+			budget.output.push(more.length > 0
+				? `...${more}; outline truncated by the ${cause} before the first row.`
+				: `... (outline truncated by the ${cause} before the first row.)`);
+		} else if (remaining > 0) {
+			budget.output.push(`...${more}; read from the last shown anchor to continue.`);
+		} else {
+			budget.output.push(`... (outline truncated by the ${cause}; read from the last shown anchor to continue.)`);
+		}
 	}
-	return { text: output.join("\n"), rows, servedHashes: servedHashesOf(rows), truncated };
+	return { text: budget.output.join("\n"), rows: budget.rows, servedHashes: budget.servedHashes, truncated: budget.truncated, complete: isComplete(budget) };
 }
 
 export function renderPreviewOutline(input: PreviewOutlineInput): OutlineRender {
-	const headCount = input.headLines ?? PREVIEW_HEAD_LINES;
-	const tailCount = input.tailLines ?? PREVIEW_TAIL_LINES;
-	const maxBytes = input.maxBytes ?? DEFAULT_MAX_BYTES;
 	const header = `=== ${input.displayPath} — ${input.lines.length} lines ===`;
-	const rows: OutlineRow[] = [];
-	const output: string[] = [header];
-	let bytes = Buffer.byteLength(header, "utf-8") + 1;
-	let truncated = false;
+	const budget = startBudget(header, Number.POSITIVE_INFINITY, input.maxBytes ?? DEFAULT_MAX_BYTES);
 	if (input.lines.length === 0) {
 		const anchor = input.hashes[0];
 		if (anchor !== undefined) {
-			output.push(`${anchor}│`, "[File is empty. Use replace to insert content.]");
-			rows.push({ line: 1, anchor, text: "" });
+			const marker = `${anchor}${HASH_SEP}`;
+			const note = "[File is empty. Use replace to insert content.]";
+			if (pushLine(budget, marker)) {
+				budget.rows.push({ line: 1, anchor, text: "" });
+				budget.servedHashes.push(anchor);
+				if (!pushLine(budget, note)) markTruncated(budget, "bytes");
+			} else {
+				markTruncated(budget, "bytes");
+			}
 		}
-		return { text: output.join("\n"), rows, servedHashes: servedHashesOf(rows), truncated: false };
+		return {
+			text: budget.output.join("\n"),
+			rows: budget.rows,
+			servedHashes: budget.servedHashes,
+			truncated: budget.truncated,
+			complete: isComplete(budget),
+		};
 	}
 
-	const addRow = (index: number): boolean => {
-		const line = input.lines[index];
-		const anchor = input.hashes[index];
-		if (line === undefined || anchor === undefined) return true;
-		const text = clipLine(line, PREVIEW_LINE_CHARS);
-		const rendered = `${anchor}│${text}`;
-		const size = Buffer.byteLength(rendered, "utf-8") + 1;
-		if (bytes + size > maxBytes) {
-			truncated = true;
-			return false;
-		}
-		bytes += size;
-		output.push(rendered);
-		rows.push({ line: index + 1, anchor, text });
-		return true;
-	};
+	const head = Math.min(input.headLines ?? PREVIEW_HEAD_LINES, input.lines.length);
+	const tail = Math.min(input.tailLines ?? PREVIEW_TAIL_LINES, input.lines.length - head);
+	const attempt = (index: number): EmitOutcome => emitRow(budget, input.hashes, input.lines, index + 1, clipLine(input.lines[index] ?? "", PREVIEW_LINE_CHARS));
 
-	const head = Math.min(headCount, input.lines.length);
-	const tail = Math.min(tailCount, input.lines.length - head);
 	for (let index = 0; index < head; index += 1) {
-		if (!addRow(index)) break;
+		if (attempt(index) === "stopped") break;
 	}
-	if (!truncated && head + tail < input.lines.length) {
-		output.push(`... (${input.lines.length - head - tail} more lines)`);
+	let middleIndex: number | undefined;
+	if (!budget.truncated && head + tail < input.lines.length) {
+		if (pushLine(budget, formatMoreLines(input.lines.length - head - tail))) middleIndex = budget.output.length - 1;
+		else markTruncated(budget, "bytes");
 	}
-	if (!truncated) {
+	if (!budget.truncated) {
 		for (let index = input.lines.length - tail; index < input.lines.length; index += 1) {
-			if (!addRow(index)) break;
+			if (attempt(index) === "stopped") break;
 		}
 	}
-	if (truncated) {
-		output.push(`... (${input.lines.length - rows.length} more lines)`);
+	if (budget.truncated) {
+		const remaining = input.lines.length - budget.rows.length;
+		if (middleIndex !== undefined) budget.output.splice(middleIndex, 1);
+		if (remaining > 0) budget.output.push(formatMoreLines(remaining));
 	}
-	return { text: output.join("\n"), rows, servedHashes: servedHashesOf(rows), truncated };
+	return {
+		text: budget.output.join("\n"),
+		rows: budget.rows,
+		servedHashes: budget.servedHashes,
+		truncated: budget.truncated,
+		complete: head + tail >= input.lines.length && isComplete(budget),
+	};
 }

package/src/outline/vendor/README.md

@@ -9,6 +9,10 @@ These files are copied from [pi-codebase-reader](https://github.com/HanzCEO/pi-c
 - `parsers/manager.ts` extracts anonymous default exports (`export default function`/`class`), function expressions, top-level variable declarators, and nested `describe`/`test`/`it` calls, so entry-point, config, data, and test files outline instead of falling back to a preview.
 - `parsers/manager.ts` adds PHP support: `parsers/php.ts` outlines classes, interfaces, traits, enums, methods, properties, constants, top-level functions, and assigned closures.
 - `parsers/manager.ts` adds Blade support: `parsers/blade.ts` outlines `@section`/`@push`/`@once`/`@php` blocks, named directives such as `@extends` and `@include`, and `<x-…>`/`<livewire:…>` components.
+- `parsers/java.ts` reads the field-based tree-sitter-java grammar shipped in `wasm/` (method, constructor, field, constant, enum, record, and annotation-element nodes), so annotated members keep their names; every member anchors on its declaration line rather than on its annotation.
+- `parsers/php.ts` anchors a declaration on its first line after its attributes, so a member with `#[Test]` starts on the declaration instead of the attribute.
+- `types.ts` and every parser drop the upstream `detail` string: outlines render the first line of each symbol's declaration, so the parameters, inheritance, and qualifier text was computed and discarded.
+- `types.ts` keeps `SymbolInfo.name` and `SymbolInfo.type`: the extractors use them while building symbol trees and the upstream contract carries them, even though outlines render a real file line for each symbol.
 
 The `wasm/` grammars come from the MIT-licensed `tree-sitter-javascript`, `tree-sitter-typescript`, `tree-sitter-python`, `tree-sitter-go`, `tree-sitter-rust`, `tree-sitter-solidity`, and `tree-sitter-java` packages, plus pi-codebase-reader's vendored Sass and SCSS grammars, the VS Code WebAssembly build of `tree-sitter-php`, and `tree-sitter-blade` built from v0.12.3; see `wasm/LICENSES.md` for the per-grammar copyright notices. Comments in these files are upstream prose and are exempt from this repository's no-comments rule.
 

package/src/outline/vendor/parsers/blade.ts

@@ -76,7 +76,7 @@ function directiveSymbol(node: Node, parameter: Node | null, source: string): Sy
   const raw = textOf(parameter, source);
   const quoted = unquote(raw);
   return quoted === undefined
-    ? { name: "", type: label, startLine, endLine, detail: raw.trim() }
+    ? { name: "", type: label, startLine, endLine }
     : { name: quoted, type: label, startLine, endLine };
 }