pi-hashline-edit-pro 4.4.4 → 4.5.1

package/src/paths.ts

@@ -1,5 +1,5 @@
 import { homedir } from "node:os";
-import { isAbsolute, relative, resolve as resolvePath, join, dirname } from "node:path";
+import { isAbsolute, relative, resolve as resolvePath, join, dirname, parse } from "node:path";
 
 
 function homeBase(): string {
@@ -55,6 +55,22 @@ export function toCwd(filePath: string, cwd: string): string {
   return isAbsolute(expanded) ? expanded : resolvePath(cwd, expanded);
 }
 
+function pathDepth(path: string): number {
+  const root = parse(path).root;
+  return path.slice(root.length).split(/[\\/]+/).filter((part) => part.length > 0).length;
+}
+
+function climbsToRoot(cwd: string, relativePath: string): boolean {
+  let climbs = 0;
+  for (const part of relativePath.split("/")) {
+    if (part !== "..") break;
+    climbs += 1;
+  }
+  return climbs > 0 && climbs >= pathDepth(resolvePath(cwd));
+}
+
 export function toDisplayPath(cwd: string, absolutePath: string, fallback?: string): string {
-  return relative(cwd, absolutePath).replace(/\\/g, "/") || (fallback ?? absolutePath);
+  const rel = relative(cwd, absolutePath).replace(/\\/g, "/");
+  if (rel.length === 0 || climbsToRoot(cwd, rel)) return fallback ?? absolutePath;
+  return rel;
 }

package/src/payload-contract.ts

@@ -4,7 +4,7 @@ import { isRec, normalizeRequest, rejectUnknownFields, assertNoNul } from "./uti
 const replacementLinesSchema = Type.Array(
   Type.String({
     description:
-      "One replacement line; never embed \\n inside an element.",
+      "One replacement line. A real line break (\\n, \\r\\n, or \\r) splits it into lines and sets their endings.",
   }),
   {
     description:
@@ -131,3 +131,31 @@ export function assertInsertReq(request: unknown): asserts request is InsertReq
   }
   assertNoNul(request.lines);
 }
+
+const TRANSFER_KEYS = new Set(["path", "source_from", "source_to", "insert_after"]);
+
+export interface TransferReq {
+  path?: string;
+  source_from: string;
+  source_to: string;
+  insert_after: string;
+}
+
+export function assertTransferReq(request: unknown): asserts request is TransferReq {
+  if (!isRec(request)) {
+    throw new Error("[E_BAD_SHAPE] Copy/move request must be an object.");
+  }
+  rejectUnknownFields(request, TRANSFER_KEYS, "Copy/move request");
+  if (request.path !== undefined && typeof request.path !== "string") {
+    throw new Error('[E_BAD_SHAPE] Copy/move request field "path" must be a string when provided.');
+  }
+  if (typeof request.source_from !== "string" || request.source_from.length === 0) {
+    throw new Error('[E_BAD_SHAPE] Copy/move request requires a "source_from" string (4-char anchor from read output).');
+  }
+  if (typeof request.source_to !== "string" || request.source_to.length === 0) {
+    throw new Error('[E_BAD_SHAPE] Copy/move request requires a "source_to" string (4-char anchor from read output).');
+  }
+  if (typeof request.insert_after !== "string" || request.insert_after.length === 0) {
+    throw new Error('[E_BAD_SHAPE] Copy/move request requires an "insert_after" string (4-char anchor from read output).');
+  }
+}

package/src/replace-render.ts

@@ -81,7 +81,7 @@ export function highlightBatchRefs(text: string, theme: FgT): string {
 }
 
 export function fmtCall(
-  args: { path?: string; remove_from?: string; remove_to?: string; anchor?: string } | undefined,
+  args: { path?: string; remove_from?: string; remove_to?: string; anchor?: string; source_from?: string; source_to?: string; insert_after?: string } | undefined,
   state: RRState,
   expanded: boolean,
   theme: CallT,
@@ -89,7 +89,7 @@ export function fmtCall(
 ): string {
   const previewPath = state.preview && "path" in state.preview ? state.preview.path : undefined;
   const path = args?.path ?? state.resolvedPath ?? previewPath;
-  const anchorFallback = typeof args?.remove_from === "string" && typeof args?.remove_to === "string" ? `${args.remove_from}→${args.remove_to}` : typeof args?.anchor === "string" ? args.anchor : undefined;
+  const anchorFallback = typeof args?.remove_from === "string" && typeof args?.remove_to === "string" ? `${args.remove_from}→${args.remove_to}` : typeof args?.anchor === "string" ? args.anchor : typeof args?.source_from === "string" && typeof args?.insert_after === "string" ? `${args.source_from}→${args.insert_after}` : undefined;
   const pathDisplay =
     typeof path === "string" && path.length > 0
       ? theme.fg("accent", path)
@@ -126,7 +126,13 @@ export function getResultText(result: {
 export function extractWarnings(
 	text: string | undefined,
 ): string | undefined {
-	return text?.match(/(?:^|\n)Warnings:\n[\s\S]*$/)?.[0]?.trimStart();
+	return text?.match(/(?:^|\n)Warnings:\n[\s\S]*?(?=\n\nHints:\n|$)/)?.[0]?.trimStart();
+}
+
+export function extractHints(
+	text: string | undefined,
+): string | undefined {
+	return text?.match(/(?:^|\n)Hints:\n[\s\S]*$/)?.[0]?.trimStart();
 }
 
 export function isApplied(
@@ -153,8 +159,8 @@ export function expandHint(): string {
 function extractSummary(text: string | undefined): string | undefined {
 	if (!text) return undefined;
 	if (text.includes("│")) return undefined;
-	const warningsIdx = text.indexOf("\n\nWarnings:");
-	const summary = warningsIdx >= 0 ? text.slice(0, warningsIdx) : text;
+	const noticesIdx = text.search(/\n\n(?:Warnings|Hints):\n/);
+	const summary = noticesIdx >= 0 ? text.slice(0, noticesIdx) : text;
 	return summary.length > 0 ? summary : undefined;
 }
 
@@ -190,6 +196,8 @@ export function buildAppliedText(
 	}
 	const warnings = details?.warnings?.length ? `Warnings:\n${details.warnings.join("\n")}` : extractWarnings(text);
 	if (warnings) sections.push(warnings);
+	const hints = details?.hints?.length ? `Hints:\n${details.hints.join("\n")}` : extractHints(text);
+	if (hints) sections.push(hints);
 	return sections.length > 0 ? sections.join("\n\n") : undefined;
 }
 
@@ -264,9 +272,9 @@ export function reuseMarkdown(context: any, content: string, theme: any): Markdo
 export function makeRenderCall(
 	preview: (args: unknown, cwd: string, signal?: AbortSignal) => Promise<RPreview>,
   options: {
-    getInput?: (args: unknown) => { path?: string; remove_from?: string; remove_to?: string; anchor?: string } | null;
+    getInput?: (args: unknown) => { path?: string; remove_from?: string; remove_to?: string; anchor?: string; source_from?: string; source_to?: string; insert_after?: string } | null;
     toolName?: string;
-    resolveTarget?: (input: { remove_from?: string; remove_to?: string; anchor?: string }) => string | undefined;
+    resolveTarget?: (input: { remove_from?: string; remove_to?: string; anchor?: string; source_from?: string; source_to?: string; insert_after?: string }) => string | undefined;
   } = {},
 ) {
 	const getInput = options.getInput ?? getPreviewInput;

package/src/replace-response.ts

@@ -85,6 +85,17 @@ function warnBlock(warnings: string[] | undefined): string {
 	return warnings?.length ? `\n\nWarnings:\n${warnings.join("\n")}` : "";
 }
 
+function hintBlock(hints: string[] | undefined): string {
+	return hints?.length ? `\n\nHints:\n${hints.join("\n")}` : "";
+}
+
+function splitNotices(notices: string[] | undefined): { warnings: string[]; hints: string[] } {
+	const warnings: string[] = [];
+	const hints: string[] = [];
+	for (const notice of notices ?? []) (notice.startsWith("[H_") ? hints : warnings).push(notice);
+	return { warnings, hints };
+}
+
 export function buildNoop(input: NoopInput, noopNoun = "Replacement"): TResult {
 	const {
 		path,
@@ -97,13 +108,14 @@ export function buildNoop(input: NoopInput, noopNoun = "Replacement"): TResult {
 	const noopDetailsText = noopEdit
 		? `${noopNoun} for ${noopEdit.loc} is identical to current content:\n  ${noopEdit.loc}: ${clipLine(noopEdit.currentContent)}`
 		: "The edit produced identical content.";
-	const text = `No changes made to ${path}\nClassification: noop\n${noopDetailsText}${warnBlock(warnings)}`;
+	const { warnings: noticeWarnings, hints } = splitNotices(warnings);
+	const text = `No changes made to ${path}\nClassification: noop\n${noopDetailsText}${warnBlock(noticeWarnings)}${hintBlock(hints)}`;
 
 	const metrics = buildMetrics({
 		classification: "noop",
 		editsAttempted: editMeta.editsAttempted,
 		noopEditsCount: editMeta.noopEditsCount,
-		warningsCount: warnings?.length ?? 0,
+		warningsCount: noticeWarnings.length,
 	});
 
 	return {
@@ -115,7 +127,8 @@ export function buildNoop(input: NoopInput, noopNoun = "Replacement"): TResult {
 			snapshotId,
 			classification: "noop" as const,
       metrics,
-      ...(warnings?.length ? { warnings: [...warnings] } : {}),
+      ...(noticeWarnings.length ? { warnings: [...noticeWarnings] } : {}),
+      ...(hints.length ? { hints: [...hints] } : {}),
 		},
 	};
 }
@@ -126,22 +139,23 @@ export function buildChanged(input: SuccessInput, verb = "replaced", diffContext
   const diffResult = genDiff(originalNormalized, result, diffContextLines, resultHashes, originalHashes, undefined, spans);
   const addedLines = editMeta.addedLines;
   const removedLines = editMeta.removedLines;
-  const warningsBlock = warnBlock(warnings);
+  const { warnings: noticeWarnings, hints } = splitNotices(warnings);
+  const noticesBlock = `${warnBlock(noticeWarnings)}${hintBlock(hints)}`;
   const successPrefix = `Successfully ${verb} in ${path}.`;
   const lineSummary = addedLines > 0 || removedLines > 0
     ? ` Added ${addedLines} line(s), removed ${removedLines} line(s).`
     : "";
   const text = resultLines.length === 0
     ? "File is empty. Use replace to insert content."
-    : warningsBlock
-      ? `${successPrefix}${lineSummary}${warningsBlock}`
+    : noticesBlock
+      ? `${successPrefix}${lineSummary}${noticesBlock}`
       : `${successPrefix}${lineSummary}`;
 
   const metrics = buildMetrics({
     classification: "applied",
     editsAttempted: editMeta.editsAttempted,
     noopEditsCount: editMeta.noopEditsCount,
-    warningsCount: warnings?.length ?? 0,
+    warningsCount: noticeWarnings.length,
     firstChangedLine: editMeta.firstChangedLine,
     lastChangedLine: editMeta.lastChangedLine,
     addedLines,
@@ -160,7 +174,8 @@ export function buildChanged(input: SuccessInput, verb = "replaced", diffContext
       snapshotId,
       metrics,
       diffLineNumbers: diffResult.lineNumbers.map((line) => line ?? null),
-      ...(warnings?.length ? { warnings: [...warnings] } : {}),
+      ...(noticeWarnings.length ? { warnings: [...noticeWarnings] } : {}),
+      ...(hints.length ? { hints: [...hints] } : {}),
     },
   };
 }

package/src/replace-undo.ts

@@ -9,6 +9,7 @@ import { lineChecksum } from "./hashline";
 import { freeAnchors, adoptAnchors, withAnchorSession, formatAnchorReclaimNotice, takeReclaimedPaths } from "./anchor-registry";
 import { resolveInCwd, writeAtomic, type FileIdentity } from "./fs-write";
 import { toLF, stripBOM, restoreEndings, type LineEnding } from "./normalize";
+import { joinSeparators } from "./line-endings";
 import { genDiff, genPatch, spansFromHashes } from "./replace-diff";
 import { getDiffContextLines } from "./config";
 import { cntDiff, errCode, makePrepareArguments, splitLines } from "./utils";
@@ -22,8 +23,10 @@ export interface UndoEntry {
   content: string;
   bom: string;
   originalEnding: LineEnding;
+  separators?: LineEnding[];
   hashes: string[];
   resultContent: string;
+  resultSeparators?: LineEnding[];
   mode?: number;
 }
 
@@ -44,8 +47,10 @@ export async function saveUndo(
       content: entry.content,
       bom: entry.bom,
       ending: entry.originalEnding,
+      ...(entry.separators !== undefined ? { separators: entry.separators } : {}),
       hashes: entry.hashes,
       resultContent: entry.resultContent,
+      ...(entry.resultSeparators !== undefined ? { resultSeparators: entry.resultSeparators } : {}),
       ...(mode !== undefined ? { mode } : {}),
     });
   } catch (error) {
@@ -80,8 +85,10 @@ export async function getUndo(path: string): Promise<UndoEntry | undefined> {
       content: record.content,
       bom: record.bom,
       originalEnding,
+      ...(record.separators !== undefined ? { separators: record.separators as LineEnding[] } : {}),
       hashes: record.hashes,
       resultContent: record.resultContent,
+      ...(record.resultSeparators !== undefined ? { resultSeparators: record.resultSeparators as LineEnding[] } : {}),
       ...(record.mode !== undefined ? { mode: record.mode } : {}),
     };
   } catch (error) {
@@ -171,7 +178,7 @@ export function regUndo(pi: ExtensionAPI, flags: EditToolFlags = DEFAULT_EDIT_FL
 
           if (
             currentRaw !== undefined &&
-            currentRaw !== undo.bom + restoreEndings(undo.resultContent, undo.originalEnding)
+            currentRaw !== undo.bom + (undo.resultSeparators !== undefined ? joinSeparators(undo.resultContent, undo.resultSeparators) : restoreEndings(undo.resultContent, undo.originalEnding))
           ) {
             return {
               content: [
@@ -187,7 +194,7 @@ export function regUndo(pi: ExtensionAPI, flags: EditToolFlags = DEFAULT_EDIT_FL
 
           await writeAtomic(
             mutationTargetPath,
-            undo.bom + restoreEndings(undo.content, undo.originalEnding),
+            undo.bom + (undo.separators !== undefined ? joinSeparators(undo.content, undo.separators) : restoreEndings(undo.content, undo.originalEnding)),
             currentIdentity,
             undo.mode ?? fallbackFileMode(),
           );

package/src/replace.ts

@@ -10,7 +10,7 @@ import {
 } from "./replace-diff";
 import { readNormFile, type NormFile } from "./file-reader";
 import { editToolSchema, buildEditToolSchema, type ReqParams, assertReq, normReq } from "./payload-contract";
-import { splitLines } from "./utils";
+import { literalEscapeHint, splitLines } from "./utils";
 import { loadP, loadGuide } from "./prompts";
 import { type FileIdentity } from "./fs-write";
 import { applyEdit,
@@ -21,6 +21,7 @@ import { applyEdit,
   AnchorMismatchError,
   type HEdit,
   type NEdit,
+  type StripWarningLocation,
 } from "./hashline";
 import { type RMetrics } from "./replace-response";
 import {
@@ -47,6 +48,7 @@ export type ReplaceDetails = {
   metrics?: RMetrics;
   diffLineNumbers?: (number | null)[];
   warnings?: string[];
+  hints?: string[];
   batch?: { id: number; size: number; last: boolean; total: number; aborted?: boolean; abortMessage?: string };
 };
 
@@ -56,6 +58,7 @@ export interface PipelineResult {
   result: string;
   bom: string;
   originalEnding: LineEnding;
+  originalSeparators: LineEnding[];
   hadUtf8DecodeErrors: boolean;
   warnings: string[];
   noopEdit?: NEdit;
@@ -67,6 +70,7 @@ export interface PipelineResult {
   totalRemovedLines: number;
   identity: FileIdentity;
   spans?: DiffSpan[];
+  contentSeparators?: (LineEnding | undefined)[];
 }
 
 
@@ -76,6 +80,9 @@ export interface ExecPipelineOptions {
   store?: HashStore;
   noPersist?: boolean;
   preloadedNorm?: NormFile;
+  served?: ReadonlyMap<string, string>;
+  allowEmpty?: boolean;
+  stripWarning?: StripWarningLocation;
 }
 
 export function hashSpan(hashes: string[], from: string, to: string): [number, number] | undefined {
@@ -91,7 +98,7 @@ export function spanForEdit(originalHashes: string[], from: string, to: string,
   const replacementCount = splitLines(resultContent).length - (originalHashes.length - (span[1] - span[0] + 1));
   return { start: span[0], end: span[1], replacementCount };
 }
-async function noteAnchorError(absolutePath: string, error: unknown, noPersist?: boolean): Promise<void> {
+export async function noteAnchorError(absolutePath: string, error: unknown, noPersist?: boolean): Promise<void> {
   if (noPersist === true) return;
   if (error instanceof RangeStaleError) {
     adoptAnchors(absolutePath, error.rangeServedMap);
@@ -137,8 +144,8 @@ export async function execPipeline(
   const { edit, warnings: editWarnings } = buildReplaceHEdit(params);
   const hashStore = options?.store ?? await loadHashStore();
   const preResolvedPath = await resolveTarget(toCwd(targetPath, cwd));
-  const served = servedForPath(preResolvedPath);
-  const { normalized: originalNormalized, bom, originalEnding, fileHashes: originalHashes, hadUtf8DecodeErrors, absolutePath, identity } = await readNormFile(
+  const served = options?.served ?? servedForPath(preResolvedPath);
+  const { normalized: originalNormalized, bom, originalEnding, endingSeparators: originalSeparators, fileHashes: originalHashes, hadUtf8DecodeErrors, absolutePath, identity } = await readNormFile(
     targetPath, cwd, { signal: options?.signal, accessMode: options?.accessMode, maxLines: MAX_HASH_LINES, store: hashStore, noPersist: options?.noPersist, allocation: options?.noPersist ? "shadow" : "real", preloadedNorm: options?.preloadedNorm },
   );
   const displayPath = toDisplayPath(cwd, absolutePath, targetPath);
@@ -152,6 +159,8 @@ export async function execPipeline(
       originalHashes,
       displayPath,
       served,
+      options?.allowEmpty,
+      options?.stripWarning,
     );
   } catch (error) {
     await noteAnchorError(absolutePath, error, options?.noPersist);
@@ -181,6 +190,7 @@ export async function execPipeline(
     result,
     bom,
     originalEnding,
+    originalSeparators,
     hadUtf8DecodeErrors,
     warnings,
     noopEdit: anchorResult.noopEdit,
@@ -192,6 +202,7 @@ export async function execPipeline(
     totalRemovedLines,
     identity,
     ...(pipeSpans ? { spans: pipeSpans } : {}),
+    ...(edit.content_separators !== undefined ? { contentSeparators: edit.content_separators } : {}),
   };
 }
 
@@ -263,6 +274,7 @@ export function buildToolDef(flags: EditToolFlags = DEFAULT_EDIT_FLAGS): ToolDef
         const canonical = normReq(params);
         assertReq(canonical);
         const normalizedParams = canonical;
+        const literalEscape = literalEscapeHint(normalizedParams.replacement_lines, "replacement_lines");
         const targetPath = await resolveEditTargetWithRequirement({
           removeFrom: normalizedParams.remove_from,
           removeTo: normalizedParams.remove_to,
@@ -287,6 +299,7 @@ export function buildToolDef(flags: EditToolFlags = DEFAULT_EDIT_FLAGS): ToolDef
               absolutePath,
               mutationTargetPath,
               editAnchors: [normalizedParams.remove_from, normalizedParams.remove_to],
+              prefixWarnings: literalEscape !== undefined ? [literalEscape] : [],
               signal,
             });
           }
@@ -305,7 +318,7 @@ export function buildToolDef(flags: EditToolFlags = DEFAULT_EDIT_FLAGS): ToolDef
             cwd: ctx.cwd,
             signal,
             hedit: built.edit,
-            extraWarnings: built.warnings,
+            extraWarnings: [...(literalEscape !== undefined ? [literalEscape] : []), ...built.warnings],
           });
         });
       });

package/src/utils.ts

@@ -342,10 +342,6 @@ export function decodeStringArray(value: unknown, warnings?: string[], label = "
 	return undefined;
 }
 
-function splitEditLines(text: string): string[] {
-	return text.replace(/\r\n/g, "\n").replace(/\r/g, "\n").split("\n");
-}
-
 function normalizeLineFieldValue(value: unknown): string[] | undefined {
 	const candidate = typeof value === "string"
 		? value
@@ -356,7 +352,7 @@ function normalizeLineFieldValue(value: unknown): string[] | undefined {
 	const decoded = decodeStringArray(candidate);
 	if (decoded !== undefined) return decoded;
 	if (/^\[\s*\]$/.test(stripTrailingMemberCall(stripCodeFence(candidate)))) return [];
-	return splitEditLines(candidate);
+	return [candidate];
 }
 
 function normalizeEditLines(record: Record<string, unknown>): void {
@@ -366,3 +362,42 @@ function normalizeEditLines(record: Record<string, unknown>): void {
 		if (lines !== undefined) record[key] = lines;
 	}
 }
+
+const LITERAL_ESCAPE_RE = /\\(?:u([0-9a-fA-F]{4})|([ntr"]))/g;
+
+const REAL_LINE_BREAK_RE = /[\n\r]/;
+
+function isSurrogateEscapePair(line: string, index: number, hex: string): boolean {
+	const code = Number.parseInt(hex, 16);
+	if (code >= 0xd800 && code <= 0xdbff) {
+		const next = /^\\u([0-9a-fA-F]{4})/.exec(line.slice(index + 6))?.[1];
+		if (next === undefined) return false;
+		const nextCode = Number.parseInt(next, 16);
+		return nextCode >= 0xdc00 && nextCode <= 0xdfff;
+	}
+	if (code >= 0xdc00 && code <= 0xdfff) {
+		const previous = /\\u([0-9a-fA-F]{4})$/.exec(line.slice(0, index))?.[1];
+		if (previous === undefined) return false;
+		const previousCode = Number.parseInt(previous, 16);
+		return previousCode >= 0xd800 && previousCode <= 0xdbff;
+	}
+	return false;
+}
+
+export function literalEscapeHint(lines: string[], label: string): string | undefined {
+	for (const line of lines) {
+		if (!line.includes("\\")) continue;
+		const hasRealBreak = REAL_LINE_BREAK_RE.test(line);
+		for (const match of line.matchAll(LITERAL_ESCAPE_RE)) {
+			const hex = match[1];
+			const simple = match[2];
+			if (simple !== undefined && hasRealBreak) continue;
+			if (hex !== undefined) {
+				if (hex.toLowerCase() === "dddd") continue;
+				if (isSurrogateEscapePair(line, match.index, hex)) continue;
+			}
+			return `[H_LITERAL_ESCAPE] "${label}" contains the literal escaped text "${match[0]}"`;
+		}
+	}
+	return undefined;
+}