pi-hashline-edit-pro 4.4.2 → 4.4.3

package/README.md

@@ -230,7 +230,7 @@ Codes starting with `E_` are errors: nothing was written — except `File was wr
 
 | Code | Meaning |
 | --- | --- |
-| `[E_BAD_SHAPE]` | Request envelope or edit item has unknown, missing, or wrongly-typed fields (for example `replacement_lines` must be an array of strings, one element per line), or content contains a NUL byte (`U+0000`), which would make the file binary. |
+| `[E_BAD_SHAPE]` | Request envelope or edit item has unknown, missing, or wrongly-typed fields (for example `replacement_lines` must be an array of strings, one element per line), content contains a NUL byte (`U+0000`), which would make the file binary, or a grep `glob` has invalid bracket or brace syntax. |
 | `[W_BAD_SHAPE]` | Auto-corrected request slip reported as a warning (for example stringified array text that could not be parsed and was kept as one literal line). |
 | `[E_BAD_REF]` | An anchor in `remove_from`/`remove_to` is not a bare 4-character anchor (the anchor table is letters only). |
 | `[W_BAD_REF]` | A pasted `anchor│` or diff-preview marker was stripped from an anchor field with a warning. |
@@ -252,6 +252,8 @@ Codes starting with `E_` are errors: nothing was written — except `File was wr
 | `[E_BATCH_OVERLAP]` | Batched `replace`/`insert` calls target overlapping ranges; the whole batch was refused. One `before` plus one `after` insert on the same anchor line is not an overlap. Retry with disjoint ranges. |
 | `[E_OP_ABORTED]` | An edit aborted (a same-message batch member failed, or the file changed or was deleted after the edit started). Nothing was written. Fix the sibling failure and retry the batch, otherwise call `read` for fresh anchors and retry. The abort names the failing call and its error code when one is known. |
 | `[E_UNSAFE_REGEX]` | A grep regex can trigger excessive backtracking; simplify it or search with `literal: true`. |
+| `[E_GREP_FAILED]` | `anchor_grep` could not start ripgrep or ripgrep exited with an error (for example a pattern valid in JavaScript but unsupported by ripgrep's regex engine); the message carries ripgrep's output. Retry with `literal: true` or simplify the pattern. |
+| `[E_GREP_TIMEOUT]` | `anchor_grep` timed out after 10 seconds; narrow `path` or simplify `pattern` and retry. |
 | `[E_AUTO_READ_ALL]` | File already attached and unchanged since this session's start; the attached content is still exact. |
 
 ## Troubleshooting
@@ -263,6 +265,7 @@ Codes starting with `E_` are errors: nothing was written — except `File was wr
 - Reset the anchor state. Anchors live in `~/.config/pi-hashline-edit-pro/hash-store.sqlite` (with `-wal`/`-shm` sidecars) and in per-session ownership logs under `~/.config/pi-hashline-edit-pro/sessions/`. Quit pi, delete those files, and everything is rebuilt on the next session. Anchor history is lost, but no project files are touched.
 - Corrupt store. If the store fails its health check it is renamed to `hash-store.sqlite.corrupt-<timestamp>` and rebuilt automatically.
 - Config directory moved. If `XDG_CONFIG_HOME` is set on a non-Windows platform, the config directory (and the anchor state inside it) lives at `$XDG_CONFIG_HOME/pi-hashline-edit-pro` instead of `~/.config/pi-hashline-edit-pro`. An existing store is not migrated automatically. To keep anchor and undo history, move the old `hash-store.sqlite` files (plus `-wal`/`-shm` sidecars) into the new directory before the first run.
+- Windows drives in WSL. Editing a file under a Windows mount (`/mnt/c`, drvfs/9p) can fail with `EPERM` from `fchmod` because those filesystems do not store POSIX modes. Mode preservation is best-effort there, so `replace`, `insert`, and `undo_last_change` still write the edit.
 
 ## Development
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-hashline-edit-pro",
-  "version": "4.4.2",
+  "version": "4.4.3",
   "type": "module",
   "description": "Hash-anchored read/replace/insert/grep tools for pi-coding-agent. Every line gets a unique 4-char tokenizer-friendly anchor that stays stable across edits; stale or ambiguous anchors are rejected, never fuzzy-matched. Undo persists across restarts.",
   "main": "index.ts",

package/src/fs-write.ts

@@ -13,7 +13,7 @@ import {
 } from "node:fs/promises";
 import { dirname, join, parse, resolve, sep } from "node:path";
 import { toCwd } from "./paths";
-import { errCode } from "./utils";
+import { errCode, isModeUnsupported } from "./utils";
 
 export interface FileIdentity {
   dev: number;
@@ -196,7 +196,11 @@ export async function writeAtomic(
     await tempHandle.writeFile(content, "utf-8");
     const mode = existingStats ? existingStats.mode & 0o7777 : restoreMode;
     if (mode !== undefined) {
-      await tempHandle.chmod(mode);
+      try {
+        await tempHandle.chmod(mode);
+      } catch (error) {
+        if (!isModeUnsupported(error)) throw error;
+      }
     }
     await tempHandle.sync();
   } catch (error: unknown) {

package/src/grep.ts

@@ -13,11 +13,13 @@ import { ANCHOR_POOL_EXHAUSTED_PREFIX, MAX_GREP_LINE_BYTES } from "./constants";
 import { toCwd, toDisplayPath } from "./paths";
 import { loadP, loadGuide } from "./prompts";
 import { normReq } from "./payload-contract";
-import { abortIf, errCode, gutterWidth, isRec, makePrepareArguments, rejectUnknownFields, truncateToBytes, visLines } from "./utils";
+import { abortIf, clipLine, errCode, gutterWidth, isRec, makePrepareArguments, rejectUnknownFields, truncateToBytes, visLines } from "./utils";
 import { withAnchorSession } from "./anchor-registry";
 import { serveRows } from "./served";
 import { Text } from "@earendil-works/pi-tui";
 import { expandHint, getResultText, reuseText, type CallT, type FgT } from "./replace-render";
+export const RG_TIMEOUT_MS = 10_000;
+
 const GREP_KS = new Set(["pattern", "path", "glob", "context", "ignoreCase", "literal", "limit"]);
 
 function cmp(a: string, b: string): number {
@@ -54,6 +56,14 @@ export function assertGrepReq(request: unknown): asserts request is GrepReq {
   }
 }
 
+function compileGrepGlob(glob: string): RegExp {
+  try {
+    return globToRegex(glob);
+  } catch {
+    throw new Error(`[E_BAD_SHAPE] Invalid glob pattern: ${glob}. Fix the bracket or brace syntax, or search without glob.`);
+  }
+}
+
 function buildRegex(pattern: string, literal: boolean, ignoreCase: boolean): RegExp {
   if (!literal) assertSafeRegex(pattern);
   const source = literal ? pattern.replace(/[.*+?^${}()|[\]\\]/g, "\\$&") : pattern;
@@ -314,8 +324,8 @@ async function collectRgMatches(
     const rgTimeout = setTimeout(() => {
       timedOut = true;
       if (!child.killed) child.kill("SIGKILL");
-      reject(new Error("rg timeout"));
-    }, 10000);
+      reject(new Error(`[E_GREP_TIMEOUT] ripgrep timed out after ${RG_TIMEOUT_MS}ms. Narrow the path or pattern and retry.`));
+    }, RG_TIMEOUT_MS);
     child.stderr?.on("data", (chunk) => {
       stderr += chunk.toString();
     });
@@ -355,7 +365,8 @@ async function collectRgMatches(
     child.on("error", (error) => {
       cleanup();
       if (rgPath === cachedRgPath) cachedRgPath = undefined;
-      reject(error);
+      const detail = error instanceof Error ? error.message : String(error);
+      reject(new Error(`[E_GREP_FAILED] ripgrep could not start: ${clipLine(detail)}`));
     });
     child.on("close", (code) => {
       cleanup();
@@ -365,8 +376,10 @@ async function collectRgMatches(
         return;
       }
       if (code !== 0 && code !== 1) {
-        const msg = stderr.trim() || `ripgrep exited with code ${code}`;
-        reject(new Error(msg));
+        const detail = clipLine(stderr.trim(), 300);
+        reject(new Error(detail
+          ? `[E_GREP_FAILED] ripgrep exited with code ${code}: ${detail}`
+          : `[E_GREP_FAILED] ripgrep exited with code ${code}.`));
         return;
       }
       resolve(result);
@@ -538,7 +551,7 @@ export function regGrep(pi: ExtensionAPI): void {
           throw new Error(`[E_ACCESS] Cannot access path: ${req.path ?? ctx.cwd}`);
         }
         const globRoot = baseStat.isFile() ? dirname(base) : base;
-        const globRegex = req.glob === undefined ? undefined : globToRegex(req.glob);
+        const globRegex = req.glob === undefined ? undefined : compileGrepGlob(req.glob);
         const matchesGlob = (absPath: string): boolean => {
           if (globRegex === undefined) return true;
           const displayPath = toDisplayPath(ctx.cwd, absPath);

package/src/hash-store.ts

@@ -2,7 +2,7 @@ import { randomUUID } from "node:crypto";
 import { existsSync } from "node:fs";
 import { chmod, readFile, rename, mkdir, stat } from "node:fs/promises";
 import { hashStorePath, hashStoreDir, legacyHashStorePath } from "./paths";
-import { errCode, isRec, splitLines } from "./utils";
+import { errCode, isModeUnsupported, isRec, splitLines } from "./utils";
 import { initHasher, contentChecksum, lineChecksum } from "./hashline/hasher";
 import { HASH_STORE_VERSION, HASH_STORE_BUSY_TIMEOUT } from "./constants";
 import {
@@ -278,7 +278,11 @@ async function openStore(storePath: string): Promise<HashStore> {
   await initHasher();
   await mkdir(hashStoreDir(), { recursive: true, mode: 0o700 });
   if (process.platform !== "win32") {
-    await chmod(hashStoreDir(), 0o700);
+    try {
+      await chmod(hashStoreDir(), 0o700);
+    } catch (error) {
+      if (errCode(error) !== "ENOENT" && !isModeUnsupported(error)) throw error;
+    }
   }
 
   let existed = existsSync(storePath);
@@ -319,7 +323,7 @@ async function openStore(storePath: string): Promise<HashStore> {
       try {
         await chmod(candidate, 0o600);
       } catch (error) {
-        if (errCode(error) !== "ENOENT") throw error;
+        if (errCode(error) !== "ENOENT" && !isModeUnsupported(error)) throw error;
       }
     }
   }

package/src/utils.ts

@@ -99,6 +99,11 @@ export function errCode(error: unknown): string | undefined {
 	return undefined;
 }
 
+export function isModeUnsupported(error: unknown): boolean {
+	const code = errCode(error);
+	return code === "EPERM" || code === "ENOTSUP" || code === "EOPNOTSUPP" || code === "EINVAL" || code === "ENOSYS";
+}
+
 export function truncateToBytes(s: string, maxBytes: number): string {
 	if (Buffer.byteLength(s, "utf-8") <= maxBytes) return s;
 	let out = "";