pi-hashline-edit-pro 0.16.4 → 0.16.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "pi-hashline-edit-pro",
-  "version": "0.16.4",
+  "version": "0.16.5",
   "description": "Strict hashline read/replace tool for pi-coding-agent with hash-anchored edits (3-char, 18-bit, perfect hashing)",
   "main": "index.ts",
   "repository": {

package/prompts/replace-bulk-guidelines.md

@@ -3,4 +3,5 @@
 - On `[E_STALE_ANCHOR]`, call `read` to get fresh anchors, copy the 3-character HASH of the start and end of the range you are replacing into `hash_range_inclusive`, and retry.
 - `hash_range_inclusive` replaces the ENTIRE range inclusively. Every line from the first anchor through the second anchor is deleted. Only put the replacement lines in `content_lines` — do not include lines that already exist outside the range.
 - **Preserve leading whitespace (indentation) exactly.** The content after `│` in read output includes all leading spaces and tabs — copy them into `content_lines` unchanged.
+- **`content_lines` must be a native JSON array of strings**, not a JSON string. Do NOT serialize it: `"content_lines": "[\"line1\", \"line2\"]"` is WRONG. Use `"content_lines": ["line1", "line2"]` instead.
 - If the response includes a "Boundary duplication" warning, the edge line of your `content_lines` matches a line outside the replaced range. Remove that line from `content_lines` — the original is still in the file outside the range.

package/prompts/replace-bulk.md

@@ -80,6 +80,18 @@ Right:
 ```json
 { "content_lines": [...], "hash_range_inclusive": ["F4T", "F4T"] }
 
+⚠️ Common mistake: do not serialize `content_lines` as a JSON string.
+
+Wrong:
+```json
+{ "changes": [{ "content_lines": "[\"line1\", \"line2\"]", "hash_range_inclusive": ["F4T", "F4T"] }], "path": "src/main.ts" }
+
+Right:
+```json
+{ "changes": [{ "content_lines": ["line1", "line2"], "hash_range_inclusive": ["F4T", "F4T"] }], "path": "src/main.ts" }
+
+`content_lines` must be a native JSON array of strings, not a string that looks like an array. Pass it as a proper JSON array value.
+
 Rules:
 - `hash_range_inclusive` is a pair `[start, end]`. A single-line replace is `hash_range_inclusive: ["X", "X"]`.
 - To delete a range, use `content_lines: []`.

package/prompts/replace-flat-guidelines.md

@@ -3,4 +3,5 @@
 - On `[E_STALE_ANCHOR]`, call `read` to get fresh anchors, copy the 3-character HASH of the start and end of the range you are replacing into `hash_range_inclusive`, and retry.
 - `hash_range_inclusive` replaces the ENTIRE range inclusively. Every line from the first anchor through the second anchor is deleted. Only put the replacement lines in `content_lines` — do not include lines that already exist outside the range.
 - **Preserve leading whitespace (indentation) exactly.** The content after `│` in read output includes all leading spaces and tabs — copy them into `content_lines` unchanged.
+- **`content_lines` must be a native JSON array of strings**, not a JSON string. Do NOT serialize it: `"content_lines": "[\"line1\", \"line2\"]"` is WRONG. Use `"content_lines": ["line1", "line2"]` instead.
 - If the response includes a "Boundary duplication" warning, the edge line of your `content_lines` matches a line outside the replaced range. Remove that line from `content_lines` — the original is still in the file outside the range.

package/prompts/replace-flat.md

@@ -65,6 +65,18 @@ Right:
 ```json
 { "content_lines": [...], "hash_range_inclusive": ["F4T", "F4T"] }
 
+⚠️ Common mistake: do not serialize `content_lines` as a JSON string.
+
+Wrong:
+```json
+{ "content_lines": "[\"line1\", \"line2\"]", "hash_range_inclusive": ["F4T", "F4T"], "path": "src/main.ts" }
+
+Right:
+```json
+{ "content_lines": ["line1", "line2"], "hash_range_inclusive": ["F4T", "F4T"], "path": "src/main.ts" }
+
+`content_lines` must be a native JSON array of strings, not a string that looks like an array. Pass it as a proper JSON array value.
+
 Rules:
 - `hash_range_inclusive` is a pair `[start, end]`. A single-line replace is `hash_range_inclusive: ["X", "X"]`.
 - To delete a range, use `content_lines: []`.

package/prompts/replace-guidelines.md

@@ -3,5 +3,6 @@
 - On `[E_STALE_ANCHOR]`, call `read` to get fresh anchors, copy the 3-character HASH of the start and end of the range you are replacing into `hash_range_inclusive`, and retry.
 - `hash_range_inclusive` replaces the ENTIRE range inclusively. Every line from the first anchor through the second anchor is deleted. Only put the replacement lines in `content_lines` — do not include lines that already exist outside the range.
 - **Preserve leading whitespace (indentation) exactly.** The content after `│` in read output includes all leading spaces and tabs — copy them into `content_lines` unchanged.
+- **`content_lines` must be a native JSON array of strings**, not a JSON string. Do NOT serialize it: `"content_lines": "[\"line1\", \"line2\"]"` is WRONG. Use `"content_lines": ["line1", "line2"]` instead.
 - Two modes are available: bulk (default, uses `changes` array) and flat (top-level `hash_range_inclusive`/`content_lines`). Toggle with `/toggle-replace-mode`.
 - If the response includes a "Boundary duplication" warning, the edge line of your `content_lines` matches a line outside the replaced range. Remove that line from `content_lines` — the original is still in the file outside the range.

package/prompts/replace.md

@@ -127,6 +127,18 @@ Right:
 ```json
 { "content_lines": [...], "hash_range_inclusive": ["F4T", "F4T"] }
 
+⚠️ Common mistake: do not serialize `content_lines` as a JSON string.
+
+Wrong:
+```json
+{ "content_lines": "[\"line1\", \"line2\"]", "hash_range_inclusive": ["F4T", "F4T"] }
+
+Right:
+```json
+{ "content_lines": ["line1", "line2"], "hash_range_inclusive": ["F4T", "F4T"] }
+
+`content_lines` must be a native JSON array of strings, not a string that looks like an array. Pass it as a proper JSON array value.
+
 Rules:
 - `hash_range_inclusive` is a pair `[start, end]`. A single-line replace is `hash_range_inclusive: ["X", "X"]`.
 - To delete a range, use `content_lines: []`.

package/src/hashline/parse.ts

@@ -56,13 +56,13 @@ function assertNoPrefixes(lines: string[]): void {
 }
 
 export function parseText(edit: string[] | string | null): string[] {
-	if (edit === null) return [];
-	const lines =
-		typeof edit === "string"
-			? (edit.endsWith("\n") ? edit.slice(0, -1) : edit)
-					.replaceAll("\r", "")
-					.split("\n")
-			: edit;
-	assertNoPrefixes(lines);
-	return lines;
+  if (edit === null) return [];
+  if (typeof edit === "string") {
+    throw new Error(
+      `[E_BAD_SHAPE] "content_lines" must be a native JSON array of strings, not a JSON string.`
+      + ` Do not serialize the array (e.g. '["line1", "line2"]') — pass it as a proper JSON array: ["line1", "line2"].`
+    );
+  }
+  assertNoPrefixes(edit);
+  return edit;
 }

package/src/hashline/resolve.ts

@@ -148,6 +148,13 @@ function assertItem(edit: Record<string, unknown>, index: number): void {
     throw new Error(`[E_BAD_SHAPE] Edit ${index} requires a "content_lines" field. Provide the replacement lines (use [] to delete).`);
   }
   if ("content_lines" in edit && !isStrArr(edit.content_lines)) {
+    const val = edit.content_lines;
+    if (typeof val === "string") {
+      throw new Error(
+        `[E_BAD_SHAPE] Edit ${index} field "content_lines" must be a native JSON array of strings, not a JSON string.`
+        + ` Do not serialize the array (e.g. '["line1", "line2"]') — pass it as a proper JSON array: ["line1", "line2"].`
+      );
+    }
     throw new Error(`[E_BAD_SHAPE] Edit ${index} field "content_lines" must be a string array.`);
   }
   if (!isStrPair(edit.hash_range_inclusive)) {

package/src/replace-normalize.ts

@@ -1,5 +1,17 @@
 import { isRec, has } from "./utils";
 
+function assertContentLinesNotString(
+  value: unknown,
+  label: string,
+): void {
+  if (typeof value === "string") {
+    throw new Error(
+      `[E_BAD_SHAPE] ${label}: "content_lines" must be a native JSON array of strings, not a JSON string.`
+      + ` Do not serialize the array (e.g. '["line1", "line2"]') — pass it as a proper JSON array: ["line1", "line2"].`
+    );
+  }
+}
+
 export function normalizeFilePath(record: Record<string, unknown>): void {
   if (typeof record.path !== "string" && typeof record.file_path === "string") {
     record.path = record.file_path;
@@ -31,9 +43,24 @@ export function normReq(input: unknown): unknown {
 
   normalizeFilePath(record);
 
+  // Early validation: reject string-typed content_lines at the top level
+  if (has(record, "content_lines") && typeof record.content_lines === "string") {
+    assertContentLinesNotString(record.content_lines, "Top-level");
+  }
+
   normalizeField(record, "changes", "changes");
   normalizeField(record, "edits", "changes");
 
+  // Validate items in the changes array before wrapping flat format
+  if (Array.isArray(record.changes)) {
+    for (let i = 0; i < record.changes.length; i++) {
+      const item = record.changes[i];
+      if (isRec(item) && has(item, "content_lines") && typeof item.content_lines === "string") {
+        assertContentLinesNotString(item.content_lines, `changes[${i}]`);
+      }
+    }
+  }
+
   if (!Array.isArray(record.changes) && has(record, "hash_range_inclusive") && has(record, "content_lines")) {
     const hri = record.hash_range_inclusive;
     const cl = record.content_lines;