pi-harness-runtime 1.1.49 → 1.1.71-3

package/packages/write-review/src/blackboard.ts

@@ -7,7 +7,12 @@
 
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from "fs";
 import { join } from "path";
-import type { WriteReviewStatus, ReviewPhase, Verdict } from "./types.js";
+import type {
+	WriteReviewStatus,
+	ReviewPhase,
+	Verdict,
+	PingPongDecisionSnapshot,
+} from "./types.js";
 
 const DEFAULT_DIR = ".write-review";
 const STATUS_FILE = "status.json";
@@ -72,6 +77,24 @@ export class WriteReviewBlackboard {
 		return this.status;
 	}
 
+	/**
+	 * Record the automatic decision that selected or skipped PING-PONG.
+	 * This is the durable middleware state shared by separate agent terminals.
+	 */
+	recordPingPongDecision(snapshot: PingPongDecisionSnapshot): void {
+		if (!this.status) this.init();
+		this.status!.mode = "ping_pong";
+		this.status!.pingPong = snapshot;
+		this.status!.writerMessage = snapshot.request;
+		if (snapshot.decision === "run_ping_pong") {
+			this.status!.phase = "writing";
+			this.status!.writerDone = false;
+		} else {
+			this.status!.phase = "idle";
+		}
+		this.save();
+	}
+
 	/**
 	 * Start a new write session
 	 */
@@ -221,9 +244,9 @@ export class WriteReviewBlackboard {
 				? "✅"
 				: verdict === "blocked"
 					? "⛔"
-				: verdict === "changes_requested"
-					? "🔄"
-					: "⏳";
+					: verdict === "changes_requested"
+						? "🔄"
+						: "⏳";
 
 		const lines: string[] = [
 			`## Write-Review Scoreboard`,
@@ -268,7 +291,17 @@ export class WriteReviewBlackboard {
 		while ((match = fencedRe.exec(code)) !== null) {
 			const path = match[1]!.trim();
 			// Skip if it looks like a filename with spaces (not a path)
-			if (path && !path.includes(" ") && (path.includes("/") || path.includes("\\") || path.endsWith(".ts") || path.endsWith(".js") || path.endsWith(".tsx") || path.endsWith(".json") || path.endsWith(".md"))) {
+			if (
+				path &&
+				!path.includes(" ") &&
+				(path.includes("/") ||
+					path.includes("\\") ||
+					path.endsWith(".ts") ||
+					path.endsWith(".js") ||
+					path.endsWith(".tsx") ||
+					path.endsWith(".json") ||
+					path.endsWith(".md"))
+			) {
 				files.add(path);
 			}
 		}

package/packages/write-review/src/types.ts

@@ -21,6 +21,17 @@ export type ReviewPhase =
  */
 export type Verdict = "approved" | "changes_requested" | "blocked";
 
+export interface PingPongDecisionSnapshot {
+	decision: "run_ping_pong" | "suggest_ping_pong" | "handle_inline";
+	score: number;
+	runThreshold: number;
+	suggestThreshold: number;
+	reasons: string[];
+	request: string;
+	taskId?: string;
+	createdAt: string;
+}
+
 /**
  * Blackboard status record
  */
@@ -37,6 +48,8 @@ export interface WriteReviewStatus {
 	changesRequested?: string[]; // Changes needed
 	approvedAt?: string; // ISO timestamp
 	blockedAt?: string; // ISO timestamp
+	mode?: "manual" | "ping_pong";
+	pingPong?: PingPongDecisionSnapshot;
 	updatedAt: string;
 	createdAt: string;
 }

package/skills/harness-runtime/SKILL.md

@@ -4,6 +4,69 @@ description: Local-first, provider-agnostic AI coding harness runtime for pi.dev
 
 # Harness Runtime — pi Extension
 
+## CRITICAL: Todo List Rule
+
+**When you identify 2+ tasks, issues, or jobs — add ALL of them to the Todo list immediately.**
+
+Do NOT just list them in text. Use the `todo` tool to create tracked tasks:
+
+```bash
+# Creating multiple tasks at once
+bd create "Fix initialRemotionData not defined" -p 2
+bd create "Fix dictionary.title undefined" -p 2
+bd create "Replace Film icon with themed icon" -p 2
+```
+
+**Rule**: If you write something like:
+
+- "There are 3 issues: ..."
+- "I found several problems: ..."
+- "Let me fix these: 1) X 2) Y 3) Z"
+- "Here are the tasks to do: ..."
+
+**Then you MUST create Todo items for each one.** Single-issue fixes don't need tracking.
+
+**Why**: Agents often identify issues verbally but forget to track them. This rule ensures nothing slips through.
+
+## Remote Server Commands (SSH)
+
+**ALWAYS use detached SSH pattern to prevent long hangs.**
+
+### Anti-Pattern (blocks SSH, hangs indefinitely)
+
+```bash
+# WRONG - SSH blocks waiting for background process
+ssh user@host "kill old; sleep 2; uvicorn ... &"
+# SSH never returns because it waits for uvicorn
+```
+
+### Correct Pattern (fast exit, process stays on server)
+
+```bash
+# CORRECT - SSH exits fast, process continues on server
+ssh -o BatchMode=yes user@host \
+  "kill -9 OLD_PID 2>/dev/null; sleep 1; \
+   cd /path/to/service && \
+   nohup .venv/bin/uvicorn amos_api.main:app --host 0.0.0.0 --port 8100 \
+   > /tmp/uvicorn.log 2>&1 & \
+   echo 'UVICORN_STARTED'"
+```
+
+**Key changes:**
+
+- `nohup ... &` — detaches from SSH session
+- `> /tmp/uvicorn.log 2>&1` — captures output to file
+- `echo 'UVICORN_STARTED'` — SSH exits fast with confirmation
+- `-o BatchMode=yes` — non-interactive, fails fast on auth issues
+
+**Why this matters**: A bare `&` in SSH keeps the shell open. `nohup` + redirect + `echo` ensures SSH exits immediately while the process runs on the server.
+
+**For long-running commands**, add a timeout guard:
+
+```bash
+timeout 60s ssh -o BatchMode=yes user@host "long-command; echo DONE"
+```
+
 **Status:** v0.3.0 | **RFCs:** 18 defined | **Implementation:** Phase 1-6
 
 ## Overview
@@ -31,7 +94,7 @@ Human Requirement
 ### Usage Commands
 
 | Command | Description |
-|---------|-------------|
+| --------- | ------------- |
 | `/usage` | Show full status (local tracking + provider mirror) |
 | `/usage refresh` | Force refresh quota from MiniMax console |
 | `/usage today` | Today's usage + 5h window |
@@ -41,7 +104,7 @@ Human Requirement
 ### Harness Commands
 
 | Command | Description |
-|---------|-------------|
+| --------- | ------------- |
 | `/harness start <requirement>` | Start a new harness job |
 | `/harness status` | Show current job status |
 | `/harness tasks` | List all tasks |
@@ -52,7 +115,7 @@ Human Requirement
 ### Authentication Commands
 
 | Command | Description |
-|---------|-------------|
+| --------- | ------------- |
 | `/harness auth minimax` | Authenticate with MiniMax (opens browser) |
 | `/harness auth check` | Check MiniMax auth status |
 | `/harness auth scrape` | Scrape MiniMax usage (silent, uses saved profile) |
@@ -86,7 +149,7 @@ cancelled  blocked   waiting_human  repairing  ready_for_client
 ### State Transitions
 
 | From | Valid Transitions |
-|------|-----------------|
+| ------ | ----------------- |
 | created | planning |
 | planning | queued, cancelled |
 | queued | running, cancelled, waiting_human |