pi-harness-runtime 1.1.439 → 1.1.441

package/packages/skill-registry/test/registry.test.ts

@@ -1,508 +0,0 @@
-/**
- * Skill Registry Tests (RFC-0052)
- */
-
-import { describe, it, expect, beforeEach } from "bun:test";
-import {
-	createSkillRegistry,
-	type InMemorySkillRegistry,
-	matchTrigger,
-	findBestMatch,
-	findAllMatches,
-	createKeywordTrigger,
-	createIntentTrigger,
-	createPatternTrigger,
-} from "../src/index.js";
-import type { Skill, SkillContext } from "../src/types.js";
-
-describe("SkillRegistry", () => {
-	let registry: InMemorySkillRegistry;
-
-	beforeEach(() => {
-		registry = createSkillRegistry(true);
-	});
-
-	describe("initialization", () => {
-		it("should load default skills", () => {
-			const skills = registry.list();
-			expect(skills.length).toBeGreaterThan(0);
-		});
-
-		it("should have introspection skill", () => {
-			const skill = registry.get("skill-registry-introspect");
-			expect(skill).toBeDefined();
-			expect(skill!.name).toBe("Introspect Skill Registry");
-		});
-	});
-
-	describe("register and unregister", () => {
-		it("should register a new skill", () => {
-			const newSkill: Skill = {
-				id: "test-skill",
-				name: "Test Skill",
-				description: "A test skill",
-				version: "1.0.0",
-				trigger: createKeywordTrigger(["test"]),
-				handler: async () => ({ success: true, output: "test" }),
-				metadata: { tags: ["test"] },
-			};
-
-			registry.register(newSkill);
-
-			const skill = registry.get("test-skill");
-			expect(skill).toBeDefined();
-			expect(skill!.name).toBe("Test Skill");
-		});
-
-		it("should not register deprecated skills", () => {
-			const deprecatedSkill: Skill = {
-				id: "deprecated-skill",
-				name: "Deprecated",
-				description: "Should not be registered",
-				version: "1.0.0",
-				trigger: createKeywordTrigger(["deprecated"]),
-				handler: async () => ({ success: true }),
-				metadata: { tags: [], deprecated: true },
-			};
-
-			registry.register(deprecatedSkill);
-
-			const skill = registry.get("deprecated-skill");
-			expect(skill).toBeUndefined();
-		});
-
-		it("should unregister a skill", () => {
-			registry.unregister("skill-registry-introspect");
-
-			const skill = registry.get("skill-registry-introspect");
-			expect(skill).toBeUndefined();
-		});
-
-		it("should track events", () => {
-			const events: any[] = [];
-			registry.onEvent((e) => events.push(e));
-
-			const newSkill: Skill = {
-				id: "event-test",
-				name: "Event Test",
-				description: "Test event",
-				version: "1.0.0",
-				trigger: createKeywordTrigger(["event"]),
-				handler: async () => ({ success: true }),
-				metadata: { tags: [] },
-			};
-
-			registry.register(newSkill);
-
-			expect(events).toContainEqual({
-				type: "skill.registered",
-				skillId: "event-test",
-				name: "Event Test",
-			});
-		});
-	});
-
-	describe("find", () => {
-		it("should find skills by trigger type", () => {
-			// "list" appears in all trigger phrases: "list skills", "show skills", "what skills"
-			const skills = registry.find({ type: "keyword", value: "list" });
-			expect(skills.length).toBeGreaterThan(0);
-		});
-
-		it("should return empty for no match", () => {
-			const skills = registry.find({
-				type: "keyword",
-				value: "xyznonexistent",
-			});
-			expect(skills).toHaveLength(0);
-		});
-	});
-
-	describe("invoke", () => {
-		it("should invoke a skill", async () => {
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: { registry },
-			};
-
-			const result = await registry.invoke(
-				"skill-registry-introspect",
-				context,
-			);
-			expect(result.success).toBe(true);
-			expect(result.output).toContain("Registered Skills");
-		});
-
-		it("should return error for unknown skill", async () => {
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: {},
-			};
-
-			const result = await registry.invoke("unknown-skill", context);
-			expect(result.success).toBe(false);
-			expect(result.error).toContain("not found");
-		});
-
-		it("should track invoke events", async () => {
-			const events: any[] = [];
-			registry.onEvent((e) => events.push(e));
-
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: { registry },
-			};
-
-			await registry.invoke("skill-registry-introspect", context);
-
-			const invokeEvents = events.filter((e) => e.type === "skill.invoked");
-			expect(invokeEvents.length).toBe(1);
-			expect(invokeEvents[0].skillId).toBe("skill-registry-introspect");
-			expect(invokeEvents[0].success).toBe(true);
-		});
-
-		it("should handle handler errors", async () => {
-			const errorSkill: Skill = {
-				id: "error-skill",
-				name: "Error Skill",
-				description: "Throws error",
-				version: "1.0.0",
-				trigger: createKeywordTrigger(["error"]),
-				handler: async () => {
-					throw new Error("Test error");
-				},
-				metadata: { tags: [] },
-			};
-
-			registry.register(errorSkill);
-
-			const events: any[] = [];
-			registry.onEvent((e) => events.push(e));
-
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: {},
-			};
-
-			const result = await registry.invoke("error-skill", context);
-			expect(result.success).toBe(false);
-			expect(result.error).toContain("Test error");
-
-			const errorEvents = events.filter((e) => e.type === "skill.error");
-			expect(errorEvents.length).toBe(1);
-		});
-	});
-
-	describe("invokeBestMatch", () => {
-		it("should find and invoke best match", async () => {
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: { registry },
-			};
-
-			// "list" appears in all trigger phrases
-			const result = await registry.invokeBestMatch(
-				{ type: "keyword", value: "list" },
-				context,
-			);
-
-			expect(result.success).toBe(true);
-		});
-
-		it("should return error when no match", async () => {
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: {},
-			};
-
-			const result = await registry.invokeBestMatch(
-				{ type: "keyword", value: "xyznonexistent" },
-				context,
-			);
-
-			expect(result.success).toBe(false);
-			expect(result.error).toContain("No matching skill");
-		});
-	});
-
-	describe("Capability Checking", () => {
-		it("should invoke skill when capabilities are available", async () => {
-			const capSkill: Skill = {
-				id: "cap-test",
-				name: "Cap Test",
-				description: "",
-				version: "1.0.0",
-				trigger: createKeywordTrigger(["captest"]),
-				handler: async () => ({ success: true, output: "ok" }),
-				metadata: { tags: [], requiresCapabilities: ["filesystem"] },
-			};
-			registry.register(capSkill);
-
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: {
-					capabilityRegistry: { has: (cap: string) => cap === "filesystem" },
-				},
-			};
-
-			const result = await registry.invokeBestMatch(
-				{ type: "keyword", value: "captest" },
-				context,
-			);
-			expect(result.success).toBe(true);
-		});
-
-		it("should fail when required capability is missing", async () => {
-			const capSkill: Skill = {
-				id: "cap-missing",
-				name: "Cap Missing",
-				description: "",
-				version: "1.0.0",
-				trigger: createKeywordTrigger(["capmiss"]),
-				handler: async () => ({ success: true }),
-				metadata: { tags: [], requiresCapabilities: ["database"] },
-			};
-			registry.register(capSkill);
-
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: {
-					capabilityRegistry: { has: (cap: string) => cap === "filesystem" },
-				},
-			};
-
-			const result = await registry.invokeBestMatch(
-				{ type: "keyword", value: "capmiss" },
-				context,
-			);
-			expect(result.success).toBe(false);
-			expect(result.error).toContain("database");
-			expect(result.error).toContain("not available");
-		});
-
-		it("should fail gracefully when no capability registry", async () => {
-			const capSkill: Skill = {
-				id: "cap-no-registry",
-				name: "Cap No Registry",
-				description: "",
-				version: "1.0.0",
-				trigger: createKeywordTrigger(["capnoreg"]),
-				handler: async () => ({ success: true }),
-				metadata: { tags: [], requiresCapabilities: ["expensive"] },
-			};
-			registry.register(capSkill);
-
-			const context: SkillContext = {
-				messages: [],
-				tools: [],
-				metadata: {},
-			};
-
-			const result = await registry.invokeBestMatch(
-				{ type: "keyword", value: "capnoreg" },
-				context,
-			);
-			expect(result.success).toBe(false);
-			expect(result.error).toContain("no capability registry");
-		});
-	});
-
-	describe("Confidence Threshold", () => {
-		it("should respect trigger.confidence as min threshold", async () => {
-			// introspect skill keywords: ["list skills", "show skills", "what skills"]
-			// match score for "xyz" = 0 (no keywords match)
-			// minConfidence = 0.8 → should not match
-			const result = await registry.invokeBestMatch(
-				{ type: "keyword", value: "xyz", confidence: 0.8 },
-				{ messages: [], tools: [], metadata: {} },
-			);
-			expect(result.success).toBe(false);
-			expect(result.error).toContain("No matching skill");
-		});
-	});
-
-	describe("Extended Default Skills", () => {
-		it("should load at least 5 default skills", () => {
-			// introspect, help, status, context-compile, skill-install
-			const skills = registry.list();
-			expect(skills.length).toBeGreaterThanOrEqual(5);
-		});
-
-		it("should have context-compile skill", () => {
-			const skill = registry.get("skill-context-compile");
-			expect(skill).toBeDefined();
-			expect(skill!.name).toBe("Context Compiler");
-		});
-
-		it("should have skill-install skill", () => {
-			const skill = registry.get("skill-install");
-			expect(skill).toBeDefined();
-			expect(skill!.name).toBe("Install Skill");
-		});
-
-		it("context-compile skill should analyze context", async () => {
-			const context: SkillContext = {
-				messages: [
-					{ role: "user", content: "hello" },
-					{ role: "assistant", content: "hi" },
-				],
-				tools: [{ name: "bash" }, { name: "read" }],
-				metadata: {},
-			};
-
-			const result = await registry.invoke("skill-context-compile", context);
-			expect(result.success).toBe(true);
-			expect(result.output).toContain("Context analysis");
-			expect(result.output).toContain("Messages: 2");
-			expect(result.output).toContain("Available tools: 2");
-		});
-
-		it("skill-install skill should provide guidance", async () => {
-			const result = await registry.invoke("skill-install", {
-				messages: [],
-				tools: [],
-				metadata: {},
-			});
-			expect(result.success).toBe(true);
-			expect(result.output).toContain("skills directory");
-		});
-	});
-});
-
-describe("Matching Functions", () => {
-	describe("matchTrigger", () => {
-		it("should match keyword trigger", () => {
-			const skill = {
-				id: "test",
-				name: "Test",
-				description: "",
-				version: "1.0.0",
-				trigger: createKeywordTrigger(["help", "assist"]),
-				handler: async () => ({ success: true }),
-				metadata: { tags: [] },
-			};
-
-			expect(matchTrigger(skill, "Can you help me?")).toBeGreaterThan(0);
-			expect(matchTrigger(skill, "I need assistance")).toBeGreaterThan(0);
-			expect(matchTrigger(skill, "Nothing relevant")).toBe(0);
-		});
-
-		it("should match pattern trigger", () => {
-			const skill = {
-				id: "test",
-				name: "Test",
-				description: "",
-				version: "1.0.0",
-				trigger: createPatternTrigger("fix\\s+\\w+"),
-				handler: async () => ({ success: true }),
-				metadata: { tags: [] },
-			};
-
-			expect(matchTrigger(skill, "fix bug")).toBe(1);
-			expect(matchTrigger(skill, "fix error")).toBe(1);
-			expect(matchTrigger(skill, "not relevant")).toBe(0);
-		});
-	});
-
-	describe("findBestMatch", () => {
-		it("should return highest scoring match", () => {
-			const skills = [
-				{
-					id: "low",
-					name: "Low",
-					description: "",
-					version: "1.0.0",
-					trigger: createKeywordTrigger(["test"]),
-					handler: async () => ({ success: true }),
-					metadata: { tags: [] },
-				},
-				{
-					id: "high",
-					name: "High",
-					description: "",
-					version: "1.0.0",
-					trigger: createKeywordTrigger(["test", "skill", "run"]),
-					handler: async () => ({ success: true }),
-					metadata: { tags: [] },
-				},
-			];
-
-			const match = findBestMatch(skills, "run test skill");
-			// Both have score 1.0 (all keywords match), so either could be returned
-			expect(["high", "low"]).toContain(match?.id);
-		});
-
-		it("should respect min confidence", () => {
-			const skills = [
-				{
-					id: "low",
-					name: "Low",
-					description: "",
-					version: "1.0.0",
-					trigger: createKeywordTrigger(["test"]),
-					handler: async () => ({ success: true }),
-					metadata: { tags: [] },
-				},
-			];
-
-			const match = findBestMatch(skills, "xyz", 0.5);
-			expect(match).toBeUndefined();
-		});
-	});
-
-	describe("findAllMatches", () => {
-		it("should return all matches above threshold", () => {
-			const skills = [
-				{
-					id: "one",
-					name: "One",
-					description: "",
-					version: "1.0.0",
-					trigger: createKeywordTrigger(["help"]),
-					handler: async () => ({ success: true }),
-					metadata: { tags: [] },
-				},
-				{
-					id: "two",
-					name: "Two",
-					description: "",
-					version: "1.0.0",
-					trigger: createKeywordTrigger(["help", "me"]),
-					handler: async () => ({ success: true }),
-					metadata: { tags: [] },
-				},
-			];
-
-			const matches = findAllMatches(skills, "help me");
-			expect(matches.length).toBe(2);
-		});
-	});
-});
-
-describe("Trigger Creators", () => {
-	it("should create keyword trigger", () => {
-		const trigger = createKeywordTrigger(["one", "two"]);
-		expect(trigger.type).toBe("keyword");
-		expect(trigger.value).toEqual(["one", "two"]);
-	});
-
-	it("should create intent trigger", () => {
-		const trigger = createIntentTrigger(["intent1"]);
-		expect(trigger.type).toBe("intent");
-		expect(trigger.value).toEqual(["intent1"]);
-	});
-
-	it("should create pattern trigger", () => {
-		const trigger = createPatternTrigger("test\\d+");
-		expect(trigger.type).toBe("pattern");
-		expect(trigger.value).toBe("test\\d+");
-	});
-});

package/packages/skills/test/init-skills.test.ts

@@ -1,114 +0,0 @@
-/**
- * The initialization of the skills system.
- *
- * The test used to be a script that ran `initSkills()` while the module was
- * imported. That scanned the real skill directories of the machine and
- * started the vector indexing of every skill it found, which opened a
- * connection per skill and starved every other test of the process.
- *
- * The test now uses a temporary directory and a registry without a vector
- * index, so it neither reads the machine nor reaches the network.
- */
-
-import { describe, it, expect, beforeEach, afterEach } from "bun:test";
-import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-
-import { initSkills } from "../src/index.js";
-import { createSkillRegistry } from "../src/loader.js";
-
-let tempDir: string;
-
-/** Write a skill into a directory of the temporary home. */
-function writeSkill(directory: string, name: string): void {
-	const skillDir = join(tempDir, directory, name);
-	mkdirSync(skillDir, { recursive: true });
-	writeFileSync(
-		join(skillDir, "SKILL.md"),
-		[
-			"---",
-			`name: ${name}`,
-			`description: The ${name} skill.`,
-			"version: 1.0.0",
-			"---",
-			"",
-			`The body of the ${name} skill.`,
-			"",
-		].join("\n"),
-		"utf8",
-	);
-}
-
-beforeEach(() => {
-	tempDir = mkdtempSync(join(tmpdir(), "test-init-skills-"));
-	mkdirSync(join(tempDir, "skills"), { recursive: true });
-	writeSkill("skills", "alpha");
-	writeSkill("skills", "beta");
-});
-
-afterEach(() => {
-	rmSync(tempDir, { recursive: true, force: true });
-});
-
-describe("the initialization of the skills system", () => {
-	it("scans the given locations", () => {
-		const result = initSkills({
-			locations: [join(tempDir, "skills")],
-			registry: createSkillRegistry({ indexer: null }),
-		});
-
-		expect(result.skills.length).toBe(2);
-		expect(result.skills.map((skill) => skill.id).sort()).toEqual(["alpha", "beta"]);
-		expect(result.errors).toEqual([]);
-	});
-
-	it("falls back to the default locations when none are given", () => {
-		// The default locations point at the machine of the test, so the
-		// result is only checked for its shape.
-		const result = initSkills({
-			registry: createSkillRegistry({ indexer: null }),
-		});
-
-		expect(Array.isArray(result.skills)).toBe(true);
-		expect(Array.isArray(result.errors)).toBe(true);
-	});
-
-	it("falls back to the default locations when they are undefined", () => {
-		// The bug case: an undefined value must not override the defaults.
-		const result = initSkills({
-			locations: undefined,
-			registry: createSkillRegistry({ indexer: null }),
-		});
-
-		expect(Array.isArray(result.skills)).toBe(true);
-		expect(Array.isArray(result.errors)).toBe(true);
-	});
-
-	it("accepts a partial configuration", () => {
-		const result = initSkills({
-			maxDepth: 5,
-			includeHidden: true,
-			registry: createSkillRegistry({ indexer: null }),
-		});
-
-		expect(Array.isArray(result.skills)).toBe(true);
-	});
-
-	it("accepts an empty list of locations", () => {
-		const result = initSkills({
-			locations: [],
-			registry: createSkillRegistry({ indexer: null }),
-		});
-
-		expect(result.skills).toEqual([]);
-	});
-
-	it("registers the scanned skills in the registry", () => {
-		const registry = createSkillRegistry({ indexer: null });
-
-		initSkills({ locations: [join(tempDir, "skills")], registry });
-
-		expect(registry.list().length).toBe(2);
-	});
-});